statesman 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 32bb973d8f35e81d00d5f6424d26dfb7af6f101b
-  data.tar.gz: 2cfacba286b5a45f15f784cf94a91cd2abc34cc7
+SHA256:
+  metadata.gz: 4ea9661229864328ca481ff132837554323967d265616d38c295c5fa94ca9103
+  data.tar.gz: 8974f12e8e70d925f0b35e3753a9977d1ff94a1a76bf05c0a967535037ce6a24
 SHA512:
-  metadata.gz: d2cd17ce3c5cb346912126ff09bb0048647347495bbd21ddb5fd4beaa36225189daae1cd6ca5c6df69bd78f247240e6d03b9c16cb8625b49713b4e4a3b4319f8
-  data.tar.gz: b8e32db8300886d2db38d7a6e8ef00666f7d7ad018b1a04e89c4bd40a8a0cabb415eed02019b3c7745a4bcc5572d6876f7d932990632bb4c50e21bcfdcfd7599
+  metadata.gz: ec7c81ee5c313377acaf35c1196ccf74036769bb945c636d93f56d346deda319534ea9dbeff87bbfe84a2f3d71d7a1a4ae3d435d80c2fa46dc43d2ff3304661a
+  data.tar.gz: 78ed181ce45c7517f8617f61e26c20780f0f2c5b3a04236e4766761b985d42172774d05a54d05bcc2d72bc379eb2f6ed3fe68c122ce8989f19d3d5ba16d286af

data/.rubocop.yml

@@ -1,30 +1,7 @@
 inherit_from: .rubocop_todo.yml
+
 inherit_gem:
-  ruboconfig: rubocop.yml
+  gc_ruboconfig: rubocop.yml
 
 AllCops:
-  DisplayCopNames: true
-  Exclude:
-    - vendor/**/*
-    - .*/**
-    - spec/fixtures/**/*
-
-StringLiterals:
-  Enabled: false
-
-MethodLength:
-  CountComments: false
-  Max: 15
-
-AbcSize:
-  Max: 18
-
-LineLength:
-  Max: 80
-
-# Allow class and message or instance raises
-Style/RaiseArgs:
-  Enabled: false
-
-Lint/RescueWithoutErrorClass:
-  Enabled: false
+  TargetRubyVersion: 2.2

data/.rubocop_todo.yml

@@ -1,17 +1,16 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-08-18 17:09:48 +0100 using RuboCop version 0.49.1.
+# on 2017-12-20 11:33:28 +0000 using RuboCop version 0.52.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 42
+# Offense count: 5
+Metrics/AbcSize:
+  Max: 18
 
-# Offense count: 2
+# Offense count: 4
 # Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 107
+Metrics/MethodLength:
+  Max: 14

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v3.3.0, 5 January 2018
+
+- Touch `updated_at` on transitions when unsetting `most_recent` flag (patch by [@NGMarmaduke](https://github.com/NGMarmaduke))
+- Fix `force_reload` for ActiveRecord models with loaded transitions (patch by [@jacobpgn](https://github.com/))
 
 ## v3.2.0, 27 November 2017
 

data/Gemfile

@@ -3,13 +3,14 @@ source 'https://rubygems.org'
 gemspec
 
 gem "rails", "~> #{ENV['RAILS_VERSION']}" if ENV["RAILS_VERSION"]
-gem "ruboconfig", git: "https://github.com/gocardless/ruboconfig", tag: "v1.0.1"
 
 group :development do
   gem "mongoid", ">= 3.1" unless ENV["EXCLUDE_MONGOID"]
 
   # test/unit is no longer bundled with Ruby 2.2, but required by Rails
-  if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
-    gem "test-unit", "~> 3.0"
-  end
+  gem "test-unit", "~> 3.0" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2.0")
+end
+
+group :development, :test do
+  gem "gc_ruboconfig", "~> 2.1.0"
 end

data/Guardfile

@@ -1,13 +1,13 @@
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
-guard :rspec, all_on_start: true, cmd: 'bundle exec rspec --color' do
+guard :rspec, all_on_start: true, cmd: "bundle exec rspec --color" do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$}) { |m| "spec/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb') { "spec" }
+  watch("spec/spec_helper.rb") { "spec" }
 end
 
-guard :rubocop, all_on_start: true, cli: ['--format', 'clang'] do
+guard :rubocop, all_on_start: true, cli: ["--format", "clang"] do
   watch(/.+\.rb$/)
   watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
   watch(%r{(?:.+/)?\rubocop-todo\.yml$}) { |m| File.dirname(m[0]) }

data/README.md

@@ -29,7 +29,7 @@ protection.
 To get started, just add Statesman to your `Gemfile`, and then run `bundle`:
 
 ```ruby
-gem 'statesman', '~> 3.1.0'
+gem 'statesman', '~> 3.3.0'
 ```
 
 ## Usage

data/lib/generators/statesman/active_record_transition_generator.rb

@@ -11,7 +11,7 @@ module Statesman
     argument :parent, type: :string, desc: "Your parent model name"
     argument :klass,  type: :string, desc: "Your transition model name"
 
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path("../templates", __FILE__)
 
     def create_model_file
       template("create_migration.rb.erb", migration_file_name)

data/lib/generators/statesman/generator_helpers.rb

@@ -9,7 +9,7 @@ module Statesman
     end
 
     def migration_class_name
-      klass.gsub(/::/, '').pluralize
+      klass.gsub(/::/, "").pluralize
     end
 
     def next_migration_number

data/lib/generators/statesman/migration_generator.rb

@@ -11,7 +11,7 @@ module Statesman
     argument :parent, type: :string, desc: "Your parent model name"
     argument :klass, type: :string, desc: "Your transition model name"
 
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path("../templates", __FILE__)
 
     def create_model_file
       template("update_migration.rb.erb", file_name)

data/lib/generators/statesman/mongoid_transition_generator.rb

@@ -10,7 +10,7 @@ module Statesman
     argument :parent, type: :string, desc: "Your parent model name"
     argument :klass, type: :string, desc: "Your transition model name"
 
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path("../templates", __FILE__)
 
     def create_model_file
       template("mongoid_transition_model.rb.erb", model_file_name)

data/lib/statesman.rb

@@ -1,10 +1,10 @@
 module Statesman
-  autoload :Config,     'statesman/config'
-  autoload :Machine,    'statesman/machine'
-  autoload :Callback,   'statesman/callback'
-  autoload :Guard,      'statesman/guard'
-  autoload :Utils,      'statesman/utils'
-  autoload :Version,    'statesman/version'
+  autoload :Config,     "statesman/config"
+  autoload :Machine,    "statesman/machine"
+  autoload :Callback,   "statesman/callback"
+  autoload :Guard,      "statesman/guard"
+  autoload :Utils,      "statesman/utils"
+  autoload :Version,    "statesman/version"
   module Adapters
     autoload :Memory,       "statesman/adapters/memory"
     autoload :ActiveRecord, "statesman/adapters/active_record"
@@ -16,7 +16,7 @@ module Statesman
     autoload :MongoidTransition,
              "statesman/adapters/mongoid_transition"
   end
-  require 'statesman/railtie' if defined?(::Rails::Railtie)
+  require "statesman/railtie" if defined?(::Rails::Railtie)
 
   # Example:
   #   Statesman.configure do

data/lib/statesman/adapters/active_record.rb

@@ -13,17 +13,17 @@ module Statesman
         if ::ActiveRecord::Base.connection.respond_to?(:supports_partial_index?)
           ::ActiveRecord::Base.connection.supports_partial_index?
         else
-          ::ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
+          ::ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
         end
       end
 
       def initialize(transition_class, parent_model, observer, options = {})
         serialized = serialized?(transition_class)
-        column_type = transition_class.columns_hash['metadata'].sql_type
+        column_type = transition_class.columns_hash["metadata"].sql_type
         if !serialized && !JSON_COLUMN_TYPES.include?(column_type)
-          raise UnserializedMetadataError.new(transition_class.name)
+          raise UnserializedMetadataError, transition_class.name
         elsif serialized && JSON_COLUMN_TYPES.include?(column_type)
-          raise IncompatibleSerializationError.new(transition_class.name)
+          raise IncompatibleSerializationError, transition_class.name
         end
         @transition_class = transition_class
         @parent_model = parent_model
@@ -41,8 +41,8 @@ module Statesman
         @last_transition = nil
       end
 
-      def history
-        if transitions_for_parent.loaded?
+      def history(force_reload: false)
+        if transitions_for_parent.loaded? && !force_reload
           # Workaround for Rails bug which causes infinite loop when sorting
           # already loaded result set. Introduced in rails/rails@b097ebe
           transitions_for_parent.to_a.sort_by(&:sort_key)
@@ -53,7 +53,7 @@ module Statesman
 
       def last(force_reload: false)
         if force_reload
-          @last_transition = history.last
+          @last_transition = history(force_reload: true).last
         else
           @last_transition ||= history.last
         end
@@ -87,6 +87,12 @@ module Statesman
       end
 
       def unset_old_most_recent
+        most_recent = transitions_for_parent.where(most_recent: true)
+        updated_at = if ::ActiveRecord::Base.default_timezone == :utc
+                       Time.now.utc
+                     else
+                       Time.now
+                     end
         # Check whether the `most_recent` column allows null values. If it
         # doesn't, set old records to `false`, otherwise, set them to `NULL`.
         #
@@ -94,10 +100,10 @@ module Statesman
         # support partial indexes. By doing the conditioning on the column,
         # rather than Rails' opinion of whether the database supports partial
         # indexes, we're robust to DBs later adding support for partial indexes.
-        if transition_class.columns_hash['most_recent'].null == false
-          transitions_for_parent.update_all(most_recent: false)
+        if transition_class.columns_hash["most_recent"].null == false
+          most_recent.update_all(most_recent: false, updated_at: updated_at)
         else
-          transitions_for_parent.update_all(most_recent: nil)
+          most_recent.update_all(most_recent: nil, updated_at: updated_at)
         end
       end
 
@@ -107,7 +113,7 @@ module Statesman
 
       def serialized?(transition_class)
         if ::ActiveRecord.respond_to?(:gem_version) &&
-            ::ActiveRecord.gem_version >= Gem::Version.new('4.2.0.a')
+            ::ActiveRecord.gem_version >= Gem::Version.new("4.2.0.a")
           transition_class.type_for_attribute("metadata").
             is_a?(::ActiveRecord::Type::Serialized)
         else
@@ -117,7 +123,7 @@ module Statesman
 
       def transition_conflict_error?(e)
         e.message.include?(@transition_class.table_name) &&
-          (e.message.include?('sort_key') || e.message.include?('most_recent'))
+          (e.message.include?("sort_key") || e.message.include?("most_recent"))
       end
     end
   end

data/lib/statesman/adapters/memory.rb

@@ -4,7 +4,6 @@ module Statesman
   module Adapters
     class Memory
       attr_reader :transition_class
-      attr_reader :history
       attr_reader :parent_model
 
       # We only accept mode as a parameter to maintain a consistent interface
@@ -32,6 +31,10 @@ module Statesman
         @history.sort_by(&:sort_key).last
       end
 
+      def history(*)
+        @history
+      end
+
       private
 
       def next_sort_key

data/lib/statesman/adapters/mongoid.rb

@@ -10,7 +10,7 @@ module Statesman
         @transition_class = transition_class
         @parent_model = parent_model
         @observer = observer
-        unless transition_class_hash_fields.include?('statesman_metadata')
+        unless transition_class_hash_fields.include?("statesman_metadata")
           raise UnserializedMetadataError, metadata_field_error_message
         end
       end
@@ -32,7 +32,7 @@ module Statesman
         @last_transition = nil
       end
 
-      def history
+      def history(*)
         transitions_for_parent.asc(:sort_key)
       end
 

data/lib/statesman/machine.rb

@@ -138,12 +138,8 @@ module Statesman
       end
 
       def validate_callback_type_and_class(callback_type, callback_class)
-        if callback_type.nil?
-          raise ArgumentError.new("missing keyword: callback_type")
-        end
-        if callback_class.nil?
-          raise ArgumentError.new("missing keyword: callback_class")
-        end
+        raise ArgumentError, "missing keyword: callback_type" if callback_type.nil?
+        raise ArgumentError, "missing keyword: callback_class" if callback_class.nil?
       end
 
       def validate_state(state)

data/lib/statesman/version.rb

@@ -1,3 +1,3 @@
 module Statesman
-  VERSION = "3.2.0".freeze
+  VERSION = "3.3.0".freeze
 end

data/lib/tasks/statesman.rake

@@ -8,6 +8,11 @@ namespace :statesman do
     parent_class = parent_model_name.constantize
     transition_class = parent_class.transition_class
     parent_fk = "#{parent_model_name.demodulize.underscore}_id"
+    updated_at = if ActiveRecord::Base.default_timezone == :utc
+                   Time.now.utc
+                 else
+                   Time.now
+                 end
 
     total_models = parent_class.count
     done_models = 0
@@ -18,10 +23,10 @@ namespace :statesman do
         if Statesman::Adapters::ActiveRecord.database_supports_partial_indexes?
           # Set all transitions' most_recent to FALSE
           transition_class.where(parent_fk => models.map(&:id)).
-            update_all(most_recent: false)
+            update_all(most_recent: false, updated_at: updated_at)
         else
           transition_class.where(parent_fk => models.map(&:id)).
-            update_all(most_recent: nil)
+            update_all(most_recent: nil, updated_at: updated_at)
         end
 
         # Set current transition's most_recent to TRUE
@@ -44,7 +49,8 @@ namespace :statesman do
         latest_ids = transition_class.find_by_sql(latest_ids_query).
           to_a.collect(&:id)
 
-        transition_class.where(id: latest_ids).update_all(most_recent: true)
+        transition_class.where(id: latest_ids).
+          update_all(most_recent: true, updated_at: updated_at)
       end
 
       done_models += batch_size

data/spec/fixtures/add_constraints_to_most_recent_for_bacon_transitions_with_partial_index.rb

@@ -2,7 +2,12 @@ class AddConstraintsToMostRecentForBaconTransitions < ActiveRecord::Migration
   disable_ddl_transaction!
 
   def up
-    add_index :bacon_transitions, [:bacon_id, :most_recent], unique: true, where: "most_recent", name: "index_bacon_transitions_parent_most_recent", algorithm: :concurrently
+    add_index :bacon_transitions,
+              %i[bacon_id most_recent],
+              unique: true,
+              where: "most_recent",
+              name: "index_bacon_transitions_parent_most_recent",
+              algorithm: :concurrently
     change_column_null :bacon_transitions, :most_recent, false
   end
 

data/spec/fixtures/add_constraints_to_most_recent_for_bacon_transitions_without_partial_index.rb

@@ -2,7 +2,11 @@ class AddConstraintsToMostRecentForBaconTransitions < ActiveRecord::Migration
   disable_ddl_transaction!
 
   def up
-    add_index :bacon_transitions, [:bacon_id, :most_recent], unique: true, name: "index_bacon_transitions_parent_most_recent", algorithm: :concurrently
+    add_index :bacon_transitions,
+              %i[bacon_id most_recent],
+              unique: true,
+              name: "index_bacon_transitions_parent_most_recent",
+              algorithm: :concurrently
   end
 
   def down

data/spec/generators/statesman/active_record_transition_generator_spec.rb

@@ -4,35 +4,35 @@ require "generators/statesman/active_record_transition_generator"
 
 describe Statesman::ActiveRecordTransitionGenerator, type: :generator do
   it_behaves_like "a generator" do
-    let(:migration_name) { 'db/migrate/create_bacon_transitions.rb' }
+    let(:migration_name) { "db/migrate/create_bacon_transitions.rb" }
   end
 
-  describe 'creates a migration' do
+  describe "creates a migration" do
     subject { file("db/migrate/#{time}_create_bacon_transitions.rb") }
 
     before { allow(Time).to receive(:now).and_return(mock_time) }
     before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
 
-    let(:mock_time) { double('Time', utc: double('UTCTime', strftime: time)) }
-    let(:time) { '5678309' }
+    let(:mock_time) { double("Time", utc: double("UTCTime", strftime: time)) }
+    let(:time) { "5678309" }
 
     it "includes a foreign key" do
       expect(subject).to contain("add_foreign_key :bacon_transitions, :bacons")
     end
   end
 
-  describe 'properly adds class names' do
+  describe "properly adds class names" do
     before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
-    subject { file('app/models/yummy/bacon_transition.rb') }
+    subject { file("app/models/yummy/bacon_transition.rb") }
 
     it { is_expected.to contain(/:bacon_transition/) }
     it { is_expected.not_to contain(%r{:yummy/bacon}) }
     it { is_expected.to contain(/class_name: 'Yummy::Bacon'/) }
   end
 
-  describe 'properly formats without class names' do
+  describe "properly formats without class names" do
     before { run_generator %w[Bacon BaconTransition] }
-    subject { file('app/models/bacon_transition.rb') }
+    subject { file("app/models/bacon_transition.rb") }
 
     it { is_expected.not_to contain(/class_name:/) }
     it { is_expected.to contain(/class BaconTransition/) }
@@ -40,7 +40,7 @@ describe Statesman::ActiveRecordTransitionGenerator, type: :generator do
 
   describe "it doesn't create any double-spacing" do
     before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
-    subject { file('app/models/yummy/bacon_transition.rb') }
+    subject { file("app/models/yummy/bacon_transition.rb") }
 
     it { is_expected.to_not contain(/\n\n\n/) }
   end

data/spec/generators/statesman/migration_generator_spec.rb

@@ -4,14 +4,14 @@ require "generators/statesman/migration_generator"
 
 describe Statesman::MigrationGenerator, type: :generator do
   it_behaves_like "a generator" do
-    let(:migration_name) { 'db/migrate/add_statesman_to_bacon_transitions.rb' }
+    let(:migration_name) { "db/migrate/add_statesman_to_bacon_transitions.rb" }
   end
 
-  describe 'the model contains the correct words' do
-    let(:migration_number) { '5678309' }
+  describe "the model contains the correct words" do
+    let(:migration_number) { "5678309" }
 
     let(:mock_time) do
-      double('Time', utc: double('UTCTime', strftime: migration_number))
+      double("Time", utc: double("UTCTime", strftime: migration_number))
     end
 
     subject do

data/spec/generators/statesman/mongoid_transition_generator_spec.rb

@@ -3,17 +3,17 @@ require "support/generators_shared_examples"
 require "generators/statesman/mongoid_transition_generator"
 
 describe Statesman::MongoidTransitionGenerator, type: :generator do
-  describe 'the model contains the correct words' do
+  describe "the model contains the correct words" do
     before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
-    subject { file('app/models/yummy/bacon_transition.rb') }
+    subject { file("app/models/yummy/bacon_transition.rb") }
 
     it { is_expected.not_to contain(%r{:yummy/bacon}) }
     it { is_expected.to contain(/class_name: 'Yummy::Bacon'/) }
   end
 
-  describe 'the model contains the correct words' do
+  describe "the model contains the correct words" do
     before { run_generator %w[Bacon BaconTransition] }
-    subject { file('app/models/bacon_transition.rb') }
+    subject { file("app/models/bacon_transition.rb") }
 
     it { is_expected.not_to contain(/class_name:/) }
     it { is_expected.not_to contain(/CreateYummy::Bacon/) }

data/spec/statesman/adapters/active_record_queries_spec.rb

@@ -132,7 +132,7 @@ describe Statesman::Adapters::ActiveRecordQueries, active_record: true do
       # this spec.
       MyActiveRecordModel.send(:has_many,
                                :custom_name,
-                               class_name: 'OtherActiveRecordModelTransition')
+                               class_name: "OtherActiveRecordModelTransition")
 
       MyActiveRecordModel.class_eval do
         def self.transition_class

data/spec/statesman/adapters/active_record_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require "timecop"
 require "statesman/adapters/shared_examples"
 require "statesman/exceptions"
 
@@ -17,11 +18,11 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
     context "with unserialized metadata and non json column type" do
       before do
         metadata_column = double
-        allow(metadata_column).to receive_messages(sql_type: '')
+        allow(metadata_column).to receive_messages(sql_type: "")
         allow(MyActiveRecordModelTransition).to receive_messages(columns_hash:
-                                           { 'metadata' => metadata_column })
+                                           { "metadata" => metadata_column })
         if ::ActiveRecord.respond_to?(:gem_version) &&
-            ::ActiveRecord.gem_version >= Gem::Version.new('4.2.0.a')
+            ::ActiveRecord.gem_version >= Gem::Version.new("4.2.0.a")
           expect(MyActiveRecordModelTransition).
             to receive(:type_for_attribute).with("metadata").
             and_return(ActiveRecord::Type::Value.new)
@@ -42,20 +43,20 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
     context "with serialized metadata and json column type" do
       before do
         metadata_column = double
-        allow(metadata_column).to receive_messages(sql_type: 'json')
+        allow(metadata_column).to receive_messages(sql_type: "json")
         allow(MyActiveRecordModelTransition).to receive_messages(columns_hash:
-                                           { 'metadata' => metadata_column })
+                                           { "metadata" => metadata_column })
         if ::ActiveRecord.respond_to?(:gem_version) &&
-            ::ActiveRecord.gem_version >= Gem::Version.new('4.2.0.a')
+            ::ActiveRecord.gem_version >= Gem::Version.new("4.2.0.a")
           serialized_type = ::ActiveRecord::Type::Serialized.new(
-            '', ::ActiveRecord::Coders::JSON
+            "", ::ActiveRecord::Coders::JSON
           )
           expect(MyActiveRecordModelTransition).
             to receive(:type_for_attribute).with("metadata").
             and_return(serialized_type)
         else
           expect(MyActiveRecordModelTransition).
-            to receive_messages(serialized_attributes: { 'metadata' => '' })
+            to receive_messages(serialized_attributes: { "metadata" => "" })
         end
       end
 
@@ -70,20 +71,20 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
     context "with serialized metadata and jsonb column type" do
       before do
         metadata_column = double
-        allow(metadata_column).to receive_messages(sql_type: 'jsonb')
+        allow(metadata_column).to receive_messages(sql_type: "jsonb")
         allow(MyActiveRecordModelTransition).to receive_messages(columns_hash:
-                                           { 'metadata' => metadata_column })
+                                           { "metadata" => metadata_column })
         if ::ActiveRecord.respond_to?(:gem_version) &&
-            ::ActiveRecord.gem_version >= Gem::Version.new('4.2.0.a')
+            ::ActiveRecord.gem_version >= Gem::Version.new("4.2.0.a")
           serialized_type = ::ActiveRecord::Type::Serialized.new(
-            '', ::ActiveRecord::Coders::JSON
+            "", ::ActiveRecord::Coders::JSON
           )
           expect(MyActiveRecordModelTransition).
             to receive(:type_for_attribute).with("metadata").
             and_return(serialized_type)
         else
           expect(MyActiveRecordModelTransition).
-            to receive_messages(serialized_attributes: { 'metadata' => '' })
+            to receive_messages(serialized_attributes: { "metadata" => "" })
         end
       end
 
@@ -125,7 +126,7 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
       context "ActiveRecord::RecordNotUnique unrelated to this transition" do
         let(:error) do
           if ::ActiveRecord.respond_to?(:gem_version) &&
-              ::ActiveRecord.gem_version >= Gem::Version.new('4.0.0')
+              ::ActiveRecord.gem_version >= Gem::Version.new("4.0.0")
             ActiveRecord::RecordNotUnique.new("unrelated")
           else
             ActiveRecord::RecordNotUnique.new("unrelated", nil)
@@ -157,6 +158,11 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
             from(true).to be_falsey
         end
 
+        it "touches the previous transition's updated_at timestamp" do
+          expect { Timecop.freeze(Time.now + 5.seconds) { create } }.
+            to(change { previous_transition.reload.updated_at })
+        end
+
         context "and a query on the parent model's state is made" do
           context "in a before action" do
             it "still has the old state" do
@@ -228,17 +234,35 @@ describe Statesman::Adapters::ActiveRecord, active_record: true do
           described_class.new(MyActiveRecordModelTransition, model, observer)
         end
 
-        before { alternate_adapter.create(:y, :z, []) }
-
         it "still returns the cached value" do
+          alternate_adapter.create(:y, :z, [])
+
           expect_any_instance_of(MyActiveRecordModel).
             to receive(:my_active_record_model_transitions).never
           expect(adapter.last.to_state).to eq("y")
         end
 
-        context "when explitly not using the cache" do
-          it "still returns the cached value" do
-            expect(adapter.last(force_reload: true).to_state).to eq("z")
+        context "when explicitly not using the cache" do
+          context "when the transitions are in memory" do
+            before do
+              model.my_active_record_model_transitions.load
+              alternate_adapter.create(:y, :z, [])
+            end
+
+            it "reloads the value" do
+              expect(adapter.last(force_reload: true).to_state).to eq("z")
+            end
+          end
+
+          context "when the transitions are not in memory" do
+            before do
+              model.my_active_record_model_transitions.reset
+              alternate_adapter.create(:y, :z, [])
+            end
+
+            it "reloads the value" do
+              expect(adapter.last(force_reload: true).to_state).to eq("z")
+            end
           end
         end
       end

data/spec/statesman/adapters/mongoid_spec.rb

@@ -48,5 +48,35 @@ describe Statesman::Adapters::Mongoid, mongo: true do
         end
       end
     end
+
+    context "when a new transition has been created elsewhere" do
+      let(:alternate_adapter) do
+        described_class.new(MyMongoidModelTransition, model, observer)
+      end
+
+      context "when explicitly not using the cache" do
+        context "when the transitions are in memory" do
+          before do
+            model.my_mongoid_model_transitions.entries
+            alternate_adapter.create(:y, :z)
+          end
+
+          it "reloads the value" do
+            expect(adapter.last(force_reload: true).to_state).to eq("z")
+          end
+        end
+
+        context "when the transitions are not in memory" do
+          before do
+            model.my_mongoid_model_transitions.reset
+            alternate_adapter.create(:y, :z)
+          end
+
+          it "reloads the value" do
+            expect(adapter.last(force_reload: true).to_state).to eq("z")
+          end
+        end
+      end
+    end
   end
 end

data/spec/statesman/adapters/shared_examples.rb

@@ -11,7 +11,6 @@ require "spec_helper"
 #   history:          Returns the full transition history
 #   last:             Returns the latest transition history item
 #
-# rubocop:disable Metrics/LineLength
 # NOTE This line cannot reasonably be shortened.
 shared_examples_for "an adapter" do |adapter_class, transition_class, options = {}|
   # rubocop:enable Metrics/LineLength

data/spec/statesman/machine_spec.rb

@@ -450,7 +450,7 @@ describe Statesman::Machine do
 
     context "with one possible state" do
       before { instance.transition_to!(:y) }
-      it { is_expected.to eq(['z']) }
+      it { is_expected.to eq(["z"]) }
 
       context "guarded using metadata" do
         before do
@@ -459,7 +459,7 @@ describe Statesman::Machine do
           end
         end
 
-        it { is_expected.to eq(['z']) }
+        it { is_expected.to eq(["z"]) }
       end
 
       context "excluded by guard using metadata" do
@@ -666,12 +666,12 @@ describe Statesman::Machine do
     context "when a non statesman exception is raised" do
       before do
         allow(instance).to receive(:transition_to!).
-          and_raise(RuntimeError, 'user defined exception')
+          and_raise(RuntimeError, "user defined exception")
       end
 
       it "should not rescue the exception" do
         expect { instance.transition_to(:some_state, metadata) }.
-          to raise_error(RuntimeError, 'user defined exception')
+          to raise_error(RuntimeError, "user defined exception")
       end
     end
   end

data/spec/support/active_record.rb

@@ -59,10 +59,10 @@ class CreateMyActiveRecordModelTransitionMigration < MIGRATION_CLASS
       t.integer :sort_key
 
       # MySQL doesn't allow default values on text fields
-      if ActiveRecord::Base.connection.adapter_name == 'Mysql2'
+      if ActiveRecord::Base.connection.adapter_name == "Mysql2"
         t.text :metadata
       else
-        t.text :metadata, default: '{}'
+        t.text :metadata, default: "{}"
       end
 
       if Statesman::Adapters::ActiveRecord.database_supports_partial_indexes?
@@ -137,10 +137,10 @@ class CreateOtherActiveRecordModelTransitionMigration < MIGRATION_CLASS
       t.integer :sort_key
 
       # MySQL doesn't allow default values on text fields
-      if ActiveRecord::Base.connection.adapter_name == 'Mysql2'
+      if ActiveRecord::Base.connection.adapter_name == "Mysql2"
         t.text :metadata
       else
-        t.text :metadata, default: '{}'
+        t.text :metadata, default: "{}"
       end
 
       if Statesman::Adapters::ActiveRecord.database_supports_partial_indexes?
@@ -234,10 +234,10 @@ class CreateNamespacedARModelTransitionMigration < MIGRATION_CLASS
       t.integer :sort_key
 
       # MySQL doesn't allow default values on text fields
-      if ActiveRecord::Base.connection.adapter_name == 'Mysql2'
+      if ActiveRecord::Base.connection.adapter_name == "Mysql2"
         t.text :metadata
       else
-        t.text :metadata, default: '{}'
+        t.text :metadata, default: "{}"
       end
 
       if Statesman::Adapters::ActiveRecord.database_supports_partial_indexes?
@@ -250,7 +250,7 @@ class CreateNamespacedARModelTransitionMigration < MIGRATION_CLASS
     end
 
     add_index :my_namespace_my_active_record_model_transitions, :sort_key,
-              unique: true, name: 'my_namespaced_key'
+              unique: true, name: "my_namespaced_key"
 
     if Statesman::Adapters::ActiveRecord.database_supports_partial_indexes?
       add_index :my_namespace_my_active_record_model_transitions,

data/spec/support/generators_shared_examples.rb

@@ -2,22 +2,22 @@ require "rails/version"
 require "rspec/rails"
 require "ammeter/init"
 
-TMP_GENERATOR_PATH = File.expand_path('../generator-tmp', __FILE__)
+TMP_GENERATOR_PATH = File.expand_path("../generator-tmp", __FILE__)
 
-shared_examples 'a generator' do
+shared_examples "a generator" do
   destination TMP_GENERATOR_PATH
   before { prepare_destination }
   let(:gen) { generator %w[Yummy::Bacon Yummy::BaconTransition] }
 
-  it 'invokes create_model_file method' do
+  it "invokes create_model_file method" do
     expect(gen).to receive(:create_model_file)
     gen.invoke_all
   end
 
-  describe 'it runs the generator and check things out' do
+  describe "it runs the generator and check things out" do
     before { run_generator %w[Yummy::Bacon Yummy::BaconTransition] }
 
-    describe 'it generates a correctly named file' do
+    describe "it generates a correctly named file" do
       subject { file(migration_name) }
       it { is_expected.to be_a_migration }
     end

data/spec/support/mongoid.rb

@@ -1,7 +1,7 @@
-require 'mongoid'
+require "mongoid"
 
 Mongoid.configure do |config|
-  config.connect_to('statesman_test')
+  config.connect_to("statesman_test")
 end
 
 class MyMongoidModel

data/statesman.gemspec

@@ -1,13 +1,13 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'statesman/version'
+require "statesman/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "statesman"
   spec.version       = Statesman::VERSION
   spec.authors       = ["GoCardless"]
   spec.email         = ["developers@gocardless.com"]
-  spec.description   = 'A statesman-like state machine library'
+  spec.description   = "A statesman-like state machine library"
   spec.summary       = spec.description
   spec.homepage      = "https://github.com/gocardless/statesman"
   spec.license       = "MIT"
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = '>= 2.2'
+  spec.required_ruby_version = ">= 2.2"
 
   spec.add_development_dependency "ammeter",               "~> 1.1"
   spec.add_development_dependency "bundler",               "~> 1.3"
@@ -29,6 +29,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec-its",             "~> 1.1"
   spec.add_development_dependency "rspec-rails",           "~> 3.1"
   spec.add_development_dependency "rspec_junit_formatter", "~> 0.3.0"
-  spec.add_development_dependency "rubocop",               "~> 0.51.0"
+  spec.add_development_dependency "rubocop",               "~> 0.52.0"
   spec.add_development_dependency "sqlite3",               "~> 1.3"
+  spec.add_development_dependency "timecop",               "~> 0.9.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: statesman
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-28 00:00:00.000000000 Z
+date: 2018-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ammeter
@@ -156,14 +156,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.52.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.52.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +178,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.1
 description: A statesman-like state machine library
 email:
 - developers@gocardless.com
@@ -265,7 +279,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: A statesman-like state machine library