starkit_banking 0.1.9 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5e0b9bfae95aca5c8ab27dbb5319872fed03d4a
-  data.tar.gz: 7edf5a42d0a48737d40f2e5039b125000af0b500
+  metadata.gz: ca947af5c2ceb3ca9d23d5173c08c889f940bd61
+  data.tar.gz: 052a471978605f89cc64605acf46d343168e5047
 SHA512:
-  metadata.gz: 966028f7deca260c9c2dba0e64bbcb57f1aa4a75d4e0fb45120bdaaea8f610936d70f5f16c99112f635d99eaf8a2c6db192bcdee8e7dda1e06d036df55f2d57e
-  data.tar.gz: 4562eb643a5bdeed904b5d8888c7b59cb4a80baf04fe10a1feb6b303c945dd2af8dcb087a91571902d60732382897107a1a4ba65d391b1dd1d94ba7faf083b23
+  metadata.gz: 716aecb37011f615d9f05a9ed3d9b1ae108e18c3978047b0239df38f39bf8f084604c681ef2e1371d8f71bf587ff6fe5403b94ab5e0ec0e427f1cb1d423f2c55
+  data.tar.gz: 72d0a547c3230172fe28278a9fd3f3b72f08dcba579189ae519bc919c2f8ba897de09d394fda8bdbb25393fe18ff091c35baad5f8a161bf29990d0a9c3becc55

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    starkit_banking (0.1.7)
+    starkit_banking (0.1.10)
       activerecord (~> 4.2.7)
       activesupport (~> 4.2.7)
-      api_banking (= 0.1.17)
+      api_banking (= 0.1.18)
       money (= 6.7.1)
       railties (~> 4.2.7)
 
@@ -39,11 +39,12 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.5.0)
       public_suffix (~> 2.0, >= 2.0.2)
-    api_banking (0.1.17)
+    api_banking (0.1.18)
       nokogiri (~> 1.6.8)
       typhoeus (~> 1.1.0)
-    arel (6.0.3)
+    arel (6.0.4)
     builder (3.2.2)
+    coderay (1.1.1)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     erubis (2.7.0)
@@ -55,6 +56,7 @@ GEM
     json (1.8.3)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
+    method_source (0.8.2)
     mini_portile2 (2.1.0)
     minitest (5.9.1)
     money (6.7.1)
@@ -62,6 +64,10 @@ GEM
       sixarm_ruby_unaccent (>= 1.1.1, < 2)
     nokogiri (1.6.8.1)
       mini_portile2 (~> 2.1.0)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     public_suffix (2.0.4)
     rack (1.6.5)
     rack-test (0.6.3)
@@ -82,6 +88,7 @@ GEM
     rake (10.5.0)
     safe_yaml (1.0.4)
     sixarm_ruby_unaccent (1.1.1)
+    slop (3.6.0)
     thor (0.19.4)
     thread_safe (0.3.5)
     typhoeus (1.1.2)
@@ -100,6 +107,7 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.9)
   minitest (= 5.9.1)
+  pry
   rake (~> 10.0)
   starkit_banking!
   vcr (= 3.0.3)

data/lib/starkit_banking/api/client.rb

@@ -6,22 +6,58 @@ module StarkitBanking
     def initialize(step_name = nil)
       @step_name = step_name
     end
-        
+
     def exec(model)
       env = Environment.build(credentials(model))
       subscription = subscription(model)
       raise ApiFault.new(OpenStruct.new(code: 'sb:412', subCode: nil, reasonText: "#{service_name} is not subscribed")) if subscription.nil?
-      
+
       req = request(subscription, model)
-                  
-      res = invoke(env, req)
-      
+      res = invoke(env, req, callbacks(model, req))
+
       if res.instance_of?ApiBanking::Fault
+        # log fault details
+        model.api_step.assign_attributes(
+          fault_code: res.code,
+          fault_subcode: res.subCode,
+          fault_reason: res.reasonText
+        )
         # for certain API calls, certain faults are expected, for example, when a retry is made it is not an error
         raise ApiFault.new(res)
       else
+        rep_reference_no = res.respond_to?(:uniqueResponseNo) ? res.uniqueResponseNo : nil
+        # log fault details
+        model.api_step.assign_attributes(
+          rep_reference: rep_reference_no
+        )
         response(res)
       end
     end
+
+    def callbacks(model, req)
+      req_reference_no = req.respond_to?(:uniqueRequestNo) ? req.uniqueRequestNo : nil
+
+      ApiBanking::Callbacks.new do |c|
+        c.before_send do |r|
+          model.api_step = ApiStep.new(
+            auditable_type: model.class,
+            auditable_id: model.id,
+            star_id: model.star_id,
+            step_name: @step_name,
+            req_reference: req_reference_no,
+            req_timestamp: Time.current,
+            req_bitstream: r.options[:body]
+          )
+        end
+
+        c.on_complete do |r|
+          model.api_step.assign_attributes(
+            status_code: r.response_code,
+            rep_timestamp: Time.current,
+            rep_bitstream: r.body
+          )
+        end
+      end
+    end
   end
-end
+end

data/lib/starkit_banking/api/ybl/account/balance.rb

@@ -3,40 +3,40 @@ module StarkitBanking
     module Account
       class GetBalance
         include ApiClient
-      
-        private 
-        
+
+        private
+
         def service_name
           'BALANCE ENQUIRY'
         end
-      
-        def invoke(env, req)
-          ApiBanking::FundsTransferByCustomerService2.get_balance(env, req)          
+
+        def invoke(env, req, callbacks)
+          ApiBanking::FundsTransferByCustomerService2.get_balance(env, req, callbacks)
         end
-        
+
         def response(rep)
           Money.new(rep.accountBalanceAmount, rep.accountCurrencyCode)
         end
-      
+
         def credentials(payment_account)
           payment_account.credentials
         end
-      
+
         def request(subscription, payment_account)
-        
+
           request = ApiBanking::FundsTransferByCustomerService2::GetBalance::Request.new()
 
           request.appID = subscription.app_id
           request.customerID = payment_account.customer_id
           request.AccountNumber = payment_account.account_number
-        
-          request       
+
+          request
         end
-      
+
         def subscription(payment_account)
           payment_account.service_subscriptions.find_by(service_name: service_name)
         end
-  
+
       end
     end
   end

data/lib/starkit_banking/api/ybl/account/mini_statement.rb

@@ -3,17 +3,17 @@ module StarkitBanking
     module Account
       class GetMiniStatement
         include ApiClient
-      
+
         private
-        
+
         def service_name
           'GET TRANSACTIONS'
         end
-        
-        def invoke(env, req)
-          ApiBanking::SocialBankingService.getTransactions(env, req)
+
+        def invoke(env, req, callbacks)
+          ApiBanking::SocialBankingService.getTransactions(env, req, callbacks)
         end
-        
+
         def response(res)
           entries = Array.new
 
@@ -26,14 +26,14 @@ module StarkitBanking
             entries << e
 
           end
-          
+
           entries
         end
-      
+
         def credentials(payment_account)
           payment_account.credentials
         end
-      
+
         def request(subscription, payment_account)
           customerIdentity = ApiBanking::SocialBankingService::GetTransactions::CustomerIdentity.new()
           accountIdentity = ApiBanking::SocialBankingService::GetTransactions::AccountIdentity.new()

data/lib/starkit_banking/api/ybl/beneficiary/imt.rb

@@ -4,81 +4,81 @@ module StarkitBanking
       module IMT
         class Add
           include ApiClient
-      
-          private 
-      
-          def invoke(env, req)
-            ApiBanking::InstantMoneyTransferService.add_beneficiary(env, request)
+
+          private
+
+          def invoke(env, req, callbacks)
+            ApiBanking::InstantMoneyTransferService.add_beneficiary(env, request, callbacks)
           end
-      
+
           def credentials(beneficiary)
             beneficiary.credentials
           end
-      
+
           def request(beneficiary)
-        
+
             beneficiaryAddress = ApiBanking::InstantMoneyTransferService::AddBeneficiary::Address.new()
             request = ApiBanking::InstantMoneyTransferService::AddBeneficiary::Request.new()
 
             @req_reference = request.uniqueRequestNo = beneficiary.id
-          
+
             request.appID = app_id(beneficiary)
             request.customerID = customer_id(beneficiary)
-          
+
             request.beneficiaryMobileNo = beneficiary.mobile
             request.beneficiaryName = beneficiary.name
             beneficiaryAddress.addressLine = beneficiary.address_line
             beneficiaryAddress.cityName = beneficiary.city
             beneficiaryAddress.postalCode = beneficiary.postal_code
             request.beneficiaryAddress = beneficiaryAddress
-        
-            request       
+
+            request
           end
-        
+
           def customer_id(beneficiary)
             beneficiary.customer_id #TODO customer_id column to be added to bank_beneficiaries table
           end
-      
+
           def app_id(beneficiary)
             beneficiary.service_subscriptions.find_by('IMT TRANSFER').app_id
           end
-  
+
         end
-      
+
         class Delete
           include ApiClient
-      
-          private 
-      
+
+          private
+
           def invoke(env, req)
             ApiBanking::InstantMoneyTransferService.delete_beneficiary(env, request)
           end
-      
+
           def credentials(beneficiary)
             beneficiary.credentials
           end
-      
+
           def request(beneficiary)
-        
+
             request = ApiBanking::InstantMoneyTransferService::DeleteBeneficiary::Request.new()
-        
+
             request.uniqueRequestNo = SecureRandom.uuid.gsub!('-','')
             request.appID = app_id(beneficiary)
             request.customerID = customer_id(beneficiary)
             request.beneficiaryMobileNo = beneficiary.mobile_no
-        
-            request       
+
+            request
           end
-        
+
           def customer_id(beneficiary)
             beneficiary.customer_id #TODO customer_id column to be added to bank_beneficiaries table
           end
-      
+
           def app_id(beneficiary)
             beneficiary.service_subscriptions.find_by('IMT TRANSFER').app_id
           end
-  
-        end      
+
+        end
       end
     end
   end

data/lib/starkit_banking/api/ybl/payment/ft2.rb

@@ -3,55 +3,55 @@ module StarkitBanking
     module Payment
       class ByFT2
         include ApiClient
-      
+
         private
-        
+
         def service_name
           'FUNDS TRANSFER'
         end
-      
-        def invoke(env, req)
-          ApiBanking::FundsTransferByCustomerService2.transfer(env, req)
+
+        def invoke(env, req, callbacks)
+          ApiBanking::FundsTransferByCustomerService2.transfer(env, req, callbacks)
         end
-        
+
         def response(res)
           Transfer::Status.new(res.transactionStatus.statusCode, res.transactionStatus.bankReferenceNo, res.transferType)
         end
-      
+
         def credentials(payment)
           payment.payment_account.credentials
         end
-      
+
         def request(subscription, payment)
-        
+
           address = ApiBanking::FundsTransferByCustomerService2::Transfer::Address.new()
           beneficiary = ApiBanking::FundsTransferByCustomerService2::Transfer::Beneficiary.new()
           request = ApiBanking::FundsTransferByCustomerService2::Transfer::Request.new()
-        
+
           # every payment is identified by its ID, repeated API attempts can be identified when the ID is used as the URN
-          @req_reference = request.uniqueRequestNo = payment.id 
-        
+          @req_reference = request.uniqueRequestNo = payment.id
+
           request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.debitAccountNo = payment.payment_account.account_number
           request.transferType = payment.transfer_type || payment.transfer_type
           request.transferAmount = payment.transfer_amount
           request.remitterToBeneficiaryInfo = translate(:transfer_description, payment.transfer_description)
-        
+
           beneficiary.accountNo = payment.beneficiary_account_number
           beneficiary.accountIFSC = payment.beneficiary_ifsc
           beneficiary.fullName = translate(:bene_name, payment.beneficiary_name)
           beneficiary.address = translate(:address_line1, payment.beneficiary_address_line1)
-        
+
           request.beneficiary = beneficiary
-        
-          request       
+
+          request
         end
-      
+
         def subscription(payment)
           payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
-        
+
         def translate(element, value)
           case element
           when :bene_name
@@ -64,7 +64,7 @@ module StarkitBanking
             value.slice(0,119)
           end
         end
-  
+
       end
     end
   end

data/lib/starkit_banking/api/ybl/payment/get_status.rb

@@ -3,40 +3,40 @@ module StarkitBanking
     module Payment
       class GetStatus
         include ApiClient
-      
-        private 
-        
+
+        private
+
         def service_name
           'STATUS ENQUIRY'
         end
-      
-        def invoke(env, req)
-          ApiBanking::FundsTransferByCustomerService2.get_status(env, req)          
+
+        def invoke(env, req, callbacks)
+          ApiBanking::FundsTransferByCustomerService2.get_status(env, req, callbacks)
         end
-        
+
         def response(res)
           Transfer::Status.new(res.transactionStatus.statusCode, res.transactionStatus.bankReferenceNo, res.transferType)
         end
-      
+
         def credentials(payment)
           payment.payment_account.credentials
         end
-      
+
         def request(subscription, payment)
-        
+
           request = ApiBanking::FundsTransferByCustomerService2::GetStatus::Request.new()
 
           request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.requestReferenceNo = payment.id
-        
-          request       
+
+          request
         end
-      
+
         def subscription(payment)
           payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
-  
+
       end
     end
   end

data/lib/starkit_banking/api/ybl/payment/imt.rb

@@ -3,46 +3,46 @@ module StarkitBanking
     module Payment
       class ByIMT
         include ApiClient
-      
+
         private
-        
+
         def service_name
           'IMT TRANSFER'
         end
-      
-        def invoke(env, req)
-          ApiBanking::InstantMoneyTransferService.transfer(env, req)
+
+        def invoke(env, req, callbacks)
+          ApiBanking::InstantMoneyTransferService.transfer(env, req, callbacks)
           # send email
         end
-      
+
         def credentials(payment)
           payment.payment_account.credentials
         end
-        
+
         def response(res)
           Transfer::Status.new('INITIATED', res.initiateTransferResult.bankReferenceNo, 'IMT')
         end
-      
+
         def request(subscription, payment)
           request = ApiBanking::InstantMoneyTransferService::InitiateTransfer::Request.new()
 
           # every payment is identified by its ID, repeated API attempts can be identified when the ID is used as the URN
-          @req_reference = request.uniqueRequestNo = payment.id 
-        
+          @req_reference = request.uniqueRequestNo = payment.id
+
           request.appID = subscription.app_id
           request.customerID = payment.payment_account.customer_id
           request.beneficiaryMobileNo = payment.beneficiary_mobile_no
           request.transferAmount = payment.transfer_amount
           request.passCode = payment.imt_passcode
           request.remitterToBeneficiaryInfo = payment.transfer_description
-        
+
           request
         end
-      
+
         def subscription(payment)
           payment.payment_account.service_subscriptions.find_by(service_name: service_name)
         end
-      
+
       end
     end
   end

data/lib/starkit_banking/concerns/api_step_concern.rb

@@ -0,0 +1,20 @@
+require 'active_support/concern'
+
+module StarkitBanking
+  module ApiStepConcern
+
+    module InstanceMethods
+      attr_accessor :api_step
+
+      def save_api_step
+        api_step.save! if api_step
+      end
+    end
+
+    def self.included(base)
+      base.send :include, InstanceMethods
+      # base.after_commit :save_api_step
+      # base.after_rollback :save_api_step
+    end
+  end
+end

data/lib/starkit_banking/concerns/bank_account.rb

@@ -3,7 +3,8 @@ require 'active_support/concern'
 module StarkitBanking
   module BankAccount
     extend ActiveSupport::Concern
-    
+    include ApiStepConcern
+
     def balance(opts = {})
       @password = opts[:api_password]
       StarkitBanking::API::Factory.get_client(self, 'GetBalance').exec(self)
@@ -13,7 +14,7 @@ module StarkitBanking
       @password = opts[:api_password]
       StarkitBanking::API::Factory.get_client(self, 'GetMiniStatement').exec(self)
     end
-    
+
     def credentials
       c = Finance::ApiBankingCred.find_by(environment: self.environment, bank_name: self.bank_name)
       raise ApiFault.new(OpenStruct.new(code: 'sb:412', subCode: nil, reasonText: "Api Banking Credentials Not Available For #{self.bank_name}, #{self.environment}")) if c.nil?
@@ -21,4 +22,4 @@ module StarkitBanking
       c
     end
   end
-end
+end

data/lib/starkit_banking/concerns/payment.rb

@@ -3,27 +3,28 @@ require 'active_support/concern'
 module StarkitBanking
   module Payment
     extend ActiveSupport::Concern
-    
+    include ApiStepConcern
+
     def is_imt
       self.transfer_type == 'IMT'
     end
-    
+
     def is_eft
       self.transfer_type != 'IMT'
     end
-    
+
     def release(opts = {})
       self.payment_account.instance_variable_set(:@password, opts[:api_password])
       self.environment = self.payment_account.environment
       self.updated_by = opts[:current_user_id]
       self.approve
-      self.reference_no = self.id      
+      self.reference_no = self.id
       self.response = StarkitBanking::API::Factory.get_client(self).exec(self)
     end
-    
+
     def sync_status(opts = {})
       self.payment_account.instance_variable_set(:@password, opts[:api_password])
       self.response = StarkitBanking::API::Factory.get_client(self, 'GetStatus').exec(self)
     end
   end
-end
+end

data/lib/starkit_banking/version.rb

@@ -1,3 +1,3 @@
 module StarkitBanking
-  VERSION = "0.1.9"
+  VERSION = '0.1.10'
 end

data/lib/starkit_banking.rb

@@ -20,6 +20,7 @@ require_relative "starkit_banking/api/ybl/payment/get_status"
 
 require_relative "starkit_banking/api/ybl/beneficiary/imt"
 
+require_relative "starkit_banking/concerns/api_step_concern"
 require_relative "starkit_banking/concerns/bank_account"
 require_relative "starkit_banking/concerns/payment"
 

data/starkit_banking.gemspec

@@ -23,10 +23,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "5.9.1"
   spec.add_development_dependency "vcr", "3.0.3"
   spec.add_development_dependency "webmock", "2.1.0"
+  spec.add_development_dependency "pry"
 
   spec.add_dependency "money", "6.7.1"
   spec.add_dependency "activesupport", "~> 4.2.7"
   spec.add_dependency "activerecord", "~> 4.2.7"
   spec.add_dependency "railties", "~> 4.2.7"
-  spec.add_dependency "api_banking", "0.1.17"
+  spec.add_dependency "api_banking", "0.1.18"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: starkit_banking
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors:
 - akil
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-30 00:00:00.000000000 Z
+date: 2017-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +156,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.17
+        version: 0.1.18
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.1.17
+        version: 0.1.18
 description: 
 email:
 - hello@quantiguous.com
@@ -183,6 +197,7 @@ files:
 - lib/starkit_banking/api/ybl/payment/ft2.rb
 - lib/starkit_banking/api/ybl/payment/get_status.rb
 - lib/starkit_banking/api/ybl/payment/imt.rb
+- lib/starkit_banking/concerns/api_step_concern.rb
 - lib/starkit_banking/concerns/bank_account.rb
 - lib/starkit_banking/concerns/payment.rb
 - lib/starkit_banking/models/api_step.rb
@@ -210,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: StarKit Banking Interface