stanford-mods 2.2.2 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d876e2b5f5ab556e1140c7846fe5a6b23bdc3163
-  data.tar.gz: 4c150486603f2ae953ed0ee7546502cbc2ab1ea2
+  metadata.gz: bf9995bc6d5890bb8520ec918ef23ef8fc6a215e
+  data.tar.gz: 6a39d07658e000e296d40e3666b93ead0c3a32ca
 SHA512:
-  metadata.gz: 9416188a4effed446e89fc9474996d02e2c0d9ab167ac80dd7ec960a83e3973edadb67ec9698d2db8bcf52b1ec594e3267542fdd057e0df51759d3ceb21c97b8
-  data.tar.gz: 1ee250dcef68b1ac7239d241977cb18e41b76dcd03df8e7e6df756a412f81670d2ca0d2d9d2b1a478e21ba5f0862993a43c48019de24dd46bf69a25531007284
+  metadata.gz: 3fb187dbfc6ac4f2f1f21a68dc8cd43940f5cf8e2f67b1895392cc9adbd91eccf163cd6d8e35e5f7fbd72fadd1a0ff7019f2f8120e790f31b8e2d65c275fe5b6
+  data.tar.gz: 4d5e7dbf3099da891b5c15b5d3e64c27b72c1ea305c503b068a5890324dc818db9fb644d500e20afaa0729fb2202628d621f12fd3b8a95fdcfd020d22fdedc05

data/lib/stanford-mods/searchworks.rb

@@ -141,11 +141,15 @@ module Stanford
 
       # @return [String] the nonSort text portion of the titleInfo node as a string (if non-empty, else nil)      
       def nonSort_title
+        return unless first_title_info_node && first_title_info_node.nonSort
+
         first_title_info_node.nonSort.text.strip.empty? ? nil : first_title_info_node.nonSort.text.strip
       end
       
       # @return [String] the text of the titleInfo node as a string (if non-empty, else nil)
       def title
+        return unless first_title_info_node && first_title_info_node.title
+
         first_title_info_node.title.text.strip.empty?   ? nil : first_title_info_node.title.text.strip
       end
       

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "2.2.2".freeze
+    VERSION = "2.3.1".freeze
   end
 end

data/spec/searchworks_title_spec.rb

@@ -26,7 +26,18 @@ describe 'title fields (searchworks.rb)' do
       expect(smods_rec_blank_node.sw_full_title).to eq 'The Jerk : A Tale of Tourettes.'
     end
   end
-  
+
+  context 'missing title node' do
+    it 'deals with missing titleInfo node' do
+      m = "<mods #{@ns_decl}></mods>"
+      smods_rec_blank_node = Stanford::Mods::Record.new
+      smods_rec_blank_node.from_str m
+      expect(smods_rec_blank_node.sw_short_title).to be_blank
+      expect(smods_rec_blank_node.sw_full_title).to be_blank
+      expect(smods_rec_blank_node.sw_sort_title).to be_blank
+    end
+  end
+
   context 'full title (for title_245_search, title_full_display)' do
     it 'should be a String' do
       expect(@smods_rec.sw_full_title).to eq 'The Jerk : A Tale of Tourettes.'

data/stanford-mods.gemspec

@@ -16,24 +16,15 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^spec/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency 'mods', '~> 2.0.2'
+  gem.add_dependency 'mods', '~> 2.0', '>= 2.0.2'
   # active_support for .ordinalize, eg. 1 -> 1st, 2 -> 2nd for centuries
   gem.add_dependency 'activesupport'
 
-  # Runtime dependencies
-  # gem.add_runtime_dependency 'nokogiri'
-
   # Development dependencies
-  # Bundler WILL install these gems too if you've checked out from git and run 'bundle install'
-  # Bundler WILL NOT add these as dependencies if you gem install or add this gem to your Gemfile
   gem.add_development_dependency "rake"
   # docs
   gem.add_development_dependency "rdoc"
   gem.add_development_dependency "yard"
   # tests
   gem.add_development_dependency 'rspec'
-  # using coveralls with travis now
-  # gem.add_development_dependency 'simplecov'
-  # gem.add_development_dependency 'simplecov-rcov'
-  # gem.add_development_dependency 'ruby-debug19'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.1
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,13 +9,16 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-20 00:00:00.000000000 Z
+date: 2016-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.2
   type: :runtime
@@ -23,6 +26,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.2
 - !ruby/object:Gem::Dependency
@@ -171,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata
@@ -195,4 +201,3 @@ test_files:
 - spec/searchworks_title_spec.rb
 - spec/spec_helper.rb
 - spec/sw_publication_spec.rb
-has_rdoc: