stanford-mods 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ceba18b41d0f172731b399e387b32ecd9f8a1c7b
-  data.tar.gz: a13407d8872f1b02eaf08e0b571b0887ef15d568
+  metadata.gz: 691c6e601bb934cb7a1e396d901a6f8205c54b35
+  data.tar.gz: 5efa051bf96155491d58b1bc45c335c138f6b171
 SHA512:
-  metadata.gz: f685d94af38eb9516590935b5eea6b904e4a8eed947006ad8cebe145879cfa15869d260213d2fbc442a2cb0e36cea40af4ab8bcef389155f1cbf59a406f170a7
-  data.tar.gz: 06189a66038f38bb22664b6169811686a8242ce9995d9d3459a2da4cf02bafc39aae42cffd0cf8a44fe642f3c68e0e1a3b6a9cacd860792dad0c6db9c68967f4
+  metadata.gz: d6eb960553c5e11b42ebe3a3ddc86ab41a60ce37d10511380914c95e4bcbbf8ba1b71547313e8be6af97d4850ca4310032b34de920e6075ba33de0e2601bc1ff
+  data.tar.gz: 307a7186e583b23980bb321f614bdc2c8b92dc51895a1cbc959dfba5f7838a5822e71726332b2ba0330b3edd7d0b2d992dc3f9d1a542259004fffcd33fb441eb

data/config/mappings_hash.rb

@@ -30,7 +30,7 @@ name_to_xpath = {
   'physical_description_form'       => '//physicalDescription/form/text()', # .to_s
   'physical_description_media_type' => '//physicalDescription/internetMediaType/text()', # .to_s
 
-# location
+# physical_location
   'physical_location' => '//location/physicalLocation/text()', # .to_s
   'location_url'      => '//location/url/text()', # .to_s
 

data/lib/stanford-mods/physical_location.rb

@@ -47,12 +47,13 @@ module Stanford
         folder_num.first
       end
 
-      # return entire contents of physicalLocation (note: single valued)
+      # return entire contents of physicalLocation as a string (note: single valued)
       #   but only if it has series, accession, box or folder data
       #   data in location/physicalLocation or in relatedItem/location/physicalLocation
       #   so use _location to get the data from either one of them
       # TODO:  should it be hierarchical series/box/folder?
-      def location
+      # NOTE: there is a "physicalLocation" and a "location" method defined in the mods gem, so we cannot use these names to avoid conflicts
+      def physical_location_str
         #   _location.physicalLocation should find top level and relatedItem
         loc = @mods_ng_xml._location.physicalLocation.map do |node|
           node.text if node.text.match(/.*(Series)|(Accession)|(Folder)|(Box).*/i)

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "2.0.0"
+    VERSION = "2.1.0"
   end
 end

data/spec/physical_location_spec.rb

@@ -179,19 +179,19 @@ describe "Physical Location for series, box, folder" do
         context 'in /location/physicalLocation' do
           it "has the expected location '#{expected}'" do
             @smods_rec.from_str(mods_loc_phys_loc)
-            expect(@smods_rec.location).to eq expected
+            expect(@smods_rec.physical_location_str).to eq expected
           end
         end
         context 'in /relatedItem/location/physicalLocation' do
           it "has the expected location '#{expected}'" do
             @smods_rec.from_str(mods_rel_item_loc_phys_loc)
-            expect(@smods_rec.location).to eq expected
+            expect(@smods_rec.physical_location_str).to eq expected
           end
         end
         context 'with multiple physicalLocation elements' do
           it "has the expected location '#{expected}'" do
             @smods_rec.from_str(mods_loc_multiple_phys_loc)
-            expect(@smods_rec.location).to eq expected
+            expect(@smods_rec.physical_location_str).to eq expected
           end
         end
       end # for example

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Naomi Dushay
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata