stanford-mods 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad8829d81dcdd467e55484dbcad16b10ad129399
-  data.tar.gz: cdd05ca0ef149eb382efca02cb5b0a33e8656dd2
+  metadata.gz: 78de4ef412a944f30348ca304d532bc275806ee4
+  data.tar.gz: 3127f3b4e900620d2a130292733957bdb63a685a
 SHA512:
-  metadata.gz: 0afd49e19a7585bb2bc07b9409479aab2d458cb502d38a3aa356326cbc1bebcb5e7beac8ee0d075307274124826802ff8c6af97f4c7aa2cc8e75a1e349419bb4
-  data.tar.gz: 1eb35fb09de5c39ad6631dc5f8e2676d7aff58b83a10e170035cae7063d6a42432f0bd64a7b81c33392ab3ab3dae2579fea2bb1dd5f34148379c1c8e76686c32
+  metadata.gz: 9d65a7dc751eaff5edc2238935a469c32d1c25d5e3965464e4c56c7019a3f865c4103025188a767e56fd58c01b772a6485945c07e81a6ceeff4b133e1878d4d0
+  data.tar.gz: abf7f4068718169e8afcc61accb4d652c90b18ec8caa1eb7bf0f08740386b39dbbb14a962e00831bbb14a1b211e1eba05b18fb03e804d1ab0be887aec788b086

data/.rubocop.yml

@@ -1,3 +1,6 @@
 inherit_from: .rubocop_todo.yml
 
 require: rubocop-rspec
+
+Metrics/LineLength:
+  Max: 120

data/lib/stanford-mods/geo_spatial.rb

@@ -23,16 +23,21 @@ module Stanford
       private
 
       def coord_to_bbox(coord)
-        lng, lat = coord.split('/')
+        matches = coord.match %r{(?<lat>.+--.+)\s*/\s*(?<lng>.+--.+)}
+        return unless matches
+
+        min_x, max_x = matches['lat'].split('--').map { |x| coord_to_decimal(x) }
+        max_y, min_y = matches['lng'].split('--').map { |y| coord_to_decimal(y) }
 
-        min_x, max_x = lng.split('--').map { |x| coord_to_decimal(x) }
-        max_y, min_y = lat.split('--').map { |y| coord_to_decimal(y) }
         "#{min_x} #{min_y} #{max_x} #{max_y}"
       end
 
       def coord_to_decimal(point)
         regex = /(?<dir>[NESW])\s*(?<deg>\d+)°(?:(?<sec>\d+)ʹ)?/
         match = regex.match(point)
+
+        return unless match
+
         dec = 0
 
         dec += match['deg'].to_i

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "1.3.0"
+    VERSION = "1.3.1"
   end
 end

data/spec/geo_spatial_spec.rb

@@ -29,6 +29,19 @@ describe "Cartographic coordinates" do
     EOF
   end
 
+  let(:with_bad_data) do
+    <<-EOF
+      <mods xmlns="#{Mods::MODS_NS}">
+        <subject>
+          <cartographics>
+          <scale>Scale 1:500,000</scale>
+          <coordinates>(Unknown).</coordinates>
+          </cartographics>
+        </subject>
+      </mods>
+    EOF
+  end
+
   context "coordinates" do
     it "returns empty array if no coordinates in the mods" do
       smods_rec.from_str(no_coord)
@@ -45,6 +58,10 @@ describe "Cartographic coordinates" do
       smods_rec.from_str(no_coord)
       expect(smods_rec.point_bbox).to eq([])
     end
+    it "returns empty array if bad data is in the mods" do
+      smods_rec.from_str(with_bad_data)
+      expect(smods_rec.point_bbox).to eq([])
+    end
     it "returns decimal representation of latitude and longitude" do
       smods_rec.from_str(with_coords)
       expect(smods_rec.point_bbox).to eq(["-16.0 -15.0 28.0 13.0"])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-24 00:00:00.000000000 Z
+date: 2015-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods