stanford-mods 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 025c7efb3e29b5c56eaf05af7f58eb364e13c8f7
-  data.tar.gz: 4d66ca23ed45283c8374fa50166f694f63c31bb8
+  metadata.gz: dec8a7a5501522cd7e061ee8c78ad8e9155f09ee
+  data.tar.gz: 279acc503c49653d0edf63d86909fd7b3679efcc
 SHA512:
-  metadata.gz: f4c1b8aaf08deb76e6de29153cd492def619aa884b8841e7c68254ea076da2948d91ab81123f81ee565f1cb41f7ba85ee2a4dff4bec1a4b2f10f72cd77775a44
-  data.tar.gz: 8b90601ce966f4ac16cac8dd78c255b692eff2bfdaef8dcd889bdc257acdc594f47925baddd705b2d969cc646c3df4295198edefba1f1bd0c6bfe3011232be6f
+  metadata.gz: 7a2239d5219fffa8346568392897d2561f7a0c68307329fa4bdbe72dc5ad5d3f24b9aeb3b3fbc4b1085d26fdb19a0eedadd00c439aa93c1313a3726d3b216a18
+  data.tar.gz: b03a84ad3ae27ebd0b6222959afc534f2468169f1262659d74645107339b9bb21b6168a55c7252b032f000edb4b3c3e8862983adaf5c4475143c39b08899ea62

data/lib/stanford-mods/name.rb

@@ -53,10 +53,13 @@ module Stanford
       def non_collector_person_authors
         result = []
         @mods_ng_xml.personal_name.map do |n|
-          r = n.role
-          unless (r.authority.include?('marcrelator') && r.value.include?('Collector')) ||
-                  r.roleTerm.valueURI.first == COLLECTOR_ROLE_URI
-            result << n.display_value_w_date
+          unless n.role.size == 0
+            n.role.each { |r|
+              unless (r.authority.include?('marcrelator') && r.value.include?('Collector')) ||
+                      r.roleTerm.valueURI.first == COLLECTOR_ROLE_URI
+                result << n.display_value_w_date
+              end
+            }
           end
         end
         result unless result.empty?

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "1.2.0"
+    VERSION = "1.2.1"
   end
 end

data/spec/name_spec.rb

@@ -305,6 +305,16 @@ describe "name/author concepts" do
       smods_rec.from_str(mods_start + name_snippet + mods_end)
       expect(smods_rec.non_collector_person_authors).to eq nil
     end
+    it 'no role present' do
+      name_snippet =
+        <<-EOF
+          <name type="personal" usage="primary">
+            <namePart>#{name}</namePart>
+          </name>
+        EOF
+      smods_rec.from_str(mods_start + name_snippet + mods_end)
+      expect(smods_rec.non_collector_person_authors).to eq nil
+    end
   end
 
   context '#collectors_w_dates' do
@@ -417,5 +427,15 @@ describe "name/author concepts" do
       smods_rec.from_str(mods_start + name_snippet + mods_end)
       expect(smods_rec.collectors_w_dates).to eq nil
     end
+    it 'no role present' do
+      name_snippet =
+        <<-EOF
+          <name type="personal" usage="primary">
+            <namePart>Nobody</namePart>
+          </name>
+        EOF
+      smods_rec.from_str(mods_start + name_snippet + mods_end)
+      expect(smods_rec.collectors_w_dates).to eq nil
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-17 00:00:00.000000000 Z
+date: 2015-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -141,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Stanford specific wrangling of MODS metadata