stanford-mods 0.0.27 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9617b16653a05aef7a4369146c3da872e27ae1fc
-  data.tar.gz: e8b07e17af94b4cfc5e3210cd875c6a217efe86a
+  metadata.gz: f1bb292e526add1944d2595260b5edfdd66950fb
+  data.tar.gz: e814a340c6e3ceff0f0d5b373631409c3f5f0253
 SHA512:
-  metadata.gz: ec62fd240d006e705d3767bb829c0ef15c18d9135b9acbab5838b4366d536c0e43de293bc53e4722b92cfb42b193c2b106ffdfbc103e3bbcd0802efd99bdfe1c
-  data.tar.gz: 7588c07a0bf04c4cbceb8a291b833c54619529b8d94de5bcc1e6b3245a6daf288a1c5d4c1676684b39b6519e52ed08f1139713efeefa1df69f5869d93a36243b
+  metadata.gz: e9f4f142a9b09f8a61d82570b1fe0588dd3224645de7047e9b9229ff47c0efc15a12bba4583d0edce2ed2d36a2beddddb66edc3ea1edcc9010a6146136c8e1a5
+  data.tar.gz: b17d44c20f7bf39645f0659ddf034d6846c13ee6a548da2386b454269144882314acb34cfbde2d7a0baacd4e63f0d9d59aa9a859c4acf41f4cc651c15eb3ae18

data/README.rdoc

@@ -59,6 +59,7 @@ Example Using SearchWorks Mixins:
 6. Create new Pull Request
 
 == Releases
+* <b>1.0.0</b> sw_full_title now includes partName and partNumber; sw_title_display created to be like sw_full_title but without trailing punctuation; sw format for typeOfResource sound recording; genre value is librettos, plural; sw format algorithm accommodates first letter upcase; genre value report does NOT map to a format, genre value 'project report' with ToR text is 'Book'
 * <b>0.0.27</b> add genres 'Issue brief', 'Book chapter' and 'Working paper' to map to searchworks format 'Book'
 * <b>0.0.26</b> map typeOfResource 'sound recording-musical' to searchworks format 'Music - Recording' with spaces
 * <b>0.0.25</b> map typeOfResource 'text' and genre 'report' to searchworks format 'Book'

data/lib/stanford-mods/searchworks.rb

@@ -75,7 +75,7 @@ module Stanford
       
       # @return [Array<String>] values for author_corp_display
       def sw_corporate_authors
-        val=@mods_ng_xml.plain_name.select {|n| n.type_at == 'corporate'}.map { |n| n.display_value_w_date }
+        val = @mods_ng_xml.plain_name.select {|n| n.type_at == 'corporate'}.map { |n| n.display_value_w_date }
         val
       end
       
@@ -123,13 +123,46 @@ module Stanford
         short_titles ? short_titles.first : nil
       end
       
-      # @return [String] value for title_245_search, title_display, title_full_display
+      # @return [String] value for title_245_search, title_full_display
       def sw_full_title
-        toret = full_titles ? full_titles.find { |s| s =~ Regexp.new(Regexp.escape(sw_short_title)) } : nil
-        if toret
-          toret = toret.gsub(/,$/, '')
+        outer_nodes = @mods_ng_xml.title_info
+        outer_node = outer_nodes ? outer_nodes.first : nil
+        if outer_node
+          nonSort = outer_node.nonSort.text.strip.empty? ? nil : outer_node.nonSort.text.strip
+          title = outer_node.title.text.strip.empty? ? nil: outer_node.title.text.strip
+          preSubTitle = nonSort ? [nonSort, title].compact.join(" ") : title
+          preSubTitle.sub!(/:$/, '') if preSubTitle # remove trailing colon
+
+          subTitle = outer_node.subTitle.text.strip
+          preParts = subTitle.empty? ? preSubTitle : preSubTitle + " : " + subTitle
+          preParts.sub!(/\.$/, '') if preParts # remove trailing period
+          
+          partName = outer_node.partName.text.strip unless outer_node.partName.text.strip.empty?
+          partNumber = outer_node.partNumber.text.strip unless outer_node.partNumber.text.strip.empty?
+          partNumber.sub!(/,$/, '') if partNumber # remove trailing comma
+          if partNumber && partName
+            parts = partNumber + ", " + partName
+          elsif partNumber
+            parts = partNumber
+          elsif partName
+            parts = partName
+          end
+          parts.sub!(/\.$/, '') if parts
+
+          result = parts ? preParts + ". " + parts : preParts
+          result += "." if !result.match(/[[:punct:]]$/)
+          result = nil if result.empty?
+          result
+        else
+          nil
         end
-        toret
+      end
+      
+      # @return [String] value for title_display (like title_full_display without trailing punctuation)
+      def sw_title_display
+        result = sw_full_title ? sw_full_title : nil
+        result.sub!(/[[:punct:]]$/, '') if result
+        result
       end
       
       # this includes all titles except 
@@ -141,17 +174,25 @@ module Stanford
       # Returns a sortable version of the main title
       # @return [String] value for title_sort field
       def sw_sort_title
-        val = '' + ( sort_title ? sort_title : '')
-        val.gsub(/[[:punct:]]*/, '').strip
+        # get nonSort piece
+        outer_nodes = @mods_ng_xml.title_info
+        outer_node = outer_nodes ? outer_nodes.first : nil
+        if outer_node
+          nonSort = outer_node.nonSort.text.strip.empty? ? nil : outer_node.nonSort.text.strip
+        end
+        
+        val = '' + ( sw_full_title ? sw_full_title : '')
+        val.sub!(Regexp.new("^" + nonSort), '') if nonSort
+        val.gsub!(/[[:punct:]]*/, '').strip
+        val.squeeze(" ").strip
       end
       
       #remove trailing commas
+      # @deprecated in favor of sw_title_display
       def sw_full_title_without_commas
-        toret = self.sw_full_title
-        if toret
-          toret = toret.gsub(/,$/, '')
-        end
-        toret
+        result = self.sw_full_title
+        result.sub!(/,$/, '') if result
+        result
       end
     
       # ---- end TITLE ----
@@ -501,23 +542,28 @@ module Stanford
                 val << 'Computer File'
               when 'sound recording-musical'
                 val << 'Music - Recording'
-              when 'sound recording-nonmusical'
+              when 'sound recording-nonmusical', 'sound recording'
                 val << 'Sound Recording'
               when 'still image'
                 val << 'Image'
               when 'text'
                 val << 'Book' if issuance and issuance.include? 'monographic'
-                val << 'Book' if genres and genres.include? 'book chapter'
-                val << 'Book' if genres and genres.include? 'issue brief'
-                val << 'Book' if genres and genres.include? 'libretto'
-                val << 'Book' if genres and genres.include? 'report'
-                val << 'Book' if genres and genres.include? 'technical report'
-                val << 'Book' if genres and genres.include? 'working paper'
-                val << 'Conference Proceedings' if genres and genres.include? 'conference publication'
+                book_genres = ['book chapter', 'Book chapter', 'Book Chapter',
+                  'issue brief', 'Issue brief', 'Issue Brief', 
+                  'librettos', 'Librettos', 
+                  'project report', 'Project report', 'Project Report',
+                  'technical report', 'Technical report', 'Technical Report',
+                  'working paper', 'Working paper', 'Working Paper']
+                val << 'Book' if genres and !(genres & book_genres).empty?
+                conf_pub = ['conference publication', 'Conference publication', 'Conference Publication']
+                val << 'Conference Proceedings' if genres and !(genres & conf_pub).empty?
                 val << 'Journal/Periodical' if issuance and issuance.include? 'continuing'
-                val << 'Journal/Periodical' if genres and genres.include? 'article'
-                val << 'Other' if genres and genres.include? 'student project report'
-                val << 'Thesis' if genres and genres.include? 'thesis'
+                article = ['article', 'Article']
+                val << 'Journal/Periodical' if genres and !(genres & article).empty?
+                stu_proj_rpt = ['student project report', 'Student project report', 'Student Project report', 'Student Project Report']
+                val << 'Other' if genres and !(genres & stu_proj_rpt).empty?
+                thesis = ['thesis', 'Thesis']
+                val << 'Thesis' if genres and !(genres & thesis).empty?
               when 'three dimensional object'
                 val << 'Other'
             end

data/lib/stanford-mods/version.rb

@@ -1,6 +1,6 @@
 module Stanford
   module Mods
     # this is the Ruby Gem version
-    VERSION = "0.0.27"
+    VERSION = "1.0.0"
   end
 end

data/spec/searchworks_format_spec.rb

@@ -13,38 +13,81 @@ describe "Format field from Searchworks mixin for Stanford::Mods::Record" do
       it 'originInfo/issuance monographic' do
         m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><originInfo><issuance>monographic</issuance></originInfo></mods>"
         @smods_rec.from_str(m)
-        @smods_rec.format.should == ['Book']
+        expect(@smods_rec.format).to eq ['Book']
       end
       context "genre" do
         it "'book chapter'", :email => 'mods-squad 2014-05-22, Joanna Dyla' do
           m = "<mods #{@ns_decl}><genre>book chapter</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Book chapter</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Book Chapter</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
         end
         it "'issue brief'", :email => 'mods-squad 2014-05-22, Joanna Dyla' do
           m = "<mods #{@ns_decl}><genre>issue brief</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Issue brief</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Issue Brief</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
         end
-        it "'libretto'", :email => 'mods-squad 2014-05-22, Laura Wilsey' do
+        it "'librettos'", :jira => 'INDEX-98' do
+          m = "<mods #{@ns_decl}><genre>librettos</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Librettos</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+        end
+        it "'libretto' isn't valid", :jira => 'INDEX-98' do
           m = "<mods #{@ns_decl}><genre>libretto</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq []
+        end
+        it "'project report'", :jira => 'GRYP-170', :github => 'gdor-indexer/#7' do
+          m = "<mods #{@ns_decl}><genre>project report</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Project report</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Project Report</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
         end
-        it "'report'", :jira => 'GRYP-170', :github => 'gdor-indexer/#7' do
+        it "'report' isn't valid", :jira => 'GRYP-170', :github => 'gdor-indexer/#7' do
           m = "<mods #{@ns_decl}><genre>report</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq []
         end
         it "'technical report'", :jira => 'GRYPHONDOR-207' do
           m = "<mods #{@ns_decl}><genre>technical report</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Technical report</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Technical Report</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
         end
         it "'working paper'", :email => 'mods-squad 2014-05-22, Joanna Dyla' do
           m = "<mods #{@ns_decl}><genre>working paper</genre><typeOfResource>text</typeOfResource></mods>"
           @smods_rec.from_str(m)
-          @smods_rec.format.should == ['Book']
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Working paper</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
+          m = "<mods #{@ns_decl}><genre>Working Paper</genre><typeOfResource>text</typeOfResource></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.format).to eq ['Book']
         end
       end
     end
@@ -54,67 +97,139 @@ describe "Format field from Searchworks mixin for Stanford::Mods::Record" do
     it "no genre (e.g. Dataset)" do
       m = "<mods #{@ns_decl}><typeOfResource>software, multimedia</typeOfResource></mods>"
       @smods_rec.from_str(m)
-      @smods_rec.format.should == ['Computer File']
+      expect(@smods_rec.format).to eq ['Computer File']
     end
     it "genre 'game'", :jira => 'GRYPHONDOR-207' do
       m = "<mods #{@ns_decl}><genre>game</genre><typeOfResource>software, multimedia</typeOfResource></mods>"
       @smods_rec.from_str(m)
-      @smods_rec.format.should == ['Computer File']
+      expect(@smods_rec.format).to eq ['Computer File']
+      m = "<mods #{@ns_decl}><genre>Game</genre><typeOfResource>software, multimedia</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Computer File']
     end
   end
 
   it "Conference Proceedings: typeOfResource 'text', genre 'conference publication'", :jira => 'GRYPHONDOR-207' do
     m = "<mods #{@ns_decl}><genre>conference publication</genre><typeOfResource>text</typeOfResource></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Conference Proceedings']
+    expect(@smods_rec.format).to eq ['Conference Proceedings']
+    m = "<mods #{@ns_decl}><genre>Conference publication</genre><typeOfResource>text</typeOfResource></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Conference Proceedings']
+    m = "<mods #{@ns_decl}><genre>Conference Publication</genre><typeOfResource>text</typeOfResource></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Conference Proceedings']
   end
   
   it "Journal/Periodical: typeOfResource 'text', genre 'article'" do
     m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>article</genre></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Journal/Periodical']
+    expect(@smods_rec.format).to eq ['Journal/Periodical']
+    m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>Article</genre></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Journal/Periodical']
   end
 
   it "Image: typeOfResource 'still image'" do
     m = "<mods #{@ns_decl}><typeOfResource>still image</typeOfResource></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Image']
+    expect(@smods_rec.format).to eq ['Image']
   end
   
   it "Music - Recording: typeOfResource 'sound recording-musical'", :jira => 'GRYPHONDOR-207' do
     m = "<mods #{@ns_decl}><typeOfResource>sound recording-musical</typeOfResource></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Music - Recording']
+    expect(@smods_rec.format).to eq ['Music - Recording']
   end
 
   it "Music - Score: typeOfResource 'notated music'" do
     m = "<mods #{@ns_decl}><typeOfResource>notated music</typeOfResource></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Music - Score']
+    expect(@smods_rec.format).to eq ['Music - Score']
   end
 
   it "Other: typeOfResource 'text', genre 'student project report'", :email => 'from Vitus, August 16, 2013' do
     m = "<mods #{@ns_decl}><genre>student project report</genre><typeOfResource>text</typeOfResource></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Other']
+    expect(@smods_rec.format).to eq ['Other']
+    m = "<mods #{@ns_decl}><genre>Student project report</genre><typeOfResource>text</typeOfResource></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Other']
+    m = "<mods #{@ns_decl}><genre>Student Project report</genre><typeOfResource>text</typeOfResource></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Other']
+    m = "<mods #{@ns_decl}><genre>Student Project Report</genre><typeOfResource>text</typeOfResource></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Other']
   end
   
-  it "Sound Recording: typeOfResource 'sound recording-nonmusical', genre 'sound", :jira => 'GRYPHONDOR-207' do
-    m = "<mods #{@ns_decl}><genre>sound</genre><typeOfResource>sound recording-nonmusical</typeOfResource></mods>"
+  context "Sound Recording:" do
+    it "typeOfResource 'sound recording-nonmusical', genre 'sound", :jira => 'GRYPHONDOR-207' do
+      m = "<mods #{@ns_decl}><genre>sound</genre><typeOfResource>sound recording-nonmusical</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Sound Recording']
+      m = "<mods #{@ns_decl}><genre>Sound</genre><typeOfResource>sound recording-nonmusical</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Sound Recording']
+    end
+    it "typeOfResource 'sound recording', genre 'sound", :jira => 'INDEX-94' do
+      m = "<mods #{@ns_decl}><genre>sound</genre><typeOfResource>sound recording</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Sound Recording']
+      m = "<mods #{@ns_decl}><genre>Sound</genre><typeOfResource>sound recording</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Sound Recording']
+    end
+  end
+
+  it "Thesis: typeOfResource 'text', genre 'thesis'" do
+    m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>thesis</genre></mods>"
+    @smods_rec.from_str(m)
+    expect(@smods_rec.format).to eq ['Thesis']
+    m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>Thesis</genre></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == ['Sound Recording']
+    expect(@smods_rec.format).to eq ['Thesis']
   end
 
   context "Video: typeOfResource 'moving image'" do
     it "no genre" do
       m = "<mods #{@ns_decl}><typeOfResource>moving image</typeOfResource></mods>"
       @smods_rec.from_str(m)
-      @smods_rec.format.should == ['Video']
+      expect(@smods_rec.format).to eq ['Video']
     end
     it "genre 'motion picture'", :jira => 'GRYPHONDOR-207' do
       m = "<mods #{@ns_decl}><genre>motion picture</genre><typeOfResource>moving image</typeOfResource></mods>"
       @smods_rec.from_str(m)
-      @smods_rec.format.should == ['Video']
+      expect(@smods_rec.format).to eq ['Video']
+      m = "<mods #{@ns_decl}><genre>Motion Picture</genre><typeOfResource>moving image</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Video']
+      m = "<mods #{@ns_decl}><genre>Motion Picture</genre><typeOfResource>moving image</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Video']
+    end
+  end
+
+  context "multiple format values", :jira => 'INDEX-32' do
+    it "multiple typeOfResource elements" do
+      m = "<mods #{@ns_decl}><typeOfResource>moving image</typeOfResource><typeOfResource>sound recording</typeOfResource></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Video', 'Sound Recording']
+    end
+    it "multiple genre elements, single typeOfResource" do
+      m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>librettos</genre><genre>article</genre></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Book', 'Journal/Periodical']
+    end
+    it "mish mash" do
+      m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><typeOfResource>still image</typeOfResource><genre>librettos</genre><genre>article</genre></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Book', 'Journal/Periodical', 'Image']
+    end
+    it "doesn't give duplicate values" do
+      m = "<mods #{@ns_decl}><typeOfResource>text</typeOfResource><genre>librettos</genre><genre>issue brief</genre></mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.format).to eq ['Book']
     end
   end
 
@@ -123,7 +238,7 @@ describe "Format field from Searchworks mixin for Stanford::Mods::Record" do
     <dateCreated>1904</dateCreated>
     </originInfo></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == []
+    expect(@smods_rec.format).to eq []
   end
 
   it "empty Array if weird typeOfResource value" do
@@ -131,6 +246,6 @@ describe "Format field from Searchworks mixin for Stanford::Mods::Record" do
     <typeOfResource>foo</typeOfResource>
     </originInfo></mods>"
     @smods_rec.from_str(m)
-    @smods_rec.format.should == []
+    expect(@smods_rec.format).to eq []
   end
 end

data/spec/searchworks_pub_dates_spec.rb

@@ -178,8 +178,6 @@ describe "Date methods in Searchworks mixin for Stanford::Mods::Record" do
   end # u notation
 
 
-
-
   context 'pub_date_sort' do
     before :all do
       m = "<mods #{@ns_decl}><originInfo>

data/spec/searchworks_spec.rb

@@ -109,92 +109,5 @@ describe "Searchworks mixin for Stanford::Mods::Record" do
       end
     end
   end # context sw author methods
-  
-  context "sw title methods" do
-    before(:all) do
-      m = "<mods #{@ns_decl}><titleInfo><title>Jerk</title><subTitle>A Tale of Tourettes</subTitle><nonSort>The</nonSort></titleInfo></mods>"
-      @smods_rec.from_str m      
-    end
-    
-    context "short title (for title_245a_search, title_245a_display) " do
-      it "should call :short_titles" do
-        @smods_rec.should_receive(:short_titles) # in Mods gem
-        @smods_rec.sw_short_title
-      end
-      it "should be a String" do
-        @smods_rec.sw_short_title.should == 'The Jerk'
-      end
-    end
-    
-    context "full title (for title_245_search, title_display, title_full_display)" do
-      it "should call :full_titles" do
-        @smods_rec.should_receive(:full_titles) # in Mods gem
-        @smods_rec.sw_full_title
-      end
-      it "should be a String" do
-        @smods_rec.sw_full_title.should == 'The Jerk A Tale of Tourettes'
-      end
-      it 'should escape regex characters in the sw_short_title' do
-        m = "<mods #{@ns_decl}><titleInfo>
-            <title>Pius V. Saint, [Michaele Gisleri),</title>
-          </titleInfo></mods>"
-        @smods_rec.from_str m
-        @smods_rec.sw_full_title.should == 'Pius V. Saint, [Michaele Gisleri)'     
-      end
-    end
-    
-    context "additional titles (for title_variant_search)" do
-      before(:all) do
-        m = "<mods #{@ns_decl}>
-          <titleInfo type='alternative'><title>Alternative</title></titleInfo>
-          <titleInfo><title>Jerk</title><nonSort>The</nonSort></titleInfo>
-          <titleInfo><title>Joke</title></titleInfo>
-          </mods>"
-        @smods_rec.from_str(m)
-        @addl_titles = @smods_rec.sw_addl_titles
-      end
-      it "should not include the main title" do
-        @addl_titles.size.should == 2
-        @addl_titles.should_not include(@smods_rec.sw_full_title)
-      end
-      it "should include any extra main titles" do
-        @addl_titles.should include('Joke')
-      end
-      it "should include all alternative titles" do
-        @addl_titles.should include('Alternative')
-      end
-      it 'shold escape the short title in the regexp' do
-         m = "<mods #{@ns_decl}>
-            <titleInfo type='alternative'><title>Alternative</title></titleInfo>
-            <titleInfo><title>[Jerk)</title><nonSort>The</nonSort></titleInfo>
-            <titleInfo><title>Joke]</title></titleInfo>
-            </mods>"
-          @smods_rec.from_str(m)
-          @addl_titles = @smods_rec.sw_addl_titles
-      end
-    end    
-    
-    context "sort title" do
-      it "should be a String" do
-        @smods_rec.sw_sort_title.should be_an_instance_of(String)
-      end
-      it "should use the sort title, as retrieved by :sort_title" do
-        @smods_rec.should_receive(:sort_title) # in Mods gem
-        @smods_rec.sw_sort_title
-      end
-      it "should not begin or end with whitespace" do
-        m = "<mods #{@ns_decl}>
-        <titleInfo><title>      Jerk     </title></titleInfo>
-        </mods>"
-        @smods_rec.from_str(m)
-        @smods_rec.sw_sort_title.should == @smods_rec.sw_sort_title.strip
-      end
-      it "should not have any punctuation marks" do
-        r = Stanford::Mods::Record.new
-        r.from_str "<mods #{@ns_decl}><titleInfo><title>J,e.r;;;k</title></titleInfo></mods>"
-        r.sw_sort_title.should =~ /^Jerk$/
-      end
-    end
-  end # content sw title methods
 
 end

data/spec/searchworks_title_spec.rb

@@ -0,0 +1,578 @@
+# encoding: UTF-8
+require 'spec_helper'
+
+describe "title fields from Searchworks mixin for Stanford::Mods::Record" do
+  before(:all) do
+    @smods_rec = Stanford::Mods::Record.new
+    @ns_decl = "xmlns='#{Mods::MODS_NS}'"
+    m = "<mods #{@ns_decl}><titleInfo><title>Jerk</title><subTitle>A Tale of Tourettes</subTitle><nonSort>The</nonSort></titleInfo></mods>"
+    @smods_rec.from_str m      
+  end
+  
+  context "short title (for title_245a_search, title_245a_display) " do
+    it "should call :short_titles" do
+      @smods_rec.should_receive(:short_titles) # in Mods gem
+      @smods_rec.sw_short_title
+    end
+    it "should be a String" do
+      expect(@smods_rec.sw_short_title).to eq 'The Jerk'
+    end
+  end
+  
+  context "full title (for title_245_search, title_full_display)" do
+    it "should be a String" do
+      expect(@smods_rec.sw_full_title).to eq 'The Jerk : A Tale of Tourettes.'
+    end
+    it 'should cope with regex chars' do
+      m = "<mods #{@ns_decl}><titleInfo>
+          <title>Pius V. Saint, [Michaele Gisleri),</title>
+        </titleInfo></mods>"
+      @smods_rec.from_str m
+      expect(@smods_rec.sw_full_title).to eq 'Pius V. Saint, [Michaele Gisleri),'
+    end
+
+    context "punctuation" do
+      context "no subtitle" do
+        it "end title with a period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics.'
+        end
+        it "title already ends in period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics.</title>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics.'
+        end
+        it "title already ends in other punctuation" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics!</title>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics!'
+        end
+      end # no subtitle
+      context "subtitle" do
+        it "end title with a colon" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history.'
+        end
+        it "title already ends with colon" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics:</title>
+              <subTitle>a history</subTitle>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history.'
+        end #
+        # "end subtitle with period" - see above
+        it "subtitle already ends with period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history.</subTitle>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history.'
+        end
+        it "subtitle already ends with other punctuation" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history?</subTitle>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history?'
+        end
+      end # subtitle
+      context "partName" do
+        context "no partNumber" do
+          it "end partName with period" do
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <nonSort>The</nonSort>
+                <title>Olympics</title>
+                <subTitle>a history</subTitle>
+                <partName>Ancient</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Ancient.'
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <title>cfb</title>
+                <partName>Appendix</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'cfb. Appendix.'
+          end
+          it "partName already ends with period" do
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <nonSort>The</nonSort>
+                <title>Olympics</title>
+                <subTitle>a history</subTitle>
+                <partName>Ancient.</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Ancient.'
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <title>cfb</title>
+                <partName>Appendix.</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'cfb. Appendix.'
+          end
+        end # no partNumber
+        context "partNumber" do
+          it "end partNumber with comma" do
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <nonSort>The</nonSort>
+                <title>Olympics</title>
+                <subTitle>a history</subTitle>
+                <partNumber>Part 1</partNumber>
+                <partName>Ancient</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Part 1, Ancient.'
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <title>cfb</title>
+                <partNumber>1894</partNumber>
+                <partName>Appendix</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'cfb. 1894, Appendix.'
+          end
+          it "partNumber already ends with comma" do
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <nonSort>The</nonSort>
+                <title>Olympics</title>
+                <subTitle>a history</subTitle>
+                <partNumber>Part 1,</partNumber>
+                <partName>Ancient</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Part 1, Ancient.'
+            m = "<mods #{@ns_decl}>
+              <titleInfo>
+                <title>cfb</title>
+                <partNumber>1894,</partNumber>
+                <partName>Appendix</partName>
+              </titleInfo></mods>"
+            @smods_rec.from_str(m)
+            expect(@smods_rec.sw_full_title).to eq 'cfb. 1894, Appendix.'
+          end
+        end
+      end # partName
+      context "no partName, but partNumber" do
+        it "end partNumber with period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partNumber>Part 1</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Part 1.'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partNumber>1894</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'cfb. 1894.'
+        end
+        it "parNumber already ends in period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partNumber>Part 1.</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Part 1.'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partNumber>1894.</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'cfb. 1894.'
+        end
+        it "partNumber already ends with other punctuation" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partNumber>Part 1!</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'The Olympics : a history. Part 1!'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partNumber>1894?</partNumber>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_full_title).to eq 'cfb. 1894?'
+        end
+      end # no partName but partNumber
+    end # punctuation
+  end # sw_full_title
+  
+  context "sw_title_display removes end punctuation of sw_full_title_display" do
+    context "no subtitle" do
+      it "end title with a period" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics'
+      end
+      it "title already ends in period" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics.</title>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics'
+      end
+      it "title already ends in other punctuation" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics!</title>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics'
+      end
+    end # no subtitle
+    context "subtitle" do
+      it "end title with a colon" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history</subTitle>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history'
+      end
+      it "title already ends with colon" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics:</title>
+            <subTitle>a history</subTitle>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history'
+      end #
+      # "end subtitle with period" - see above
+      it "subtitle already ends with period" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history.</subTitle>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history'
+      end
+      it "subtitle already ends with other punctuation" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history?</subTitle>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history'
+      end
+    end # subtitle
+    context "partName" do
+      context "no partNumber" do
+        it "end partName with period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partName>Ancient</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Ancient'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partName>Appendix</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'cfb. Appendix'
+        end
+        it "partName already ends with period" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partName>Ancient.</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Ancient'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partName>Appendix.</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'cfb. Appendix'
+        end
+      end # no partNumber
+      context "partNumber" do
+        it "end partNumber with comma" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partNumber>Part 1</partNumber>
+              <partName>Ancient</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1, Ancient'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partNumber>1894</partNumber>
+              <partName>Appendix</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'cfb. 1894, Appendix'
+        end
+        it "partNumber already ends with comma" do
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <nonSort>The</nonSort>
+              <title>Olympics</title>
+              <subTitle>a history</subTitle>
+              <partNumber>Part 1,</partNumber>
+              <partName>Ancient</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1, Ancient'
+          m = "<mods #{@ns_decl}>
+            <titleInfo>
+              <title>cfb</title>
+              <partNumber>1894,</partNumber>
+              <partName>Appendix</partName>
+            </titleInfo></mods>"
+          @smods_rec.from_str(m)
+          expect(@smods_rec.sw_title_display).to eq 'cfb. 1894, Appendix'
+        end
+      end
+    end # partName
+    context "no partName, but partNumber" do
+      it "end partNumber with period" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history</subTitle>
+            <partNumber>Part 1</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1'
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <title>cfb</title>
+            <partNumber>1894</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'cfb. 1894'
+      end
+      it "parNumber already ends in period" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history</subTitle>
+            <partNumber>Part 1.</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1'
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <title>cfb</title>
+            <partNumber>1894.</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'cfb. 1894'
+      end
+      it "partNumber already ends with other punctuation" do
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <nonSort>The</nonSort>
+            <title>Olympics</title>
+            <subTitle>a history</subTitle>
+            <partNumber>Part 1!</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'The Olympics : a history. Part 1'
+        m = "<mods #{@ns_decl}>
+          <titleInfo>
+            <title>cfb</title>
+            <partNumber>1894?</partNumber>
+          </titleInfo></mods>"
+        @smods_rec.from_str(m)
+        expect(@smods_rec.sw_title_display).to eq 'cfb. 1894'
+      end
+    end # no partName but partNumber
+  end # sw_title_display
+  
+  context "additional titles (for title_variant_search)" do
+    before(:all) do
+      m = "<mods #{@ns_decl}>
+        <titleInfo type='alternative'><title>Alternative</title></titleInfo>
+        <titleInfo><title>Jerk</title><nonSort>The</nonSort></titleInfo>
+        <titleInfo><title>Joke</title></titleInfo>
+        </mods>"
+      @smods_rec.from_str(m)
+      @addl_titles = @smods_rec.sw_addl_titles
+    end
+    it "should not include the main title" do
+      expect(@addl_titles.size).to eq 2
+      expect(@addl_titles).not_to include(@smods_rec.sw_full_title)
+    end
+    it "should include any extra main titles" do
+      expect(@addl_titles).to include('Joke')
+    end
+    it "should include all alternative titles" do
+      expect(@addl_titles).to include('Alternative')
+    end
+    it 'should cope with regexp chars in the short title when determining addl titles' do
+      m = "<mods #{@ns_decl}>
+          <titleInfo type='alternative'><title>Alternative</title></titleInfo>
+          <titleInfo><title>[Jerk)</title><nonSort>The</nonSort></titleInfo>
+          <titleInfo><title>Joke]</title></titleInfo>
+          </mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.sw_addl_titles).to eq ['Alternative', 'Joke]']
+    end
+  end    
+  
+  context "sort title" do
+    it "should be a String" do
+      expect(@smods_rec.sw_sort_title).to be_an_instance_of(String)
+    end
+    it "should use the sw_full_title as a starting point" do
+      @smods_rec.should_receive(:sw_full_title)
+      @smods_rec.sw_sort_title
+    end
+    it "should not begin or end with whitespace" do
+      m = "<mods #{@ns_decl}>
+        <titleInfo><title>      Jerk     </title></titleInfo>
+        </mods>"
+      @smods_rec.from_str(m)
+      expect(@smods_rec.sw_sort_title).to eq @smods_rec.sw_sort_title.strip
+    end
+    it "should not have any punctuation marks" do
+      r = Stanford::Mods::Record.new
+      r.from_str "<mods #{@ns_decl}><titleInfo><title>J,e.r;;;k</title></titleInfo></mods>"
+      expect(r.sw_sort_title).to match /^Jerk$/
+    end
+  end
+  
+  context "part number should be in full title and sort title", :jira => ['INDEX-31', 'GRYPHONDOR-372'] do
+    before(:all) do
+      @mccarthy_smods_rec = Stanford::Mods::Record.new
+      mccarthy = "<mods #{@ns_decl}>
+        <titleInfo>
+          <title>McCarthy, John</title>
+          <partNumber>Part 2</partNumber>
+        </titleInfo></mods>"
+      @mccarthy_smods_rec.from_str(mccarthy)
+      @insp_general_smods_rec = Stanford::Mods::Record.new
+      insp_general = "<mods #{@ns_decl}>
+        <titleInfo>
+          <title>Semiannual report to Congress</title>
+          <partNumber>October 1, 1998 - March 31, 1999</partNumber>
+        </titleInfo>
+        <titleInfo type=\"uniform\">
+          <title>Semiannual report to Congress (Online)</title>
+        </titleInfo></mods>"
+      @insp_general_smods_rec.from_str(insp_general)
+      @cfb_smods_rec = Stanford::Mods::Record.new
+      cfb = "<mods #{@ns_decl}>
+        <titleInfo>
+          <title>cfb</title>
+          <partNumber>1894</partNumber>
+          <partName>Appendix</partName>
+        </titleInfo></mods>"
+      @cfb_smods_rec.from_str(cfb)
+      @all_smods_rec = Stanford::Mods::Record.new
+      all = "<mods #{@ns_decl}>
+        <titleInfo>
+          <nonSort>The</nonSort>
+          <title>Olympics</title>
+          <subTitle>a history</subTitle>
+          <partNumber>Part 1</partNumber>
+          <partName>Ancient</partName>
+        </titleInfo></mods>"
+      @all_smods_rec.from_str(all)
+    end
+    it "short titles" do
+      expect(@mccarthy_smods_rec.sw_short_title).to eql 'McCarthy, John'
+      expect(@insp_general_smods_rec.sw_short_title).to eql 'Semiannual report to Congress'
+      expect(@cfb_smods_rec.sw_short_title).to eql 'cfb'
+      expect(@all_smods_rec.sw_short_title).to eql 'The Olympics'
+    end
+    it "full titles" do
+      expect(@mccarthy_smods_rec.sw_full_title).to eql 'McCarthy, John. Part 2.'
+      expect(@insp_general_smods_rec.sw_full_title).to eql 'Semiannual report to Congress. October 1, 1998 - March 31, 1999.'
+      expect(@cfb_smods_rec.sw_full_title).to eql 'cfb. 1894, Appendix.'
+      expect(@all_smods_rec.sw_full_title).to eql 'The Olympics : a history. Part 1, Ancient.'
+    end
+    it "additional titles" do
+      expect(@mccarthy_smods_rec.sw_addl_titles).to eql []
+      expect(@insp_general_smods_rec.sw_addl_titles).to eql []
+      expect(@cfb_smods_rec.sw_addl_titles).to eql []
+      expect(@all_smods_rec.sw_addl_titles).to eql []
+    end
+    it "sort title" do
+      expect(@mccarthy_smods_rec.sw_sort_title).to eql 'McCarthy John Part 2'
+      expect(@insp_general_smods_rec.sw_sort_title).to eql 'Semiannual report to Congress October 1 1998 March 31 1999'
+      expect(@cfb_smods_rec.sw_sort_title).to eql 'cfb 1894 Appendix'
+      expect(@all_smods_rec.sw_sort_title).to eql 'Olympics a history Part 1 Ancient'
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stanford-mods
 version: !ruby/object:Gem::Version
-  version: 0.0.27
+  version: 1.0.0
 platform: ruby
 authors:
 - Naomi Dushay
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-27 00:00:00.000000000 Z
+date: 2014-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mods
@@ -111,6 +111,7 @@ files:
 - spec/searchworks_spec.rb
 - spec/searchworks_subject_raw_spec.rb
 - spec/searchworks_subject_spec.rb
+- spec/searchworks_title_spec.rb
 - spec/spec_helper.rb
 - stanford-mods.gemspec
 homepage: https://github.com/sul-dlss/stanford-mods
@@ -143,5 +144,6 @@ test_files:
 - spec/searchworks_spec.rb
 - spec/searchworks_subject_raw_spec.rb
 - spec/searchworks_subject_spec.rb
+- spec/searchworks_title_spec.rb
 - spec/spec_helper.rb
 has_rdoc: