standard 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad16fa94acb2de73ebed6090c37d6e73791f7db9588ce441606963930381d36a
-  data.tar.gz: 2a649119dd14d36e72f0eb159373cba7b173e43b92566a27d92c8d4582564a89
+  metadata.gz: 5243ef8e251d58a567e45ac2ced197b1e7aecebb11fe062017673f60b72c20d9
+  data.tar.gz: 1b7b1d75fd42803b4e2ffe96738bcb67ec60d1fc4db7e7fbda7b8e5b7693d113
 SHA512:
-  metadata.gz: 6190b3e6ffd7bc1f7254c42d085fa42e4e7e5d16032c46841be6c7149a7ee3d3b01ea07487380237bc7745d2d52112b9c1f8434fac55ce11935212ed6f081b08
-  data.tar.gz: d3c470c9d92695eaa9acb8532b2959176e2c6caa42115cb5781eb6efff81ebab9f711ead27598b7acc3c643a193a9848c7b81dc26637f1d239d38cb8131f2009
+  metadata.gz: 6cbb608448c4a9da25f2c88941217272dbd133c6e356d380fcd82109b4921eb1d32c930da5974bef9540da9116b5e5dfa469c5b7241b4b1d2af758d7600fd8e3
+  data.tar.gz: 18248be1abd1e69c865bf2387fc70bcdc271bdf5c90b99e446370aa2e592438326e59656c84e2b6ab36fd404c27db8d1e5b43bbd4005f05c954eeeaa07dfb585

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.0.2
+
+* Preserve RuboCop's CLI exit codes
+  ([#270](https://github.com/testdouble/standard/pull/270)) by
+  [@nicksieger](https://github.com/nicksieger)
+
 ## 1.0.1
 
 * Update rubocop from 1.10.0 to [1.11.0](https://github.com/rubocop-hq/rubocop/releases/tag/v1.11.0)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    standard (1.0.1)
+    standard (1.0.2)
       rubocop (= 1.11.0)
       rubocop-performance (= 1.10.1)
 
@@ -61,4 +61,4 @@ DEPENDENCIES
   standard!
 
 BUNDLED WITH
-   2.2.6
+   2.3.0.dev

data/README.md

@@ -231,11 +231,6 @@ style.
 
 ## I disagree with rule X, can you change it?
 
-**[NOTE: until StandardRB hits 1.0.0, the answer is yes! It just requires
-[opening an issue](https://github.com/testdouble/standard/issues/new) and
-convincing [@searls](https://twitter.com/searls) (the BDFNow) to make the
-change.]**
-
 No. The whole point of Standard is to save you time by avoiding
 [bikeshedding](https://www.freebsd.org/doc/en/books/faq/misc.html#bikeshed-painting)
 about code style. There are lots of debates online about tabs vs. spaces, etc.

data/lib/standard/cli.rb

@@ -3,9 +3,6 @@ require_relative "loads_runner"
 
 module Standard
   class Cli
-    SUCCESS_STATUS_CODE = 0
-    FAILURE_STATUS_CODE = 1
-
     def initialize(argv)
       @argv = argv
       @builds_config = BuildsConfig.new
@@ -14,10 +11,7 @@ module Standard
 
     def run
       config = @builds_config.call(@argv)
-
-      success = @loads_runner.call(config.runner).call(config)
-
-      success ? SUCCESS_STATUS_CODE : FAILURE_STATUS_CODE
+      @loads_runner.call(config.runner).call(config)
     end
   end
 end

data/lib/standard/runners/genignore.rb

@@ -13,7 +13,7 @@ module Standard
           config.rubocop_options[:formatters] = [["files", temp_file.path]]
           config.rubocop_options[:format] = "files"
           config.rubocop_options[:out] = temp_file.path
-          Runners::Rubocop.new.call(config)
+          exit_code = Runners::Rubocop.new.call(config)
 
           # Read in the files with errors.  It will have the absolute paths
           # of the files but we only want the relative path.
@@ -37,6 +37,7 @@ module Standard
             file.puts "# Remove from this list as you refactor files."
             file.write(yaml_format_errors.to_yaml)
           end
+          exit_code
         ensure
           # Clean up temp file.
           temp_file.close

data/lib/standard/runners/rubocop.rb

@@ -4,36 +4,15 @@ module Standard
   module Runners
     class Rubocop
       def call(config)
-        rubocop_runner = RuboCop::Runner.new(
-          config.rubocop_options,
-          config.rubocop_config_store
+        rubocop_runner = RuboCop::CLI::Command::ExecuteRunner.new(
+          RuboCop::CLI::Environment.new(
+            config.rubocop_options,
+            config.rubocop_config_store,
+            config.paths
+          )
         )
 
-        rubocop_runner.run(config.paths).tap do |success|
-          print_errors_and_warnings(success, rubocop_runner)
-          print_corrected_code_if_fixing_stdin(config.rubocop_options)
-        end
-      end
-
-      private
-
-      def print_errors_and_warnings(success, rubocop_runner)
-        return unless success
-
-        (rubocop_runner.warnings + rubocop_runner.errors).each do |message|
-          warn message
-        end
-      end
-
-      def print_corrected_code_if_fixing_stdin(rubocop_options)
-        return unless rubocop_options[:stdin] && rubocop_options[:auto_correct]
-
-        if rubocop_options[:stderr]
-          warn "=" * 20
-        else
-          puts "=" * 20
-        end
-        print rubocop_options[:stdin]
+        rubocop_runner.run
       end
     end
   end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("1.0.1")
+  VERSION = Gem::Version.new("1.0.2")
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-03-04 00:00:00.000000000 Z
+date: 2021-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Ruby Style Guide, with linter & automatic code fixer