standard-rails 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5eeb3e6ba8d4da6c2401a846947814610787ca970fb46f12a9e3afbdb5b5b17e
-  data.tar.gz: 267862f4b09d3a910eee0f38c7851443a6e4a7264502ca22c1e43424e7315fd3
+  metadata.gz: 21a20b533745e4b6761fc789fe128b03e4b03e9921a30f14d85087d3398ed130
+  data.tar.gz: 11bbf5b4c1a2c69803d9c5ca12ddf9ee2ed62f82a4843a7df22fe14f0debdad0
 SHA512:
-  metadata.gz: 63d213467768a22f8dd7bcb589c048e84661d26c5d86f547bc46113d37fe6c993efd61018222b0bcd9d064103b982751e64387194dadb13d149b0f3b9dfa9a43
-  data.tar.gz: 85ec0dcdce846df434133d9ebd0bf0bb7f4044b4766297b828904a528e80d90850954853e31e89283df2902159a56d32fa763a8b5a6649fae3e8396aadc2b334
+  metadata.gz: f40c5286a74fd60bad778ba9aeb35b9e6368edf5fc9bff23822afe8cbadcd72c4f7f5a4915481e7f98c55d094f92cdf0c4901c63e80c64091e56e6af53e81746
+  data.tar.gz: 20031a03010687d9e46deb65c6d28d1113e21583f1f4465b2f3f8120ab6cc07ed1c604e1965429a83afcbf99698dd9c31cf6c820f29b6410188688eddf07e751

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [1.0.2]
+
+- Clear warnings about cops extended by rubocop-rails [#25](https://github.com/standardrb/standard-rails/issues/25)
+
+## [1.0.1]
+
+- Fix errors int he initial config [#24](https://github.com/standardrb/standard-rails/pull/24)
+
 ## [1.0.0]
 
 - Update Rubocop Rails to [v2.23.1](https://github.com/rubocop/rubocop-rails/releases/tag/v2.23.1)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    standard-rails (1.0.1)
+    standard-rails (1.0.2)
       lint_roller (~> 1.0)
       rubocop-rails (~> 2.23.1)
 

data/config/base.yml

@@ -19,15 +19,6 @@ AllCops:
   # as the default.
   TargetRailsVersion: ~
 
-# This cop from rubocop was added to the Rubocop-Rails
-# config as part of this PR:
-# https://github.com/rubocop/rubocop-rails/pull/1014
-# in order to support some Rails-specific methods. At the
-# time of writing, it's disabled in Standard, so it's
-# disabled here.
-Lint/RedundantSafeNavigation:
-  Enabled: false
-
 Lint/SafeNavigationChain:
   Enabled: true
   AllowedMethods:
@@ -427,6 +418,3 @@ Rails/WhereNot:
 
 Rails/WhereNotWithMultipleConditions:
   Enabled: false
-
-Style/InvertibleUnlessCondition:
-  Enabled: false

data/lib/standard/rails/plugin.rb

@@ -27,7 +27,9 @@ module Standard
         LintRoller::Rules.new(
           type: :object,
           config_format: :rubocop,
-          value: rules_with_config_applied
+          value: without_extended_rule_configs(
+            rules_with_config_applied
+          )
         )
       end
 
@@ -44,6 +46,18 @@ module Standard
         )
       end
 
+      # rubocop-rails adds additional options to a couple out-of-the-box cops
+      # but Standard (1) doesn't enable these to begin with and (2) doesn't
+      # allow rules' configs to be edited once they are defined, so we'll just
+      # remove them here
+      #
+      # See: https://github.com/standardrb/standard-rails/issues/25#issuecomment-1881127173
+      def without_extended_rule_configs(rules)
+        rules.reject { |(name,_)|
+          ["Style/InvertibleUnlessCondition", "Lint/SafeNavigationChain"].include?(name)
+        }.to_h
+      end
+
       # This is not fantastic.
       #
       # When you `require "rubocop-rails"`, it will not only load the cops,

data/lib/standard/rails/version.rb

@@ -1,5 +1,5 @@
 module Standard
   module Rails
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: standard-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Justin Searls