stacker_bee 2.1.0.pre195 → 2.1.0.pre196

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OGQ4M2Q4OGVjYWQxOWNhNjVhNjZkMGM5NzhjZWRkOWE0YmI3MTE3YQ==
+    ZGJiNzgyOGVhMjIyNzYxZmVkOTE0OWE4MDUzYTAzNzQ0ODY4MTA4Mw==
   data.tar.gz: !binary |-
-    Y2QzMzVjZDMyMzZmMWFjYTk4MzlmYTg0MzdiYmJiNDAxNGRmY2ZkYQ==
+    ZWU2ZTQ3NGQ2YjRmMGJiM2EwNzdmY2RiM2E5N2JhM2ZlMDRiOWVhNg==
 SHA512:
   metadata.gz: !binary |-
-    NTg0MGZiZDY1YTMwZjg3NmJmYjY4MGU3ZDg2MTdkOTZkNzlmYmMyYjA5YjVk
-    NGVhYjQxMzZjYzIyYjViNWJhZjIwYjg1MWY2NGIzZGE3MjJjYzJhZDFjNTY2
-    MDY0MmM5MDk3ZDFhNmE3YmYyYTBmN2Q4MzFmZGE3NzgyM2E5ZWQ=
+    YTVjYTMxN2ZiYWFjMTJiNjZhNDdjMjNhNGUwYTQ2ZmQ3YjdmYTYwMGNhMTYz
+    ZDBjYjRmNjAyN2MwNmZkY2U3NTBlZmVhZmI4MjBmZDY2YmYzNjUzMWJlOWZi
+    YTQ3MDU2NzFlY2QyNGMwMjZkOTkxMDlmNmQyMTY0YTNmYTk5NTU=
   data.tar.gz: !binary |-
-    ZTE0NWIzMzRlNDMwMGM1MDUwY2Y3YjBlNTM4N2VjNGM1MjBkMTYwZjMyYzll
-    ZTA1YTBkNDYzYTE2ZDkyNDRkZmVkMWI2MGNkYTY5MTU5MDcxNzY2ZGIwMDA4
-    OTJmMzI5MDA1MTVjNDU3YzMyMzYzOTM5YWI1NjVmMGU3ZGZiZWE=
+    ODNlZGE1ZWRkODkyYWQ2MmQ4YjEzOWQ0NWFkYWRiOTg3MjBiZmRiNDNmOWMz
+    OWU0ODA3MGRiZDA1ZDIwNDk5M2Q3ZmJmODQ0YmViODI4MjEyNDhiM2E1ZDc0
+    MzMxMDQ2YTY5NmQ5NDhhODBkZjU0YTIxYTY4MzU5N2I2YTI2MTE=

data/lib/stacker_bee/configuration.rb

@@ -2,5 +2,8 @@ require "ostruct"
 
 module StackerBee
   class Configuration < OpenStruct
+    def ssl_verify?
+      !ssl_verify.nil? ? ssl_verify : true
+    end
   end
 end

data/lib/stacker_bee/connection.rb

@@ -19,7 +19,7 @@ module StackerBee
 
       initialize_faraday(
         url: uri.to_s,
-        ssl: { verify: ssl_verify? }
+        ssl: { verify: configuration.ssl_verify? }
       )
     end
 
@@ -48,13 +48,5 @@ module StackerBee
       raise ConnectionError,
             "Failed to connect to #{configuration.url}, #{error}"
     end
-
-    def ssl_verify?
-      if !configuration.ssl_verify.nil?
-        configuration.ssl_verify
-      else
-        true
-      end
-    end
   end
 end

data/spec/units/stacker_bee/configuration_spec.rb

@@ -4,4 +4,22 @@ describe StackerBee::Configuration do
   its(:url)        { should be_nil }
   its(:api_key)    { should be_nil }
   its(:secret_key) { should be_nil }
+
+  describe "#ssl_verify?" do
+    subject { configuration.ssl_verify? }
+    let(:configuration) { described_class.new(ssl_verify: ssl_verify) }
+
+    context "when nil" do
+      let(:ssl_verify) { nil }
+      it { should eq true }
+    end
+    context "when false" do
+      let(:ssl_verify) { false }
+      it { should eq false }
+    end
+    context "when true" do
+      let(:ssl_verify) { true }
+      it { should eq true }
+    end
+  end
 end

data/spec/units/stacker_bee/connection_spec.rb

@@ -4,15 +4,20 @@ describe StackerBee::Connection do
   subject(:get) { connection.get(path, query_params) }
   before { Faraday.stub new: faraday }
 
-  let(:url)           { "http://test.com:1234/foo/bar/" }
-  let(:path)          { "/foo/bar" }
-  let(:secret_key)    { "shhh" }
-  let(:query_params)  { [[:foo, :bar]] }
-  let(:response)      { double(:response) }
-  let(:faraday)       { double(:faraday, get: response) }
-  let(:connection)    { described_class.new(configuration) }
+  let(:url)          { "http://test.com:1234/foo/bar/" }
+  let(:path)         { "/foo/bar" }
+  let(:secret_key)   { "shhh" }
+  let(:query_params) { [[:foo, :bar]] }
+  let(:response)     { double(:response) }
+  let(:faraday)      { double(:faraday, get: response) }
+  let(:connection)   { described_class.new(configuration) }
+  let(:ssl_verify)   { true }
   let(:configuration) do
-    double(url: url, secret_key: secret_key, ssl_verify: nil)
+    StackerBee::Configuration.new(
+      url: url,
+      secret_key: secret_key,
+      ssl_verify: ssl_verify
+    )
   end
 
   context "successfully connecting" do
@@ -52,9 +57,7 @@ describe StackerBee::Connection do
   end
 
   context "when verifying an ssl connection" do
-    let(:configuration) do
-      double(url: url, secret_key: secret_key, ssl_verify: false)
-    end
+    let(:ssl_verify) { false }
     it "specifies the ssl verify option when creating a connection" do
       get
       Faraday.should have_received(:new).with(url: "http://test.com:1234",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stacker_bee
 version: !ruby/object:Gem::Version
-  version: 2.1.0.pre195
+  version: 2.1.0.pre196
 platform: ruby
 authors:
 - Greg Sterndale
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-09 00:00:00.000000000 Z
+date: 2014-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday