staccato 0.1.0 → 0.1.1

data/.rspec

@@ -1,2 +1,2 @@
 --color
---format nested
+--format documentation

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Staccato 0.1.1 ##
+
+*   fixes NoopTracker when track! is called on a hit *martin1keogh*
+
 ## Staccato 0.1.0 ##
 
 *   adds support for all global hit options in any hit type

data/lib/staccato/hit.rb

@@ -122,18 +122,12 @@ module Staccato
       end
     end
 
-    # post the hit to GA collection endpoint
-    # @return [Net::HTTPOK] the GA api always returns 200 OK
+    # send the hit to the tracker
     def track!
-      post(Staccato.tracking_uri, params)
+      tracker.track(params)
     end
 
     private
-    # @private
-    def post(uri, params = {})
-      Net::HTTP.post_form(uri, params)
-    end
-
     def convert_booleans(hash)
       hash.each_pair.with_object({}, &method(:convert_boolean))
     end

data/lib/staccato/tracker.rb

@@ -104,6 +104,19 @@ module Staccato
     def transaction_item(options = {})
       Staccato::TransactionItem.new(self, options).track!
     end
+
+    # post the hit to GA collection endpoint
+    # @return [Net::HTTPOK] the GA api always returns 200 OK
+    def track(params={})
+      post(Staccato.tracking_uri, params)
+    end
+
+    private
+
+    # @private
+    def post(uri, params)
+      Net::HTTP.post_form(uri, params)
+    end
   end
 
   # A tracker which does no tracking
@@ -144,5 +157,8 @@ module Staccato
     # (see Tracker#transaction_item)
     def transaction_item(*)
     end
+
+    def track(*)
+    end
   end
 end

data/lib/staccato/version.rb

@@ -1,4 +1,4 @@
 module Staccato
   # The current Staccato VERSION
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/integration/noop_tracker_spec.rb

@@ -99,4 +99,14 @@ describe Staccato::NoopTracker do
       codez.should have_received(:test)
     end
   end
+
+  describe "#track" do
+    before(:each) do
+      tracker.track
+    end
+
+    it 'does not send a post request' do
+      Net::HTTP.should have_received(:post_form).never
+    end
+  end
 end

data/spec/lib/staccato/exception_spec.rb

@@ -16,6 +16,6 @@ describe Staccato::Exception do
   end
 
   it 'rejects nil fatal boolean field values' do
-    expect(Staccato::Exception.new(tracker, fatal: nil).params.has_key?('exf')).to be_false
+    expect(Staccato::Exception.new(tracker, fatal: nil).params.has_key?('exf')).to eq(false)
   end
 end

data/spec/lib/staccato/hit_spec.rb

@@ -25,6 +25,6 @@ describe Staccato::Hit do
   end
 
   it 'rejects nil boolean field values' do
-    expect(hit_klass.new(tracker, non_interactive: nil).params.has_key?('ni')).to be_false
+    expect(hit_klass.new(tracker, non_interactive: nil).params.has_key?('ni')).to eq(false)
   end
 end

data/staccato.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rake", ">= 3.0.0"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "mocha"
   spec.add_development_dependency "bourne"

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: staccato
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
+  prerelease: 
 platform: ruby
 authors:
 - Tony Pitale
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-05 00:00:00.000000000 Z
+date: 2014-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -27,20 +30,23 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -48,6 +54,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -55,6 +62,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -69,6 +78,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bourne
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -76,6 +86,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -83,6 +94,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -90,6 +102,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -135,26 +148,27 @@ files:
 homepage: https://github.com/tpitale/staccato
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 1.8.29
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Ruby Google Analytics Measurement
 test_files:
 - spec/integration/noop_tracker_spec.rb

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MDM3ZjczOTg3NDUzNWUyZmUxMzI5ZWZhMzEwYmVlMjYyMmY4N2M5YQ==
-  data.tar.gz: !binary |-
-    NGUwOTE4YWIyNWE0ZGRjYjlmMzMxNzlmNzY3ZDJkMzMxMDk5ZjhlMw==
-SHA512:
-  metadata.gz: !binary |-
-    MTdhMzc1NDQ0M2I1ZThiYTVjYTg5ZjFmZmRlY2NlMTdiNDJmODQxZTQwODU0
-    MTY5MDgyMjg1NjZkNjE2ODdmM2JiNjgxN2ZhY2EwOWVmNGY4NDI4N2Q0OTky
-    YThkMGMyYTM3Y2UxMDQ2OWJlYTFjMTcxMTliYThlZTU2ZTNjY2M=
-  data.tar.gz: !binary |-
-    NGIyZDcxMzVmNzE0NTIwOGQxZjY0MDQyNmEyYjM5NDhjY2EzOTc3MTMyNGJi
-    YmI1YTRiZTZiOTkzOWQwYmNmZDVlZmJkY2NkOTY2Zjc0YTBmMmQ1NTRkNjcw
-    NTdkYmMwNjhjZTcyNjIwMWU3NzU2OTZkMzBjZDdkZjc5ZDlkMzY=