ssn_validation 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 055a5606a0f3628720394e6fadc9d7d031cccfd56ae1004184bc7e1c741881b2
-  data.tar.gz: 9fa6a0e907840f4b7e04981144e6d13930a1af4d53103d29ed0d61ad691a0c2b
+  metadata.gz: 0d6fc2b63bb6a88c25c5f12e6893f8981a38b5c370401208ae3545f5a5de62ba
+  data.tar.gz: b8d05dcfcf93ef235727dd14e495e84219ca3bdf58f560f93c60538ed9dd62a0
 SHA512:
-  metadata.gz: 77969a0983d95df462807ea033cf37aca5142e1122d28867e736fcf1515f53b3cf72ed8e8722b1c38603f07f162a225406702fb0ce7671d3510459c38faacffe
-  data.tar.gz: 58ec9cef29eed8d78060b14a3a7d006c746816ab1f6b37f9a3bb2111359b8ad9cd5ae3866fc4850207ed0620e21a44d372ba54cbe0b72c3ac342d18570396620
+  metadata.gz: f851627f3d715d7df181ce92c1039296ae1ab535fca5459632d4b584f317fcb2c79bc18b634993caa56d1508e5d353c69b55c5f4b5f05b864753ff65bd1e0682
+  data.tar.gz: 4c8b4e5b1b27975e0348222ff73bf4c85a104ee5d677953a80f928b8ac4be0702eb57368fa0a2a86b10c026147219f4c38a3ae999ec82ee1cbc62438dbf6e258

data/lib/ssn_validation/ssn.rb

@@ -18,15 +18,23 @@ module SsnValidation
       (ssn[0..2] == "000") && errors[:zero_area]          = "SSN value contains zeros in area number 000-xx-xxxx"
       (ssn[3..4] == "00") && errors[:zero_group]          = "SSN value contains zeros in group number xxx-00-xxxx"
       (ssn[5..8] == "0000") && errors[:zero_serial]       = "SSN value contains zeros in serial number xxx-xx-0000"
-      ascending?(ssn) && errors[:ascending]               = "SSN value contains all ASCENDING digits"
-      descending?(ssn) && errors[:descending]             = "SSN value contains all DESCENDING digits"
       return errors if errors.any?  # return if ssn conditions fail
 
       # check valid ITIN format last
       invalid_itin?(ssn) && errors[:invalid_itin] = "SSN value contains invalid ITIN format 9xx-[x]x-xxxx"
+
+      # check extra validations for possible fake ssns if enabled
+      errors.merge!(validate_ascending_descending(ssn)) if enable_ascending?
       errors
     end
 
+    def self.validate_ascending_descending(ssn)
+      errors = {}
+      ascending?(ssn) && errors[:ascending]               = "SSN value contains all ASCENDING digits"
+      descending?(ssn) && errors[:descending]             = "SSN value contains all DESCENDING digits"
+      return errors 
+    end
+
     def self.ascending?(ssn)
       return true if ssn.chars == DIGITS.rotate(ssn[0].to_i)[0..8]
       return true if ssn.chars == DIGITS_EX0.rotate(ssn[0].to_i - 1)
@@ -48,6 +56,10 @@ module SsnValidation
     def self.test_ssn?(ssn)
       SsnValidation.config.test_ssns.any? {|p| p.match(ssn)}
     end
+
+    def self.enable_ascending?
+      SsnValidation.config.enable_ascending
+    end
   end
 
   def self.validate(ssn)

data/lib/ssn_validation/ssn_validation.rb

@@ -10,9 +10,11 @@ module SsnValidation
 
   class Configuration
     attr_accessor :test_ssns
+    attr_accessor :enable_ascending
 
     def initialize
       @test_ssns = []
+      @enable_ascending = false
     end
   end
 end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module SsnValidation
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/test/lib/ssn_validation/ssn_test.rb

@@ -52,6 +52,21 @@ class SsnTest < Minitest::Test
           assert_equal({nine_digits: 'SSN value is not 9 digits'}, Ssn.validate('303'))
         end
       end
+     describe 'repeating digits invalid' do
+        it 'is invalid' do
+          assert_equal({repeating: 'SSN value contains repeating digits'}, Ssn.validate('888888888'))
+        end
+      end
+      describe 'invalid ITIN' do
+        it 'is invalid' do
+          assert_equal({invalid_itin: 'SSN value contains invalid ITIN format 9xx-[x]x-xxxx'}, Ssn.validate('900991234'))
+        end
+      end
+    end
+    describe 'do extra validations based on probably bogus SSNSs' do
+      before do
+        SsnValidation.config.enable_ascending = true
+      end
       describe 'ascending digits invalid' do
         it 'is invalid' do
           assert_equal({ascending: 'SSN value contains all ASCENDING digits'}, Ssn.validate('123456789'))
@@ -69,7 +84,7 @@ class SsnTest < Minitest::Test
         it 'is invalid' do
           assert_equal({descending: 'SSN value contains all DESCENDING digits'}, Ssn.validate('876543210'))
           assert_equal({descending: 'SSN value contains all DESCENDING digits'}, Ssn.validate('321098765'))
-          assert_equal({descending: 'SSN value contains all DESCENDING digits'}, Ssn.validate('987654321'))
+          assert_equal({descending: 'SSN value contains all DESCENDING digits'}, Ssn.validate('765432109'))
         end
       end
       describe 'descending digits ex 0 invalid' do
@@ -78,16 +93,6 @@ class SsnTest < Minitest::Test
           assert_equal({descending: 'SSN value contains all DESCENDING digits'}, Ssn.validate('765432198'))
         end
       end
-      describe 'repeating digits invalid' do
-        it 'is invalid' do
-          assert_equal({repeating: 'SSN value contains repeating digits'}, Ssn.validate('888888888'))
-        end
-      end
-      describe 'invalid ITIN' do
-        it 'is invalid' do
-          assert_equal({invalid_itin: 'SSN value contains invalid ITIN format 9xx-[x]x-xxxx'}, Ssn.validate('900991234'))
-        end
-      end
     end
     describe 'allowing dummy ssns' do
       it 'allows 666xxxxx' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ssn_validation
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - John Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-26 00:00:00.000000000 Z
+date: 2019-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -50,6 +50,7 @@ files:
 - lib/ssn_validation/ssn_validation.rb
 - lib/validators/social_security_number_validator.rb
 - lib/version.rb
+- ssn_validation-0.1.2.gem
 - ssn_validation.gemspec
 - test/lib/ssn_validation/ssn_test.rb
 - test/lib/ssn_validation_test.rb