sslcheck 0.9.4 → 0.9.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3cef80868e3796537488bac3896a10c52853757
-  data.tar.gz: 12dbc2542745a65fbf439798e208290b4a08b744
+  metadata.gz: c20562eb72f671cb97f212cd1eba23b56bb536ff
+  data.tar.gz: 708991cda40f732a0a7227ddd7237d6853682c52
 SHA512:
-  metadata.gz: b003ebe52cfcea15993e6c2234cb161f81794a924605849b4f6fb55bebea91ba9fbb86a0402050a3caa6b86412129cbfb55705ef6d9cb91ef85cb0fca21134e6
-  data.tar.gz: 7ab5cda4f44d57a15ad209a0315c2bce1355da107382cb35843b1844f32eb1a03af6c26263792c5c779298fe01a2fa5b21ee55a12aed5ae052d6f796fc3b0b71
+  metadata.gz: ddd27cf5c945cc4829da97285e503060db844049bf239a049b41383f094eb14c0a012bf4a457d0151ab30841b599291a9134d8b2c8cee881b9a2de0ff4ba5d39
+  data.tar.gz: 76cf8262a72908aa519bea9f2e3af3ab5ab13bd3134200cad7928c5bf0856b4c9a6e3e3c1fa03fbd646abb22aa742f3f7c3d118ef37ed6ec56be335502fc1b3b

data/acceptance/checking_certificates_spec.rb

@@ -30,5 +30,16 @@ module SSLCheck
         expect(@check.ca_bundle).to be
       end
     end
+    context "when the common name is not correct" do
+      before do
+        @check = Check.new.check('https://mismatch.examples.sslinsight.com')
+      end
+      it 'should not be valid' do
+        expect(@check.valid?).to_not be
+      end
+      it 'should have errors' do
+        expect(@check.errors).to_not be_empty
+      end
+    end
   end
 end

data/lib/sslcheck/check.rb

@@ -63,6 +63,7 @@ module SSLCheck
 
     def validate
       @validator.validate(host_name, peer_cert, ca_bundle)
+      @errors = @errors + @validator.errors
       true
     end
   end

data/lib/sslcheck/validator.rb

@@ -28,6 +28,8 @@ module SSLCheck
       raise CABundleMissingError if ca_bundle.nil? || ca_bundle.empty?
       @common_name = common_name
       @peer_cert = peer_cert
+      @ca_bundle = ca_bundle
+
 
       run_validations(validators)
     end

data/lib/sslcheck/validators/common_name.rb

@@ -12,7 +12,8 @@ module SSLCheck
       end
 
       def matching_wildcard_domain
-        true if (@peer_cert.common_name.match(/\*\./) && @common_name.include?(@peer_cert.common_name.gsub(/\*\./,'')))
+        return true if (@peer_cert.common_name.match(/\*\./) && @common_name.include?(@peer_cert.common_name.gsub(/\*\./,'')))
+        false
       end
 
       def direct_common_name_match

data/lib/sslcheck/version.rb

@@ -1,3 +1,3 @@
 module SSLCheck
-  VERSION = "0.9.4"
+  VERSION = "0.9.4.1"
 end

data/spec/cert_fixtures.rb

@@ -812,3 +812,37 @@ ReYNnyicsbkqWletNw+vHX/bvZ8=
 """
 
 VALID_CA_BUNDLE = [CA_PARENT, CA_GRAND_PARENT, CA_GREAT_GRAND_PARENT]
+
+APP_SSL_INSIGHT_CERT = """
+-----BEGIN CERTIFICATE-----
+MIIFWjCCBEKgAwIBAgIQSXt7yzPv7c88GVt1NwDupzANBgkqhkiG9w0BAQsFADCB
+kDELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4G
+A1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQxNjA0BgNV
+BAMTLUNPTU9ETyBSU0EgRG9tYWluIFZhbGlkYXRpb24gU2VjdXJlIFNlcnZlciBD
+QTAeFw0xNTA0MDMwMDAwMDBaFw0xNjA0MDIyMzU5NTlaMFYxITAfBgNVBAsTGERv
+bWFpbiBDb250cm9sIFZhbGlkYXRlZDEUMBIGA1UECxMLUG9zaXRpdmVTU0wxGzAZ
+BgNVBAMTEmFwcC5zc2xpbnNpZ2h0LmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEP
+ADCCAQoCggEBAOMvQ5zflXGZ6JM7fjyOiOvaYsQepgiegG7uxISWCzCXa+lA49xo
+Or2j7Il5HsuOfF9LuCKFo+1H6+V8X71xqZK4P8IW7Z31iyFmw6uIczuhzwVRs1YJ
+xoE8DzErmtKFSV4IHeEgbNZsZlkfdA7YflSTSXwxcDisJv7STFxLNiGHbu1dCVOl
+j3C1ipiF5rZbwh2P8pUcQwGkp8OWr1XS4K7bsDiRqDTuslykOPyAPEqwgKJu1tAm
+lW0tIs653qRuW7VySmBexBNonQ8HmSqO4NVpqejpy+tSS9VrcADS4UGTpwUUQG7V
+2yA8ymg9RnyaKOLoe7wgkwyy/3YyJE44e1MCAwEAAaOCAecwggHjMB8GA1UdIwQY
+MBaAFJCvajqUWgvYkOoSVnPfQ7Q6KNrnMB0GA1UdDgQWBBTsG2YDDmHoOTHQZEmO
+A/hUsAr4FDAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAU
+BggrBgEFBQcDAQYIKwYBBQUHAwIwTwYDVR0gBEgwRjA6BgsrBgEEAbIxAQICBzAr
+MCkGCCsGAQUFBwIBFh1odHRwczovL3NlY3VyZS5jb21vZG8uY29tL0NQUzAIBgZn
+gQwBAgEwVAYDVR0fBE0wSzBJoEegRYZDaHR0cDovL2NybC5jb21vZG9jYS5jb20v
+Q09NT0RPUlNBRG9tYWluVmFsaWRhdGlvblNlY3VyZVNlcnZlckNBLmNybDCBhQYI
+KwYBBQUHAQEEeTB3ME8GCCsGAQUFBzAChkNodHRwOi8vY3J0LmNvbW9kb2NhLmNv
+bS9DT01PRE9SU0FEb21haW5WYWxpZGF0aW9uU2VjdXJlU2VydmVyQ0EuY3J0MCQG
+CCsGAQUFBzABhhhodHRwOi8vb2NzcC5jb21vZG9jYS5jb20wNQYDVR0RBC4wLIIS
+YXBwLnNzbGluc2lnaHQuY29tghZ3d3cuYXBwLnNzbGluc2lnaHQuY29tMA0GCSqG
+SIb3DQEBCwUAA4IBAQBugXKmDVrHxahyQhOc4FJjV3QeMlgu2wHwjziUdwCFFVLA
+HrJjNsdkgL0/yggTafwHYSq2FF1ZrP8w261frl+JpLSB/Xmfe8eai6lN6/vAGH8U
+vckcrWFEwoEDp1ui4sWEfibHjaDjIcNRkSBuaodhK9Y8OPlhzO0Sw/hRQ1rfaQF1
+y4RKl6auZwAmccdcYDICrbHqocX76tSyZMi6UmE3kQzqH5YUAVP4G3pAn2/kCI4p
+X4nnqR6A1Qz7WsWIY0PdHA4wK5sOSy11a3c7Z2vOABG8LF6HL/UZZIVvSnDvoPWT
+FXKBj7iNTKZDyn1G8b0kxE7zaLF6kAryW3F7IXr0
+-----END CERTIFICATE-----
+"""

data/spec/check_spec.rb

@@ -111,6 +111,13 @@ module SSLCheck
           expect(@sut.valid?).to be
         end
       end
+      context "when the certificate is invalid" do
+        it 'should bubble up any errors found during validation' do
+          @sut = Check.new(FakeClient.new(FakeClientResponse.new(@peer_cert, @ca_bundle)), FakeValidator.new(false, [SSLCheck::Errors::GenericError.new({:name => "generic error", :message => "generic error"})]))
+          @sut.check('www.example.com')
+          expect(@sut.errors.empty?).to_not be
+        end
+      end
     end
   end
 end

data/spec/common_name_validator_spec.rb

@@ -27,7 +27,6 @@ module SSLCheck
           expect(result).to_not be
         end
       end
-
     end
     context "when the common name is mismatched" do
       it 'should return errors' do
@@ -36,5 +35,18 @@ module SSLCheck
         expect(result).to be_a SSLCheck::Errors::Validation::CommonNameMismatch
       end
     end
+    context "When not a wildcard domain" do
+
+      context "and part of the common name matches" do
+        @cert = Certificate.new(APP_SSL_INSIGHT_CERT)
+        @ca_bundle = [Certificate.new(CA_PARENT), Certificate.new(CA_GRAND_PARENT)]
+        it 'should return errors' do
+          sut = Validators::CommonName.new("mismatch.examples.sslinsight.com", @cert, @ca_bundle)
+          result = sut.validate
+          expect(result).to be_a SSLCheck::Errors::Validation::CommonNameMismatch
+        end
+      end
+    end
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sslcheck
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.4.1
 platform: ruby
 authors:
 - Clayton Lengel-Zigich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-02 00:00:00.000000000 Z
+date: 2015-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -140,7 +140,6 @@ files:
 - spec/response_spec.rb
 - spec/spec_helper.rb
 - spec/validator_spec.rb
-- sslcheck-0.9.0.gem
 - sslcheck.gemspec
 homepage: http://github.com/clayton/sslcheck
 licenses: