sshkit 0.0.12 → 0.0.13

data/CHANGELOG.md

@@ -3,6 +3,13 @@
 This file is written in reverse chronological order, newer releases will
 appear at the top.
 
+## 0.0.13
+
+ * Correctly quote `as(user)` commands, previously it would expand to:
+   `sudo su user -c /usr/bin/env echo "Hello World"`, in which the command to
+   run was taken as simply `/usr/bin/env`. By quoting all arguments it should
+   now work as expected. `sudo su user -c "/usr/bin/env echo \""Hello World\""`
+
 ## 0.0.12
 
  * Also print anything the program wrote to stdout when the exit status is

data/lib/sshkit/command.rb

@@ -142,7 +142,7 @@ module SSHKit
           end
         end
         if options[:user]
-          cs << "sudo su #{options[:user]} -c "
+          cs << "sudo su #{options[:user]} -c \""
         end
         if options[:run_in_background]
           cs << 'nohup '
@@ -155,6 +155,9 @@ module SSHKit
         if options[:run_in_background]
           cs << ' > /dev/null &'
         end
+        if options[:user]
+          cs << "\""
+        end
         if options[:env]
           cs << ' )'
         end

data/lib/sshkit/version.rb

@@ -1,3 +1,3 @@
 module SSHKit
-  VERSION = "0.0.12"
+  VERSION = "0.0.13"
 end

data/test/unit/test_command.rb

@@ -78,7 +78,7 @@ module SSHKit
 
     def test_working_as_a_given_user
       c = Command.new(:whoami, user: :anotheruser)
-      assert_equal "sudo su anotheruser -c /usr/bin/env whoami", String(c)
+      assert_equal "sudo su anotheruser -c \"/usr/bin/env whoami\"", String(c)
     end
 
     def test_backgrounding_a_task
@@ -88,12 +88,12 @@ module SSHKit
 
     def test_backgrounding_a_task_as_a_given_user
       c = Command.new(:sleep, 15, run_in_background: true, user: :anotheruser)
-      assert_equal "sudo su anotheruser -c nohup /usr/bin/env sleep 15 > /dev/null &", String(c)
+      assert_equal "sudo su anotheruser -c \"nohup /usr/bin/env sleep 15 > /dev/null &\"", String(c)
     end
 
     def test_backgrounding_a_task_as_a_given_user_with_env
       c = Command.new(:sleep, 15, run_in_background: true, user: :anotheruser, env: {a: :b})
-      assert_equal "( A=b sudo su anotheruser -c nohup /usr/bin/env sleep 15 > /dev/null & )", String(c)
+      assert_equal "( A=b sudo su anotheruser -c \"nohup /usr/bin/env sleep 15 > /dev/null &\" )", String(c)
     end
 
     def test_complete?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sshkit
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
   prerelease: 
 platform: ruby
 authors: