ssdb-attr 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dab5dc911606b9a78c5aa08bb0286befa3d41dec
-  data.tar.gz: d9565247664146d3f8085731cd95a3ca9a947180
+  metadata.gz: 42862ff9c47b1a76de97dad8d083f9f600f59899
+  data.tar.gz: 29d3a85d0b87e99d2b392d571a705c8c0bf31b9b
 SHA512:
-  metadata.gz: d8d060517bede443c4f825d0d6562b924f81922769454a744c87ef12baeee5b6dbf9c6cc77b2108b8721efded04850fac661d068ccf1710b52326d1ebce0976f
-  data.tar.gz: 291e03dc49cabfdba7a1cd1ae92b58efae73a4f08a7fa47d5e7920cbb578b1b178ffbfa1ec0797d1e277fe8a1341a9a74f1e4055e6f6ee6337e0becd669669a6
+  metadata.gz: 015184c70c5f94521c89f9e25f7a6d3c1d4c695b96ffbc70d239b8a706ccd87b968cf7f0240af359066eed9c86983fae5d5c3db20c7f6a0b8d86e605cf3bea65
+  data.tar.gz: bcf2ca89d68a6fe73ff897b8300e825ac2de3973c08a85a270e64a89ea8d22239304167004ce0398a3471d6a014df15bc3f96056641cf4abccc97a113fcd73e2

data/.travis.yml

@@ -0,0 +1,22 @@
+language: ruby
+
+rvm:
+  - 2.3.0
+
+before_install:
+  - git clone -b stable-1.9.2 git://github.com/ideawu/ssdb.git
+  - cd ssdb
+  - make
+  - cd ..
+
+before_script:
+  - ./ssdb/ssdb-server -d ./ssdb/ssdb.conf
+
+after_script:
+  - killall -w ssdb-server
+
+script:
+  - bundle exec rake
+
+notifications:
+  email: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ssdb-attr (0.1.1)
+    ssdb-attr (0.1.3)
       activesupport (~> 4.2.1)
       connection_pool (~> 2.2.0)
       redis (~> 3.2.1)
@@ -72,4 +72,4 @@ DEPENDENCIES
   ssdb-attr!
 
 BUNDLED WITH
-   1.14.5
+   1.15.3

data/README.md

@@ -1,3 +1,11 @@
 # SSDB Attr
 
+[![Build Status](https://travis-ci.org/jianshucom/ssdb-attr.svg?branch=master)](https://travis-ci.org/jianshucom/ssdb-attr)
+
 This gem provides an intuitive interface to define attributes on your ActiveModel class and save them in SSDB server.
+
+# Changelog
+
+### 0.1.3
+
+- Add `load_ssdb_attrs` to get multiple values from SSDB once to avoid multiple SSDB calls.

data/lib/ssdb-attr/version.rb

@@ -1,3 +1,3 @@
 module SSDBAttr
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/ssdb/attr.rb

@@ -3,14 +3,14 @@ module SSDB
     extend ActiveSupport::Concern
 
     included do
-      instance_variable_set(:@ssdb_attr_names, [])
+      instance_variable_set(:@ssdb_attr_definition, {})
 
       after_commit :save_ssdb_attrs,  on: %i(create update)
       after_commit :clear_ssdb_attrs, on: :destroy
     end
 
     module ClassMethods
-      attr_reader :ssdb_attr_names
+      attr_reader :ssdb_attr_definition
       attr_reader :ssdb_attr_id_field
       attr_reader :ssdb_attr_pool_name
 
@@ -37,6 +37,10 @@ module SSDB
         @ssdb_attr_pool_name = pool_name
       end
 
+      def ssdb_attr_names
+        @ssdb_attr_definition.keys
+      end
+
       #
       # Method to define a SSDB attribute in a Ruby Class
       #
@@ -51,14 +55,13 @@ module SSDB
           raise "Type not supported, only `:string` and `:integer` are supported now."
         end
 
-        @ssdb_attr_names << name.to_s
+        @ssdb_attr_definition[name.to_s] = type.to_s
 
         define_method(name) do
           instance_variable_get("@#{name}") || begin
             val = ssdb_attr_pool.with { |conn| conn.get(ssdb_attr_key(name)) } || options[:default]
-            instance_variable_set("@#{name}", val)
+            instance_variable_set("@#{name}", typecaster(val, type))
           end
-          typecaster(instance_variable_get("@#{name}"), type)
         end
 
         define_method("#{name}=") do |val|
@@ -91,6 +94,25 @@ module SSDB
       end
     end
 
+    #
+    # Load the values of all specified attrs.
+    #
+    #
+    # @return [void]
+    #
+    def load_ssdb_attrs(*fields)
+      fields = (fields.map(&:to_s) & self.class.ssdb_attr_names)
+
+      values = ssdb_attr_pool.with do |conn|
+        conn.mget(fields.map { |name| ssdb_attr_key(name) })
+      end
+
+      fields.each_with_index do |attr, index|
+        value = typecaster(values[index], self.class.ssdb_attr_definition[attr])
+        instance_variable_set("@#{attr}", value)
+      end
+    end
+
     private
 
     #
@@ -173,10 +195,11 @@ module SSDB
     # @return [void]
     #
     def reload_ssdb_attrs
-      values = ssdb_attr_pool.with { |conn| conn.mget(*self.class.ssdb_attr_names) }
+      keys = self.class.ssdb_attr_names.map { |name| ssdb_attr_key(name) }
+      values = ssdb_attr_pool.with { |conn| conn.mget(keys) }
 
       self.class.ssdb_attr_names.each_with_index do |attr, index|
-        instance_variable_set("@#{attr}", values[index])
+        instance_variable_set("@#{attr}", typecaster(values[index], self.class.ssdb_attr_definition[attr]))
       end
     end
   end

data/spec/ssdb/attr_spec.rb

@@ -54,11 +54,18 @@ describe SSDB::Attr do
     let(:post) { Post.create(updated_at: 1.day.ago, saved_at: 1.day.ago, changed_at: 1.day.ago) }
     let(:redis) { Redis.new(:url => 'redis://localhost:8888') }
 
-    describe "@ssdb_attr_names" do
-      it "should set `@ssdb_attr_names` correctly"  do
-        ssdb_attr_names = Post.instance_variable_get(:@ssdb_attr_names)
-        expect(ssdb_attr_names).to match_array(["name", "int_version", "default_title", "title",
-          "content", "version", "default_version", "field_with_validation"])
+    describe "@ssdb_attr_definition" do
+      it "should set `@ssdb_attr_definition` correctly"  do
+        ssdb_attr_definition = Post.instance_variable_get(:@ssdb_attr_definition)
+
+        expect(ssdb_attr_definition["name"]).to eq("string")
+        expect(ssdb_attr_definition["int_version"]).to eq("integer")
+        expect(ssdb_attr_definition["default_title"]).to eq("string")
+        expect(ssdb_attr_definition["title"]).to eq("string")
+        expect(ssdb_attr_definition["content"]).to eq("string")
+        expect(ssdb_attr_definition["version"]).to eq("integer")
+        expect(ssdb_attr_definition["default_version"]).to eq("integer")
+        expect(ssdb_attr_definition["field_with_validation"]).to eq("string")
       end
     end
 
@@ -101,8 +108,8 @@ describe SSDB::Attr do
         post.version = 3
 
         post.send(:reload_ssdb_attrs)
-        expect(post.title).to eq("foobar")
-        expect(post.version).to eq(4)
+        expect(post.instance_variable_get(:@title)).to eq("foobar")
+        expect(post.instance_variable_get(:@version)).to eq(4)
       end
     end
 
@@ -125,6 +132,18 @@ describe SSDB::Attr do
       end
     end
 
+    describe "#load_ssdb_attrs" do
+      it "loads the values of all specified attrs" do
+        post = Post.create(title: "foobar", version: 4)
+        post = Post.find(post.id)
+        expect(post.instance_variable_get(:@title)).to be_nil
+
+        post.load_ssdb_attrs(:title, :version)
+        expect(post.instance_variable_get(:@title)).to eq("foobar")
+        expect(post.instance_variable_get(:@version)).to eq(4)
+      end
+    end
+
     describe "#ssdb_attr_key" do
       it "should return correct key" do
         expect(post.send(:ssdb_attr_key, "name")).to eq("posts:#{post.id}:name")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ssdb-attr
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Larry Zhao
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-14 00:00:00.000000000 Z
+date: 2017-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -161,6 +161,7 @@ files:
 - ".rspec"
 - ".ruby-gemset"
 - ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -192,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Provide simple helpers on persist values in redis for performance. Works