sqlserver-sequence 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea055f44adbc2fdc216305cab3d9fca8d158f947
-  data.tar.gz: 648a4d03260ab26bc7437bc61196687d8142e638
+  metadata.gz: ae433f7e06f518a5cb7e1e8ea7658ad1ebf4622b
+  data.tar.gz: 57e0f2334be57255b6422ea4c74aaab12398c6c2
 SHA512:
-  metadata.gz: fd6eabfe7c6a303167b62fadf6af2caf87d42ee3564187657b627dd7ea5b50a1196a8d97fe573186832a6ab175d296c45a3f8814dec6400d5c53c39f4e91627e
-  data.tar.gz: 158697f35073a7f5068307cbf03706643f7e51d6136bbda21154d5a50434c8dd275650921e84bddc9ba71b7b859df480bdbf147d53dffbea16e1a56559ea0591
+  metadata.gz: 806c283d8fb10cacfb17666cdcb0c82bf2697d519a13db6ad97422c9e9fa0a4932abbe5a6af1460e77bce891b616efe21f7f79383c8884e92cda2939e1a9f00d
+  data.tar.gz: 7c668647ae2d70b22e53a22d91a1aeaeb33354d028d373517167e8d54206477cce0bd2ecac29dac15d1ea3932e3a3b10cfb256ed673d8b0c997084264992a112

data/.gitignore

@@ -14,7 +14,7 @@
 mkmf.log
 .idea
 /bin
-
+.rspec
 .idea
 bin
 

data/CODE_OF_CONDUCT.md

@@ -35,7 +35,7 @@ This code of conduct applies both within project spaces and in public spaces
 when an individual is representing the project or its community.
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting a project maintainer at ramanathan.tirunellaisubramanian@careerbuilder.com. All
+reported by contacting one or more of the project maintainers. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. Maintainers are
 obligated to maintain confidentiality with regard to the reporter of an

data/README.md

@@ -93,13 +93,44 @@ end
     $ supplier.number
     > S-0000000010
 
-## Testing with SQLite
 
-If your test suite uses SQLite you'll need to turn off sequence generation or provide a stub for `next_sequence_value`.
+## Configuration
+
+Override any of these defaults in `config/initializers/sqlserver_sequence.rb`:
+
+```ruby
+Sqlserver::Sequence.configure do |config|
+  config.next_value_strategy = Sqlserver::Sequence::Strategies::NextValueFor
+end
+```
+
+### next_value_strategy
+
+By default `Sqlserver::Sequence` will use a strategy that implements SQL Server's [NEXT VALUE FOR](https://msdn.microsoft.com/en-us/library/ff878370.aspx) function.
+
+To change how sequences are generated you can also assign your own strategy:
+
+```ruby
+# lib/size_strategy.rb
+module SizeStrategy
+  def next_sequence_value(sequence_name)
+    self.class.size
+  end
+end
+
+# config/initializers/sqlserver_sequence.rb
+Sqlserver::Sequence.configure do |config|
+  config.next_value_strategy = SizeStrategy
+end
+```
+
+### Development and Testing without SQL Server
+
+If your test or development environment uses something other than SQL Server (e.g. SQLite) a `Simple` strategy is provided to avoid errors.
 
 ```ruby
-before do
-  allow_any_instance_of(Supplier).to receive(:next_sequence_value).and_return('10')
+Sqlserver::Sequence.configure do |config|
+  config.next_value_strategy = Sqlserver::Sequence::Strategies::Simple
 end
 ```
 

data/lib/sqlserver/sequence.rb

@@ -1,15 +1,18 @@
 require 'active_support/concern'
+require 'sqlserver/sequence/configuration'
+require 'sqlserver/sequence//strategies'
 require 'sqlserver/sequence/version'
 
 module Sqlserver
   module Sequence
     extend ActiveSupport::Concern
 
-    class_methods do
+    module ClassMethods
       def sequence(field, options = {})
         unless defined?(sequences)
           include Sqlserver::Sequence::InstanceMethods
-    
+          include next_value_strategy
+
           class_attribute :sequences
           self.sequences = {}
     
@@ -19,16 +22,17 @@ module Sqlserver
         default_options = { name: field.to_s, format: nil, prefix: nil }
         self.sequences[field] = default_options.merge(options)
       end
+
+      private
+
+      def next_value_strategy
+        Sqlserver::Sequence.configuration.next_value_strategy || 
+          Strategies::NextValueFor
+      end
     end
 
     module InstanceMethods
       
-      def next_sequence_value(sequence_name)
-        self.class.connection.select_value(
-          "select next value for #{sequence_name}"
-        )
-      end
-
       private
 
       def set_sequences

data/lib/sqlserver/sequence/configuration.rb

@@ -0,0 +1,21 @@
+module Sqlserver
+  module Sequence
+    class Configuration
+      # The next value strategy is used when generating the next sequence value.
+      # Defaults to {Sqlserver::Sequence::Strategies::NextValueFor}.
+      attr_accessor :next_value_strategy
+    end
+
+    def self.configuration
+      @configuration ||= Configuration.new
+    end
+
+    def self.configuration=(config)
+      @configuration = config
+    end
+
+    def self.configure
+      yield configuration
+    end
+  end
+end

data/lib/sqlserver/sequence/strategies.rb

@@ -0,0 +1,8 @@
+module Sqlserver
+  module Sequence
+    module Strategies
+      autoload :NextValueFor, 'sqlserver/sequence/strategies/next_value_for'
+      autoload :Simple, 'sqlserver/sequence/strategies/simple'
+    end
+  end
+end

data/lib/sqlserver/sequence/strategies/next_value_for.rb

@@ -0,0 +1,13 @@
+module Sqlserver
+  module Sequence
+    module Strategies
+      module NextValueFor
+        def next_sequence_value(sequence_name)
+          self.class.connection.select_value(
+            "select next value for #{sequence_name}"
+          )
+        end
+      end
+    end
+  end
+end

data/lib/sqlserver/sequence/strategies/simple.rb

@@ -0,0 +1,11 @@
+module Sqlserver
+  module Sequence
+    module Strategies
+      module Simple
+        def next_sequence_value(sequence_name)
+          self.class.maximum(:id).to_i.next
+        end
+      end
+    end
+  end
+end

data/lib/sqlserver/sequence/version.rb

@@ -1,5 +1,5 @@
 module Sqlserver
   module Sequence
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

data/spec/configuration_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Sqlserver::Sequence::Configuration do
+
+  context 'when next_value_strategy is set' do    
+    let(:mock_strategy) { Module.new }
+    
+    before do    
+      Sqlserver::Sequence.configure do |config|
+        config.next_value_strategy = mock_strategy
+      end
+
+      spawn_model(:Supplier) { sequence :number }
+    end
+
+    it 'includes that strategy' do
+      expect(Supplier.new).to be_kind_of(mock_strategy)
+    end
+  end
+
+  context 'when next_value_strategy is not set' do   
+    before do
+      Sqlserver::Sequence.configure do |config|
+        config.next_value_strategy = nil
+      end
+
+      spawn_model(:Supplier) { sequence :number }
+    end
+
+    it 'includes Sqlserver::NextValueStrategies::NextValueFor' do
+      expect(Supplier.new).to be_kind_of(
+        Sqlserver::Sequence::Strategies::NextValueFor
+      )
+    end
+  end
+end

data/spec/sequence_spec.rb

@@ -1,15 +1,12 @@
 require 'spec_helper'
 
-class Supplier < ActiveRecord::Base; end
-
 describe Sqlserver::Sequence do
   
-  after(:each) { Supplier.sequences = {} }
+  before { spawn_model :Supplier }
   
   describe '.sequences' do
 
     context 'single sequence' do
-
       before do
         Supplier.sequence :number, name: 'sequence', prefix: 'N'
       end
@@ -28,7 +25,6 @@ describe Sqlserver::Sequence do
     end
 
     context 'multiple sequences' do
-
       before do
         Supplier.sequence :number1, name: 'sequence1', prefix: 'N'
         Supplier.sequence :number2, name: 'sequence2', prefix: 'N'
@@ -53,7 +49,6 @@ describe Sqlserver::Sequence do
     end
 
     context 'with defaults' do
-
       before do
         Supplier.sequence :number
       end
@@ -72,20 +67,6 @@ describe Sqlserver::Sequence do
     end
   end
 
-  describe '#next_sequence_number' do
-
-    before do
-      Supplier.sequence :number
-    end
-
-    let!(:supplier) { Supplier.create }
-    let!(:other_supplier) { Supplier.create }
-
-    it 'returns the next value' do
-      expect(other_supplier.number).to be > supplier.number
-    end
-  end
-
   describe 'saving' do
 
     before do 

data/spec/spec_helper.rb

@@ -27,3 +27,17 @@ ActiveRecord::Schema.define do
     INSERTSEQUENCESQL
   end
 end
+
+RSpec.configure do |config|
+  config.include Sqlserver::Sequence::Testing::ModelMacros
+
+  config.before :each do
+    @spawned_models = []
+  end
+
+  config.after :each do
+    @spawned_models.each do |model|
+      Object.instance_eval { remove_const model } if Object.const_defined?(model)
+    end
+  end
+end

data/spec/strategies/simple_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Sqlserver::Sequence::Strategies::Simple do  
+  
+  before do
+    Sqlserver::Sequence.configure do |config|
+      config.next_value_strategy = Sqlserver::Sequence::Strategies::Simple
+    end
+
+    spawn_model(:Supplier) { sequence :number }
+  end
+
+  describe 'saving' do
+
+    let!(:supplier) { Supplier.create }
+    let!(:other_supplier) { Supplier.create }
+
+    it 'returns the next value' do
+      expect(other_supplier.number).to be > supplier.number
+    end
+
+    it 'uses the maximum id' do
+      expected = Supplier.maximum(:id).next.to_s
+      expect(Supplier.create.number).to eq expected
+    end
+  end
+end

data/spec/support/model_macros.rb

@@ -0,0 +1,12 @@
+module Sqlserver::Sequence
+  module Testing
+    module ModelMacros
+      def spawn_model(klass, &block)
+        Object.instance_eval { remove_const klass } if Object.const_defined?(klass)
+        Object.const_set klass, Class.new(ActiveRecord::Base)
+        Object.const_get(klass).class_eval(&block) if block_given?
+        @spawned_models << klass.to_sym
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sqlserver-sequence
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Zac
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-12 00:00:00.000000000 Z
+date: 2016-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -119,7 +119,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -127,10 +126,17 @@ files:
 - RUNNING_TESTS.md
 - Rakefile
 - lib/sqlserver/sequence.rb
+- lib/sqlserver/sequence/configuration.rb
+- lib/sqlserver/sequence/strategies.rb
+- lib/sqlserver/sequence/strategies/next_value_for.rb
+- lib/sqlserver/sequence/strategies/simple.rb
 - lib/sqlserver/sequence/version.rb
 - spec/config.yml.sample
+- spec/configuration_spec.rb
 - spec/sequence_spec.rb
 - spec/spec_helper.rb
+- spec/strategies/simple_spec.rb
+- spec/support/model_macros.rb
 - sqlserver-sequence.gemspec
 homepage: https://github.com/zacharywelch/sqlserver-sequence
 licenses:
@@ -158,5 +164,8 @@ specification_version: 4
 summary: Sequence number generation in Rails
 test_files:
 - spec/config.yml.sample
+- spec/configuration_spec.rb
 - spec/sequence_spec.rb
 - spec/spec_helper.rb
+- spec/strategies/simple_spec.rb
+- spec/support/model_macros.rb

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.2.3
-before_install: gem install bundler -v 1.12.5