sqa 0.0.32 → 0.0.37

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ce65f3dece761390257e68d4b3ddaf878e27e0b932b6b4dbd2dfecac2244c5f
-  data.tar.gz: 4dc160dda96a433049aeb06898a8a3cbfe1ecec439e1a9942d8272593658be14
+  metadata.gz: 484455cc08530992abd5fc38f02ae973bf1fb243aced961bdf7a8961e3f1b161
+  data.tar.gz: dd3f4cfc5fc7112d6c6e84973f1f5c6376678e69d7713a653c9e04223df35cd1
 SHA512:
-  metadata.gz: 3194aaf4f55f8b2e388af48012ad71b5e282e4a69505f59dae78b29d30d2cb38c74ea06a25eff4b0323644a5b05581562b1c846c80ae0f7a39b2bc2210a58e1b
-  data.tar.gz: 5f5c72d9cbb21e508d85318a2d4173a6ea0e77cbe10f866131a90004b7fe8cb7278422f033038477dcd215cc46fd2738a841d3217b61da6e7ac8f05c18b149dc
+  metadata.gz: bce9d957fb7014508833d97fc733eafb0b776fd824b9c2c5fd8417c94ce29f0ff3cbd6a164a19f82f8a5c25cff657ed200f89d223e6a246ddc19bb9857e4befb
+  data.tar.gz: 57477ab3cc699310ebd205588855252db79127dd160ca981ae2ab0b6ebebd39f3dd19b7b26829f130decaf1a38fe006c3c20857e6a739342b793390d5f3fecea

data/CHANGELOG.md

@@ -1,6 +1,97 @@
 ## [Unreleased]
 
-## [0.0.32] 2025-11-12
+## [0.0.36] - 2025-11-24
+
+### Changed
+- **Phase 3 Architecture & Design Improvements**:
+  - Added deprecation warning for auto-initialization at require time (will be removed in v1.0)
+    - Added `SQA::Config.initialized?` class method to track initialization state
+    - Warning only shows when `$VERBOSE` is set
+  - `concat_and_deduplicate!` now enforces ascending order for TA-Lib compatibility
+    - Warns and forces `descending: false` if `descending: true` is passed
+    - Prevents silent calculation errors from incorrect data ordering
+  - Extracted Faraday connection to configurable dependency in `SQA::Stock`
+    - Added `ALPHA_VANTAGE_URL` constant
+    - Added class methods: `connection`, `connection=`, `default_connection`, `reset_connection!`
+    - Allows injection of custom connections for testing/mocking
+    - Deprecated `CONNECTION` constant (will be removed in v1.0)
+
+### Added
+- **Test Coverage for Phase 3**:
+  - Added 2 tests to `test/config_test.rb` for `initialized?` method
+  - Added 7 tests to `test/stock_test.rb` for configurable connection
+  - Updated `test/data_frame_test.rb` to verify ascending order enforcement
+
+## [0.0.35] - 2025-11-23
+
+### Changed
+- **Phase 2 Code Quality & Best Practices**:
+  - Replaced class variables (`@@var`) with class instance variables (`@var`) for thread safety
+    - `SQA::init.rb`: `@@config`, `@@av_api_key` → `@config`, `@av_api_key`
+    - `SQA::Ticker`: Restructured with `class << self` block, added `reset!` method
+    - `SQA::Stock`: `@@top` → `@top`, added `reset_top!` method
+  - Replaced `puts` statements with `debug_me` in `SQA::SectorAnalyzer`
+  - Simplified `method_missing` in `SQA::DataFrame` (no longer dynamically defines methods)
+  - Fixed type checking pattern in `SQA::Strategy#add` to use `is_a?` instead of `.class ==`
+  - Fixed `SQA::Strategy#available` to use `.name` instead of `.to_s` (avoids pretty_please gem conflict)
+  - Removed magic placeholder "xyzzy" from `SQA::Stock#create_data`
+
+### Fixed
+- **DataFrame.from_aofh**: Fixed Polars compatibility by converting to hash-of-arrays format
+- **DataFrame.from_aofh**: Now properly passes `mapping:` and `transformers:` parameters
+- **Ticker.valid?**: Now handles nil and empty string inputs gracefully
+- **Ticker.lookup**: Now handles nil and empty string inputs gracefully
+
+### Added
+- **Test Coverage for Phase 2**:
+  - New `test/ticker_test.rb` with 10 tests for Ticker class
+  - New `test/strategy_test.rb` with 10 tests for Strategy class
+  - Added 4 tests to `test/data_frame_test.rb` for `from_aofh` and `method_missing`
+  - Added 2 tests to `test/stock_test.rb` for `reset_top!` method
+
+## [0.0.34] - 2025-11-23
+
+### Fixed
+- **Test Suite**: Fixed 15+ pre-existing test failures
+  - Fixed typo in RiskManagerTest (`var` → `cvar`)
+  - Fixed Portfolio test expectations (total_cost, P&L calculation, summary keys)
+  - Fixed URL trailing slash comparisons in AlphaVantage/YahooFinance tests
+  - Fixed FPOP test expectation (implementation returns partial windows)
+  - Fixed SectorAnalyzer symbol/string comparison
+  - Fixed AlphaVantage header mapping test (timestamp, no adjusted_close)
+- **PatternMatcher**: Fixed integer division bug in `pattern_quality` method
+  - Added `.to_f` conversion to prevent truncation with integer inputs
+- **Config Coercion**: Fixed string-to-symbol coercion for `log_level` and `plotting_library`
+  - Added explicit `coerce_key` handlers
+
+### Added
+- **Portfolio**: Added `commission` to `attr_accessor` for public access
+- **Error Namespacing**: Added `SQA::BadParameterError` namespace with backwards-compatible alias
+
+### Changed
+- **Phase 1 Security & Correctness** (from improvement plan):
+  - Replaced shell injection vulnerability (`touch` backticks → `FileUtils.touch`)
+  - Replaced deprecated `has_key?` with `key?` across codebase
+  - Added `SQA::DataFetchError` and `SQA::ConfigurationError` exception classes
+  - Replaced bare `rescue` clauses with specific exception types
+
+## [0.0.33] - 2025-11-23
+
+### Removed
+- **Sinatra Example App**: Removed `examples/sinatra_app/` directory
+  - Functionality moved to separate gem: [sqa_demo-sinatra](https://github.com/MadBomber/sqa_demo-sinatra)
+  - Cleaner separation between library and demo application
+
+### Added
+- **Documentation**: Added links to sqa_demo-sinatra demo application
+  - Updated README.md with Web Demo Application section
+  - Updated docs/index.md with Demo Application section
+  - Updated examples/README.md with reference to web demo
+- **LLM Documentation**: Added llms.txt for AI assistant compatibility
+- **Improvement Plan**: Added docs/IMPROVEMENT_PLAN.md for upcoming code quality improvements
+
+## [0.0.32] - 2024-11-12
+
 ### Added
 - **CSV Updates**: Conditional CSV updates based on timestamp
   - Only updates CSV files when new data is available

data/README.md

@@ -913,6 +913,10 @@ ruby examples/strategy_generator_example.rb
 
 See `examples/README.md` for detailed documentation and integration patterns.
 
+### Web Demo Application
+
+For a complete web-based demonstration of SQA's capabilities, see the **[sqa_demo-sinatra](https://github.com/MadBomber/sqa_demo-sinatra)** gem. This Sinatra application provides a visual interface for exploring stock analysis, technical indicators, and trading strategies.
+
 ## Architecture
 
 **Core Components:**

data/Rakefile

@@ -1,25 +1,67 @@
 # frozen_string_literal: true
 
-
-
 begin
-  require "tocer/rake/register"
-rescue LoadError => error
-  puts error.message
+  require 'tocer/rake/register'
+rescue LoadError => e
+  puts e.message
 end
 
 Tocer::Rake::Register.call
 
+begin
+  require 'yard'
+
+  namespace :docs do
+    desc 'Build complete documentation site (API markdown + MkDocs)'
+    task :build do
+      puts 'Step 1: Generating API documentation from YARD comments...'
+      sh 'ruby bin/generate_api_docs.rb'
+
+      puts "\nStep 2: Building MkDocs site with Material theme..."
+      sh 'mkdocs build'
 
+      puts "\nDocumentation complete!"
+      puts '  Site: site/index.html'
+      puts '  API Reference: site/api-reference/index.html'
+      puts "\nTo preview: rake docs:serve"
+    end
+
+    desc 'Serve documentation locally with live reload'
+    task :serve do
+      puts 'Starting MkDocs development server...'
+      puts 'View at: http://127.0.0.1:8000'
+      puts 'Press Ctrl+C to stop'
+      sh 'mkdocs serve'
+    end
+
+    desc 'Clean generated documentation files'
+    task :clean do
+      puts 'Cleaning generated documentation...'
+      sh 'rm -rf docs/api-reference site .yardoc'
+      puts 'Done!'
+    end
+
+    desc 'Deploy documentation to GitHub Pages'
+    task deploy: :build do
+      puts "\nDeploying to GitHub Pages..."
+      sh 'mkdocs gh-deploy --force'
+
+      puts "\nDeployment complete!"
+      puts 'Documentation is live at: https://madbomber.github.io/sqa/'
+    end
+  end
+rescue LoadError
+  # YARD not available
+end
 
-require "bundler/gem_tasks"
-require "minitest/test_task"
+require 'bundler/gem_tasks'
+require 'minitest/test_task'
 
 Minitest::TestTask.create(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
+  t.libs << 'test'
+  t.libs << 'lib'
   t.warning = false
-  t.test_globs = ["test/**/*_test.rb"]
+  t.test_globs = ['test/**/*_test.rb']
 end
 
 task default: %i[]