spyke 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18786d5a16e1af110485c81e9c7174507bad9ffc
-  data.tar.gz: a12316a477c6c9baf8dc95985ac0c378279cc88f
+  metadata.gz: ccd9957900a277390812c84d78b30985292cb2a9
+  data.tar.gz: c5cdb9be619f68febc8b20a51d339db19fcb7d4e
 SHA512:
-  metadata.gz: caa7363096f246e4a8547499545b288262c6cae186f6130071284619d7f7ccd1f3ddddaa48f840134d7748e88b2c670a532759dcc161e6d21658809bd538529d
-  data.tar.gz: 02a3ece5fbcba5c35723b40459cb85593c5e72be3a3ada1d1840a1b628ec08c9aca6a2bfeb20086aa6c55526cfa673dec54adfa88c375b9765cdcd398d7fae96
+  metadata.gz: af321cc8a304dc3e169ce7d31f113db4a7032de30f4b96e886d3ad8db6961a66b8f88ae932f732aa733b272a69a9840dc5226e9692cb40b3047bc4b44dadbe16
+  data.tar.gz: cddd07072bde4a26fe0bfa5b497747f612f09327f7e7edb35f8f9e428959b32fdbaa90d1bd87e611e500e916e16b730fdfd05460a8e9b7d983ccd4c85ac460c5

data/README.md

@@ -5,10 +5,10 @@
   <br/>
   Interact with remote <strong>REST services</strong> in an <strong>ActiveRecord-like</strong> manner.
   <br /><br />
-  <a href="http://badge.fury.io/rb/spyke"><img src="https://badge.fury.io/rb/spyke.svg" alt="Gem Version" height="18"></a>
+  <a href="https://rubygems.org/gems/spyke"><img src="https://badge.fury.io/rb/spyke.svg?style=flat" alt="Gem Version"></a>
+  <a href='https://gemnasium.com/balvig/spyke'><img src="https://gemnasium.com/balvig/spyke.svg" /></a>
   <a href="https://codeclimate.com/github/balvig/spyke"><img src="https://codeclimate.com/github/balvig/spyke/badges/gpa.svg" /></a>
-  <a href='https://gemnasium.com/balvig/spyke'><img src="http://img.shields.io/gemnasium/balvig/spyke.svg" /></a>
-  <a href='https://coveralls.io/r/balvig/spyke?branch=master'><img src='https://coveralls.io/repos/balvig/spyke/badge.png?branch=master' /></a>
+  <a href='https://coveralls.io/r/balvig/spyke?branch=master'><img src='https://img.shields.io/coveralls/balvig/spyke.svg?style=flat' /></a>
   <a href="https://travis-ci.org/balvig/spyke"><img src="https://travis-ci.org/balvig/spyke.svg?branch=master" /></a>
 </p>
 

data/lib/spyke/associations.rb

@@ -28,6 +28,7 @@ module Spyke
 
       def has_one(name, options = {})
         self.associations = associations.merge(name => options.merge(type: HasOne))
+
         define_method "build_#{name}" do |attributes = nil|
           association(name).build(attributes)
         end

data/lib/spyke/attributes.rb

@@ -46,10 +46,6 @@ module Spyke
 
     private
 
-      def default_attributes
-        self.class.default_attributes
-      end
-
       def parse(attributes)
         attributes.each_with_object({}) do |(key, value), parameters|
           parameters[key] = parse_value(value)

data/lib/spyke/orm.rb

@@ -43,10 +43,6 @@ module Spyke
         new(id: id).destroy
       end
 
-      def build(attributes = {})
-        new(attributes)
-      end
-
       def strip_slug(id)
         id.to_s.split('-').first
       end

data/lib/spyke/version.rb

@@ -1,3 +1,3 @@
 module Spyke
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

data/test/associations_test.rb

@@ -10,9 +10,9 @@ module Spyke
     end
 
     def test_initializing_with_has_many_association
-      group = Group.new(ingredients: [Ingredient.new(title: 'Water'), Ingredient.new(title: 'Flour')])
-      assert_equal %w{ Water Flour }, group.ingredients.map(&:title)
-      assert_equal({ 'group' => { 'ingredients' => [{ 'title' => 'Water' }, { 'title' => 'Flour' }] } }, group.to_params)
+      group = Group.new(ingredients: [Ingredient.new(name: 'Water'), Ingredient.new(name: 'Flour')])
+      assert_equal %w{ Water Flour }, group.ingredients.map(&:name)
+      assert_equal({ 'group' => { 'ingredients' => [{ 'name' => 'Water' }, { 'name' => 'Flour' }] } }, group.to_params)
     end
 
     def test_initializing_with_has_one_association
@@ -255,29 +255,40 @@ module Spyke
       assert_equal %w{ nice spicy }, recipe.groups.map(&:description)
     end
 
-    def test_deeply_nested_attributes_using_array_style
-      params = { groups_attributes: [{ id: 1, ingredient_attributes: [{ title: 'fish' }, { title: 'sauce' } ]}] }
+    def test_nested_attributes_has_many_using_hash_syntax
+      recipe = Recipe.new(groups_attributes: { '0' => { title: 'starter' }, '1' => { title: 'sauce' } })
+      assert_equal %w{ starter sauce }, recipe.groups.map(&:title)
+    end
+
+    def test_deeply_nested_attributes_has_many_using_array_syntax
+      params = { groups_attributes: [{ id: 1, ingredients_attributes: [{ id: 1, name: 'Salt' }, { id: 2, name: 'Pepper' } ]}] }
       recipe = Recipe.new(params)
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
       recipe.attributes = params
-      assert_equal 1, recipe.groups.size
-      skip "ingredients don't get built properly it seems?"
-      assert_equal 'fish', recipe.groups.first.ingredients.first.title
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
     end
 
-    def test_deeply_nested_attributes_with_no_ids
-      params = { groups_attributes: [{ ingredient_attributes: [{ title: 'fish' }, { title: 'sauce' }]}] }
+    def test_deeply_nested_attributes_has_many_using_hash_syntax
+      params = { groups_attributes: { '0' => { id: 1, ingredients_attributes: { '0' => { id: 1, name: 'Salt' }, '1' => { id: 2, name: 'Pepper' } } } } }
       recipe = Recipe.new(params)
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
       recipe.attributes = params
-      assert_equal 1, recipe.groups.size
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
     end
 
-    def test_nested_attributes_has_many_using_hash_syntax
-      recipe = Recipe.new(groups_attributes: { '0' => { title: 'starter' }, '1' => { title: 'sauce' } })
-      assert_equal %w{ starter sauce }, recipe.groups.map(&:title)
+    def test_deeply_nested_attributes_has_many_with_blank_ids_using_array_syntax
+      params = { groups_attributes: [{ ingredients_attributes: [{ name: 'Salt' }, { name: 'Pepper' }]}] }
+      recipe = Recipe.new(params)
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
+      recipe.attributes = params
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
     end
 
-    def test_deeply_nested_attributes_with_blank_ids
-      recipe = Recipe.new(groups_attributes: { '0' => { ingredients_attributes: { '0' => { id: '', name: 'Salt' }, '1' => { id: '', name: 'Pepper' } } } })
+    def test_deeply_nested_attributes_has_many_with_blank_ids_using_hash_syntax
+      params = { groups_attributes: { '0' => { ingredients_attributes: { '0' => { id: '', name: 'Salt' }, '1' => { id: '', name: 'Pepper' } } } } }
+      recipe = Recipe.new(params)
+      assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
+      recipe.attributes = params
       assert_equal %w{ Salt Pepper }, recipe.ingredients.map(&:name)
     end
 

data/test/custom_request_test.rb

@@ -2,9 +2,10 @@ require 'test_helper'
 
 module Spyke
   class CustomRequestTest < MiniTest::Test
-    def test_custom_get_request_from_class
+    def test_custom_get_request_using_class_method
       endpoint = stub_request(:get, 'http://sushi.com/recipes/recent').to_return_json(result: [{ id: 1, title: 'Bread' }])
-      assert_equal %w{ Bread }, Recipe.get('/recipes/recent').map(&:title)
+      recipes = Recipe.get('/recipes/recent')
+      assert_equal %w{ Bread }, recipes.map(&:title)
       assert_requested endpoint
     end
 

data/test/support/fixtures.rb

@@ -16,11 +16,7 @@ class Recipe < Spyke::Base
   accepts_nested_attributes_for :image, :user, :groups
 
   def self.page(number)
-    if number.present?
-      where(page: number)
-    else
-      all
-    end
+    where(page: number)
   end
 
   def ingredients

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spyke
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Jens Balvig