spy 0.4.5 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 459078e1b4845518e7c5e484f86d9b60fe804b89
-  data.tar.gz: c4723869289fb3afcba314f16c2f0c9cd5f4a1ac
+SHA256:
+  metadata.gz: cc1c3954f26350a18af51b75fd2400d06600c859ba9e4675a2ddfb5b983f8a8d
+  data.tar.gz: e535c67bdf68ba225c6cfb98f3182c53004de5452e27eb3d3476deaa16369956
 SHA512:
-  metadata.gz: 9686fc4befa165a861d1e9bb862902e02b153a0584961af9b672c225d8206720f2894d33f64062a8d7b8f4ee0cadd6461ae9cd7c12c9d584fc7ad879faaf6d7e
-  data.tar.gz: 53892408f38307099ecc5ccf7864fbd899f3150c238b71fd8189f561589d702b5d025ed3a5a59800e7caac7277c2d8f98d3f82d99ab647740d164ab98ce067dd
+  metadata.gz: 6d6fb00c5cdc3e0f435f24ffdff53921fa8578f69a004c0b995fda335b69a694a4ea06fe61541d66fb0d40c0a52303d197ceec5b429bec102c09828da19082a4
+  data.tar.gz: 16de7875661311fa5d6ca327ff4510751e88d743e672e937492a8d4abcbd11599f12df9667965c2e5434a5bd6b5725c12caf4c781672fac033ce6c51b5746dbe

data/.travis.yml

@@ -1,11 +1,11 @@
 language: ruby
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - jruby-19mode
+  - 2.1.0
+  - 2.5.1
+  - jruby
   - ruby-head
-  - rbx-19mode
+  - rbx-3
 matrix:
   allow_failures:
       - rvm: ruby-head
-      - rvm: rbx-19mode
+      - rvm: rbx-3

data/CHANGELOG.md

@@ -1,6 +1,7 @@
-## Spy 0.4.3 (Not Released) ##
+## Spy 1.0.0 (October 10, 2018) ##
 
-*   Not Released
+*   drop support for ruby 1.9.3, 2.0. Only support 2.1+ (@dylanahsmith)
+*   support named arguments (@dylanahsmith)
 
 ## Spy 0.4.3 (April 14, 2016) ##
 

data/README.md

@@ -9,7 +9,8 @@
 
 Spy is a lightweight stubbing framework with support for method spies, constant stubs, and object mocks.
 
-Spy was designed for 1.9.3+.
+Spy supports ruby 2.1.0+.
+For versions less than 2.1 use v0.4.5
 
 Spy features that were completed were tested against the rspec-mocks tests so it covers all cases that rspec-mocks does.
 
@@ -197,7 +198,7 @@ In your test file
 ```ruby
   def test_title
     book = Book.new
-    title_spy = Spy.on(book, title)
+    title_spy = Spy.on(book, :title)
     book.title
     book.title
 

data/Rakefile

@@ -3,7 +3,7 @@ require 'rake/testtask'
 
 Rake::TestTask.new do |t|
   t.libs << "test"
-  t.test_files = FileList['test/**/test*.rb']
+  t.test_files = FileList['test/**/test_*.rb']
   t.verbose = true
 end
 

data/lib/spy/subroutine.rb

@@ -32,6 +32,7 @@ module Spy
     def initialize(object, method_name, singleton_method = true)
       @base_object, @method_name = object, method_name
       @singleton_method = singleton_method
+      @plan = nil
       reset!
     end
 
@@ -282,6 +283,8 @@ module Spy
       @arity_range ||=
         if original_method
           min = max = 0
+          key_args = false
+          opt_keys = false
           original_method.parameters.each do |type,_|
             case type
             when :req
@@ -291,8 +294,17 @@ module Spy
               max += 1
             when :rest
               max = Float::INFINITY
+            when :keyreq
+              key_args = true
+            when :keyrest, :key
+              key_args = true
+              opt_keys = true
             end
           end
+          if key_args
+            max += 1
+            min += 1 unless opt_keys
+          end
           (min..max)
         end
     end

data/lib/spy/version.rb

@@ -1,3 +1,3 @@
 module Spy
-  VERSION = "0.4.5"
+  VERSION = "1.0.0"
 end

data/spy.gemspec

@@ -6,12 +6,12 @@ require 'spy/version'
 Gem::Specification.new do |gem|
   gem.name          = "spy"
   gem.version       = Spy::VERSION
-  gem.required_ruby_version = '>= 1.9.3'
+  gem.required_ruby_version = '>= 2.1.0'
   gem.license       = 'MIT'
   gem.authors       = ["Ryan Ong"]
   gem.email         = ["ryanong@gmail.com"]
   gem.summary       = %q{A simple modern mocking library that uses the spy pattern and checks method's existence and arity.}
-  gem.description   = %q{Spy is a mocking library that was made for the modern age. It supports only 1.9.3+. Spy by default will raise an error if you attempt to stub a method that doesn't exist or call the stubbed method with the wrong arity.}
+  gem.description   = %q{Spy is a mocking library that was made for the modern age. It supports only 2.1.0+. Spy by default will raise an error if you attempt to stub a method that doesn't exist or call the stubbed method with the wrong arity.}
   gem.homepage      = "https://github.com/ryanong/spy"
 
   gem.files         = `git ls-files`.split($/)
@@ -20,7 +20,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.add_development_dependency('pry')
   gem.add_development_dependency('pry-nav')
+  gem.add_development_dependency('pry-stack_explorer')
   gem.add_development_dependency('minitest', '>= 4.5.0')
+  gem.add_development_dependency('minitest-reporters')
   gem.add_development_dependency('rspec-core')
   gem.add_development_dependency('rspec-expectations')
   gem.add_development_dependency('coveralls')

data/test/spy/test_mock.rb

@@ -68,6 +68,7 @@ module Spy
       end
     end
 
+    BUGGY_METHODS = %i(tap pretty_print_inspect trust untrust untrusted?)
     def test_mocked_methods
       pen_methods = Pen.public_instance_methods(false) +
         Pen.protected_instance_methods(false) +
@@ -76,8 +77,7 @@ module Spy
       assert_equal pen_methods.sort, @pen_mock.mocked_methods.sort
     end
 
-    buggy_methods = [:tap, :pretty_print_inspect]
-    methods_to_test = Object.instance_methods - buggy_methods
+    methods_to_test = Object.instance_methods - BUGGY_METHODS
     methods_to_test.each do |method_name|
       object_method = Object.instance_method(method_name)
       if object_method.arity == 0 || (RUBY_ENGINE != "jruby" && object_method.parameters == [])

data/test/spy/test_subroutine.rb

@@ -40,13 +40,13 @@ module Spy
     end
 
     def test_spy_can_hook_and_record_a_meta_method_call_on_a_constant
-      assert_equal "meta_method", Pen.meta_method
-      meta_spy = spy_on(Pen, :meta_method)
+      assert_equal "meta_class_method", Pen.meta_class_method
+      meta_spy = spy_on(Pen, :meta_class_method)
       refute meta_spy.has_been_called?
-      assert_nil Pen.meta_method
+      assert_nil Pen.meta_class_method
       assert meta_spy.has_been_called?
       meta_spy.unhook
-      assert_equal "meta_method", Pen.meta_method
+      assert_equal "meta_class_method", Pen.meta_class_method
     end
 
     def test_spy_can_hook_record_and_unhook_a_meta_method
@@ -199,6 +199,38 @@ module Spy
       end
     end
 
+    def test_that_method_spy_keeps_arity_with_optional_keyword_args
+      spy_on(@pen, :opt_kwargs)
+      @pen.opt_kwargs(:pos1)
+      @pen.opt_kwargs(:pos1, opt: 1, opt2: 2)
+      assert_raises ArgumentError do
+        @pen.opt_kwargs
+      end
+      assert_raises ArgumentError do
+        @pen.opt_kwargs(:pos1, :pos2, opt: 1)
+      end
+    end
+
+    def test_that_method_spy_keeps_arity_with_keyword_splat
+      spy_on(@pen, :keyrest)
+      @pen.keyrest
+      @pen.keyrest(a: 1, b: 2)
+      assert_raises ArgumentError do
+        @pen.keyrest(:pos1, :pos2)
+      end
+    end
+
+    def test_that_method_spy_keeps_arity_with_required_keyword_args
+      spy_on(@pen, :req_kwargs)
+      @pen.req_kwargs(req1: 1, req2: 2)
+      assert_raises ArgumentError do
+        @pen.req_kwargs
+      end
+      assert_raises ArgumentError do
+        @pen.req_kwargs(:pos1, :pos2)
+      end
+    end
+
     def test_hook_mimics_public_visibility
       spy_on(@pen, :public_method)
       assert @pen.singleton_class.public_method_defined? :public_method

data/test/support/pen.rb

@@ -38,6 +38,18 @@ class Pen
     "another"
   end
 
+  def opt_kwargs(required, opt: nil, opt2: nil)
+    [required, opt: opt, opt2: opt2]
+  end
+
+  def keyrest(**kwargs)
+    kwargs
+  end
+
+  def req_kwargs(req1:, req2:)
+    [req1, req2]
+  end
+
   protected
   def protected_method
   end
@@ -65,13 +77,11 @@ class Pen
   end
 end
 
-another = "meta_method"
-
-Pen.define_singleton_method(:meta_method) do
-  another
+Pen.define_singleton_method(:meta_class_method) do
+  "meta_class_method".freeze
 end
 
 Pen.send(:define_method, :meta_method) do
-  another
+  "meta_method".freeze
 end
 

data/test/test_helper.rb

@@ -1,9 +1,11 @@
 require 'bundler/setup'
 require 'minitest/autorun'
+require "minitest/reporters"
 require 'pry'
 require 'pry-nav'
 require 'coveralls'
 Coveralls.wear!
+Minitest::Reporters.use!
 
 require 'spy'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spy
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 1.0.0
 platform: ruby
 authors:
 - Ryan Ong
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-26 00:00:00.000000000 Z
+date: 2018-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-stack_explorer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.5.0
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-core
   requirement: !ruby/object:Gem::Requirement
@@ -95,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Spy is a mocking library that was made for the modern age. It supports
-  only 1.9.3+. Spy by default will raise an error if you attempt to stub a method
+  only 2.1.0+. Spy by default will raise an error if you attempt to stub a method
   that doesn't exist or call the stubbed method with the wrong arity.
 email:
 - ryanong@gmail.com
@@ -162,7 +190,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -170,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A simple modern mocking library that uses the spy pattern and checks method's
@@ -201,4 +229,3 @@ test_files:
 - test/spy/test_subroutine.rb
 - test/support/pen.rb
 - test/test_helper.rb
-has_rdoc: