sprockets-urlrewriter 0.0.3 → 0.1.0

data/.gitignore

@@ -2,3 +2,4 @@
 .bundle
 Gemfile.lock
 pkg/*
+*.swp

data/lib/sprockets-urlrewriter/version.rb

@@ -0,0 +1,3 @@
+module SprocketsUrlRewriter
+  VERSION = "0.1.0"
+end

data/lib/sprockets-urlrewriter.rb

@@ -4,14 +4,19 @@ require 'uri'
  
 module Sprockets 
   class UrlRewriter < Processor 
-    VERSION = "0.0.3"
-
     def evaluate(context, locals) 
-      rel = Pathname.new(context.logical_path).parent 
+      # FIXME: Accessing logical_path instance variable directly instead of
+      # using public method, since the public method incorrectly chops paths
+      # with periods in them: https://github.com/sstephenson/sprockets/pull/299
+      #
+      # logical_path = context.logical_path
+      logical_path = context.instance_variable_get(:@logical_path)
+
+      rel = Pathname.new(logical_path).parent
       data.gsub /url\(['"]?([^\s)]+\.[a-z]+)(\?\d+)?['"]?\)/ do |url| 
-        return url if URI.parse($1).absolute? 
-        new_path = rel.join Pathname.new($1) 
-        "url(#{new_path})" 
+        next url if URI.parse($1).absolute?
+        new_path = rel.join Pathname.new($1)
+        "url(#{new_path}#{$2})"
       end 
     end 
   end 

data/spec/urlrewriter_spec.rb

@@ -2,16 +2,24 @@ require 'minitest/autorun'
 require './lib/sprockets-urlrewriter'
 
 describe 'UrlRewriter' do
-  class FakeContext
-    attr_accessor :logical_path
+  let(:context) { FakeContext.new "/assets/css/jada.css" }
+  let(:rewriter) { Sprockets::UrlRewriter.new { @css } }
+  subject { rewriter.evaluate context, {} }
+
+  it 'finds relatives urls and makes them absolute' do
+    @css = "body { background-url: url('bg.jpg?1232') }"
+    assert_equal "body { background-url: url(/assets/css/bg.jpg?1232) }", subject
+  end
+
+  it 'leaves absolute URLs as is' do
+    @css = "body { background-url: url('http://example.com/bg.jpg?1232') }"
+    assert_equal @css, subject
   end
+end
 
-  it 'finds relatives urls and makes them absolut' do
-    ctx = FakeContext.new
-    ctx.logical_path = "/assets/css/jada.css"
-    css = "body { background-url: url('bg.jpg?1232') }"
-    ur = Sprockets::UrlRewriter.new { css }
-    result = ur.evaluate ctx, {}
-    assert_equal "body { background-url: url(/assets/css/bg.jpg) }", result
+class FakeContext
+  attr_accessor :logical_path
+  def initialize(lpath)
+    @logical_path = lpath
   end
 end

data/sprockets-urlrewriter.gemspec

@@ -1,10 +1,10 @@
 # -*- encoding: utf-8 -*-
 $:.push File.expand_path("../lib", __FILE__)
-require "sprockets-urlrewriter"
+require "sprockets-urlrewriter/version"
 
 Gem::Specification.new do |s|
   s.name        = "sprockets-urlrewriter"
-  s.version     = Sprockets::UrlRewriter::VERSION
+  s.version     = SprocketsUrlRewriter::VERSION
   s.authors     = ["Carl Hoerberg"]
   s.email       = ["carl.hoerberg@gmail.com"]
   s.homepage    = "http://github.com/carlhoerberg/sprockets-urlrewriter"
@@ -19,5 +19,6 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_development_dependency "minitest"
+  s.add_development_dependency "rake"
   s.add_runtime_dependency "sprockets"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sprockets-urlrewriter
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-31 00:00:00.000000000 Z
+date: 2012-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70319700411940 !ruby/object:Gem::Requirement
+  requirement: &70294673074580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,21 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70319700411940
+  version_requirements: *70294673074580
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70294673073000 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70294673073000
 - !ruby/object:Gem::Dependency
   name: sprockets
-  requirement: &70319700411240 !ruby/object:Gem::Requirement
+  requirement: &70294673072280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +43,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70319700411240
+  version_requirements: *70294673072280
 description: ! ' Replaces all instances of url() in CSS files Sprockets concats, if
   the url is relative. '
 email:
@@ -46,6 +57,7 @@ files:
 - README.md
 - Rakefile
 - lib/sprockets-urlrewriter.rb
+- lib/sprockets-urlrewriter/version.rb
 - spec/urlrewriter_spec.rb
 - sprockets-urlrewriter.gemspec
 homepage: http://github.com/carlhoerberg/sprockets-urlrewriter
@@ -68,7 +80,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: sprockets-urlrewriter
-rubygems_version: 1.8.10
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: Makes absolut urls in CSS files generated by Sprockets