sprig 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fd26878690f5befbdc2cd52dc8723adbadfaf6c
-  data.tar.gz: 6b0a87bad03c4958fcdd927079bac2c1acf64442
+  metadata.gz: c09e094cca99e32c1042adb111565a9f79f321f2
+  data.tar.gz: 056a2e3a6ac418608dbbbd99dd905f36b8d0b39b
 SHA512:
-  metadata.gz: 6a9f637cd904135b5d7358a235ce8f9350775119a17ce9766eb3e7fea77e2252eff1f90d2cdb7197fe5a5e0e586033835788f3f94b5696d5c9b6b17004f47290
-  data.tar.gz: fa856e5062d5893685b3fa2f9ccd866041d20ba95b8a7c8b722e4137c20b571a0b7f8b3b0d5bdea136fff5a08f55ff202c1ffe835a3047242c1b559ad64eb373
+  metadata.gz: 694d572f95471fde7c7141d97c5e4cd86826791a61e6cd833fd5c54094cb63273ca7d157756c248de35e5b2b5fb35891a4b6bc9064749867a72cdb6c98115879
+  data.tar.gz: 3c3bd1e7530e21baec6cf9b616d271a05aa4ce1fbd2263d5404229121d391778f745113cb4293d8da6bcf2c3a67429b8ba44f9b303329d4d386008fb42bf4154

data/README.md

@@ -1,6 +1,6 @@
 ![Sprig](http://i.imgur.com/XCu3iVO.png)
 
-[![Code Climate](https://codeclimate.com/github/vigetlabs/sprig.png)](https://codeclimate.com/github/vigetlabs/sprig) [![Build Status](https://travis-ci.org/vigetlabs/sprig.png?branch=master)](https://travis-ci.org/vigetlabs/sprig) [![Gem Version](https://badge.fury.io/rb/sprig.png)](http://badge.fury.io/rb/sprig)
+[![Code Climate](https://codeclimate.com/github/vigetlabs/sprig.png)](https://codeclimate.com/github/vigetlabs/sprig) [![Coverage Status](https://coveralls.io/repos/vigetlabs/sprig/badge.png)](https://coveralls.io/r/vigetlabs/sprig) [![Build Status](https://travis-ci.org/vigetlabs/sprig.png?branch=master)](https://travis-ci.org/vigetlabs/sprig) [![Gem Version](https://badge.fury.io/rb/sprig.png)](http://badge.fury.io/rb/sprig)
 
 Seed Rails application by convention, not configuration.
 

data/lib/sprig/dependency.rb

@@ -33,9 +33,6 @@ module Sprig
       raise ArgumentError, 'First argument must be a Class.' unless klass.is_a?(Class)
 
       klass
-    rescue NameError => e
-      raise NameError, e.message
-      #TODO: rescue bad class references
     end
 
     def self.collection

data/lib/sprig/directive.rb

@@ -7,7 +7,7 @@ module Sprig
         case
         when args.is_a?(Hash)
           args
-        when args < ActiveRecord::Base
+        when args.is_a?(Class) && args < ActiveRecord::Base
           { :class => args }
         else
           raise ArgumentError, argument_error_message

data/lib/sprig/helpers.rb

@@ -4,10 +4,6 @@ module Sprig
       Sprig.configuration.directory
     end
 
-    def sprig_environment
-      Rails.env #TODO: make customizable
-    end
-
     def sprig(directive_definitions)
       hopper = []
       DirectiveList.new(directive_definitions).add_seeds_to_hopper(hopper)

data/lib/sprig/seed/factory.rb

@@ -48,10 +48,6 @@ module Sprig
       def options
         @options ||= datasource.options.merge(initial_options)
       end
-
-      def data
-        @data ||= datasource.to_hash
-      end
     end
   end
 end

data/lib/sprig/version.rb

@@ -1,3 +1,3 @@
 module Sprig
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/spec/fixtures/models/post.rb

@@ -1,2 +1,7 @@
 class Post < ActiveRecord::Base
+
+  def photo=(file)
+    write_attribute(:photo, File.basename(file.path))
+  end
+
 end

data/spec/fixtures/seeds/staging/posts.yml

@@ -1,5 +1,3 @@
-# posts.yml
-
 records:
   - sprig_id: 1
     title: 'Staging yaml title'

data/spec/fixtures/seeds/test/comments.yml

@@ -1,5 +1,3 @@
-# comments.yml
-
 records:
   - sprig_id: 1
     post_id: "<%= sprig_record(Post, 1).id %>"

data/spec/fixtures/seeds/test/invalid_users.yml

@@ -1,5 +1,3 @@
-# users.yml
-
 records:
   - sprig_id: 1
     first_name: "Clark"

data/spec/fixtures/seeds/test/legacy_posts.yml

@@ -1,5 +1,3 @@
-# posts.yml
-
 records:
   - sprig_id: 'l_1'
     title: 'Legacy yaml title'

data/spec/fixtures/seeds/test/posts.md

@@ -0,0 +1,5 @@
+# Posts
+
+- Post 1
+- Post 2
+- Post 3

data/spec/fixtures/seeds/test/posts.yml

@@ -1,5 +1,3 @@
-# posts.yml
-
 records:
   - sprig_id: 1
     title: 'Yaml title'

data/spec/fixtures/seeds/test/posts_delete_existing_by.yml

@@ -0,0 +1,7 @@
+options:
+  delete_existing_by: 'title'
+
+records:
+  - sprig_id: 1
+    title: 'Such Title'
+    content: 'New content'

data/spec/fixtures/seeds/test/posts_find_existing_by_missing.yml

@@ -0,0 +1,7 @@
+options:
+  find_existing_by: 'unicorn'
+
+records:
+  - sprig_id: 1
+    title: 'Existing title'
+    content: 'Updated content'

data/spec/fixtures/seeds/test/posts_find_existing_by_multiple.yml

@@ -1,4 +1,3 @@
-# posts_find_existing_by_multiples.yml
 options:
   find_existing_by: ['title', 'content']
 

data/spec/fixtures/seeds/test/posts_find_existing_by_single.yml

@@ -1,4 +1,3 @@
-# posts_find_existing_by_single.yml
 options:
   find_existing_by: 'title'
 

data/spec/fixtures/seeds/test/posts_missing_dependency.yml

@@ -1,5 +1,3 @@
-# posts_missing_dependency.yml
-
 records:
   - sprig_id: 1
     title: 'Yaml title'

data/spec/fixtures/seeds/test/posts_missing_record.yml

@@ -1,5 +1,3 @@
-# posts_missing_dependency.yml
-
 records:
   - sprig_id: 1
     title: 'Yaml title'

data/spec/fixtures/seeds/test/posts_with_cyclic_dependencies.yml

@@ -0,0 +1,4 @@
+records:
+  - sprig_id: 1
+    title: "Title"
+    content: "<%= sprig_record(Comment, 1) %>"

data/spec/fixtures/seeds/test/posts_with_files.yml

@@ -0,0 +1,5 @@
+records:
+  - sprig_id: 1
+    title: 'Staging yaml title'
+    content: 'Staging yaml content'
+    photo: '<%= sprig_file("cat.png") %>'

data/spec/lib/sprig/parser/base_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Sprig::Parser::Base do
+  describe "#parse" do
+    it "enforces implementation in a subclass" do
+      expect {
+        described_class.new('data').parse
+      }.to raise_error(NotImplementedError)
+    end
+  end
+end

data/spec/lib/sprig/source_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe Sprig::NullRecord do
+  let(:error_msg) { 'Something bad happened.' }
+  subject { described_class.new(error_msg) }
+
+  describe "#new" do
+    it "logs an error upon initialization" do
+      log_should_receive(:error, with: "#{error_msg} (Substituted with NullRecord)")
+
+      subject
+    end
+  end
+
+  describe "#method_missing" do
+    it "returns nil for undefined method calls" do
+      subject.enhance_your_calm.should == nil
+    end
+  end
+
+  it_behaves_like "a logging entity" do
+    subject! { described_class.new(error_msg) }
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,11 @@
 ENV["RAILS_ENV"] ||= 'test'
 
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+SimpleCov.start "rails"
+
 require "rails"
 require "active_record"
 require "database_cleaner"
@@ -47,7 +53,7 @@ User.connection.execute "DROP TABLE IF EXISTS users;"
 User.connection.execute "CREATE TABLE users (id INTEGER PRIMARY KEY , first_name VARCHAR(255), last_name VARCHAR(255), type VARCHAR(255));"
 
 Post.connection.execute "DROP TABLE IF EXISTS posts;"
-Post.connection.execute "CREATE TABLE posts (id INTEGER PRIMARY KEY , title VARCHAR(255), content VARCHAR(255), published BOOLEAN , user_id INTEGER);"
+Post.connection.execute "CREATE TABLE posts (id INTEGER PRIMARY KEY AUTOINCREMENT, title VARCHAR(255), content VARCHAR(255), photo VARCHAR(255), published BOOLEAN , user_id INTEGER);"
 
 Comment.connection.execute "DROP TABLE IF EXISTS comments;"
 Comment.connection.execute "CREATE TABLE comments (id INTEGER PRIMARY KEY , post_id INTEGER, body VARCHAR(255));"
@@ -68,12 +74,16 @@ end
 def load_seeds(*files)
   env = Rails.env
 
+  `cp -R ./spec/fixtures/seeds/#{env}/files ./spec/fixtures/db/seeds/#{env}`
+
   files.each do |file|
     `cp ./spec/fixtures/seeds/#{env}/#{file} ./spec/fixtures/db/seeds/#{env}`
   end
 
   yield
 
+  `rm -R ./spec/fixtures/db/seeds/#{env}/files`
+
   files.each do |file|
     `rm ./spec/fixtures/db/seeds/#{env}/#{file}`
   end

data/spec/sprig_spec.rb

@@ -60,6 +60,24 @@ describe "Seeding an application" do
     end
   end
 
+  context "with an invalid custom parser" do
+    around do |example|
+      load_seeds('posts.yml', &example)
+    end
+
+    it "fails with an argument error" do
+      expect {
+        sprig [
+          {
+            :class  => Post,
+            :source => open('spec/fixtures/seeds/test/posts.yml'),
+            :parser => Object # Not a valid parser
+          }
+        ]
+      }.to raise_error(ArgumentError, 'Parsers must define #parse.')
+    end
+  end
+
   context "with a custom source" do
     around do |example|
       load_seeds('legacy_posts.yml', &example)
@@ -78,6 +96,31 @@ describe "Seeding an application" do
     end
   end
 
+  context "with a custom source that cannot be parsed by native parsers" do
+    around do |example|
+      load_seeds('posts.md', &example)
+    end
+
+    it "fails with an unparsable file error" do
+      expect {
+        sprig [
+          {
+            :class  => Post,
+            :source => open('spec/fixtures/seeds/test/posts.md')
+          }
+        ]
+      }.to raise_error(Sprig::Source::ParserDeterminer::UnparsableFileError)
+    end
+  end
+
+  context "with an invalid custom source" do
+    it "fails with an argument error" do
+      expect {
+        sprig [ { :class => Post, :source => 42 } ]
+      }.to raise_error(ArgumentError, 'Data sources must act like an IO.')
+    end
+  end
+
   context "with multiple file relationships" do
     around do |example|
       load_seeds('posts.yml', 'comments.yml', &example)
@@ -92,6 +135,14 @@ describe "Seeding an application" do
     end
   end
 
+  context "with missing seed files" do
+    it "raises a missing file error" do
+      expect {
+        sprig [Post]
+      }.to raise_error(Sprig::Source::SourceDeterminer::FileNotFoundError)
+    end
+  end
+
   context "with a relationship to an undefined record" do
     around do |example|
       load_seeds('posts.yml', 'posts_missing_dependency.yml', &example)
@@ -166,8 +217,125 @@ describe "Seeding an application" do
     end
   end
 
+  context "with files defined as attributes" do
+    around do |example|
+      load_seeds('posts_with_files.yml', &example)
+    end
+
+    it "seeds the db" do
+      sprig [
+        {
+          :class  => Post,
+          :source => open('spec/fixtures/seeds/test/posts_with_files.yml')
+        }
+      ]
+
+      Post.count.should == 1
+      Post.pluck(:photo).should =~ ['cat.png']
+    end
+  end
+
+  context "with cyclic dependencies" do
+    around do |example|
+      load_seeds('comments.yml', 'posts_with_cyclic_dependencies.yml', &example)
+    end
+
+    it "raises an cyclic dependency error" do
+      expect {
+        sprig [
+          {
+            :class  => Post,
+            :source => open('spec/fixtures/seeds/test/posts_with_cyclic_dependencies.yml')
+          },
+          Comment
+        ]
+      }.to raise_error(Sprig::DependencySorter::CircularDependencyError)
+    end
+  end
+
+  context "with a malformed directive" do
+    let(:expected_error_message) { 'Sprig::Directive must be instantiated with an ActiveRecord subclass or a Hash with :class defined' }
+
+    context "including a class that is not a subclass of AR" do
+      it "raises an argument error" do
+        expect {
+          sprig [
+            Object
+          ]
+        }.to raise_error(ArgumentError, expected_error_message)
+      end
+    end
+
+    context "including a non-class, non-hash" do
+      it "raises an argument error" do
+        expect {
+          sprig [
+            42
+          ]
+        }.to raise_error(ArgumentError, expected_error_message)
+      end
+    end
+  end
+
+
   context "with custom seed options" do
+    context "using delete_existing_by" do
+      around do |example|
+        load_seeds('posts_delete_existing_by.yml', &example)
+      end
+
+      context "with an existing record" do
+        let!(:existing_match) do
+          Post.create(
+            :title    => "Such Title",
+            :content  => "Old Content")
+        end
+
+        let!(:existing_nonmatch) do
+          Post.create(
+            :title    => "Wow Title",
+            :content  => "Much Content")
+        end
+
+        it "replaces only the matching existing record" do
+          sprig [
+            {
+              :class  => Post,
+              :source => open("spec/fixtures/seeds/test/posts_delete_existing_by.yml")
+            }
+          ]
+
+          Post.count.should == 2
+
+          expect {
+            existing_match.reload
+          }.to raise_error(ActiveRecord::RecordNotFound)
+
+          expect {
+            existing_nonmatch.reload
+          }.to_not raise_error
+        end
+      end
+    end
+
     context "using find_existing_by" do
+      context "with a missing attribute" do
+        around do |example|
+          load_seeds('posts_find_existing_by_missing.yml', &example)
+        end
+
+        it "raises a missing attribute error" do
+          expect {
+            sprig [
+              {
+                :class  => Post,
+                :source => open("spec/fixtures/seeds/test/posts_find_existing_by_missing.yml")
+              }
+            ]
+          }.to raise_error(Sprig::Seed::AttributeCollection::AttributeNotFoundError, "Attribute 'unicorn' is not present.")
+        end
+      end
+
       context "with a single attribute" do
         around do |example|
           load_seeds('posts.yml', 'posts_find_existing_by_single.yml', &example)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sprig
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Lawson Kurtz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-17 00:00:00.000000000 Z
+date: 2014-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -123,6 +123,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Sprig is a library for managing interconnected, environment-specific
   seed data.
 email:
@@ -176,23 +204,31 @@ files:
 - spec/fixtures/models/user.rb
 - spec/fixtures/seeds/staging/posts.yml
 - spec/fixtures/seeds/test/comments.yml
+- spec/fixtures/seeds/test/files/cat.png
 - spec/fixtures/seeds/test/invalid_users.yml
 - spec/fixtures/seeds/test/legacy_posts.yml
 - spec/fixtures/seeds/test/posts.csv
 - spec/fixtures/seeds/test/posts.json
+- spec/fixtures/seeds/test/posts.md
 - spec/fixtures/seeds/test/posts.yml
+- spec/fixtures/seeds/test/posts_delete_existing_by.yml
+- spec/fixtures/seeds/test/posts_find_existing_by_missing.yml
 - spec/fixtures/seeds/test/posts_find_existing_by_multiple.yml
 - spec/fixtures/seeds/test/posts_find_existing_by_single.yml
 - spec/fixtures/seeds/test/posts_missing_dependency.yml
 - spec/fixtures/seeds/test/posts_missing_record.yml
+- spec/fixtures/seeds/test/posts_with_cyclic_dependencies.yml
+- spec/fixtures/seeds/test/posts_with_files.yml
 - spec/lib/generators/sprig/install_generator_spec.rb
 - spec/lib/sprig/configuration_spec.rb
 - spec/lib/sprig/directive_list_spec.rb
 - spec/lib/sprig/directive_spec.rb
 - spec/lib/sprig/null_record_spec.rb
+- spec/lib/sprig/parser/base_spec.rb
 - spec/lib/sprig/process_notifier_spec.rb
 - spec/lib/sprig/seed/entry_spec.rb
 - spec/lib/sprig/seed/record_spec.rb
+- spec/lib/sprig/source_spec.rb
 - spec/lib/sprig_spec.rb
 - spec/spec_helper.rb
 - spec/sprig_spec.rb
@@ -235,23 +271,31 @@ test_files:
 - spec/fixtures/models/user.rb
 - spec/fixtures/seeds/staging/posts.yml
 - spec/fixtures/seeds/test/comments.yml
+- spec/fixtures/seeds/test/files/cat.png
 - spec/fixtures/seeds/test/invalid_users.yml
 - spec/fixtures/seeds/test/legacy_posts.yml
 - spec/fixtures/seeds/test/posts.csv
 - spec/fixtures/seeds/test/posts.json
+- spec/fixtures/seeds/test/posts.md
 - spec/fixtures/seeds/test/posts.yml
+- spec/fixtures/seeds/test/posts_delete_existing_by.yml
+- spec/fixtures/seeds/test/posts_find_existing_by_missing.yml
 - spec/fixtures/seeds/test/posts_find_existing_by_multiple.yml
 - spec/fixtures/seeds/test/posts_find_existing_by_single.yml
 - spec/fixtures/seeds/test/posts_missing_dependency.yml
 - spec/fixtures/seeds/test/posts_missing_record.yml
+- spec/fixtures/seeds/test/posts_with_cyclic_dependencies.yml
+- spec/fixtures/seeds/test/posts_with_files.yml
 - spec/lib/generators/sprig/install_generator_spec.rb
 - spec/lib/sprig/configuration_spec.rb
 - spec/lib/sprig/directive_list_spec.rb
 - spec/lib/sprig/directive_spec.rb
 - spec/lib/sprig/null_record_spec.rb
+- spec/lib/sprig/parser/base_spec.rb
 - spec/lib/sprig/process_notifier_spec.rb
 - spec/lib/sprig/seed/entry_spec.rb
 - spec/lib/sprig/seed/record_spec.rb
+- spec/lib/sprig/source_spec.rb
 - spec/lib/sprig_spec.rb
 - spec/spec_helper.rb
 - spec/sprig_spec.rb