spreewald 4.6.1 → 4.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 256b5e48d9fcbb9c845bc5f8503475a10184d2356f5483307100b43c7ae1a504
-  data.tar.gz: 9374a61e063de94a0b240b24c8f48b292f95d87adc285b9893b3bc2a3d725c2d
+  metadata.gz: a8b36c0e7f58e2fdc53690d9bed5690077215e16f874cf953d04e3bc96eb6ad5
+  data.tar.gz: 5be73a131b725ed532f318f8dc373f2758b29620ad11a4e83154ba068b754a5f
 SHA512:
-  metadata.gz: 934b5123e15812171d3d3dd1cf9f477024ac8f217b612ac85d6cf165afbd535fb2fd052755e52d389804c1f2b4222bce2c59259dfea1af771d367352e6d1baa8
-  data.tar.gz: 837aa75e2071c48ccca0855746d86c1f4a205be84d15ba8a4c569036f56f51fb940700c1cdf362f253a66acb96b29e467e9353255ec6244501ce9cff1c9df6a8
+  metadata.gz: c0ccd9c02ae206858b788f96d8a5a79144046e64cc8164e577fd81c4b02e1eccb94fd241295ddb29827374115c83d072b24e2818d3aea0c42685ec907dd874e7
+  data.tar.gz: a8ecc4aff210a281a7e077ea6e7c9200ab402ce5e2171db3e9c4dee251adad36f834227f5d70c27ace7f697df1dc71b40556e5ef6fbed2b7e9e3bc2eb1805d3f

data/CHANGELOG.md

@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.6.2
+- Fix uninitialized constant `XPath::HTML` when using `When I fill in "..." with "..." inside any "..."` ([#210](https://github.com/makandra/spreewald/issues/210))
+
 ## 4.6.1
 - Fix undefined method `irb_at_exit` in new IRB versions ([#208](https://github.com/makandra/spreewald/pull/208))
 

data/Gemfile.ruby266.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spreewald (4.6.1)
+    spreewald (4.6.2)
       capybara
       cucumber
       cucumber_priority (>= 0.3.0)

data/Gemfile.ruby320.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spreewald (4.6.1)
+    spreewald (4.6.2)
       capybara
       cucumber
       cucumber_priority (>= 0.3.0)

data/README.md

@@ -211,6 +211,10 @@ the step definitions.
 
 ### email_steps.rb 
 
+  When specifying the `to`, `cc`, `bcc`, `from` or `reply_to` targets within email steps, you can either specify email addresses or any arbitrary identifier. When an identifier (other than an email address) is given, Spreewald can try to use this information to determine the associated user and gather its email address automatically over the application's `User` model. For this, you may set `Spreewald::MailFinder.user_identity` to an attribute name and Spreewald will call `User.find_by_<user_identity>(identifier)` and then use the `email` of the found user.<br/>
+
+  For example, if you set `reply_to` to the name `John Doe` within a scenario step and specify `Spreewald::MailFinder.user_identity = 'name'`, Spreewald will call `User.find_by_name('John Doe')`, find the according user with this name and expect its email address as `reply_to`.
+
 * **When I clear my e?mails**
 
 
@@ -568,7 +572,11 @@ deprecation notice. Decide for yourself whether you want to use them:
 
 * **Then the "..." field should have the error "..."**
 
-  Checks that an input field was wrapped with a validation error
+  Checks that an input field was wrapped with a validation error. This is done by checking for different error HTML structures that display errors.<br/><br/>
+
+  Spreewald first checks for custom error wrappers (if specified), then Boostrap 3 error wrappers (`.form-group.has-error`), then Bootstrap 4/5 error wrappers (`:invalid` or `is-invalid`) and lastly, Rails error wrappers (`field_with_errors`). You are able to specify a custom error wrapper by setting `Spreewald.field_error_class = 'my-custom-error-class'` which is then used to look for the error class on the current or any ancestor `div`.<br /><br />
+
+  The same principle applies for matching the error message. First, it will look for the message text (starting from the input element) with a custom XPath (if specified), then one targeting a sibling element with a `help-block` class for Bootstrap 3 and then one targeting a sibling element with an `invalid-feedback` class for Bootstrap 4/5. Rails errors are checked specifically over the field title as this one contains the error message. You may specify the custom XPath by setting (e.g.) `Spreewald.error_message_xpath_selector = 'parent::*/child::*[@class="my-error-message"]'`.
 
 
 * **Then the "..." field should( not)? have an error**

data/lib/spreewald/web_steps.rb

@@ -620,7 +620,9 @@ When /^I fill in "([^"]*)" with "([^"]*)" inside any "([^"]*)"$/ do |field, valu
   containers = all(:css, selector)
   input = nil
   containers.detect do |container|
-    input = container.first(:xpath, XPath::HTML.fillable_field(field))
+    input = container.first(:fillable_field, field)
+  rescue Capybara::ElementNotFound
+    # Capybara changed the behavior of #first and raises an error when the first container finds no matching field
   end
   if input
     input.set(value)

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.6.1'
+  VERSION = '4.6.2'
 end

data/tests/rails-7_capybara-3/.ruby-version

@@ -1 +1 @@
-3.0.0
+3.2.0

data/tests/rails-7_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (4.6.1)
+    spreewald (4.6.2)
       capybara
       cucumber
       cucumber_priority (>= 0.3.0)

data/tests/shared/app/controllers/forms_controller.rb

@@ -12,6 +12,9 @@ class FormsController < ApplicationController
   def form2
   end
 
+  def form_with_two_inputs_in_separate_css_blocks_with_the_same_selector
+  end
+
   def select_fields
   end
 

data/tests/shared/app/views/forms/form_with_two_inputs_in_separate_css_blocks_with_the_same_selector.html.haml

@@ -0,0 +1,8 @@
+= form_tag do
+  .my-container
+    = label_tag 'first_text_field', 'First Text field'
+    = text_field_tag 'first_text_field', 'First value'
+
+  .my-container
+    = label_tag 'second_text_field', 'Second Text field'
+    = text_field_tag 'second_text_field', 'Second value'

data/tests/shared/config/routes.rb

@@ -22,6 +22,7 @@ Rails.application.routes.draw do
   get '/forms/disabled_elements', to: 'forms#disabled_elements'
   get '/forms/form1', to: 'forms#form1'
   get '/forms/form2', to: 'forms#form2'
+  get '/forms/form_with_two_inputs_in_separate_css_blocks_with_the_same_selector', to: 'forms#form_with_two_inputs_in_separate_css_blocks_with_the_same_selector'
   get '/forms/select_fields', to: 'forms#select_fields'
   get '/forms/invalid_rails_form', to: 'forms#invalid_rails_form'
   get '/forms/invalid_bootstrap3_form', to: 'forms#invalid_bootstrap3_form'

data/tests/shared/features/shared/web_steps.feature

@@ -416,3 +416,13 @@ Feature: Web steps
   Scenario: /^the window should be titled "([^"]*)"$/
     When I go to "/static_pages/home"
     Then the window should be titled "spreewald test application"
+
+
+  Scenario: I fill in "..." with "..." inside any "..."
+    When I go to "/forms/form_with_two_inputs_in_separate_css_blocks_with_the_same_selector"
+    Then the "First Text field" field should contain "First value"
+      And the "Second Text field" field should contain "Second value"
+
+    When I fill in "Second Text field" with "My new value" inside any ".my-container"
+    Then the "First Text field" field should contain "First value"
+      And the "Second Text field" field should contain "My new value"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 4.6.1
+  version: 4.6.2
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-25 00:00:00.000000000 Z
+date: 2024-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -225,6 +225,7 @@ files:
 - tests/shared/app/views/forms/disabled_elements.html.haml
 - tests/shared/app/views/forms/form1.html.haml
 - tests/shared/app/views/forms/form2.html.haml
+- tests/shared/app/views/forms/form_with_two_inputs_in_separate_css_blocks_with_the_same_selector.html.haml
 - tests/shared/app/views/forms/invalid_bootstrap3_form.html.haml
 - tests/shared/app/views/forms/invalid_bootstrap4_form.html.haml
 - tests/shared/app/views/forms/invalid_custom_form.html.haml
@@ -315,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.4.1
 signing_key: 
 specification_version: 4
 summary: Collection of useful cucumber steps.
@@ -394,6 +395,7 @@ test_files:
 - tests/shared/app/views/forms/disabled_elements.html.haml
 - tests/shared/app/views/forms/form1.html.haml
 - tests/shared/app/views/forms/form2.html.haml
+- tests/shared/app/views/forms/form_with_two_inputs_in_separate_css_blocks_with_the_same_selector.html.haml
 - tests/shared/app/views/forms/invalid_bootstrap3_form.html.haml
 - tests/shared/app/views/forms/invalid_bootstrap4_form.html.haml
 - tests/shared/app/views/forms/invalid_custom_form.html.haml