spreewald 2.4.0 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18febfccd8fa518df388635fd50815c8255a3970a3b67b7022a0ccca1280d4d1
-  data.tar.gz: 626984be2ce97aac2144383650319f5240e1e624c3847f9dac1e140d85da18b3
+  metadata.gz: c226a047c194764d7645b43c70ab3b07d1a3e7a0d609a4e87dd8baab8e3c3a88
+  data.tar.gz: ecdfa9f9aa7fe19da7bc3a8e2f7852a80d4d397f4342e873fe89a32276c9f9d0
 SHA512:
-  metadata.gz: 74a4c47fb0e1c33814f1f298eb1dda0f7d1b551f254325e0e26dded66c0dff88e260b6303d3f30d337a9af8d7170d7ae11ff54b0a22079ba2a26cbfa48cb7879
-  data.tar.gz: 9a55a3db1f0b4f78e701b87fc567e036e1eaa146ce439ed1b4fb4c95a5ef0e646f8019028878d81a34cc3093f9ba25cfd561bca44be0aabfe582dfa1a6717657
+  metadata.gz: d2e322bb7fb70096255ade88045b40408f0d1b0899120f159ea5831b65a40bc5a4d7d2bfb0b9b9ede7ba3f7b8aca0a904129076c7c49cafc7c6780bcd0e329d1
+  data.tar.gz: 190918ee162ba71606593416c1ae87f1f963a92f316f10f0c7c50f6a3217c7bc1670ccd1412372faa75504d4c0bbff98bd7dd49b88470a3ee162f477052fff5b

data/.gitignore

@@ -11,4 +11,4 @@ InstalledFiles
 tmp
 _yardoc
 *.log
-tests/shared/db/test.sqlite3
+tests/shared/db/*.sqlite3

data/.travis.yml

@@ -6,25 +6,24 @@ language: ruby
 rvm:
   - 2.1.8
   - 2.4.5
-
-gemfile:
-  # Test projects
-  - tests/rails-3_capybara-1/Gemfile
-  - tests/rails-3_capybara-2/Gemfile
-  - tests/rails-4_capybara-3/Gemfile
-  # Used to run rspec and tests for spreewald binary:
-  - Gemfile.ruby218
-  - Gemfile.ruby245
+  - 2.6.6
 
 matrix:
-  exclude:
+  include:
+    # Test projects
     - gemfile: tests/rails-3_capybara-1/Gemfile
-      rvm: 2.4.5
+      rvm: 2.1.8
     - gemfile: tests/rails-3_capybara-2/Gemfile
-      rvm: 2.4.5
-    - gemfile: tests/rails-4_capybara-3/Gemfile
       rvm: 2.1.8
-    - gemfile: Gemfile.ruby218
+    - gemfile: tests/rails-4_capybara-3/Gemfile
       rvm: 2.4.5
-    - gemfile: Gemfile.ruby245
+    - gemfile: tests/rails-6_capybara-3/Gemfile
+      rvm: 2.6.6
+    # Used to run rspec and tests for spreewald binary:
+    - gemfile: Gemfile.ruby218
       rvm: 2.1.8
+    - gemfile: Gemfile.ruby245
+      rvm: 2.4.5
+    - gemfile: Gemfile.ruby266
+      rvm: 2.6.6
+

data/CHANGELOG.md

@@ -3,6 +3,13 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 2.4.2
+* Fix the step `I should( not)? see a link labeled "STRING"`, it is now overridable.
+
+## 2.4.1
+
+- Adapt `I should get a download with filename "..."` step to also work if the `filename` is not the last attribute in `Content-Disposition` header.
+
 ## 2.4.0
 
 - Fix "I follow the ... link in the email" step for HTML e-mails to only follow URLs from `<a href="...">` links.

data/Gemfile

@@ -1,5 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'rake'
-gem 'gemika'
-gem 'rspec', '>=2.14.0'
+gem 'gemika'

data/Gemfile.lock

@@ -1,22 +1,8 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.3)
-    gemika (0.3.4)
+    gemika (0.4.0)
     rake (12.3.2)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.3)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
 
 PLATFORMS
   ruby
@@ -24,7 +10,6 @@ PLATFORMS
 DEPENDENCIES
   gemika
   rake
-  rspec (>= 2.14.0)
 
 BUNDLED WITH
    1.17.3

data/Gemfile.ruby266

@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+ruby '2.6.6'
+
+gem 'rspec'
+gem 'cucumber'
+gem 'aruba'
+
+gem 'gemika'

data/Gemfile.ruby266.lock

@@ -0,0 +1,65 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    aruba (1.0.0)
+      childprocess (~> 3.0)
+      contracts (~> 0.16.0)
+      cucumber (>= 2.4, < 4.0)
+      ffi (~> 1.9)
+      rspec-expectations (~> 3.4)
+      thor (~> 1.0)
+    backports (3.17.0)
+    builder (3.2.4)
+    childprocess (3.0.0)
+    contracts (0.16.0)
+    cucumber (3.1.2)
+      builder (>= 2.1.2)
+      cucumber-core (~> 3.2.0)
+      cucumber-expressions (~> 6.0.1)
+      cucumber-wire (~> 0.0.1)
+      diff-lcs (~> 1.3)
+      gherkin (~> 5.1.0)
+      multi_json (>= 1.7.5, < 2.0)
+      multi_test (>= 0.1.2)
+    cucumber-core (3.2.1)
+      backports (>= 3.8.0)
+      cucumber-tag_expressions (~> 1.1.0)
+      gherkin (~> 5.0)
+    cucumber-expressions (6.0.1)
+    cucumber-tag_expressions (1.1.1)
+    cucumber-wire (0.0.1)
+    diff-lcs (1.3)
+    ffi (1.12.2)
+    gemika (0.4.0)
+    gherkin (5.1.0)
+    multi_json (1.14.1)
+    multi_test (0.1.2)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
+    rspec-expectations (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.2)
+    thor (1.0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  aruba
+  cucumber
+  gemika
+  rspec
+
+RUBY VERSION
+   ruby 2.6.6p146
+
+BUNDLED WITH
+   2.1.4

data/README.md

@@ -93,6 +93,11 @@ Capybara.default_normalize_ws = true
 
 This will affect all Spreewald steps that are using Capybara's `:text` option.
 
+Furthermore, we recommend setting [Capybara's matching strategy](https://github.com/teamcapybara/capybara/blob/master/README.md#strategy) to `:prefer_exact`. This will positively affect Spreewald steps as it prevents the `Capybara::Ambiguous` error in the edge case when two fields are matching the given name, but one of the matches includes the name only as a substring,
+
+```ruby
+Capybara.match = :prefer_exact
+````
 
 ## Contributing
 

data/Rakefile

@@ -1,5 +1,5 @@
 #!/usr/bin/env rake
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 
 begin
   require 'gemika/tasks'
@@ -17,7 +17,7 @@ namespace :matrix do
       directory = File.dirname(row.gemfile)
       if directory.start_with?('tests')
         # Run integration tests (uses embedded projects)
-        system("cd #{directory} && BUNDLE_GEMFILE=Gemfile geordi cucumber")
+        system(cucumber_command(directory, row.ruby))
       else
         # Run specs and tests for spreewald binary
         [
@@ -54,6 +54,16 @@ task :update_readme do
   puts '', '> Done (diff applied).'
 end
 
+def cucumber_command(directory, ruby_version)
+  command = "cd #{directory} && BUNDLE_GEMFILE=Gemfile geordi cucumber"
+  if Gem::Version.new(ruby_version) > Gem::Version.new('2.5')
+    # Modern cucumber sees pending tests as failures.
+    # We don't want this.
+    command << ' --no-strict-pending'
+  end
+  command
+end
+
 def warn(text)
   puts "\e[31m#{text}\e[0m" # red text
 end

data/lib/spreewald/web_steps.rb

@@ -322,7 +322,7 @@ Then /^I should( not)? see a link labeled "([^"]*)"$/ do |negate, label|
   expectation = negate ? :not_to : :to
   link = page.first('a', :text => label, minimum: 0) || page.first(%(a[title="#{label}"]), minimum: 0)
   expect(link).send(expectation, be_present)
-end
+end.overridable
 
 # Checks that an input field contains some value (allowing * as wildcard character)
 Then /^the "([^"]*)" field should (not )?contain "([^"]*)"$/ do |label, negate, expected_string|
@@ -463,7 +463,7 @@ end.overridable
 #
 # Attention: Doesn't work with Selenium, see https://github.com/jnicklas/capybara#gotchas
 Then /^I should get a download with filename "([^\"]*)"$/ do |filename|
-  expect(page.response_headers['Content-Disposition']).to match /filename="#{Regexp.escape(filename)}"$/
+  expect(page.response_headers['Content-Disposition']).to match /filename="#{Regexp.escape(filename)}"(;|$)/
 end.overridable
 
 # Checks that a certain option is selected for a text field

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '2.4.0'
+  VERSION = '2.4.2'
 end

data/tests/rails-3_capybara-1/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (2.4.0)
+    spreewald (2.4.2)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/rails-3_capybara-1/config/routes.rb

@@ -0,0 +1 @@
+../../shared/config/routes.rb

data/tests/rails-3_capybara-2/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (2.4.0)
+    spreewald (2.4.2)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/rails-4_capybara-3/Gemfile

@@ -14,7 +14,7 @@ end
 
 group :test do
   gem 'database_cleaner'
-  gem 'capybara', "~>3" # todo
+  gem 'capybara', "~>3"
   gem 'capybara-screenshot'
   gem 'cucumber-rails', require: false
   gem 'cucumber'

data/tests/rails-4_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (2.4.0)
+    spreewald (2.4.1)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/rails-4_capybara-3/config/routes.rb

@@ -0,0 +1 @@
+../../shared/config/routes.rb

data/tests/rails-6_capybara-3/.ruby-version

@@ -0,0 +1 @@
+2.7.1

data/tests/rails-6_capybara-3/Gemfile

@@ -0,0 +1,25 @@
+source 'https://rubygems.org'
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
+
+ruby '2.6.6'
+
+gem 'rails', '~>6.0'
+gem 'sqlite3'
+gem 'haml-rails'
+gem 'gemika'
+
+group :development, :test do
+  gem 'byebug'
+  gem 'pry'
+end
+
+group :test do
+  gem 'database_cleaner'
+  gem 'capybara', "~>3"
+  gem 'capybara-screenshot'
+  gem 'cucumber-rails', require: false
+  gem 'cucumber'
+  gem 'selenium-webdriver'
+  gem 'rspec-rails'
+  gem 'spreewald', :path => '../..'
+end

data/tests/rails-6_capybara-3/Gemfile.lock

@@ -0,0 +1,264 @@
+PATH
+  remote: ../..
+  specs:
+    spreewald (2.4.1)
+      cucumber
+      cucumber_priority (>= 0.3.0)
+      rspec (>= 2.13.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailbox (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      activejob (= 6.0.2.2)
+      activerecord (= 6.0.2.2)
+      activestorage (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+      mail (>= 2.7.1)
+    actionmailer (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      actionview (= 6.0.2.2)
+      activejob (= 6.0.2.2)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (6.0.2.2)
+      actionview (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+      rack (~> 2.0, >= 2.0.8)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actiontext (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      activerecord (= 6.0.2.2)
+      activestorage (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+      nokogiri (>= 1.8.5)
+    actionview (6.0.2.2)
+      activesupport (= 6.0.2.2)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.0.2.2)
+      activesupport (= 6.0.2.2)
+      globalid (>= 0.3.6)
+    activemodel (6.0.2.2)
+      activesupport (= 6.0.2.2)
+    activerecord (6.0.2.2)
+      activemodel (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+    activestorage (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      activejob (= 6.0.2.2)
+      activerecord (= 6.0.2.2)
+      marcel (~> 0.3.1)
+    activesupport (6.0.2.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    backports (3.17.0)
+    builder (3.2.4)
+    byebug (11.1.1)
+    capybara (3.32.0)
+      addressable
+      mini_mime (>= 0.1.3)
+      nokogiri (~> 1.8)
+      rack (>= 1.6.0)
+      rack-test (>= 0.6.3)
+      regexp_parser (~> 1.5)
+      xpath (~> 3.2)
+    capybara-screenshot (1.0.24)
+      capybara (>= 1.0, < 4)
+      launchy
+    childprocess (3.0.0)
+    coderay (1.1.2)
+    concurrent-ruby (1.1.6)
+    crass (1.0.6)
+    cucumber (3.1.2)
+      builder (>= 2.1.2)
+      cucumber-core (~> 3.2.0)
+      cucumber-expressions (~> 6.0.1)
+      cucumber-wire (~> 0.0.1)
+      diff-lcs (~> 1.3)
+      gherkin (~> 5.1.0)
+      multi_json (>= 1.7.5, < 2.0)
+      multi_test (>= 0.1.2)
+    cucumber-core (3.2.1)
+      backports (>= 3.8.0)
+      cucumber-tag_expressions (~> 1.1.0)
+      gherkin (~> 5.0)
+    cucumber-expressions (6.0.1)
+    cucumber-rails (2.0.0)
+      capybara (>= 2.12, < 4)
+      cucumber (>= 3.0.2, < 4)
+      mime-types (>= 2.0, < 4)
+      nokogiri (~> 1.8)
+      railties (>= 4.2, < 7)
+    cucumber-tag_expressions (1.1.1)
+    cucumber-wire (0.0.1)
+    cucumber_priority (0.3.2)
+      cucumber
+    database_cleaner (1.7.0)
+    diff-lcs (1.3)
+    erubi (1.9.0)
+    erubis (2.7.0)
+    gemika (0.4.0)
+    gherkin (5.1.0)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    haml (5.1.2)
+      temple (>= 0.8.0)
+      tilt
+    haml-rails (2.0.1)
+      actionpack (>= 5.1)
+      activesupport (>= 5.1)
+      haml (>= 4.0.6, < 6.0)
+      html2haml (>= 1.0.1)
+      railties (>= 5.1)
+    html2haml (2.2.0)
+      erubis (~> 2.7.0)
+      haml (>= 4.0, < 6)
+      nokogiri (>= 1.6.0)
+      ruby_parser (~> 3.5)
+    i18n (1.8.2)
+      concurrent-ruby (~> 1.0)
+    launchy (2.5.0)
+      addressable (~> 2.7)
+    loofah (2.4.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (1.0.0)
+    mime-types (3.3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2019.1009)
+    mimemagic (0.3.4)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.0)
+    multi_json (1.14.1)
+    multi_test (0.1.2)
+    nio4r (2.5.2)
+    nokogiri (1.10.9)
+      mini_portile2 (~> 2.4.0)
+    pry (0.13.0)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.3)
+    rack (2.2.2)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (6.0.2.2)
+      actioncable (= 6.0.2.2)
+      actionmailbox (= 6.0.2.2)
+      actionmailer (= 6.0.2.2)
+      actionpack (= 6.0.2.2)
+      actiontext (= 6.0.2.2)
+      actionview (= 6.0.2.2)
+      activejob (= 6.0.2.2)
+      activemodel (= 6.0.2.2)
+      activerecord (= 6.0.2.2)
+      activestorage (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+      bundler (>= 1.3.0)
+      railties (= 6.0.2.2)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    railties (6.0.2.2)
+      actionpack (= 6.0.2.2)
+      activesupport (= 6.0.2.2)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.20.3, < 2.0)
+    rake (13.0.1)
+    regexp_parser (1.7.0)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
+    rspec-expectations (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-rails (4.0.0)
+      actionpack (>= 4.2)
+      activesupport (>= 4.2)
+      railties (>= 4.2)
+      rspec-core (~> 3.9)
+      rspec-expectations (~> 3.9)
+      rspec-mocks (~> 3.9)
+      rspec-support (~> 3.9)
+    rspec-support (3.9.2)
+    ruby_parser (3.14.2)
+      sexp_processor (~> 4.9)
+    rubyzip (2.3.0)
+    selenium-webdriver (3.142.7)
+      childprocess (>= 0.5, < 4.0)
+      rubyzip (>= 1.2.2)
+    sexp_processor (4.14.1)
+    sprockets (4.0.0)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    sqlite3 (1.4.2)
+    temple (0.8.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tilt (2.0.10)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.1)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.4)
+    xpath (3.2.0)
+      nokogiri (~> 1.8)
+    zeitwerk (2.3.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  byebug
+  capybara (~> 3)
+  capybara-screenshot
+  cucumber
+  cucumber-rails
+  database_cleaner
+  gemika
+  haml-rails
+  pry
+  rails (~> 6.0)
+  rspec-rails
+  selenium-webdriver
+  spreewald!
+  sqlite3
+
+RUBY VERSION
+   ruby 2.6.6p146
+
+BUNDLED WITH
+   2.1.4