spreewald 1.11.1 → 1.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfdc79fd11e503ee95441067b8512739f163c9e9215fe0c2cfa619a032cb5cc8
-  data.tar.gz: fe32fb4537956bf8d0853fb35a51027e1c044c8928055a62d4d26f3c0216958a
+  metadata.gz: 832e19b87b9d9d63a8074bb73bf98bc49953a7dfc8b7d656c5193f88760bd643
+  data.tar.gz: 547826cf456d15f228b9fe15e9f7a31dbd3345e31b7bbf0586b9d8a47571cb3a
 SHA512:
-  metadata.gz: 0fe4f50cdfa4a3d14209e82844b7f8b6471cb31a5d3f2007ae643a5efe1bf756c7cc93858e9a2310ffa298635a85c2bc601a759b4b2ce0d7373e42ba284f361d
-  data.tar.gz: 15376abcf33575c2601cff104cbff187381d5a475ef73d9a997051db8f07eb7f232a5fc132325c34bb2f232c961e36a2ff6b566660642e5adcf972604ba6a11c
+  metadata.gz: 9b7e7a8c2113bc2f813c0415872791248dcea1fe234256c4a0c1424e7fd90c9468300945bf1e222f5d0ccd9f6fa3693cfbd3249d33e9032d5c535cd33fa62d77
+  data.tar.gz: 17e7049f1552e788fd1784f396e43cd188258bd17ff62c49139da4ce794d8b2824b0e7b5743a1f80b42e085b6c0836e4fb5d238fa9f28f35cad758cf58f4fdc7

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gem 'rspec'

data/Gemfile.lock

@@ -0,0 +1,26 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    diff-lcs (1.3)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  rspec
+
+BUNDLED WITH
+   1.16.1

data/Rakefile

@@ -4,6 +4,12 @@ require "bundler/gem_tasks"
 desc 'Default: Run all tests.'
 task :default => 'all:rubies'
 
+begin
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec)
+rescue LoadError
+end
+
 desc 'Update the "Steps" section of the README'
 task :update_readme do
   readme_path = 'README.md'
@@ -78,7 +84,8 @@ def run_for_all_rubies(version_manager)
     current_version = `#{execute} ruby -v`.match(/^ruby (\d\.\d\.\d)/)[1]
     if current_version == ruby_version
       puts "Currently active Ruby is #{current_version}"
-      system "#{execute} rake all:bundle all:features"
+      system "#{execute} bundle"
+      system "#{execute} rake all:bundle spec all:features"
     else
       fail "Failed to set Ruby #{ruby_version} (#{current_version} active!)"
     end

data/lib/spreewald/web_steps.rb

@@ -42,6 +42,12 @@ require 'cgi'
 #
 #     Then I should see "some text" within ".page_body"
 When /^(.*) within (.*[^:])$/ do |nested_step, parent|
+  selector = _selector_for(parent)
+  if selector.is_a?(String) # could also be a Capybara::Node::Element
+    patiently do
+      page.should have_css(selector)
+    end
+  end
   patiently do
     with_scope(parent) { step(nested_step) }
   end

data/lib/spreewald_support/tolerance_for_selenium_sync_issues.rb

@@ -34,82 +34,38 @@ module ToleranceForSeleniumSyncIssues
     end
   end
 
-  class PatientStack
-
-    def initialize
-      @stack ||= []
-    end
-
-    def add_segment(max_seconds)
-      index = @stack.length
-      segment = PatientStackSegment.new(@stack, index, max_seconds)
-      @stack[index] = segment
-      segment
-    end
+  class Patiently
+    WAIT_PERIOD = 0.05
 
     def patiently(seconds, &block)
-      segment = add_segment(seconds)
-
+      started = Time.now
+      tries = 0
       begin
+        tries += 1
         block.call
       rescue Exception => e
-        raise e unless RETRY_ERRORS.include?(e.class.name)
-        raise e unless segment.seconds_left?
-        sleep(0.05)
-        raise Capybara::FrozenInTime, "time appears to be frozen, Capybara does not work with libraries which freeze time, consider using time travelling instead" if segment.frozen_time?
+        raise e unless retryable_error?(e)
+        raise e if (Time.now - started > seconds && tries >= 2)
+        sleep(WAIT_PERIOD)
+        raise Capybara::FrozenInTime, "time appears to be frozen, Capybara does not work with libraries which freeze time, consider using time travelling instead" if Time.now == started
         retry
-      ensure
-        segment.done!
       end
-
     end
 
-  end
-
-  class PatientStackSegment
-
-    def initialize(stack, index, max_seconds)
-      @stack = stack
-      @index = index
-      @started_at = Time.now
-      @max_seconds = max_seconds
-    end
-
-    attr_reader :max_seconds
-
-    def seconds_elapsed
-      Time.now - @started_at
-    end
+    private
 
-    def seconds_left
-      max_seconds - seconds_elapsed
+    def retryable_error?(e)
+      RETRY_ERRORS.include?(e.class.name)
     end
-
-    def seconds_left?
-      seconds_left > 0
-    end
-
-    def frozen_time?
-      Time.now == @started_at
-    end
-
-    def extend_seconds(additional_seconds)
-      @max_seconds += additional_seconds
-    end
-
-    def done!
-      if @index > 0
-        @stack[@index - 1].extend_seconds(seconds_elapsed)
-        @stack.pop
-      end
-    end
-
   end
 
+
   def patiently(seconds = CapybaraWrapper.default_max_wait_time, &block)
-    return block.call unless page.driver.wait?
-    @wait_stack ||= PatientStack.new
-    @wait_stack.patiently(seconds, &block)
+    if page.driver.wait?
+      Patiently.new.patiently(seconds, &block)
+    else
+      block.call
+    end
   end
 end
 

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '1.11.1'
+  VERSION = '1.11.2'
 end

data/spec/spec_helper.rb

@@ -0,0 +1,104 @@
+require 'bundler'
+Bundler.setup
+
+require 'pathname'
+
+Dir[Pathname.new(__FILE__).join('..', 'support', '**', '*.rb')].each { |f| require f }
+
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end

data/spec/spreewald_support/tolerance_for_selenium_sync_issues_spec.rb

@@ -0,0 +1,122 @@
+require 'spreewald_support/tolerance_for_selenium_sync_issues'
+
+module Capybara
+  class ElementNotFound < StandardError; end
+
+  class << self
+    attr_accessor :default_max_wait_time
+  end
+end
+
+describe ToleranceForSeleniumSyncIssues do
+  subject { World.new }
+  let(:wait_time) { 0.2 }
+
+  before do
+    Capybara.default_max_wait_time = wait_time
+    allow(subject.page.driver).to receive(:wait?).and_return(true)
+  end
+
+  describe '#patiently' do
+    it 'calls the block' do
+      reached = false
+      subject.patiently do
+        reached = true
+      end
+      expect(reached).to eq true
+    end
+
+    it 'fails if the block raises an unknown error' do
+      reached = false
+      expect {
+        subject.patiently do
+          raise 'some unknown error'
+          reached = true
+        end
+      }.to raise_error(/some unknown error/)
+      expect(reached).to eq false
+    end
+
+    it 'retries the block if it raises a whitelisted error, but eventually raises it' do
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          raise Capybara::ElementNotFound
+        end
+      }.to raise_error(Capybara::ElementNotFound)
+      expect(count).to be > 2
+    end
+
+    it 'retries the block if it fails an expectation' do
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          expect(true).to eq false
+        end
+      }.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+      expect(count).to be > 2
+    end
+
+    it 'does not retry the block if page.driver.wait? is false' do
+      allow(subject.page.driver).to receive(:wait?).and_return(false)
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          raise Capybara::ElementNotFound
+        end
+      }.to raise_error(Capybara::ElementNotFound)
+      expect(count).to eq 1
+    end
+
+    it 'will not raise an error if the block eventually succeeds' do
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          if count < 3
+            raise Capybara::ElementNotFound
+          end
+        end
+      }.not_to raise_error
+    end
+
+    it 'will retry the block until a specified amount of time has passed' do
+      started = Time.now
+      expect {
+        subject.patiently do
+          raise Capybara::ElementNotFound
+        end
+      }.to raise_error(Capybara::ElementNotFound)
+      expect(Time.now - started).to be > wait_time
+    end
+
+    it 'retries the block at least twice even if the given time has passed' do
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          sleep wait_time
+          raise Capybara::ElementNotFound
+        end
+      }.to raise_error(Capybara::ElementNotFound)
+      expect(count).to be > 1
+    end
+
+    it 'will retry an outer patiently block if an inner patiently block took up all the time' do
+      try = 0
+      expect {
+        subject.patiently do
+          try += 1
+          correct_element_found = try > 1
+          subject.patiently do
+            raise Capybara::ElementNotFound unless correct_element_found
+          end
+        end
+      }.not_to raise_error
+    end
+
+  end
+end

data/spec/support/world.rb

@@ -0,0 +1,23 @@
+class World
+  class Driver
+    def wait?
+      true
+    end
+  end
+
+  class Page
+    def driver
+      @driver ||= Driver.new
+    end
+  end
+
+  def page
+    @page ||= Page.new
+  end
+end
+
+def World(mod)
+  World.class_eval do
+    include mod
+  end
+end

data/spreewald.gemspec

@@ -27,6 +27,5 @@ Gem::Specification.new do |gem|
 
   # Testing
   gem.add_development_dependency 'aruba', '~> 0.10.2'
-  gem.add_development_dependency 'guard-cucumber'
   gem.add_development_dependency 'rspec', '~> 3.4.0'
 end

data/tests/rails-2.3/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: ../..
   specs:
-    spreewald (1.11.0)
+    spreewald (1.11.2)
       cucumber
-      cucumber_priority
+      cucumber_priority (>= 0.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -36,7 +36,7 @@ GEM
       term-ansicolor (>= 1.0.6)
     cucumber-rails (0.3.2)
       cucumber (>= 0.8.0)
-    cucumber_priority (0.2.0)
+    cucumber_priority (0.3.1)
       cucumber
     database_cleaner (1.0.1)
     diff-lcs (1.2.4)

data/tests/rails-3.2/capybara-1/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: ../../..
   specs:
-    spreewald (1.11.0)
+    spreewald (1.11.2)
       cucumber
-      cucumber_priority
+      cucumber_priority (>= 0.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -57,7 +57,7 @@ GEM
       cucumber (>= 1.2.0)
       nokogiri (>= 1.5.0)
       rails (>= 3.0.0)
-    cucumber_priority (0.2.0)
+    cucumber_priority (0.3.1)
       cucumber
     database_cleaner (1.0.1)
     diff-lcs (1.3)

data/tests/rails-3.2/capybara-2/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: ../../..
   specs:
-    spreewald (1.11.0)
+    spreewald (1.11.2)
       cucumber
-      cucumber_priority
+      cucumber_priority (>= 0.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -58,7 +58,7 @@ GEM
       cucumber (>= 1.2.0)
       nokogiri (>= 1.5.0)
       rails (>= 3.0.0)
-    cucumber_priority (0.2.0)
+    cucumber_priority (0.3.1)
       cucumber
     database_cleaner (1.0.1)
     diff-lcs (1.3)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 1.11.1
+  version: 1.11.2
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-28 00:00:00.000000000 Z
+date: 2018-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -94,20 +94,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.2
-- !ruby/object:Gem::Dependency
-  name: guard-cucumber
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -132,7 +118,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".ruby-version"
+- Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -157,6 +146,9 @@ files:
 - lib/spreewald_support/tolerance_for_selenium_sync_issues.rb
 - lib/spreewald_support/version.rb
 - lib/spreewald_support/web_steps_helpers.rb
+- spec/spec_helper.rb
+- spec/spreewald_support/tolerance_for_selenium_sync_issues_spec.rb
+- spec/support/world.rb
 - spreewald.gemspec
 - support/parser.rb
 - support/paths_manager.rb
@@ -280,7 +272,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Collection of useful cucumber steps.