spree_zaez_correios 3.0.4 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e91f8fcf0ed0b9cc3a0887d65fbe8f0127553ac
-  data.tar.gz: 3416cc8d1fcf7a14c64cae51dce7355707fb6952
+  metadata.gz: b30e23fbc5293123daf61b2e4b9038b2c459407d
+  data.tar.gz: 4b7ecb4c78ad7c1acd6a98db07d71b90e5a4671d
 SHA512:
-  metadata.gz: 9bb71a124c0ce79ebf6a2c35bf01a8264fda66c6dffaa2f23f408e257ff65738e8988a2ef9e6d7c0e88c4bd03d3606a498d6b3f6b097a61d80b6d60504a223a2
-  data.tar.gz: 78a0167704e884c350d7e0dd0d62cdaf3c92365477dfde6a79efeb632a65a8d51eafe49769c03988f4bc4715e5f9b508fa6da54d2b5b78d1969235909cf813be
+  metadata.gz: 3d59e8761e019426b7b948d2afca952c017426a72ce8e86fc45ca29d424d38075c7558415719678da193a4ac207d4c70292a3aa6cf36d84596196e91c678607b
+  data.tar.gz: f20d8b11ad51361889d46c59afc537f22d0f14ca917e21f1c46fc0fdda7115ca1d69016d505f6a9846c9782eeb1e3c1412d9fd93849e1d57a670334dc7965794

data/app/models/spree/calculator/shipping/correios_base_calculator.rb

@@ -7,51 +7,186 @@ module Spree
     preference :declared_value,       :boolean, default: false
     preference :receipt_notification, :boolean, default: false
     preference :receive_in_hands,     :boolean, default: false
-    
+
+    # Tamanhos maximos que um pacote pode ter para ser enviado pelos correios
+    # Soma maxima das dimensoes (compr. + alt. + larg.)
+    #
+    # documentacao em: http://www.correios.com.br/para-voce/precisa-de-ajuda/limites-de-dimensoes-e-de-peso
+    #
+    MAX_WIDTH = 105
+    MAX_DEPTH = 105
+    MAX_HEIGHT = 105
+    MAX_DIMENSIONS = 200
+
     attr_reader :delivery_time
-    
-    def compute_package(object)
-      return if object.nil?
-      order = if object.is_a?(Spree::Order) then object else object.order end
 
-      stock_location = object.stock_location
+    # Calculates the shipping cost
+    #
+    # Algorithm inspired in Opencart extension created by Thalles Cardoso <thallescard@gmail.com>
+    #
+    # @param package [Spree::Package]
+    #
+    # @return [Hash]
+    #
+    def compute_package package
+      return if package.nil?
+      @order = package.order
+
+      @stock_location = package.stock_location
+
+      pkg = Correios::Frete::Pacote.new
+      pkg_dimensions = {width: 0, height: 0, depth: 0, weight: 0}
+      packages = [pkg]
+
+      package.contents.each do |item|
+        return {} unless valid_dimensions?(item.variant)
+
+        new_width = item.variant.width + pkg_dimensions[:width]
+        new_height = item.variant.height + pkg_dimensions[:height]
+        new_depth = item.variant.depth + pkg_dimensions[:depth]
+        new_weight = item.variant.weight + pkg_dimensions[:weight]
+
+        if (new_width <= MAX_WIDTH and verify_max_dimensions(pkg_dimensions, item.variant, :width)) and (new_weight <= max_weight)
+          pkg_dimensions[:weight] += item.variant.weight
+
+          pkg_dimensions[:width] += item.variant.width
+          pkg_dimensions[:height] = pkg_dimensions[:height] >= item.variant.height ? pkg_dimensions[:height] : item.variant.height
+          pkg_dimensions[:depth] = pkg_dimensions[:depth] >= item.variant.depth ? pkg_dimensions[:depth] : item.variant.depth
+        elsif (new_height <= MAX_HEIGHT and verify_max_dimensions(pkg_dimensions, item.variant, :height)) and (new_weight <= max_weight)
+          pkg_dimensions[:weight] += item.variant.weight
+
+          pkg_dimensions[:height] += item.variant.height
+          pkg_dimensions[:width] = pkg_dimensions[:width] >= item.variant.width ? pkg_dimensions[:width] : item.variant.width
+          pkg_dimensions[:depth] = pkg_dimensions[:depth] >= item.variant.depth ? pkg_dimensions[:depth] : item.variant.depth
+        elsif (new_depth <= MAX_DEPTH and verify_max_dimensions(pkg_dimensions, item.variant, :depth)) and (new_weight <= max_weight)
+          pkg_dimensions[:weight] += item.variant.weight
 
-      require 'correios-frete'
+          pkg_dimensions[:depth] += item.variant.depth
+          pkg_dimensions[:height] = pkg_dimensions[:height] >= item.variant.height ? pkg_dimensions[:height] : item.variant.height
+          pkg_dimensions[:width] = pkg_dimensions[:width] >= item.variant.width ? pkg_dimensions[:width] : item.variant.width
+        else
+          pkg = Correios::Frete::Pacote.new
+          pkg_dimensions = {width: item.variant.width,
+                            height: item.variant.height,
+                            depth: item.variant.depth,
+                            weight: item.variant.weight}
 
-      package = Correios::Frete::Pacote.new
+          packages << pkg
+        end
+        package_item = Correios::Frete::PacoteItem.new(peso: item.variant.weight.to_f,
+                                                       comprimento: item.variant.depth.to_f,
+                                                       largura: item.variant.width.to_f,
+                                                       altura: item.variant.height.to_f)
+        pkg.add_item(package_item)
+      end
+
+      value = 0
+      delivery_time = 0
+
+      packages.each do |pkg|
+        response = calculate_shipping pkg
 
-      object.contents.each do |item|
-        weight = item.variant.weight.to_f
-        depth  = item.variant.depth.to_f
-        width  = item.variant.width.to_f
-        height = item.variant.height.to_f
-        package_item = Correios::Frete::PacoteItem.new(peso: weight, comprimento: depth, largura: width, altura: height)
-        package.add_item(package_item)
+        if response.is_a? Hash
+          value += response[:value]
+          delivery_time = response[:delivery_time] if response[:delivery_time] > delivery_time
+        else
+          return {}
+        end
       end
 
+      @delivery_time = delivery_time + preferred_additional_days
+      cost = value + preferred_additional_value
+      {cost: cost, delivery_time: @delivery_time}
+    rescue
+      {}
+    end
+
+    # Verify if the store has contract to Correios
+    #
+    # @author Isabella Santos
+    #
+    # @return [Boolean]
+    #
+    def has_contract?
+      preferred_token.present? && preferred_password.present?
+    end
+
+    protected
+
+    # Verify if the produtct has valid dimensions for Correios
+    #
+    # @author Isabella Santos
+    #
+    # @param variant [Spree::Variant]
+    #
+    # @return [Boolean]
+    #
+    def valid_dimensions? variant
+      dimensions = variant.width + variant.depth + variant.height
+      if variant.width > MAX_WIDTH or variant.depth > MAX_DEPTH or
+         variant.height > MAX_HEIGHT or dimensions > MAX_DIMENSIONS or
+         variant.weight > max_weight
+        return false
+      end
+      true
+    end
+
+    # Verify the size of the product and the available space inside the box
+    #
+    # @author Isabella Santos
+    #
+    # @param dimensions [Hash]
+    #   used dimensions of the box
+    # @param variant [Spree::Variant]
+    #   variant of the package
+    # @param position [Symbol]
+    #   position of the box
+    #   The options are: :width, :height or :depth
+    #
+    # @return [Boolean]
+    #
+    def verify_max_dimensions(dimensions, variant, position)
+      case position
+        when :width
+          width = dimensions[:width] + variant.width
+          height = dimensions[:height] >= variant.height ? dimensions[:height] : variant.height
+          depth = dimensions[:depth] >= variant.depth ? dimensions[:depth] : variant.depth
+        when :height
+          height = dimensions[:height] + variant.height
+          depth = dimensions[:depth] >= variant.depth ? dimensions[:depth] : variant.depth
+          width = dimensions[:width] >= variant.width ? dimensions[:width] : variant.width
+        when :depth
+          depth = dimensions[:depth] + variant.depth
+          height = dimensions[:height] >= variant.height ? dimensions[:height] : variant.height
+          width = dimensions[:width] >= variant.width ? dimensions[:width] : variant.width
+      end
+
+      (width + height + depth) <= MAX_DIMENSIONS
+    end
+
+    # Request to Correios webservice
+    # the cost and delivery time
+    #
+    # @param package [Correios::Frete::Pacote]
+    #
+    # @return [Hash]
+    #
+    def calculate_shipping(package)
       calculator = Correios::Frete::Calculador.new do |c|
-        c.cep_origem        = stock_location.zipcode
-        c.cep_destino       = order.ship_address.zipcode
+        c.cep_origem        = @stock_location.zipcode
+        c.cep_destino       = @order.ship_address.zipcode
         c.encomenda         = package
         c.mao_propria       = preferred_receive_in_hands
         c.aviso_recebimento = preferred_receipt_notification
-        c.valor_declarado   = order.amount.to_f  if preferred_declared_value
-        c.codigo_empresa    = preferred_token    if preferred_token.present?
-        c.senha             = preferred_password if preferred_password.present?
+        c.valor_declarado   = @order.amount.to_f  if preferred_declared_value
+        c.codigo_empresa    = preferred_token     if preferred_token.present?
+        c.senha             = preferred_password  if preferred_password.present?
       end
 
       webservice = calculator.calculate(shipping_method)
       return false if webservice.erro?
 
-      @delivery_time = webservice.prazo_entrega + preferred_additional_days
-      cost = webservice.valor + preferred_additional_value
-      {cost: cost, delivery_time: @delivery_time}
-    rescue
-      {}
-    end
-    
-    def has_contract?
-      preferred_token.present? && preferred_password.present?
+      {value: webservice.valor, delivery_time: webservice.prazo_entrega}
     end
   end
 end

data/app/models/spree/calculator/shipping/pac.rb

@@ -1,5 +1,6 @@
 module Spree
   class Calculator::Shipping::PAC < Calculator::Shipping::CorreiosBaseCalculator
+
     def self.description
       'PAC'
     end
@@ -19,5 +20,9 @@ module Spree
         41106
       end
     end
+
+    def max_weight
+      30
+    end
   end
 end

data/app/models/spree/calculator/shipping/sedex.rb

@@ -19,5 +19,9 @@ module Spree
         40010
       end
     end
+
+    def max_weight
+      30
+    end
   end
 end

data/app/models/spree/calculator/shipping/sedex10.rb

@@ -11,5 +11,9 @@ module Spree
     def shipping_code
       40215
     end
+
+    def max_weight
+      10
+    end
   end
 end

data/lib/spree_zaez_correios.rb

@@ -1,2 +1,3 @@
 require 'spree_core'
 require 'spree_zaez_correios/engine'
+require 'correios-frete'

data/spec/models/spree/calculator/shipping/correios_calculator_spec.rb

@@ -2,29 +2,29 @@ require 'spec_helper'
 
 describe Spree::Calculator::Shipping::CorreiosBaseCalculator do
 
-  before { @calculator = Spree::Calculator::Shipping::CorreiosBaseCalculator.new }
+  let(:calculator) { subject.class.new }
 
   it 'should have preferences' do
     preferences = [:token, :password, :additional_days, :additional_value, :declared_value, :receipt_notification, :receive_in_hands]
-    expect(@calculator.preferences.keys).to eq(preferences)
+    expect(calculator.preferences.keys).to eq(preferences)
   end
 
   it 'declared value should default to false' do
-    expect(@calculator.preferred_declared_value).to eq(false)
+    expect(calculator.preferred_declared_value).to eq(false)
   end
 
   it 'receipt notification should default to false' do
-    expect(@calculator.preferred_receipt_notification).to eq(false)
+    expect(calculator.preferred_receipt_notification).to eq(false)
   end
 
   it 'receive in hands should default to false' do
-    expect(@calculator.preferred_receive_in_hands).to eq(false)
+    expect(calculator.preferred_receive_in_hands).to eq(false)
   end
 
   it 'should have a contract if both token and password are given' do
-    expect(@calculator).not_to have_contract
-    @calculator.preferred_token = 'some token'
-    @calculator.preferred_password = 'some password'
-    expect(@calculator).to have_contract
+    expect(calculator).not_to have_contract
+    calculator.preferred_token = 'some token'
+    calculator.preferred_password = 'some password'
+    expect(calculator).to have_contract
   end
 end

data/spec/models/spree/calculator/shipping/pac_spec.rb

@@ -1,38 +1,36 @@
 require 'spec_helper'
 
 describe Spree::Calculator::Shipping::PAC do
-  before do
-    @pac = Spree::Calculator::Shipping::PAC.new
-  end
+  let(:pac) { subject.class.new }
 
   it_behaves_like 'correios calculator'
 
   it 'should have a description' do
-    expect(@pac.description).to eq('PAC')
+    expect(pac.description).to eq('PAC')
   end
 
   context 'without a token and password' do
     it 'should have a shipping method of :pac' do
-      expect(@pac.shipping_method).to eq(:pac)
+      expect(pac.shipping_method).to eq(:pac)
     end
 
     it 'should have a shipping code of 41106' do
-      expect(@pac.shipping_code).to eq(41106)
+      expect(pac.shipping_code).to eq(41106)
     end
   end
 
   context 'with a token and password' do
     before do
-      @pac.preferred_token = 'some token'
-      @pac.preferred_password = 'some password'
+      pac.preferred_token = 'some token'
+      pac.preferred_password = 'some password'
     end
 
     it 'should have a shipping method of :pac_com_contrato' do
-      expect(@pac.shipping_method).to eq(:pac_com_contrato)
+      expect(pac.shipping_method).to eq(:pac_com_contrato)
     end
 
     it 'should have a shipping code of 41068' do
-      expect(@pac.shipping_code).to eq(41068)
+      expect(pac.shipping_code).to eq(41068)
     end
   end
 end

data/spec/models/spree/calculator/shipping/sedex10_spec.rb

@@ -1,23 +1,21 @@
 require 'spec_helper'
 
 describe Spree::Calculator::Shipping::SEDEX10 do
-  before do
-    @sedex10 = Spree::Calculator::Shipping::SEDEX10.new
-  end
+  let(:sedex10) { subject.class.new }
 
   it_behaves_like 'correios calculator'
 
   it 'should have a description' do
-    expect(@sedex10.description).to eq('SEDEX 10')
+    expect(sedex10.description).to eq('SEDEX 10')
   end
 
   context 'without a token and password' do
     it 'should have a shipping method of :pac' do
-      expect(@sedex10.shipping_method).to eq(:sedex_10)
+      expect(sedex10.shipping_method).to eq(:sedex_10)
     end
 
     it 'should have a shipping code of 40215' do
-      expect(@sedex10.shipping_code).to eq(40215)
+      expect(sedex10.shipping_code).to eq(40215)
     end
   end
 

data/spec/models/spree/calculator/shipping/sedex_spec.rb

@@ -1,38 +1,36 @@
 require 'spec_helper'
 
 describe Spree::Calculator::Shipping::SEDEX do
-  before do
-    @sedex = Spree::Calculator::Shipping::SEDEX.new
-  end
+  let(:sedex) { subject.class.new }
 
   it_behaves_like 'correios calculator'
 
   it 'should have a description' do
-    expect(@sedex.description).to eq('SEDEX')
+    expect(sedex.description).to eq('SEDEX')
   end
 
   context 'without a token and password' do
     it 'should have a shipping method of :pac' do
-      expect(@sedex.shipping_method).to eq(:sedex)
+      expect(sedex.shipping_method).to eq(:sedex)
     end
 
     it 'should have a shipping code of 40010' do
-      expect(@sedex.shipping_code).to eq(40010)
+      expect(sedex.shipping_code).to eq(40010)
     end
   end
 
   context 'with a token and password' do
     before do
-      @sedex.preferred_token = 'some token'
-      @sedex.preferred_password = 'some password'
+      sedex.preferred_token = 'some token'
+      sedex.preferred_password = 'some password'
     end
 
     it 'should have a shipping method of :pac_com_contrato' do
-      expect(@sedex.shipping_method).to eq(:sedex_com_contrato_1)
+      expect(sedex.shipping_method).to eq(:sedex_com_contrato_1)
     end
 
     it 'should have a shipping code of 40096' do
-      expect(@sedex.shipping_code).to eq(40096)
+      expect(sedex.shipping_code).to eq(40096)
     end
   end
 end

data/spec/models/spree/stock/estimator_decorator_spec.rb

@@ -27,6 +27,19 @@ module Spree
           shipping_rates = subject.shipping_rates(package)
           expect(shipping_rates.first.delivery_time).to eq 1
         end
+
+        it 'should not create shipping rate if cost is unknow' do
+          allow_any_instance_of(ShippingMethod).to receive_message_chain(:calculator, :compute).and_return({})
+          shipping_rates = subject.shipping_rates(package)
+          expect(shipping_rates).to eq Array.new
+        end
+
+        it 'should save only cost if delivery time is not provided' do
+          allow_any_instance_of(ShippingMethod).to receive_message_chain(:calculator, :compute).and_return(10.0)
+          shipping_rate = subject.shipping_rates(package).first
+          expect(shipping_rate.cost).to eq 10.0
+          expect(shipping_rate.delivery_time).to be_nil
+        end
       end
     end
   end

data/spec/support/correios_shared_examples.rb

@@ -1,105 +1,142 @@
 shared_examples_for 'correios calculator' do
 
-  before { @calculator = subject.class.new }
+  let(:calculator) { subject.class.new }
 
   context 'compute_package' do
 
-    # @param url [String]
+    # Stub the request to Correios Webservice
     #
-    # @return [price Float, delivery_time Integer]
+    # @param params [Hash]
     #
-    def get_correios_price_and_value_for(url)
-      doc = Nokogiri::XML(open(url))
-      price = doc.css('Valor').first.content.sub(/,(\d\d)$/, '.\1').to_f
-      delivery_time = doc.css('PrazoEntrega').first.content.to_i
-      return price, delivery_time
+    def stub_correios_request(params = {})
+      correios_attr = {valor: 10.0, prazo_entrega: 1}.merge!(params)
+      response = Correios::Frete::Servico.new(correios_attr)
+      allow_any_instance_of(Correios::Frete::Calculador).to receive(:calculate).and_return(response)
     end
 
-    before do
-      address = FactoryGirl.build(:address, zipcode: '17209420')
-      variant = FactoryGirl.build(:variant, weight: 1, height: 5, width: 15, depth: 20)
-
-      @order = FactoryGirl.build(:order_with_shipments, ship_address: address)
-      line_item = FactoryGirl.build(:line_item, variant: variant, price: 100, order: @order)
-      @order.line_items << line_item
-
-      # stock location
-      @stock_location = FactoryGirl.build(:stock_location, zipcode: '08465312')
-
-      # shipment
-      @shipment = FactoryGirl.build(:shipment, order: @order, stock_location: @stock_location)
-      @shipment.inventory_units << FactoryGirl.build(:inventory_unit, variant: variant, order: @order, line_item: line_item, shipment: @shipment)
-
-      # package
-      @package = @shipment.to_package
-      @package.add @shipment.inventory_units.first
-
-      # default query
-      @default_query = {
-          nCdEmpresa: nil,
-          sDsSenha: nil,
-          sCepOrigem: '08465312',
-          sCepDestino: '17209420',
-          nVlPeso: 1,
-          nCdFormato: 1,
-          nVlComprimento: 20,
-          nVlAltura: 5,
-          nVlLargura: 15,
-          sCdMaoPropria: 'n',
-          nVlValorDeclarado: 0,
-          sCdAvisoRecebimento: 'n',
-          nCdServico: @calculator.shipping_code,
-          nVlDiametro: 0,
-          StrRetorno: 'xml'
-      }
+    let(:address) { FactoryGirl.build(:address, zipcode: '12345678') }
+    let(:variant) { FactoryGirl.build(:variant, weight: 1, height: 5, width: 15, depth: 20) }
+    let(:order) { FactoryGirl.build(:order_with_shipments, ship_address: address) }
+    let(:line_item) {FactoryGirl.build(:line_item, variant: variant, price: 100, order: order)  }
+    let(:stock_location) { FactoryGirl.build(:stock_location, zipcode: '87654321') }
+    let(:shipment) { FactoryGirl.build(:shipment, order: order, stock_location: stock_location) }
+    let(:inventory_unit) { FactoryGirl.build(:inventory_unit, variant: variant, order: order, line_item: line_item, shipment: shipment) }
+    let(:package) do
+      order.line_items << line_item
+      shipment.inventory_units << inventory_unit
+      package = shipment.to_package
+      package.add inventory_unit
+      package
     end
 
     it 'should calculate shipping cost and delivery time' do
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{@default_query.to_query}")
+      stub_correios_request
 
-      expect(@calculator.compute_package(@package)[:cost]).to eq(price)
-      expect(@calculator.delivery_time).to eq(delivery_time)
+      response = calculator.compute_package(package)
+      expect(response[:cost]).to eq(10.0)
+      expect(response[:delivery_time]).to eq(1)
     end
 
     it 'should possible add days to delivery time' do
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{@default_query.to_query}")
+      stub_correios_request
 
-      @calculator.preferred_additional_days = 3
+      calculator.preferred_additional_days = 3
 
-      @calculator.compute_package(@package)
-      expect(@calculator.delivery_time).to eq(delivery_time + 3)
+      response = calculator.compute_package(package)
+      expect(response[:delivery_time]).to eq(4)
     end
 
     it 'should possible add some value to price' do
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{@default_query.to_query}")
+      stub_correios_request
 
-      @calculator.preferred_additional_value = 10.0
+      calculator.preferred_additional_value = 10.0
 
-      expect(@calculator.compute_package(@package)[:cost]).to eq(price + 10.0)
+      response = calculator.compute_package(package)
+      expect(response[:cost]).to eq(20.0)
     end
 
     it 'should change price according to declared value' do
-      query = @default_query.merge({nVlValorDeclarado: '100,00'})
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{query.to_query}")
+      stub_correios_request({valor: 15.0, valor_valor_declarado: 100.0})
 
-      @calculator.preferred_declared_value = true
-      expect(@calculator.compute_package(@package)[:cost]).to eq(price)
+      calculator.preferred_declared_value = true
+
+      response = calculator.compute_package(package)
+      expect(response[:cost]).to eq(15.0)
     end
 
     it 'should change price according to in hands' do
-      query = @default_query.merge({sCdMaoPropria: 's'})
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{query.to_query}")
+      stub_correios_request({valor: 17.0, valor_mao_propria: 4.0})
+
+      calculator.preferred_receive_in_hands = true
 
-      @calculator.preferred_receive_in_hands = true
-      expect(@calculator.compute_package(@package)[:cost]).to eq(price)
+      response = calculator.compute_package(package)
+      expect(response[:cost]).to eq(17.0)
     end
 
     it 'should change price according to receipt notification' do
-      query = @default_query.merge({sCdAvisoRecebimento: 's'})
-      price, delivery_time = get_correios_price_and_value_for("http://ws.correios.com.br/calculador/CalcPrecoPrazo.aspx?#{query.to_query}")
+      stub_correios_request({valor: 21.0, valor_aviso_recebimento: 5.0})
+
+      calculator.preferred_receipt_notification = true
+
+      response = calculator.compute_package(package)
+      expect(response[:cost]).to eq(21.0)
+    end
+
+    context 'validate dimensions' do
+      it 'should split in 2 boxes' do
+        variant.weight = 0.3
+        variant.width = 100
+        variant.height = 30
+        variant.depth = 30
+
+        package.add FactoryGirl.build(:inventory_unit, variant: variant, order: order, line_item: line_item, shipment: shipment)
+        package.add FactoryGirl.build(:inventory_unit, variant: variant, order: order, line_item: line_item, shipment: shipment)
+
+        stub_correios_request
+
+        # Pacote tem 3 produtos com as dimensoes 100x30x30
+        # resultando em duas caixas
+        # Cada caixa tem o frete determinado de 10
+        # entao o retorno deve ser de 20
+
+        response = calculator.compute_package(package)
+        expect(response[:cost]).to eq(20.0)
+      end
+    end
+  end
+
+  context 'valid_dimensions?' do
+    let(:variant) { FactoryGirl.build(:variant, width: 50, height: 50, depth: 50, weight: 5) }
+
+    it 'valid if dimensions is permitted' do
+      expect(calculator.send(:valid_dimensions?, variant)).to be true
+    end
+
+    it 'invalid if weight is greather than the permitted' do
+      variant.weight = calculator.max_weight + 1
+      expect(calculator.send(:valid_dimensions?, variant)).to be false
+    end
+
+    it 'invalid if height is greather than 105cm' do
+      variant.height = 120
+      expect(calculator.send(:valid_dimensions?, variant)).to be false
+    end
+
+    it 'invalid if width is greather than 105cm' do
+      variant.width = 120
+      expect(calculator.send(:valid_dimensions?, variant)).to be false
+    end
+
+    it 'invalid if depth is greather than 105cm' do
+      variant.depth = 120
+      expect(calculator.send(:valid_dimensions?, variant)).to be false
+    end
 
-      @calculator.preferred_receipt_notification = true
-      expect(@calculator.compute_package(@package)[:cost]).to eq(price)
+    it 'invalid if sum of dimensions is greather than 200cm' do
+      variant.height = 100
+      variant.width = 100
+      variant.depth = 100
+      expect(calculator.send(:valid_dimensions?, variant)).to be false
     end
   end
 end

data/spree_zaez_correios.gemspec

@@ -2,7 +2,7 @@
 Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.name        = 'spree_zaez_correios'
-  s.version     = '3.0.4'
+  s.version     = '3.0.5'
   s.summary     = "Implements diverse functions in order to enable the use of services from Brazil's Correios in Spree Commerce"
   s.description = s.summary
   s.required_ruby_version = '>= 2.0.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_zaez_correios
 version: !ruby/object:Gem::Version
-  version: 3.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Zaez Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-27 00:00:00.000000000 Z
+date: 2015-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core