spree_pinterest 0.1.1 → 0.2.0

data/.gitignore

@@ -9,3 +9,4 @@ nbproject
 *.swp
 spec/dummy
 *.gem
+Gemfile.lock

data/.rspec

@@ -1 +1,2 @@
 --colour
+--format Fuubar

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.2.0
+
+* Always use product_url when pinning
+
 # 0.1.1
 
 * Relaxed dependency on `spree_core`

data/Gemfile

@@ -1,7 +1,17 @@
 source 'http://rubygems.org'
 
+group :development do
+  gem "guard-rspec"
+end
+
 group :test do
   gem 'ffaker'
+  gem "fuubar"
+  gem "nokogiri"
+
+  # See https://github.com/spree/spree/issues/1155.  This can be removed
+  # once they push the next release.
+  gem "spree", :git => "git://github.com/spree/spree.git"
 end
 
 if RUBY_VERSION < "1.9"

data/Guardfile

@@ -0,0 +1,17 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+guard 'rspec', :version => 2, :cli => "--format Fuubar --fail-fast" do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+
+  # Rails example
+  watch(%r{^app/(.+)\.rb$})                           { |m| "spec/#{m[1]}_spec.rb" }
+  watch(%r{^app/(.*)(\.erb|\.haml)$})                 { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
+  watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| ["spec/routing/#{m[1]}_routing_spec.rb", "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb"] }
+  watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
+  watch('config/routes.rb')                           { "spec/routing" }
+  watch('app/controllers/application_controller.rb')  { "spec/controllers" }
+end
+

data/app/helpers/spree/pinterest_helper.rb

@@ -1,9 +1,9 @@
 module Spree
   module PinterestHelper
     def pin_it_button(product)
-      return if product.images.blank?
+      return if product.images.empty?
 
-      url = escape request.url
+      url = escape spree.product_url(product)
       media = escape product.images.first.attachment.url
       description = escape product.name
 

data/lib/spree_pinterest/version.rb

@@ -1,3 +1,3 @@
 module SpreePinterest
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/spec/factories.rb

@@ -0,0 +1,5 @@
+FactoryGirl.define do
+  factory :image, :class => 'Spree::Image' do
+    attachment File.open(File.expand_path(File.dirname(__FILE__) + '/fixtures/lambo.jpg'))
+  end
+end

data/spec/helpers/spree/pinterest_helper_spec.rb

@@ -0,0 +1,63 @@
+require "spec_helper"
+
+module Spree
+  describe PinterestHelper do
+    describe "pin_it_button output" do
+      let(:product) { Factory(:product) }
+      let(:output) { helper.pin_it_button(product) }
+
+      context "when the product contains no images" do
+        subject { output }
+        it { should be_nil }
+      end
+
+      context "when the product does contain images" do
+        let(:url) { "http://mystore.com/image1.gif" }
+
+        before do
+          product.images << Factory.build(:image)
+          product.save!
+        end
+
+        describe "href" do
+          let(:expected_output) do
+            image = product.images.first
+            "http://pinterest.com/pin/create/button/?url=#{escape(spree.product_url(product, :host => "test.host"))}&media=#{escape(image.attachment.url)}&description=#{escape(product.name)}"
+          end
+
+          subject { Nokogiri::HTML(output).xpath("//a/@href").text }
+
+          it { should == expected_output }
+
+          def escape(string)
+            URI.escape string, /[^#{URI::PATTERN::UNRESERVED}]/
+          end
+
+          def spree
+            Spree::Core::Engine.routes.url_helpers
+          end
+        end
+
+        describe "class" do
+          subject { Nokogiri::HTML(output).xpath("//a/@class").text }
+
+          it { should == "pin-it-button" }
+        end
+
+        describe "class" do
+          subject { Nokogiri::HTML(output).xpath("//a/@count-layout").text }
+
+          it { should == "horizontal" }
+        end
+
+        it "is html safe" do
+          link_output = double(:link_output)
+          link_output.should_receive(:html_safe)
+          helper.stub(:link_to).and_return(link_output)
+
+          helper.pin_it_button product
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -11,6 +11,7 @@ Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each {|f| require f }
 
 # Requires factories defined in spree_core
 require 'spree/core/testing_support/factories'
+FactoryGirl.find_definitions
 
 RSpec.configure do |config|
   # == Mock Framework

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_pinterest
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-02 00:00:00.000000000 Z
+date: 2012-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core
-  requirement: &70109602092360 !ruby/object:Gem::Requirement
+  requirement: &70100608233560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70109602092360
+  version_requirements: *70100608233560
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &70109602091760 !ruby/object:Gem::Requirement
+  requirement: &70100608228740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -32,10 +32,10 @@ dependencies:
         version: 1.0.1
   type: :development
   prerelease: false
-  version_requirements: *70109602091760
+  version_requirements: *70100608228740
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70109602090980 !ruby/object:Gem::Requirement
+  requirement: &70100608227720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70109602090980
+  version_requirements: *70100608227720
 - !ruby/object:Gem::Dependency
   name: ffaker
-  requirement: &70109602090260 !ruby/object:Gem::Requirement
+  requirement: &70100608227020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70109602090260
+  version_requirements: *70100608227020
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &70109602089320 !ruby/object:Gem::Requirement
+  requirement: &70100608226500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '2.7'
   type: :development
   prerelease: false
-  version_requirements: *70109602089320
+  version_requirements: *70100608226500
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70109602088880 !ruby/object:Gem::Requirement
+  requirement: &70100608225820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70109602088880
+  version_requirements: *70100608225820
 description: This extension provides a Pinterest "Pin it" button for your Spree product
   images.
 email: chad@genuitytech.com
@@ -88,6 +88,7 @@ files:
 - .rspec
 - CHANGELOG.md
 - Gemfile
+- Guardfile
 - LICENSE
 - README.md
 - Rakefile
@@ -106,6 +107,9 @@ files:
 - lib/spree_pinterest/engine.rb
 - lib/spree_pinterest/version.rb
 - script/rails
+- spec/factories.rb
+- spec/fixtures/lambo.jpg
+- spec/helpers/spree/pinterest_helper_spec.rb
 - spec/spec_helper.rb
 - spree_pinterest.gemspec
 homepage: http://genuitytech.com
@@ -134,4 +138,7 @@ signing_key:
 specification_version: 3
 summary: Pinterest button for Spree products
 test_files:
+- spec/factories.rb
+- spec/fixtures/lambo.jpg
+- spec/helpers/spree/pinterest_helper_spec.rb
 - spec/spec_helper.rb