spree_doordash 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba867fc23a044f6166e7fcb61f1641a9f3bd79ddc7c08cf1808abf20664defee
-  data.tar.gz: c3dba97527799999bcbd5cc9881b936c368a1ff819f89e4bc8cf568e7513f568
+  metadata.gz: 11ea8c9082c5f3a17fb5e7ad172eab82c717d17af077bee7d0df14c92a75fba6
+  data.tar.gz: 5e435d16a2bef4e610760fb993533cf54f31a81343b1f5ade02f7889f8eb622c
 SHA512:
-  metadata.gz: 9eccedd59afafb3bc174d769deb3cd47aa6511ca0ec4f6aec3989adab82c148928c74ba0c4416096996d1fa032f49534f1a22736292e670bcacf7ee33a1c090a
-  data.tar.gz: f5bb35207b1cfba4544b47c459c56936eb69b163c3deb3f9fd4f5322ad043b6f36b5b7a220d306037dcffa5d68967b39fac1b2bd0bc558715a41ed78aa1da034
+  metadata.gz: bcee352d7bc9b0a6eeb877d5cd112cf40de922de796739f607058ad92735c787f665641d981d501e3d21af5b82b7e8f4e289b4a96cc6351d659d9f78eed95174
+  data.tar.gz: 99e77a1d48d37fe6f1573341a0e93d90f4d7a68690ede1f1ecdfc43c508340ef9b60aec101f9c4b7aea32fca25109dc94e8f13f8712124802f8b4e64e7866295

data/CHANGELOG.md

@@ -2,7 +2,33 @@
 
 All notable changes to this project are documented here.
 
-## 0.1.0 (unreleased)
+## 0.1.1
+
+Two real production bugs, both invisible to the full spec suite and to every prior "live
+verification" in this project, both found only by driving a genuine storefront checkout end to
+end instead of calling the services directly:
+
+- **DoorDash rejects any phone number that isn't strict E.164.** Every earlier live test in this
+  project — including the M1–M5 verifications documented below — happened to type phone numbers
+  directly in `+1XXXXXXXXXX` form. The first real checkout, with a number typed the way an address
+  form actually produces one (`(202) 555-0199`), got a real `400 Unknown phone number format` from
+  DoorDash's `/drive/v2/quotes` endpoint — which silently dropped the DoorDash Delivery shipping
+  rate with no error surfaced anywhere in checkout. Fixed by normalizing both `pickup_phone_number`
+  and `dropoff_phone_number` to E.164 before every quote request.
+
+- **The order-completed subscriber was never actually registered with Spree's event system.**
+  `Spree::Subscriber`'s own docstring claims subscribers are "automatically registered during Rails
+  initialization" — that's not what `spree_core` 5.6.1 actually does. `Spree::Events.register_subscribers!`
+  only iterates an explicit `Spree.subscribers` array, populated via `Spree.subscribers << YourClass`
+  in an initializer; there's no automatic scan. This gem never had that initializer line. Every spec
+  for `OrderCompletedSubscriber` called `.call` on it directly, which bypasses the registry entirely
+  and kept passing regardless — so a real storefront order, placed with DoorDash Delivery selected,
+  completed successfully and was never dispatched, with nothing anywhere indicating a problem. Fixed
+  by adding the missing `config/initializers/spree.rb`, plus a new spec that asserts
+  `Spree.subscribers` actually includes the class — the one test that would have caught this from
+  the start.
+
+## 0.1.0
 
 Initial development. M1 (foundation) — complete and verified against a real DoorDash Sandbox
 endpoint (`bin/rails spree_doordash:verify_connection`, a real accepted quote):

data/app/services/spree_doordash/quote.rb

@@ -73,14 +73,34 @@ module SpreeDoordash
         external_delivery_id: external_delivery_id,
         pickup_address: format_address(location_mapping.stock_location),
         pickup_business_name: location_mapping.stock_location.name,
-        pickup_phone_number: location_mapping.stock_location.phone.presence || '+10000000000',
+        pickup_phone_number: format_phone(location_mapping.stock_location.phone),
         pickup_instructions: location_mapping.stock_location.pickup_instructions,
         dropoff_address: format_address(order.ship_address),
-        dropoff_phone_number: order.ship_address.phone.presence || '+10000000000',
+        dropoff_phone_number: format_phone(order.ship_address.phone),
         order_value: (order.total * 100).to_i
       }
     end
 
+    # DoorDash wants E.164 (+1XXXXXXXXXX) and rejects anything else outright
+    # — confirmed live: a real checkout with a normally-typed US phone number
+    # ("(202) 555-0199", exactly what an address form produces) got a real
+    # 400 "Unknown phone number format" from DoorDash, silently dropping the
+    # DoorDash Delivery rate with no visible error anywhere in the UI. Every
+    # earlier live verification in this project used numbers already typed
+    # in +1XXXXXXXXXX form by hand, which is why this never surfaced until
+    # an actual storefront checkout was driven through normally.
+    #
+    # US-only, matching the rest of this demo (every address here is a US
+    # address) — strips everything but digits, assumes a bare 10-digit
+    # number is domestic and prepends the country code.
+    def format_phone(raw)
+      digits = raw.to_s.gsub(/\D/, '')
+      digits = "1#{digits}" if digits.length == 10
+      return '+10000000000' if digits.blank?
+
+      "+#{digits}"
+    end
+
     # Spree::StockLocation and Spree::Address share the same field shape
     # (address1/address2/city/state/zipcode/country) even though they're
     # unrelated classes — DoorDash wants one flat string, not structured

data/config/initializers/spree.rb

@@ -0,0 +1,17 @@
+# Registers this extension's event subscriber with Spree's event system.
+#
+# Spree::Subscriber's own docstring says subscribers are "automatically
+# registered during Rails initialization" — that's not what actually
+# happens in spree_core 5.6.1: Spree::Events.register_subscribers! only
+# ever iterates the explicit Spree.subscribers array (see
+# spree_core/lib/spree/events.rb) — there is no Zeitwerk-descendant scan.
+# Without this file, SpreeDoordash::OrderCompletedSubscriber is a real,
+# loadable class (so specs calling it directly always passed) but is never
+# actually wired to the 'order.completed' event in the running app — found
+# live: a real storefront order completed with DoorDash Delivery selected
+# and never got dispatched, because nothing ever appended this subscriber
+# to Spree.subscribers. Mirrors spree_square's own identical registration
+# in its own config/initializers/spree.rb.
+Rails.application.config.after_initialize do
+  Spree.subscribers << SpreeDoordash::OrderCompletedSubscriber
+end

data/lib/spree_doordash/version.rb

@@ -1,5 +1,5 @@
 module SpreeDoordash
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 
   def gem_version
     Gem::Version.new(VERSION)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_doordash
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Amit Solanki
@@ -136,6 +136,7 @@ files:
 - app/views/spree/admin/doordash_delivery_mappings/index.html.erb
 - app/views/spree/admin/doordash_webhook_events/index.html.erb
 - config/brakeman.ignore
+- config/initializers/spree.rb
 - config/initializers/spree_admin_doordash_navigation.rb
 - config/initializers/spree_admin_doordash_tables.rb
 - config/initializers/spree_doordash_calculators.rb