spree_core 4.2.7 → 4.3.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b469e8dee55a662982149fbc79bb798341a52da2d7d7ded1e0353a4c8010859
-  data.tar.gz: b633068dd8204485b512dd395216ffbda53e9fc7cc62f113a08b1fcbe7183d4d
+  metadata.gz: 2b031163e0c77da6776854068fb9769ed6cd44ff048e75a088ee6526c40db986
+  data.tar.gz: 2cfbcbfb7a1c5221270e7b677222a94047b5965cb32e5144ca6540d927f2b51b
 SHA512:
-  metadata.gz: feecadebe12b6959f521a39bcce7508acb1f48b815679a7916b0003d6330e96a6003e2f19a9c9b58e76c016e79af71f865586097534013739c1a7371160aabc5
-  data.tar.gz: c020b19d48c81bf75ae67f1c3404e0b18a69a7d6021a06f0edff442d5bee5d8e7d627d2e207adec190d74b6a4c66f93ec1eaa34bfe1b494e05c1d682846c08f0
+  metadata.gz: 375bd44efe93e706a1bd58abcc9be1fb3f2af0b0a993fe223a1e093033193105012284e0a7f03413fad0099feb105fa4b1526b8d576d76e58e62e37967c67768
+  data.tar.gz: c82f2406e121b6fff092677e91d0344e35c5b6e19aee5aca1916ee819d7909a42ef854653922413e215c67934cb73df2a1af002fbe3d48f53db99ff854d80f93

data/app/finders/concerns/spree/product_filterable.rb

@@ -0,0 +1,9 @@
+module Spree
+  module ProductFilterable
+    private
+
+    def find_available(scope, products_scope)
+      scope.filterable.for_products(products_scope)
+    end
+  end
+end

data/app/finders/spree/cms_pages/find.rb

@@ -0,0 +1,41 @@
+module Spree
+  module CmsPages
+    class Find < ::Spree::BaseFinder
+      ALLOWED_KINDS = %w[standard home feature].freeze
+
+      def initialize(scope:, params:)
+        @scope = scope
+        @title = params.dig(:filter, :title)
+        @kind  = params.dig(:filter, :type)
+      end
+
+      def execute
+        pages = by_title(scope)
+        pages = by_kind(pages)
+
+        pages
+      end
+
+      private
+
+      attr_reader :scope, :title, :kind
+
+      def title_matcher
+        Spree::CmsPage.arel_table[:title].matches("%#{title}%")
+      end
+
+      def by_title(pages)
+        return pages if title.blank?
+
+        pages.where(title_matcher)
+      end
+
+      def by_kind(pages)
+        return pages if kind.blank?
+        return pages if ALLOWED_KINDS.exclude?(kind)
+
+        pages.send(kind)
+      end
+    end
+  end
+end

data/app/finders/spree/menus/find.rb

@@ -0,0 +1,11 @@
+module Spree
+  module Menus
+    class Find < ::Spree::BaseFinder
+      def execute
+        return scope.where(location: params[:filter]['location']) if params[:filter].present? && params[:filter]['location'].present?
+
+        scope
+      end
+    end
+  end
+end

data/app/finders/spree/option_values/find_available.rb

@@ -0,0 +1,20 @@
+module Spree
+  module OptionValues
+    class FindAvailable
+      include ProductFilterable
+
+      def initialize(scope: OptionValue.spree_base_scopes, products_scope: Product.spree_base_scopes)
+        @scope = scope
+        @products_scope = products_scope
+      end
+
+      def execute
+        find_available(scope, products_scope)
+      end
+
+      private
+
+      attr_reader :scope, :products_scope
+    end
+  end
+end

data/app/finders/spree/orders/find_complete.rb

@@ -1,18 +1,20 @@
 module Spree
   module Orders
     class FindComplete
-      attr_reader :user, :number, :token
+      attr_reader :user, :number, :token, :store
 
-      def initialize(user: nil, number: nil, token: nil)
+      def initialize(user: nil, number: nil, token: nil, store: nil)
         @user = user
         @number = number
         @token = token
+        @store = store
       end
 
       def execute
         orders = by_user(scope)
         orders = by_number(orders)
         orders = by_token(orders)
+        orders = by_store(orders)
 
         orders
       end
@@ -35,6 +37,10 @@ module Spree
         token.present?
       end
 
+      def store?
+        store.present?
+      end
+
       def by_user(orders)
         return orders unless user?
 
@@ -53,6 +59,12 @@ module Spree
         orders.where(token: token)
       end
 
+      def by_store(orders)
+        return orders unless store?
+
+        orders.where(store: store)
+      end
+
       def scope_includes
         {
           line_items: [

data/app/finders/spree/orders/find_current.rb

@@ -15,19 +15,7 @@ module Spree
       private
 
       def incomplete_orders
-        Spree::Order.incomplete.not_canceled.includes(scope_includes)
-      end
-
-      def scope_includes
-        {
-          line_items: [
-            variant: [
-              :images,
-              option_values: :option_type,
-              product: :product_properties,
-            ]
-          ]
-        }
+        Spree::Order.incomplete.not_canceled
       end
     end
   end

data/app/finders/spree/product_properties/find_available.rb

@@ -0,0 +1,20 @@
+module Spree
+  module ProductProperties
+    class FindAvailable
+      include ProductFilterable
+
+      def initialize(scope: ProductProperty.spree_base_scopes, products_scope: Product.spree_base_scopes)
+        @scope = scope
+        @products_scope = products_scope
+      end
+
+      def execute
+        find_available(scope, products_scope)
+      end
+
+      private
+
+      attr_reader :scope, :products_scope
+    end
+  end
+end

data/app/finders/spree/products/find.rb

@@ -1,13 +1,23 @@
 module Spree
   module Products
     class Find
-      def initialize(scope:, params:, current_currency:)
+      def initialize(scope:, params:, current_currency: nil)
         @scope = scope
 
+        ActiveSupport::Deprecation.warn('`current_currency` param is deprecated and will be removed in Spree 5') if current_currency
+
+        if current_currency.present?
+          ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
+            `current_currency` param is deprecated and will be removed in Spree 5.
+            Please pass `:currency` in `params` hash instead.
+          DEPRECATION
+        end
+
         @ids              = String(params.dig(:filter, :ids)).split(',')
         @skus             = String(params.dig(:filter, :skus)).split(',')
-        @price            = String(params.dig(:filter, :price)).split(',').map(&:to_f)
-        @currency         = current_currency
+        @store            = params[:store] || Spree::Store.default
+        @price            = map_prices(String(params.dig(:filter, :price)).split(','))
+        @currency         = current_currency || params.dig(:filter, :currency) || params[:currency]
         @taxons           = taxon_ids(params.dig(:filter, :taxons))
         @concat_taxons    = taxon_ids(params.dig(:filter, :concat_taxons))
         @name             = params.dig(:filter, :name)
@@ -16,6 +26,7 @@ module Spree
         @sort_by          = params.dig(:sort_by)
         @deleted          = params.dig(:filter, :show_deleted)
         @discontinued     = params.dig(:filter, :show_discontinued)
+        @properties       = params.dig(:filter, :properties)
       end
 
       def execute
@@ -28,6 +39,7 @@ module Spree
         products = by_name(products)
         products = by_options(products)
         products = by_option_value_ids(products)
+        products = by_properties(products)
         products = include_deleted(products)
         products = include_discontinued(products)
         products = ordered(products)
@@ -38,7 +50,7 @@ module Spree
       private
 
       attr_reader :ids, :skus, :price, :currency, :taxons, :concat_taxons, :name, :options,
-                  :option_value_ids, :scope, :sort_by, :deleted, :discontinued
+                  :option_value_ids, :scope, :sort_by, :deleted, :discontinued, :properties, :store
 
       def ids?
         ids.present?
@@ -80,8 +92,8 @@ module Spree
         sort_by.present?
       end
 
-      def name_matcher
-        Spree::Product.arel_table[:name].matches("%#{name}%")
+      def properties?
+        properties.present? && properties.values.reject(&:empty?).present?
       end
 
       def by_ids(products)
@@ -99,19 +111,13 @@ module Spree
       def by_price(products)
         return products unless price?
 
-        products.joins(master: :prices).
-          where(
-            spree_prices: {
-              amount: price.min..price.max,
-              currency: currency&.upcase
-            }
-          )
+        products.price_between(price.min, price.max)
       end
 
       def by_currency(products)
         return products unless currency?
 
-        products.joins(master: :prices).where(spree_prices: { currency: currency.upcase })
+        products.with_currency(currency)
       end
 
       def by_taxons(products)
@@ -136,7 +142,7 @@ module Spree
       def by_name(products)
         return products unless name?
 
-        products.where(name_matcher)
+        products.like_any([:name], [name])
       end
 
       def by_options(products)
@@ -160,6 +166,27 @@ module Spree
         products.where(id: product_ids)
       end
 
+      def by_properties(products)
+        return products unless properties?
+
+        product_ids = []
+        index = 0
+
+        properties.to_unsafe_hash.each do |property_filter_param, product_properties_values|
+          next if property_filter_param.blank? || product_properties_values.empty?
+
+          values = product_properties_values.split(',').reject(&:empty?).uniq.map(&:parameterize)
+
+          next if values.empty?
+
+          ids = products.with_property_values(property_filter_param, values).ids
+          product_ids = index == 0 ? ids : product_ids & ids
+          index += 1
+        end
+
+        products.where(id: product_ids)
+      end
+
       def option_types_count(option_value_ids)
         Spree::OptionValue.
           where(id: option_value_ids).
@@ -173,12 +200,14 @@ module Spree
         case sort_by
         when 'default'
           if taxons?
-            products.
-              select("#{Product.table_name}.*, #{Classification.table_name}.position").
-              order("#{Classification.table_name}.position" => :asc)
+            products.ascend_by_taxons_min_position(taxons)
           else
             products
           end
+        when 'name-a-z'
+          products.order(name: :asc)
+        when 'name-z-a'
+          products.order(name: :desc)
         when 'newest-first'
           products.order(available_on: :desc)
         when 'price-high-to-low'
@@ -199,13 +228,19 @@ module Spree
       end
 
       def include_discontinued(products)
-        discontinued ? products : products.available
+        discontinued ? products : products.active(currency)
+      end
+
+      def map_prices(prices)
+        prices.map do |price|
+          price == 'Infinity' ? Float::INFINITY : price.to_f
+        end
       end
 
       def taxon_ids(taxons_ids)
         return if taxons_ids.nil? || taxons_ids.to_s.blank?
 
-        taxons = Spree::Taxon.where(id: taxons_ids.to_s.split(','))
+        taxons = store.taxons.where(id: taxons_ids.to_s.split(','))
         taxons.map(&:cached_self_and_descendants_ids).flatten.compact.uniq.map(&:to_s)
       end
     end

data/app/finders/spree/stores/find_current.rb

@@ -0,0 +1,24 @@
+module Spree
+  module Stores
+    class FindCurrent
+      def initialize(scope: nil, url: nil)
+        @scope = scope || Spree::Store
+        @url = url
+      end
+
+      def execute
+        by_url(scope) || scope.default
+      end
+
+      protected
+
+      attr_reader :scope, :url
+
+      def by_url(scope)
+        return if url.blank?
+
+        scope.by_url(url).first
+      end
+    end
+  end
+end

data/app/helpers/spree/base_helper.rb

@@ -9,6 +9,25 @@ module Spree
       end.sort_by { |c| c.name.parameterize }
     end
 
+    def all_countries
+      countries = Spree::Country.all
+
+      countries.collect do |country|
+        country.name = Spree.t(country.iso, scope: 'country_names', default: country.name)
+        country
+      end.sort_by { |c| c.name.parameterize }
+    end
+
+    def spree_resource_path(resource)
+      last_word = resource.class.name.split('::', 10).last
+
+      spree_class_name_as_path(last_word)
+    end
+
+    def spree_class_name_as_path(class_name)
+      class_name.underscore.humanize.parameterize(separator: '_')
+    end
+
     def display_price(product_or_variant)
       product_or_variant.
         price_in(current_currency).
@@ -36,6 +55,11 @@ module Spree
     end
 
     def logo(image_path = nil, options = {})
+      ActiveSupport::Deprecation.warn(<<-DEPRECATION, caller)
+        `BaseHelper#logo` is deprecated and will be removed in Spree 5.0.
+        Please use `FrontendHelper#logo` instead
+      DEPRECATION
+
       image_path ||= if current_store.logo.attached? && current_store.logo.variable?
                        main_app.url_for(current_store.logo.variant(resize: '244x104>'))
                      elsif current_store.logo.attached? && current_store.logo.image?
@@ -51,6 +75,10 @@ module Spree
       end
     end
 
+    def spree_favicon_path
+      main_app.url_for(current_store.favicon || 'favicon.ico')
+    end
+
     def object
       instance_variable_get('@' + controller_name.singularize)
     end
@@ -95,7 +123,7 @@ module Spree
                               description: [object.name, current_store.meta_description].reject(&:blank?).join(', '))
         else
           meta.reverse_merge!(keywords: (current_store.meta_keywords || current_store.seo_title),
-                              description: (current_store.meta_description || current_store.seo_title))
+                              description: (current_store.homepage(I18n.locale)&.seo_meta_description || current_store.seo_meta_description))
         end
       end
       meta
@@ -143,6 +171,34 @@ module Spree
       Spree::Core::Engine.frontend_available?
     end
 
+    def rails_5?
+      Rails::VERSION::STRING < '6.0'
+    end
+
+    def spree_storefront_resource_url(resource, options = {})
+      if defined?(locale_param) && locale_param.present?
+        options.merge!(locale: locale_param)
+      end
+
+      localize = if options[:locale].present?
+                   "/#{options[:locale]}"
+                 else
+                   ''
+                 end
+
+      if resource.instance_of?(Spree::Product)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_products_path]}/#{resource.slug}"
+      elsif resource.instance_of?(Spree::Taxon)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_taxons_path]}/#{resource.permalink}"
+      elsif resource.instance_of?(Spree::Cms::Pages::FeaturePage) || resource.instance_of?(Spree::Cms::Pages::StandardPage)
+        "#{current_store.formatted_url + localize}/#{Spree::Config[:storefront_pages_path]}/#{resource.slug}"
+      elsif localize.blank?
+        current_store.formatted_url
+      else
+        current_store.formatted_url + localize
+      end
+    end
+
     # we should always try to render image of the default variant
     # same as it's done on PDP
     def default_image_for_product(product)
@@ -171,7 +227,7 @@ module Spree
 
     def base_cache_key
       [I18n.locale, current_currency, defined?(try_spree_current_user) && try_spree_current_user.present?,
-        defined?(try_spree_current_user) && try_spree_current_user.try(:has_spree_role?, 'admin')]
+       defined?(try_spree_current_user) && try_spree_current_user.try(:has_spree_role?, 'admin')]
     end
 
     def maximum_quantity
@@ -211,5 +267,9 @@ module Spree
 
       tag('meta', name: 'robots', content: current_store.seo_robots)
     end
+
+    def taxon_wysiwyg_editor_enabled?
+      Spree::Config[:taxon_wysiwyg_editor_enabled]
+    end
   end
 end

data/app/helpers/spree/locale_helper.rb

@@ -16,12 +16,16 @@ module Spree
 
     def locale_presentation(locale)
       if I18n.exists?('spree.i18n.this_file_language', locale: locale)
-        [Spree.t('i18n.this_file_language', locale: locale), locale.to_s]
+        [locale_full_name(locale), locale.to_s]
       else
         locale.to_s == 'en' ? ['English (US)', 'en'] : [locale, locale.to_s]
       end
     end
 
+    def locale_full_name(locale)
+      Spree.t('i18n.this_file_language', locale: locale)
+    end
+
     def should_render_locale_dropdown?
       return false if current_store.nil?
 

data/app/helpers/spree/products_helper.rb

@@ -44,9 +44,13 @@ module Spree
       variants_option_types_presenter(variants, product).options
     end
 
+    def product_wysiwyg_editor_enabled?
+      Spree::Config[:product_wysiwyg_editor_enabled]
+    end
+
     # converts line breaks in product description into <p> tags (for html display purposes)
     def product_description(product)
-      description = if Spree::Config[:show_raw_product_description]
+      description = if Spree::Config[:show_raw_product_description] || product_wysiwyg_editor_enabled?
                       product.description
                     else
                       product.description.to_s.gsub(/(.*?)\r?\n\r?\n/m, '<p>\1</p>')
@@ -63,7 +67,7 @@ module Spree
     end
 
     def cache_key_for_products(products = @products, additional_cache_key = nil)
-      max_updated_at = (products.maximum(:updated_at) || Date.today).to_s(:number)
+      max_updated_at = (products.except(:group, :order).maximum(:updated_at) || Date.today).to_s(:number)
       products_cache_keys = "spree/products/#{products.map(&:id).join('-')}-#{params[:page]}-#{params[:sort_by]}-#{max_updated_at}-#{@taxon&.id}"
       (common_product_cache_keys + [products_cache_keys] + [additional_cache_key]).compact.join('/')
     end
@@ -131,7 +135,7 @@ module Spree
 
       return [] if product_ids.empty?
 
-      Spree::Product.
+      current_store.products.
         available.not_discontinued.distinct.
         where(id: product_ids).
         includes(

data/app/models/concerns/spree/display_link.rb

@@ -0,0 +1,42 @@
+module Spree
+  module DisplayLink
+    def link
+      case linked_resource_type
+      when 'Spree::Taxon'
+        return if linked_resource&.permalink.blank?
+
+        if spree_routes.method_defined?(:nested_taxons_path)
+          spree_routes.nested_taxons_path(linked_resource.permalink)
+        else
+          "/#{Spree::Config[:storefront_taxons_path]}/#{linked_resource.permalink}"
+        end
+      when 'Spree::Product'
+        return if linked_resource&.slug.blank?
+
+        if spree_routes.method_defined?(:products_path)
+          spree_routes.product_path(linked_resource)
+        else
+          "/#{Spree::Config[:storefront_products_path]}/#{linked_resource.slug}"
+        end
+      when 'Spree::CmsPage'
+        return if linked_resource&.slug.blank?
+
+        if spree_routes.method_defined?(:page_path)
+          spree_routes.page_path(linked_resource.slug)
+        else
+          "/#{Spree::Config[:storefront_pages_path]}/#{linked_resource.slug}"
+        end
+      when 'Home Page'
+        '/'
+      when 'URL'
+        destination
+      end
+    end
+
+    private
+
+    def spree_routes
+      Spree::Core::Engine.routes.url_helpers
+    end
+  end
+end

data/app/models/concerns/spree/filter_param.rb

@@ -0,0 +1,21 @@
+module Spree
+  module FilterParam
+    extend ActiveSupport::Concern
+
+    included do
+      before_save :set_filter_param
+    end
+
+    protected
+
+    def set_filter_param
+      return if param_candidate.blank?
+
+      self.filter_param = param_candidate.parameterize
+    end
+
+    def param_candidate
+      name
+    end
+  end
+end

data/app/models/concerns/spree/memoized_data.rb

@@ -0,0 +1,24 @@
+module Spree
+  module MemoizedData
+    extend ActiveSupport::Concern
+
+    included do
+      # reset cache on save inside trasaction and transaction commit
+      after_save :reset_memoized_data
+      after_commit :reset_memoized_data
+
+      def reload(options = {})
+        reset_memoized_data
+        super(options)
+      end
+
+      private
+
+      def reset_memoized_data
+        self.class.const_get('MEMOIZED_METHODS').each do |v|
+          instance_variable_set(:"@#{v.gsub(/\?/, '')}", nil)
+        end
+      end
+    end
+  end
+end

data/app/models/concerns/spree/multi_store_resource.rb

@@ -0,0 +1,24 @@
+module Spree
+  module MultiStoreResource
+    extend ActiveSupport::Concern
+
+    included do
+      scope :for_store, ->(store) { joins(:stores).where(Store.table_name => { id: store.id }) }
+
+      validate :must_have_one_store, unless: :disable_store_presence_validation?
+    end
+
+    protected
+
+    def must_have_one_store
+      return if stores.any?
+
+      errors.add(:stores, Spree.t(:must_have_one_store))
+    end
+
+    # this can be overriden on model basis
+    def disable_store_presence_validation?
+      Spree::Config[:disable_store_presence_validation]
+    end
+  end
+end