spree_cm_commissioner 2.9.5 → 2.9.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b5fced09e0795a88c5dfc1cd5ef84584dc557c0c8f0c26f0c1ed8f0c62f5b9a
-  data.tar.gz: 612e81f2f3b4f7e15e6481c9910523fabc9fed36c9b8b265c83bd9fa1834b826
+  metadata.gz: f187ec143a0546d2099b322062ef981cac276ced2ef0ae9714bd5d5984040d2c
+  data.tar.gz: 1f2a838ce0779597fd0c5b06784b9e0fbb260085457612dcb7e646f61da0482b
 SHA512:
-  metadata.gz: 460533fe4a445145c9edd9e4c0fa1c9fa4c4fc6153105f0dea7e9cf2e873e423e6f967ba734931b5206a9309706a40d92c0a0a13b93d3c59bc57d65fc8be023f
-  data.tar.gz: 5f11f494bc107000bd15cf51a6ba29f43c64436f8803257f793488fce84f8d4549c15057f2c5b169460cc601a9fd5cea86bf5ec044999467fe013f9a5c6e5778
+  metadata.gz: 9f722ef15d8fef51009e1da877520831551d33d4c2391036dcd31db1ddc6f485cc0d475b6144843fb660404e7e75ecfb77769a646bc6933378b4eca181cadfaa
+  data.tar.gz: 8ef07513d2cb8b65635dfa960b60d84fdbb6d0ad2731cc098f3e99de64901bd3100e80b9a10c0ac1e1243a4c451f2633b93ca3496775f690b10bd6edc2f66369

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.9.5)
+    spree_cm_commissioner (2.9.6)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/models/concerns/spree_cm_commissioner/event_metadata.rb

@@ -9,6 +9,11 @@ module SpreeCmCommissioner
       store_public_metadata :group_check_in_enabled, :boolean, default: true
       store_public_metadata :individual_check_in_enabled, :boolean, default: true
 
+      # Cached existence flag, kept in sync by Role's after_commit callback (see role_decorator.rb) —
+      # lets User#check_in_group_for skip querying spree_roles for the common case of an event with no
+      # check-in groups at all.
+      store_public_metadata :has_check_in_groups, :boolean, default: false
+
       # By default, for most events, manual search is allowed for operators.
       # For certain large events, admin can disable this manually.
       store_public_metadata :allow_manual_search_for_operator, :boolean, default: true

data/app/models/spree_cm_commissioner/role_decorator.rb

@@ -36,6 +36,8 @@ module SpreeCmCommissioner
       # events under the same vendor can each own a "VIP" group.
       base.validates :presentation, uniqueness: { scope: :vendor_id }, if: -> { vendor_id.present? && !check_in? }
       base.validates :presentation, uniqueness: { scope: %i[vendor_id event_id] }, if: -> { vendor_id.present? && check_in? }
+
+      base.after_commit :sync_event_has_check_in_groups_flag, on: %i[create destroy], if: -> { check_in? }
     end
 
     def generate_unique_name
@@ -67,6 +69,15 @@ module SpreeCmCommissioner
       ids = product_ids.map(&:to_i)
       check_in_exclude? ? event_product_ids.map(&:to_i) - ids : ids
     end
+
+    private
+
+    # Keeps Taxon#has_check_in_groups? in sync so User#check_in_group_for can skip querying
+    # spree_roles for events with none. Recomputes from scratch rather than assuming true/false from
+    # the create/destroy alone, since an event can have more than one check-in group.
+    def sync_event_has_check_in_groups_flag
+      event.update!(has_check_in_groups: event.check_in_groups.exists?)
+    end
   end
 end
 

data/app/models/spree_cm_commissioner/user_decorator.rb

@@ -165,10 +165,12 @@ module SpreeCmCommissioner
       @check_in_group_cache[event_id] = spree_roles.find_by(role_type: :check_in, event_id: event_id)
     end
 
-    # Whether this user may check in the given guest. Admins and organizers are never restricted by a
-    # check-in group; otherwise the crew may check in the guest's ticket if their check-in group allows
-    # it (include/exclude evaluated on that one group).
+    # Whether this user may check in the given guest. Events with no check-in groups at all are
+    # unrestricted. Otherwise admins and organizers are never restricted; everyone else may check in
+    # the guest's ticket only if their check-in group allows it (include/exclude evaluated on that one
+    # group).
     def can_check_in_guest?(guest)
+      return true unless guest.event.has_check_in_groups?
       return true if admin? || organizer?
 
       group = check_in_group_for(guest.event_id)
@@ -178,9 +180,10 @@ module SpreeCmCommissioner
     end
 
     # This user's check-in role for the event, used to scope the operator offline export (one role, one
-    # export — see Exports::OperatorGuestJsonGzip#role). `nil` = unrestricted (admins/organizers, or
-    # crew in no group).
+    # export — see Exports::OperatorGuestJsonGzip#role). `nil` = unrestricted (admins/organizers, crew in
+    # no group, or an event with no check-in groups at all — see #can_check_in_guest?).
     def check_in_role_for(event)
+      return nil unless event.has_check_in_groups?
       return nil if admin? || organizer?
 
       check_in_group_for(event.id)

data/lib/spree_cm_commissioner/version.rb

@@ -1,5 +1,5 @@
 module SpreeCmCommissioner
-  VERSION = '2.9.5'.freeze
+  VERSION = '2.9.6'.freeze
 
   module_function
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree_cm_commissioner
 version: !ruby/object:Gem::Version
-  version: 2.9.5
+  version: 2.9.6
 platform: ruby
 authors:
 - You