spree_cm_commissioner 2.8.3.pre.pre4 → 2.8.3.pre.pre5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8bd441927a9bb64c823a003b5a1f0ecbb7591a90de805f3e3edfdcaaa48180ba
-  data.tar.gz: 3a5b5097a6b2daf1edf5d2b8a55d3d87cc6de0127022b3859817ffe3994ae75d
+  metadata.gz: 145ade12d325f15a3f1963b4fd75e56093cbb182e1f3ac115d0101c0c6cad285
+  data.tar.gz: e47239cbfa8a359ce7e0b0ed2f73e5270876f679d3047a2d88be89493683004a
 SHA512:
-  metadata.gz: 37bcbc34200db68f4647ff333e5e923939b42d46f669ea04b721be9652f7280e12f047ad9541b538054723cd16a63350f62cc586d978fa8ad94a7e4625695ca9
-  data.tar.gz: ab2ee51768d3b2d9c7b1145120b0d70defa14c6cbb6ea7c9a550a11f7ec2496b3674bdbba48f0a37f452c11f7fc5c7ba2d567eacd4f9de0380a18c06ce1fe68e
+  metadata.gz: '06134389566fe49ae2dfe58a65919130cc57dcf43694d33af480d2930d517cfbba1ba97c7714f0b011cdb063a9a7d1611dc205fdcce1cf7f77fd4618c6d9ffd9'
+  data.tar.gz: 60d6491f501f2baa87fb971bee6a906f3180425d9f72917462adc2d266c0f3302a44bf532c39fe9885b3b965d7c94fdae9b158d0c7bc9263879b2d2e43197e23

data/.github/workflows/test_and_build_gem.yml

@@ -164,7 +164,8 @@ jobs:
         env:
           DATABASE_URL: postgres://myuser:mypassword@localhost:5432/test_db
         run: |
-          bundle exec brakeman --no-exit-on-warn
+          # Using --no-threads to bypass a known Ruby 3.2.0 GC segmentation fault in CI.
+          bundle exec brakeman --no-threads --no-exit-on-warn
 
   test:
     needs: [setup]

data/.gitignore

@@ -38,3 +38,5 @@ dump.rdb
 .code-review-graph/
 .cursorrules
 .claude
+CLAUDE.md
+AGENTS.md

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.8.3.pre.pre4)
+    spree_cm_commissioner (2.8.3.pre.pre5)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/controllers/spree/api/v2/tenant/episodes_controller.rb

@@ -0,0 +1,38 @@
+module Spree
+  module Api
+    module V2
+      module Tenant
+        class EpisodesController < BaseController
+          private
+
+          def model_class
+            SpreeCmCommissioner::ShowEpisode
+          end
+
+          def resource
+            @resource ||= scope.find(params[:id])
+          end
+
+          def scope
+            current_season.episodes.includes(:voting_sessions)
+          end
+
+          def current_season
+            @current_season ||= SpreeCmCommissioner::Show
+                                .where(vendor_id: @tenant.vendors.select(:id))
+                                .where.not(parent_id: nil)
+                                .find_by!(slug: params[:show_id])
+          end
+
+          def resource_serializer
+            Spree::V2::Tenant::ShowEpisodeSerializer
+          end
+
+          def collection_serializer
+            Spree::V2::Tenant::ShowEpisodeSerializer
+          end
+        end
+      end
+    end
+  end
+end

data/app/controllers/spree/api/v2/tenant/shows_controller.rb

@@ -20,7 +20,9 @@ module Spree
             return model_class.none if vendor_ids.blank?
 
             model_class.where(vendor_id: vendor_ids, preview: false)
-                       .includes(:parent, :app_banner, episodes: :voting_sessions, seasons: { episodes: :voting_sessions })
+                       .includes(:parent, :app_banner, show_people: :show_person_images,
+                                                       episodes: :voting_sessions, seasons: { episodes: :voting_sessions }
+                       )
           end
 
           # override

data/app/controllers/spree/api/v2/tenant/voting_contestants_controller.rb

@@ -9,7 +9,10 @@ module Spree
           def collection
             @collection ||= @voting_session
                             .voting_contestants
-                            .includes(show_contestant: :show_contestant_images)
+                            .includes(:voting_session, :show_contestant,
+                                      :show_contestant_images, :show_contestant_videos,
+                                      :advanced_to, :advanced_from
+                            )
                             .order(:id)
           end
 

data/app/models/spree_cm_commissioner/taxon_decorator.rb

@@ -86,7 +86,9 @@ module SpreeCmCommissioner
       base.scope :events,     -> { where(taxonomy_id: Spree::Taxonomy.events.id, depth: 1) }
       base.scope :campaigns,  -> { where(taxonomy_id: Spree::Taxonomy.ads.id, depth: 1) }
 
-      base.has_many :advertisements, -> { advertisement }, through: :classifications, class_name: 'Spree::Product', source: :product
+      base.has_many :advertisements, lambda {
+                                       advertisement.where(deleted_at: nil)
+                                     }, through: :classifications, class_name: 'Spree::Product', source: :product
       base.has_many :agencies, class_name: 'SpreeCmCommissioner::Agency', foreign_key: :agency_category_id
       base.has_many :preview_roles, class_name: 'SpreeCmCommissioner::PreviewRole', as: :previewable
 

data/app/models/spree_cm_commissioner/voting_contestant.rb

@@ -19,6 +19,8 @@ module SpreeCmCommissioner
     end
 
     before_destroy :prevent_if_last_contestant_in_parent_session
+    before_destroy :prevent_if_advanced_from_session
+    before_destroy :prevent_if_pre_vote_session
 
     validates :eliminated_via, presence: true, if: :eliminated?
 
@@ -45,6 +47,14 @@ module SpreeCmCommissioner
       (special_rules || {})['type']
     end
 
+    def advanced_from_name
+      advanced_from&.name
+    end
+
+    def advanced_to_name
+      advanced_to&.name
+    end
+
     private
 
     # Prevent removing the last contestant from a session that is referenced as a parent
@@ -57,5 +67,23 @@ module SpreeCmCommissioner
       errors.add(:base, :last_contestant_in_parent_session, session_name: voting_session.name)
       throw :abort
     end
+
+    def prevent_if_pre_vote_session
+      return unless voting_session.pre_vote?
+
+      errors.add(:base, :pre_vote_session)
+      throw :abort
+    end
+
+    # Prevent direct destroy when this record was advanced here from a previous session.
+    # Destroying it directly would leave the source session's advanced_to pointer dangling.
+    # The correct removal path is to clear advanced_to on the source VotingContestant,
+    # which triggers the Advancer service to clean up this record atomically.
+    def prevent_if_advanced_from_session
+      return if advanced_from_id.blank?
+
+      errors.add(:base, :advanced_from_session)
+      throw :abort
+    end
   end
 end

data/app/models/spree_cm_commissioner/voting_session.rb

@@ -119,7 +119,7 @@ module SpreeCmCommissioner
     end
 
     def can_vote?
-      enabled? && Time.zone.now.between?(opens_at, closes_at)
+      enabled? && Time.zone.now.between?(opens_at, closes_at) && !manual_advance?
     end
 
     # Returns the next advanceable session within the same episode (by position).

data/app/serializers/spree/v2/tenant/campaign_serializer.rb

@@ -6,6 +6,10 @@ module Spree
 
         attributes :name, :from_date, :to_date
 
+        attribute :sorted_ads_ids do |campaign|
+          SpreeCmCommissioner::Advertisements::SortedAdvertisements.call(campaign: campaign).value
+        end
+
         has_many :advertisements, serializer: Spree::V2::Tenant::AdvertisementSerializer
       end
     end

data/app/serializers/spree/v2/tenant/show_episode_serializer.rb

@@ -11,6 +11,8 @@ module Spree
             'upcoming'
           end
         end
+
+        has_many :voting_sessions, serializer: Spree::V2::Tenant::VotingSessionSerializer
       end
     end
   end

data/app/serializers/spree/v2/tenant/show_serializer.rb

@@ -9,6 +9,8 @@ module Spree
 
         attribute :name, &:display_name
 
+        has_many :show_people, serializer: Spree::V2::Tenant::ShowPersonSerializer
+        has_many :episodes, serializer: Spree::V2::Tenant::ShowEpisodeSerializer
         has_many :voting_sessions, serializer: Spree::V2::Tenant::VotingSessionSerializer
         has_one :current_episode, serializer: Spree::V2::Tenant::ShowEpisodeSerializer
         has_one :current_voting_session, serializer: Spree::V2::Tenant::VotingSessionSerializer

data/app/serializers/spree/v2/tenant/voting_contestant_serializer.rb

@@ -4,9 +4,9 @@ module Spree
       class VotingContestantSerializer < BaseSerializer
         set_type :voting_contestant
 
-        attributes :show_id, :show_contestant_id, :name, :contestant_number, :vote_number, :category, :gender,
-                   :vote_count, :eliminated, :eliminated_via, :eliminated_at, :advanced_to_type, :advanced_to_id, :special_rules,
-                   :created_at, :updated_at, :advanced_from_type, :advanced_from_id, :unique_voter_count, :preferences
+        attributes :show_contestant_id, :name, :contestant_number, :vote_number, :category, :gender,
+                   :eliminated, :eliminated_via, :vote_count, :unique_voter_count, :special_rules,
+                   :created_at, :updated_at, :advanced_from_name, :advanced_to_name, :confirmed_rank
 
         attribute :voting_session_id, &:voting_session_id
 
@@ -16,6 +16,7 @@ module Spree
 
         has_many :show_contestant_images, serializer: ::Spree::V2::Tenant::AssetSerializer
         has_many :show_contestant_videos, serializer: ::Spree::V2::Tenant::VideoSerializer
+        belongs_to :voting_session, serializer: ::Spree::V2::Tenant::VotingSessionSerializer
       end
     end
   end

data/app/serializers/spree/v2/tenant/voting_session_serializer.rb

@@ -4,7 +4,7 @@ module Spree
       class VotingSessionSerializer < BaseSerializer
         attributes :opens_at, :name, :closes_at, :status, :session_type, :live_stream_enabled,
                    :live_stream_thumbnail, :live_stream_title, :live_stream_description,
-                   :position, :fraud_config
+                   :position, :fraud_config, :display, :public_metadata
 
         attribute :live_stream_url, &:embedded_live_stream_url
         attribute :can_vote, &:can_vote?
@@ -12,6 +12,8 @@ module Spree
         belongs_to :episode, serializer: Spree::V2::Tenant::ShowEpisodeSerializer
         belongs_to :show, serializer: Spree::V2::Tenant::ShowSerializer
 
+        has_many :voting_contestants, serializer: ::Spree::V2::Tenant::VotingContestantSerializer
+
         has_many :eliminated_voting_contestants, serializer: ::Spree::V2::Tenant::VotingContestantSerializer
       end
     end

data/app/services/spree_cm_commissioner/advertisements/sorted_advertisements.rb

@@ -0,0 +1,61 @@
+# Builds a weighted round-robin slot sequence for one ad rotation cycle.
+#
+# Ads are interleaved so the same ad never repeats until all others have appeared.
+# Each round emits one slot per ad in descending weight order. Higher weight =
+# appears first in every round + appears in more rounds = displayed more often.
+#
+# Usage:
+#   result = SpreeCmCommissioner::Advertisements::SortedAdvertisements.call(campaign: campaign)
+#
+#   result.success?   # => true
+#   result.value      # => [469, 470, 468, 469, 470, 468, 469, 470, ...]
+#
+# Example: Bachuss weight=5, Feranado weight=5, Ganzberg weight=4  (14 slots total)
+#   Round 1: Bachuss, Feranado, Ganzberg
+#   Round 2: Bachuss, Feranado, Ganzberg
+#   Round 3: Bachuss, Feranado, Ganzberg
+#   Round 4: Bachuss, Feranado, Ganzberg
+#   Round 5: Bachuss, Feranado              ← Ganzberg exhausted
+#
+#   Bachuss  → 5/14 ≈ 36% of opens
+#   Feranado → 5/14 ≈ 36% of opens
+#   Ganzberg → 4/14 ≈ 28% of opens
+module SpreeCmCommissioner
+  module Advertisements
+    class SortedAdvertisements
+      prepend ::Spree::ServiceModule::Base
+
+      def call(campaign:)
+        return success([]) unless campaign
+
+        ads = campaign.advertisements.to_a
+        return success([]) if ads.empty?
+
+        success(weighted_round_robin(ads))
+      end
+
+      private
+
+      # Interleaves ads so no ID repeats until all others have appeared.
+      # Each round emits one slot per ad (highest weight first); ads with
+      # remaining quota continue into the next round until all slots are filled.
+      def weighted_round_robin(ads)
+        pool = ads
+               .map { |ad| { id: ad.id, remaining: ad.advertise_weight.to_i } }
+               .sort_by { |entry| -entry[:remaining] }
+
+        slots = []
+        until pool.all? { |entry| entry[:remaining].zero? }
+          pool.each do |entry|
+            next if entry[:remaining].zero?
+
+            slots << entry[:id]
+            entry[:remaining] -= 1
+          end
+        end
+
+        slots
+      end
+    end
+  end
+end

data/app/services/spree_cm_commissioner/voting_contestants/advancer.rb

@@ -190,8 +190,9 @@ module SpreeCmCommissioner
         # e.g. vc_b.vote_count = 5 → return false
         return false if linked.vote_count.to_i.positive?
 
-        # Safe to destroy (0 votes); signal that the pointer can be cleared.
-        # e.g. vc_b.vote_count = 0 → destroy vc_b, return true
+        # Clear back-reference before destroy so prevent_if_advanced_from_session doesn't abort.
+        # The Advancer manages both sides atomically, so the source pointer is cleaned up by the caller.
+        linked.update!(advanced_from_type: nil, advanced_from_id: nil)
         linked.destroy!
         true
       end
@@ -235,8 +236,8 @@ module SpreeCmCommissioner
           end
         end
 
-        # Destroy this node after its subtree is cleaned up (post-order).
-        # e.g. destroy vc_b after vc_c was already removed
+        # Clear back-reference before destroy so prevent_if_advanced_from_session doesn't abort.
+        linked_row.update!(advanced_from_type: nil, advanced_from_id: nil)
         linked_row.destroy!
       end
 

data/app/services/spree_cm_commissioner/voting_contestants/assigner.rb

@@ -21,9 +21,17 @@ module SpreeCmCommissioner
         target_ids = @show_contestant_ids.uniq
         return if target_ids.empty?
 
-        @episode.season.show_contestants.where(id: target_ids).find_each do |show_contestant|
-          @voting_session.voting_contestants.find_or_create_by!(show_contestant: show_contestant) do |voting_contestant|
-            voting_contestant.show_id = @voting_session.show_id
+        ApplicationRecord.transaction do
+          @episode.season.show_contestants.where(id: target_ids).find_each do |show_contestant|
+            if @voting_session.save_vote? && !show_contestant.eliminated?
+              raise I18n.t('spree_cm_commissioner.voting_contestants.assigner.not_eliminated',
+                           name: show_contestant.name, status: show_contestant.status
+              )
+            end
+
+            @voting_session.voting_contestants.find_or_create_by!(show_contestant: show_contestant) do |voting_contestant|
+              voting_contestant.show_id = @voting_session.show_id
+            end
           end
         end
       end

data/app/services/spree_cm_commissioner/voting_sessions/finalize.rb

@@ -3,10 +3,18 @@ module SpreeCmCommissioner
     class Finalize
       prepend ::Spree::ServiceModule::Base
 
-      def call(voting_session:)
+      def call(voting_session:, save_advance_to_session_id: nil)
+        @save_advance_to_session_id = save_advance_to_session_id
+
         ApplicationRecord.transaction do
           validate_confirmed_ranks!(voting_session)
-          advance_confirmed_winners(voting_session) if next_session?(voting_session)
+
+          if voting_session.save_vote?
+            restore_and_advance_saved_contestants(voting_session)
+          elsif next_session?(voting_session)
+            advance_confirmed_winners(voting_session)
+          end
+
           voting_session.update!(status: :finalized)
           success(voting_session: voting_session)
         end
@@ -17,7 +25,7 @@ module SpreeCmCommissioner
       private
 
       def validate_confirmed_ranks!(voting_session)
-        if next_session?(voting_session)
+        if voting_session.save_vote? || next_session?(voting_session)
           raise I18n.t('voting.errors.no_winners_confirmed') if voting_session.voting_contestants.where.not(confirmed_rank: nil).none?
         else
           unranked = voting_session.voting_contestants.where(eliminated: false, confirmed_rank: nil)
@@ -25,6 +33,27 @@ module SpreeCmCommissioner
         end
       end
 
+      def restore_and_advance_saved_contestants(voting_session)
+        target_session = SpreeCmCommissioner::VotingSession.find_by(id: @save_advance_to_session_id)
+        raise I18n.t('voting.errors.save_advance_to_session_required') if target_session.nil?
+
+        voting_session.voting_contestants.each do |vc|
+          if vc.confirmed_rank.present?
+            vc.show_contestant.update!(status: :active)
+            SpreeCmCommissioner::VotingContestants::Advancer.call(
+              voting_contestant: vc,
+              attributes: { advanced_to: target_session }
+            )
+          else
+            SpreeCmCommissioner::VotingContestants::Advancer.call(
+              voting_contestant: vc,
+              attributes: { eliminated: true, eliminated_via: :instant_save_lost, advanced_to_type: nil, advanced_to_id: nil }
+            )
+            # ShowContestant#status already :eliminated — no change needed
+          end
+        end
+      end
+
       # Re-syncs advancement on every call — handles first finalize and re-finalize.
       # Contestants without a confirmed_rank get their advanced_to cleared.
       def advance_confirmed_winners(voting_session)
@@ -48,6 +77,7 @@ module SpreeCmCommissioner
               voting_contestant: voting_contestant,
               attributes: { eliminated: true, eliminated_via: :public_vote, advanced_to_type: nil, advanced_to_id: nil }
             )
+            voting_contestant.show_contestant.update!(status: :eliminated)
           end
         end
       end

data/config/locales/en.yml

@@ -557,6 +557,8 @@ en:
           attributes:
             base:
               last_contestant_in_parent_session: 'cannot remove the last contestant from "%{session_name}" because child sessions depend on it'
+              advanced_from_session: 'was advanced from a previous session and cannot be removed directly. Clear the advancement in the source session instead.'
+              pre_vote_session: 'cannot be removed from a pre-vote session.'
         spree_cm_commissioner/tenant:
           attributes:
             host:
@@ -777,6 +779,9 @@ en:
     verification_failed: "Human verification failed"
     service_unavailable: "Verification service is temporarily unavailable"
   spree_cm_commissioner:
+    voting_contestants:
+      assigner:
+        not_eliminated: "Only eliminated contestants can be added to a Save Contestants session. %{name} is %{status}."
     voting_leaderboards:
       combined_result:
         pre_vote_not_finalized: "Cannot combine results: Pre-Vote sessions not yet finalized: %{names}"

data/config/locales/km.yml

@@ -419,6 +419,12 @@ km:
               must_not_exceed_parent: "មិនអាចក្រោយ closes_at របស់ session មេ"
             parent_id:
               must_have_contestants: '"%{name}" ត្រូវតែមានអ្នកចូលប្រកួត'
+        spree_cm_commissioner/voting_contestant:
+          attributes:
+            base:
+              last_contestant_in_parent_session: 'មិនអាចដកអ្នកចូលប្រកួតចុងក្រោយពី "%{session_name}" ព្រោះ session កូនពឹងផ្អែកលើវា'
+              advanced_from_session: 'ត្រូវបានដំឡើងពី session មុន ហើយមិនអាចដកចេញដោយផ្ទាល់បានទេ។ សូមលុបការដំឡើងនៅក្នុង session ប្រភពជំនួសវិញ។'
+              pre_vote_session: 'មិនអាចដកចេញពី pre-vote session បានទេ។'
         spree_cm_commissioner/tenant:
           attributes:
             host:
@@ -612,6 +618,10 @@ km:
     token_missing: "សញ្ញាណផ្ទៀងផ្ទាត់គឺបាត់"
     verification_failed: "ការផ្ទៀងផ្ទាត់បានបរាជ័យ"
     service_unavailable: "សេវាកម្មពេលនេះមិនមានការផ្ទៀងផ្ទាត់"
+  spree_cm_commissioner:
+    voting_contestants:
+      assigner:
+        not_eliminated: "តែអ្នកចូលប្រកួតដែលត្រូវបានលុបចោលប៉ុណ្ណោះអាចបន្ថែមទៅ Save Contestants session បាន។ %{name} មានស្ថានភាព %{status}។"
   voting:
     errors:
       no_winners_confirmed: "មិនមានអ្នកឈ្នះត្រូវបានបញ្ជាក់"

data/config/routes.rb

@@ -589,6 +589,7 @@ Spree::Core::Engine.add_routes do
         resources :waiting_room_sessions, only: :create
 
         resources :shows, only: [:show] do
+          resources :episodes, only: %i[index show]
           resources :people, controller: :show_people, only: %i[index] do
             resources :assignments, controller: :show_person_assignments, only: %i[index]
           end

data/db/migrate/20260608000000_add_display_to_cm_voting_sessions.rb

@@ -0,0 +1,5 @@
+class AddDisplayToCmVotingSessions < ActiveRecord::Migration[7.0]
+  def change
+    add_column :cm_voting_sessions, :display, :boolean, default: true, null: false, if_not_exists: true
+  end
+end

data/lib/spree_cm_commissioner/version.rb

@@ -1,5 +1,5 @@
 module SpreeCmCommissioner
-  VERSION = '2.8.3.pre.pre4'.freeze
+  VERSION = '2.8.3.pre.pre5'.freeze
 
   module_function
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_cm_commissioner
 version: !ruby/object:Gem::Version
-  version: 2.8.3.pre.pre4
+  version: 2.8.3.pre.pre5
 platform: ruby
 authors:
 - You
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-08 00:00:00.000000000 Z
+date: 2026-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree
@@ -1045,6 +1045,7 @@ files:
 - app/controllers/spree/api/v2/tenant/cms_pages_controller.rb
 - app/controllers/spree/api/v2/tenant/customer_notifications_controller.rb
 - app/controllers/spree/api/v2/tenant/dynamic_field_options_controller.rb
+- app/controllers/spree/api/v2/tenant/episodes_controller.rb
 - app/controllers/spree/api/v2/tenant/free_vote_claims_controller.rb
 - app/controllers/spree/api/v2/tenant/guests_controller.rb
 - app/controllers/spree/api/v2/tenant/homepage_sections_controller.rb
@@ -2102,7 +2103,7 @@ files:
 - app/services/sms_adapter/base.rb
 - app/services/sms_adapter/plasgate.rb
 - app/services/sms_adapter/twillio.rb
-- app/services/spree_cm_commissioner/advertisements/weight_validator.rb
+- app/services/spree_cm_commissioner/advertisements/sorted_advertisements.rb
 - app/services/spree_cm_commissioner/aes_encryption_service.rb
 - app/services/spree_cm_commissioner/agency_categories/create.rb
 - app/services/spree_cm_commissioner/agency_users/add.rb
@@ -3282,6 +3283,7 @@ files:
 - db/migrate/20260527062005_add_eliminated_at_to_cm_show_contestants.rb
 - db/migrate/20260603063652_add_parent_to_voting_sessions.rb
 - db/migrate/20260603090000_add_session_type_to_cm_voting_sessions.rb
+- db/migrate/20260608000000_add_display_to_cm_voting_sessions.rb
 - docker-compose.yml
 - docs/api/scoped-access-token-endpoints.md
 - docs/option_types/attr_types.md

data/app/services/spree_cm_commissioner/advertisements/weight_validator.rb

@@ -1,43 +0,0 @@
-# Validates that adding or updating an advertisement keeps the campaign total within 100.
-#
-# Usage:
-#   # on create
-#   result = SpreeCmCommissioner::Advertisements::WeightValidator.call(
-#     campaign: campaign,
-#     new_weight: 40
-#   )
-#
-#   # on update (exclude current ad from total)
-#   result = SpreeCmCommissioner::Advertisements::WeightValidator.call(
-#     campaign: campaign,
-#     new_weight: 40,
-#     exclude_id: advertisement.id
-#   )
-#
-#   result.success?    # => true
-#   result.error.value # => "Campaign weights must not exceed 100, got 130"
-#
-# Rules:
-#   - Skip validation if campaign is nil
-#   - All other ads in the campaign + new_weight must not exceed 100
-module SpreeCmCommissioner
-  module Advertisements
-    class WeightValidator
-      prepend ::Spree::ServiceModule::Base
-
-      def call(campaign:, new_weight:, exclude_id: nil)
-        return success(campaign) unless campaign
-
-        scope = campaign.advertisements
-        scope = scope.where.not(id: exclude_id) if exclude_id
-
-        existing_total = scope.sum { |ad| ad.advertise_weight.to_i }
-        total = existing_total + new_weight.to_i
-
-        return success(campaign) if total <= 100
-
-        failure(nil, "Campaign weights must not exceed 100, got #{total}")
-      end
-    end
-  end
-end