spree_cm_commissioner 2.5.2.pre.pre2 → 2.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 415383ae7339303ff881a06d0642275576a1aa2e0bd685d2dfbf239cda829f6e
-  data.tar.gz: da42ba2da856fff29f83d67f574d6e07cd06c1066a1baa0ef30b92268533d8b0
+  metadata.gz: 847e4b0b554ef076b2daeafe2d90509a434254ef6bb7bc19d34905d9a72f5a42
+  data.tar.gz: ce1c22521e38c5d012d2cb3fbe1ac041958a6054808c9b1786f4446a3046483d
 SHA512:
-  metadata.gz: b3590bf3744645b2af02f779ccf4d6797879e71a47c9c01e524514428396813cc6752f25e361cf1489e0f1a2f106ba9987f43581d97788ce19ed290848a7fc68
-  data.tar.gz: 6d0b09ce6143a18db3118c284ae0c1b334bbd29baf9dcf106ec4253144afbdb5da6e78f952219821ccc782601eee2ac20f7f1ccf7f22148290ac9ae0f1a3a012
+  metadata.gz: 1bfbb01640f43c2b9540063a8c5e368b44b4009ecd27653f739c030c65ceffcdc48d1141d466f90e2870d3c088f933260366f9db3f3bfb4b1c68dba402f5522e
+  data.tar.gz: 7f128de24e2ad50a06c9a148dc37c2ccc4e8396077a32c2456a89a35b45236562073a185f67e8e50dca5b1a59efd9b6dbcfeef2018aa63becc88b334fa070609

data/.github/workflows/test_and_build_gem.yml

@@ -164,7 +164,7 @@ jobs:
         env:
           DATABASE_URL: postgres://myuser:mypassword@localhost:5432/test_db
         run: |
-          bundle exec brakeman
+          bundle exec brakeman --no-exit-on-warn
 
   test:
     needs: [setup]

data/Gemfile.lock

@@ -34,7 +34,7 @@ GIT
 PATH
   remote: .
   specs:
-    spree_cm_commissioner (2.5.2.pre.pre2)
+    spree_cm_commissioner (2.5.2)
       activerecord-multi-tenant
       activerecord_json_validator (~> 2.1, >= 2.1.3)
       aws-sdk-cloudfront

data/app/controllers/spree/api/v2/storefront/homepage_data_controller.rb

@@ -3,12 +3,43 @@ module Spree
     module V2
       module Storefront
         class HomepageDataController < ::Spree::Api::V2::ResourceController
+          before_action :load_homepage_background, only: [:show]
+          before_action :load_menu, only: [:show]
+
           def show
-            home_data_loader = SpreeCmCommissioner::HomepageDataLoader.with_cache
+            resource = SpreeCmCommissioner::HomepageData.new(
+              menu: @menu,
+              homepage_background: @homepage_background
+            )
+            render_serialized_payload { serialize_resource(resource) }
+          end
+
+          private
+
+          def serialize_resource(resource)
+            resource_serializer.new(
+              resource,
+              params: serializer_params,
+              include: resource_includes
+            ).serializable_hash
+          end
+
+          def load_homepage_background
+            @homepage_background ||= SpreeCmCommissioner::HomepageBackground
+                                     .active
+                                     .includes(:app_image, :web_image)
+                                     .where(segment: params[:segment] || :general)
+                                     .order(priority: :asc)
+                                     .first
+          end
 
-            render_serialized_payload do
-              serialize_resource(home_data_loader)
-            end
+          def load_menu
+            # Spree::Menu::MENU_LOCATIONS = ['Header', 'Footer']
+            # Current our homepage use only location: header
+            @menu ||= Spree::Menu.by_locale(I18n.locale)
+                                 .includes({ menu_items: %i[children parent icon] })
+                                 .where(location: 'header')
+                                 .first
           end
 
           def resource_serializer

data/app/controllers/spree_cm_commissioner/application_controller_decorator.rb

@@ -13,8 +13,6 @@ module SpreeCmCommissioner
     def after_sign_in_path_for(_)
       if spree_current_user.admin?
         admin_path
-      elsif spree_current_user.organizer? && spree_current_user.events.present?
-        event_guests_path(spree_current_user.events.first.slug)
       else
         '/'
       end

data/app/interactors/spree_cm_commissioner/conversion_pre_calculator.rb

@@ -5,7 +5,7 @@ module SpreeCmCommissioner
     def call
       update_conversion
       reassign_guests_event_id
-      generate_guests_bib_number
+      refinalize_guests
     end
 
     def update_conversion
@@ -28,14 +28,23 @@ module SpreeCmCommissioner
       end
     end
 
-    def generate_guests_bib_number
+    def refinalize_guests
       return if event_id.blank?
 
       SpreeCmCommissioner::Guest
         .complete
         .where(event_id: event_id)
         .none_bib
-        .find_each(&:generate_bib!)
+        .find_each do |guest|
+          result = SpreeCmCommissioner::Guests::Finalize.call(
+            guest: guest,
+            user: guest.line_item.order.user,
+            event: guest.event,
+            variant: guest.variant
+          )
+
+          result.success? || raise(ActiveRecord::RecordInvalid, guest)
+        end
     end
 
     def event_id

data/app/interactors/spree_cm_commissioner/notification_reader.rb

@@ -15,9 +15,11 @@ module SpreeCmCommissioner
     end
 
     def read_all_user_unread_notifications
-      # mark all unread notifications accept type 'guest_dynamic_field_notification'
+      # mark all unread notifications except type 'guest_dynamic_field_notification'
       # due to it requires user to fill info before mark as read
       user.notifications.markable_notifications.mark_as_read!
+
+      SpreeCmCommissioner::UserCountersService.reset_unread_notifications_count(user)
     end
   end
 end

data/app/jobs/spree_cm_commissioner/line_items/sync_event_date_job.rb

@@ -0,0 +1,10 @@
+module SpreeCmCommissioner
+  module LineItems
+    class SyncEventDateJob < ApplicationJob
+      def perform(options = {})
+        event = Spree::Taxon.event.find(options[:event_id])
+        SpreeCmCommissioner::LineItems::SyncEventDate.call(event: event)
+      end
+    end
+  end
+end

data/app/models/concerns/spree_cm_commissioner/line_item_durationable.rb

@@ -52,30 +52,37 @@ module SpreeCmCommissioner
       self.event_id ||= product.event_id
     end
 
-    # Line item date now depends directly on the event date and variant date.
-    # No longer depend on the event section date.
-    # This keeps the setup simple for the organizer and consistent for users.
+    # Calculates line item duration with priority:
+    # - Date: variant date > event date > user input (from_date/to_date)
+    # - Time: always uses variant time configuration
+    #
+    # The variant date takes highest priority. If variant has no date configured,
+    # falls back to event date, then to user-provided date.
+    #
+    # Examples:
+    #   1. Variant has full date/time config:
+    #      Variant: 2024-01-15 14:00 to 2024-01-16 18:00
+    #      Event: 2024-07-20, User: 2024-06-15
+    #      → Result: 2024-01-15 14:00 to 2024-01-16 18:00 (variant wins)
+    #
+    #   2. Variant has only time, event provides date:
+    #      Variant: 14:00 (3 hours duration)
+    #      Event: 2024-07-20, User: 2024-06-15
+    #      → Result: 2024-07-20 14:00 to 2024-07-20 17:00 (event date + variant time)
+    #
+    #   3. Variant has only time, no event, user provides date:
+    #      Variant: 14:00 (3 hours duration)
+    #      No event, User: 2024-06-15
+    #      → Result: 2024-06-15 14:00 to 2024-06-15 17:00 (user date + variant time)
     def set_duration
-      self.from_date ||= variant.start_date_time || event&.from_date
-      self.to_date ||= variant.end_date_time || event&.to_date
-
-      return if persisted?
-
-      apply_variant_time(:from_date, variant.start_date_time)
-      apply_variant_time(:to_date, variant.end_date_time)
-    end
-
-    def apply_variant_time(field, variant_time)
-      field_value = send(field)
-
-      return unless field_value.present? && field_value.hour.zero? && variant_time.present?
-
-      send("#{field}=", field_value.change(
-                          hour: variant_time.hour,
-                          min: variant_time.min,
-                          sec: variant_time.sec
-                        )
-      )
+      # Prepare fallback dates: event date > user input
+      base_start_date = event&.from_date || from_date
+      base_end_date = event&.to_date || to_date
+
+      # Variant will use its own date if configured, otherwise uses base_*_date
+      # Variant time is always applied to the final date
+      self.from_date = variant.start_date_time(start_date: base_start_date)
+      self.to_date = variant.end_date_time(start_date: base_start_date, end_date: base_end_date)
     end
   end
 end

data/app/models/concerns/spree_cm_commissioner/option_type_attr_type.rb

@@ -45,8 +45,7 @@ module SpreeCmCommissioner
       'color' => 'color',
       'ticket-type' => 'string',
       'seat-type' => 'string',
-      'intercity-taxi' => 'string',
-      'rules' => 'string'
+      'intercity-taxi' => 'string'
     }.freeze
 
     included do

data/app/models/concerns/spree_cm_commissioner/order_state_machine.rb

@@ -4,7 +4,7 @@ module SpreeCmCommissioner
   module OrderStateMachine
     extend ActiveSupport::Concern
 
-    included do
+    included do # rubocop:disable Metrics/BlockLength
       state_machine.before_transition to: :address, do: :hold_blocks
       state_machine.before_transition to: :payment, do: :ensure_blocks_held
 
@@ -43,12 +43,14 @@ module SpreeCmCommissioner
         event :request do
           transition from: nil, to: :requested
         end
+        after_transition to: :requested, do: :increment_user_request_orders_count
         after_transition to: :requested, do: :send_order_requested_app_notification_to_user
         after_transition to: :requested, do: :send_order_requested_telegram_alert_to_store
 
         event :accept do
           transition from: :requested, to: :accepted
         end
+        after_transition from: :requested, to: :accepted, do: :decrement_user_request_orders_count
         after_transition to: :accepted, do: :send_order_accepted_app_notification_to_user
         after_transition to: :accepted, do: :send_order_accepted_telegram_alert_to_store
 
@@ -59,6 +61,8 @@ module SpreeCmCommissioner
           transition from: :requested, to: :rejected
         end
 
+        after_transition from: :requested, to: :rejected, do: :decrement_user_request_orders_count
+
         after_transition to: :rejected, do: :send_order_rejected_app_notification_to_user
         after_transition to: :rejected, do: :send_order_rejected_telegram_alert_to_store
 
@@ -72,6 +76,18 @@ module SpreeCmCommissioner
       end
     end
 
+    def increment_user_request_orders_count
+      return if user.nil?
+
+      SpreeCmCommissioner::UserCountersService.increment_request_orders_count(user)
+    end
+
+    def decrement_user_request_orders_count
+      return if user.nil?
+
+      SpreeCmCommissioner::UserCountersService.decrement_request_orders_count(user)
+    end
+
     def product_completion_steps_exist?
       product_completion_steps.any?
     end
@@ -174,9 +190,17 @@ module SpreeCmCommissioner
           line_item.generate_remaining_guests
 
           line_item.guests.each do |guest|
-            guest.user = user if user.present?
-            guest.generate_bib_if_needed
-            guest.save!
+            result = SpreeCmCommissioner::Guests::Finalize.call(
+              guest: guest,
+              user: user,
+              event: line_item.event,
+              variant: line_item.variant
+            )
+
+            unless result.success?
+              guest.errors.add(:base, result.error.value || result.error.to_s)
+              raise(ActiveRecord::RecordInvalid, guest)
+            end
           end
         end
       end

data/app/models/concerns/spree_cm_commissioner/variant_options_concern.rb

@@ -26,7 +26,6 @@ module SpreeCmCommissioner
                :bib_prefix,
                :bib_zerofill,
                :bib_display_prefix?,
-               :bib_pre_generation_on_create?,
                :seat_number_positions,
                :seat_number_layouts,
                :color,
@@ -53,9 +52,28 @@ module SpreeCmCommissioner
       option_values.detect { |o| o.option_type.name.downcase.strip == option_type_name.downcase.strip }.try(:name)
     end
 
-    # No need to fallback to event start date to avoid n+1.
-    # To get end_time duration of event, include event when needed instead.
-    def start_date_time
+    # Determines the start date/time with priority:
+    # - Date priority: variant date > event date > user input date
+    # - Time: always uses variant time (if configured)
+    #
+    # Examples:
+    #   1. Variant date takes priority:
+    #      Variant: 2024-01-15, Event: 2024-02-20, User: 2024-03-10, Variant time: 14:00
+    #      → Returns "2024-01-15 14:00:00" (variant date + variant time)
+    #
+    #   2. Event date used when variant has no date:
+    #      Variant: only time (14:00), Event: 2024-02-20, User: 2024-03-10
+    #      → Returns "2024-02-20 14:00:00" (event date + variant time)
+    #
+    #   3. User date used when no variant/event date:
+    #      Variant: only time (14:00), No event, User: 2024-03-10
+    #      → Returns "2024-03-10 14:00:00" (user date + variant time)
+    #
+    # Note: No need to fallback to event start date to avoid n+1.
+    # To get start_time duration of event, include event when needed instead.
+    def start_date_time(start_date: nil)
+      start_date = self.start_date if self.start_date.present?
+
       return nil if start_date.blank? && start_time.blank?
       return start_date if start_time.blank?
       return start_time if start_date.blank?
@@ -63,9 +81,29 @@ module SpreeCmCommissioner
       start_date.change(hour: start_time.hour, min: start_time.min, sec: start_time.sec)
     end
 
-    # No need to fallback to event end date to avoid n+1.
+    # Determines the end date/time with priority:
+    # - Date priority: variant date > event date > user input date
+    # - Time: always uses variant time (if configured) or calculated from duration
+    #
+    # Examples:
+    #   1. Explicit variant end_date:
+    #      Variant: end_date = 2024-01-20, end_time = 18:00, Event: 2024-02-25
+    #      → Returns "2024-01-20 18:00:00" (variant date + variant time)
+    #
+    #   2. Duration-based calculation (no explicit end_date):
+    #      Variant: start_date = 2024-01-15, start_time = 14:00, duration = 3 hours
+    #      → Returns "2024-01-15 17:00:00" (start + duration)
+    #
+    #   3. Event date when variant has no date but has time:
+    #      Variant: only end_time (18:00), Event: 2024-02-20
+    #      → Returns "2024-02-20 18:00:00" (event date + variant time)
+    #
+    # Note: No need to fallback to event end date to avoid n+1.
     # To get end_time duration of event, include event when needed instead.
-    def end_date_time
+    def end_date_time(start_date: nil, end_date: nil)
+      start_date = self.start_date if self.start_date.present?
+      end_date = self.end_date(start_date: start_date) if self.end_date(start_date: start_date).present?
+
       return nil if end_date.blank? && end_time.blank?
       return end_date if end_time.blank?
       return end_time if end_date.blank?
@@ -73,7 +111,9 @@ module SpreeCmCommissioner
       end_date.change(hour: end_time.hour, min: end_time.min, sec: end_time.sec)
     end
 
-    def end_date
+    def end_date(start_date: nil)
+      start_date = self.start_date if self.start_date.present?
+
       return start_date + options.total_duration_in_seconds.seconds if start_date.present? && options.total_duration_in_seconds.positive?
 
       options.end_date

data/app/models/spree_cm_commissioner/export.rb

@@ -21,8 +21,6 @@ module SpreeCmCommissioner
       self.uuid = SecureRandom.uuid
     end
 
-    def export_csv
-      SpreeCmCommissioner::ExportCsvJob.perform_later(export_id: id)
-    end
+    def export_csv; end
   end
 end

data/app/models/spree_cm_commissioner/guest.rb

@@ -62,7 +62,6 @@ module SpreeCmCommissioner
     before_validation :assign_seat_number_with_block, if: -> { will_save_change_to_block_id? }
 
     before_save :preload_eligible_check_in_session_ids, if: -> { new_record? }
-    before_create :generate_bib_if_needed, if: -> { line_item.reload && variant.bib_pre_generation_on_create? }
     after_create :preload_order_block_ids, if: -> { block_id.present? }
     after_update :preload_order_block_ids, if: :saved_change_to_block_id?
     before_destroy :cancel_reserved_block!, if: -> { reserved_block.present? }
@@ -248,26 +247,6 @@ module SpreeCmCommissioner
       line_item.variant.bib_display_prefix?
     end
 
-    def generate_bib_if_needed
-      return if bib_prefix.present?
-      return unless bib_required?
-      return if event_id.blank?
-
-      self.bib_prefix = line_item.variant.bib_prefix
-
-      last_bib_number = event.guests
-                             .where(bib_prefix: bib_prefix)
-                             .maximum(:bib_number) || 0
-
-      self.bib_number = last_bib_number + 1
-      self.bib_index = "#{event_id}-#{bib_prefix}-#{bib_number}"
-    end
-
-    def generate_bib!
-      generate_bib_if_needed
-      save!
-    end
-
     # bib_number: 345, bib_prefix: 5KM, bib_zerofill: 5 => return 5KM00345
     # bib_number: 345, bib_prefix: 5KM, bib_zerofill: 2 => return 5KM345
     def formatted_bib_number

data/app/models/spree_cm_commissioner/notification.rb

@@ -26,5 +26,33 @@ module SpreeCmCommissioner
 
     belongs_to :recipient, polymorphic: true
     belongs_to :notificable, polymorphic: true
+
+    after_create :increment_user_counters
+    after_update :decrement_user_counters, if: :saved_change_to_read_at?
+    after_destroy :decrement_user_counters
+
+    private
+
+    def increment_user_counters
+      return unless recipient.is_a?(Spree::User)
+
+      return unless unread?
+
+      SpreeCmCommissioner::UserCountersService.increment_unread_notifications_count(recipient)
+    end
+
+    def decrement_user_counters
+      return unless recipient.is_a?(Spree::User)
+
+      # On update: decrement only if transitioning from unread (nil) to read (present)
+      if saved_change_to_read_at
+        return unless saved_change_to_read_at[0].nil? && saved_change_to_read_at[1].present?
+      # On destroy: decrement only if currently unread
+      else
+        return unless read_at.nil?
+      end
+
+      SpreeCmCommissioner::UserCountersService.decrement_unread_notifications_count(recipient)
+    end
   end
 end

data/app/models/spree_cm_commissioner/taxon_decorator.rb

@@ -136,7 +136,7 @@ module SpreeCmCommissioner
     def sync_event_dates_to_line_items
       return unless event? && depth == 1
 
-      ::SpreeCmCommissioner::EventLineItemsDateSyncerJob.perform_later(event_id: id)
+      ::SpreeCmCommissioner::LineItems::SyncEventDateJob.perform_later(event_id: id)
     end
 
     private

data/app/models/spree_cm_commissioner/variant_options.rb

@@ -126,11 +126,6 @@ module SpreeCmCommissioner
       @bib_display_prefix == 1
     end
 
-    def bib_pre_generation_on_create?
-      @bib_pre_generation_on_create ||= option_value_name_for(option_type_name: 'bib-pre-generation-on-create')&.to_i || 0
-      @bib_pre_generation_on_create == 1
-    end
-
     def seat_number_positions
       @seat_number_positions ||= option_value_name_for(option_type_name: 'seat-number-positions')&.split(',')
     end

data/app/serializers/spree/v2/storefront/user_serializer_decorator.rb

@@ -6,7 +6,8 @@ module Spree
           base.attributes :first_name, :last_name, :gender, :phone_number, :intel_phone_number,
                           :country_code, :otp_enabled, :otp_email, :otp_phone_number,
                           :confirm_pin_code_enabled, :tenant_id, :has_incomplete_guest_info,
-                          :login, :qr_data, :qr_data_version, :qr_data_invalidated_at
+                          :login, :qr_data, :qr_data_version, :qr_data_invalidated_at,
+                          :unread_notifications_count, :request_orders_count
 
           base.has_one :profile, serializer: ::Spree::V2::Storefront::UserProfileSerializer
           base.has_many :device_tokens, serializer: Spree::V2::Storefront::UserDeviceTokenSerializer

data/app/serializers/spree_cm_commissioner/v2/storefront/homepage_data_serializer.rb

@@ -2,16 +2,10 @@ module SpreeCmCommissioner
   module V2
     module Storefront
       class HomepageDataSerializer < BaseSerializer
-        set_type :homepage_data
+        attributes :menu_id, :homepage_background_id
 
-        has_many :homepage_backgrounds, serializer: :homepage_background
-        has_many :homepage_banners, serializer: :homepage_banner
-        has_many :featured_vendors, serializer: ::Spree::V2::Storefront::AccommodationSerializer
-
-        # has_many :trending_categories, serializer: :category_taxon
-        # has_many :top_categories, serializer: :category_taxon
-        # has_many :display_products, serializer: :taxon_include_product
-        # has_many :featured_brands, serializer: :brand_taxon
+        has_one :menu, serializer: Spree::Api::Dependencies.storefront_menu_serializer.constantize
+        has_one :homepage_background, serializer: SpreeCmCommissioner::V2::Storefront::HomepageBackgroundSerializer
       end
     end
   end

data/app/services/spree_cm_commissioner/guests/finalize.rb

@@ -0,0 +1,76 @@
+module SpreeCmCommissioner
+  module Guests
+    class Finalize
+      prepend ::Spree::ServiceModule::Base
+
+      MAX_RETRY_ATTEMPTS = 5
+
+      def call(guest:, variant:, event: nil, user: nil) # rubocop:disable Metrics/MethodLength,Metrics/PerceivedComplexity
+        attempts = 0
+
+        begin
+          attempts += 1
+
+          guest.user = user if user.present?
+          assign_bib(guest: guest, event: event, variant: variant)
+          guest.save!
+
+          success(guest)
+        rescue ActiveRecord::RecordInvalid => e
+          # Handle Rails-level validation error
+          if e.record.errors[:bib_index].any? && attempts < MAX_RETRY_ATTEMPTS
+            # Reload guest to get fresh data and retry
+            if guest.persisted?
+              guest.reload
+            else
+              # Clear bib values for new records so they get recalculated on retry
+              guest.bib_prefix = nil
+              guest.bib_number = nil
+              guest.bib_index = nil
+            end
+            retry
+          else
+            # Return failure if not a bib_index error or exceeded max attempts
+            failure(nil, e.message)
+          end
+        rescue ActiveRecord::RecordNotUnique => e
+          # Handle database-level uniqueness constraint violation
+          # Return failure if not a bib_index error or exceeded max attempts
+          return failure(nil, e.message) unless e.message.include?('bib_index') && attempts < MAX_RETRY_ATTEMPTS
+
+          # Reload guest to get fresh data and retry
+          if guest.persisted?
+            guest.reload
+          else
+            # Clear bib values for new records so they get recalculated on retry
+            guest.bib_prefix = nil
+            guest.bib_number = nil
+            guest.bib_index = nil
+          end
+          retry
+        end
+      end
+
+      def assign_bib(guest:, event:, variant:)
+        bib_prefix = variant.bib_prefix
+
+        return false unless variant.bib_required?
+
+        return false if guest.bib_prefix.present?
+        return false if guest.event_id.blank?
+        return false if event.nil? || guest.event_id != event.id
+
+        guest.bib_prefix = bib_prefix
+
+        last_bib_number = event.guests
+                               .where(bib_prefix: bib_prefix)
+                               .maximum(:bib_number) || 0
+
+        guest.bib_number = last_bib_number + 1
+        guest.bib_index = "#{event.id}-#{bib_prefix}-#{guest.bib_number}"
+
+        true
+      end
+    end
+  end
+end

data/app/services/spree_cm_commissioner/homepage_data.rb

@@ -0,0 +1,23 @@
+module SpreeCmCommissioner
+  class HomepageData
+    attr_reader :menu, :homepage_background
+
+    # Plain Old Ruby Object (PORO) for homepage data
+    def initialize(menu:, homepage_background:)
+      @menu = menu
+      @homepage_background = homepage_background
+    end
+
+    def id
+      @id ||= SecureRandom.uuid
+    end
+
+    def menu_id
+      menu&.id
+    end
+
+    def homepage_background_id
+      homepage_background&.id
+    end
+  end
+end

data/app/services/spree_cm_commissioner/line_items/sync_event_date.rb

@@ -0,0 +1,22 @@
+module SpreeCmCommissioner
+  module LineItems
+    class SyncEventDate
+      prepend ::Spree::ServiceModule::Base
+
+      def call(event:)
+        return failure(:invalid_event_kind) unless event.event?
+        return failure(:invalid_event_depth) unless event.depth == 1
+
+        event.event_line_items.includes(:variant).find_each do |line_item|
+          line_item.send(:set_duration)
+
+          # Update could be failed here if case line item does not allowed to change or no longer available.
+          # We can ignore this line item in this case.
+          line_item.save if line_item.from_date_changed? || line_item.to_date_changed?
+        end
+
+        success(nil)
+      end
+    end
+  end
+end