spree_api 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a420ffcea7708290cc00ef92bc229128f71c52f5
-  data.tar.gz: c448f467f44145e7255784bc73e8596211fff73c
+  metadata.gz: 312dad95a36f976a119c7548cb87beb86b496e46
+  data.tar.gz: bf74b689033ee0464d019029fc9ef21c9d340c09
 SHA512:
-  metadata.gz: 9fa28a7494f1bf6b67f74d8ee1d514251a43a87d2156198dce6a980111b93f980c95fe5b0a8af0c0672ec4e72675b0939d7ead87c1333d83cc1667a6ba4abfc4
-  data.tar.gz: fdb0759f783dfca6da8c09161745220a5069265f8b6d02cd82a5d58fdbdcc73dc098f8c13920585bbb13c245e60a98ea9c4338b95afc95f6414461e66ce7d511
+  metadata.gz: 6c840d1ac0335d2980dbd7802af4a8afbf119f90b897a4a5c48f0f5f8862a96b646548fb1739e657ecceeab94ba5b83b1866195eafc542a1d3e9e413fe8ec890
+  data.tar.gz: 7399b407d17c2f90d763f6709ccbd97894dcf9961ad8c85bf5bef0765d4d3a4181f4ad2de172309727173c3e3ad090578c929cfa2f7ed1d8f588b34ebbfdb55d

data/app/helpers/spree/api/api_helpers.rb

@@ -85,7 +85,7 @@ module Spree
 
       @@payment_attributes = [
         :id, :source_type, :source_id, :amount, :display_amount,
-        :payment_method_id, :response_code, :state, :avs_response, :created_at,
+        :payment_method_id, :state, :avs_response, :created_at,
         :updated_at
       ]
 

data/spec/controllers/spree/api/payments_controller_spec.rb

@@ -6,7 +6,7 @@ module Spree
     let!(:order) { create(:order) }
     let!(:payment) { create(:payment, :order => order) }
     let!(:attributes) { [:id, :source_type, :source_id, :amount, :display_amount,
-                         :payment_method_id, :response_code, :state, :avs_response,
+                         :payment_method_id, :state, :avs_response,
                          :created_at, :updated_at] }
 
     let(:resource_scoping) { { :order_id => order.to_param } }
@@ -82,7 +82,7 @@ module Spree
       end
 
       context "multiple payments" do
-        before { @payment = create(:payment, :order => order, :response_code => '99999') }
+        before { @payment = create(:payment, :order => order) }
 
         it "can view all payments on an order" do
           api_get :index
@@ -95,12 +95,6 @@ module Spree
           expect(json_response['current_page']).to eq(1)
           expect(json_response['pages']).to eq(2)
         end
-
-        it 'can query the results through a paramter' do
-          api_get :index, :q => { :response_code_cont => '999' }
-          expect(json_response['count']).to eq(1)
-          expect(json_response['payments'].first['response_code']).to eq @payment.response_code
-        end
       end
 
       context "for a given payment" do

data/spec/requests/ransackable_attributes_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe "Ransackable Attributes" do
+  let(:user) { create(:user).tap(&:generate_spree_api_key!) }
+  let(:order) { create(:order_with_line_items, user: user) }
+  context "filtering by attributes one association away" do
+    it "does not allow the filtering of variants by order attributes" do
+      2.times { create(:variant) }
+
+      get "/api/variants?q[orders_email_start]=#{order.email}", token: user.spree_api_key
+
+      variants_response = JSON.parse(response.body)
+      expect(variants_response['total_count']).to eq(Spree::Variant.count)
+    end
+  end
+
+  context "filtering by attributes two associations away" do
+    it "does not allow the filtering of variants by user attributes" do
+      2.times { create(:variant) }
+
+      get "/api/variants?q[orders_user_email_start]=#{order.user.email}", token: user.spree_api_key
+
+      variants_response = JSON.parse(response.body)
+      expect(variants_response['total_count']).to eq(Spree::Variant.count)
+    end
+  end
+
+  context "it maintains desired association behavior" do
+    it "allows filtering of variants product name" do
+      product = create(:product, name: "Fritos")
+      variant = create(:variant, product: product)
+      other_variant = create(:variant)
+
+      get "/api/variants?q[product_name_or_sku_cont]=fritos", token: user.spree_api_key
+
+      skus = JSON.parse(response.body)['variants'].map { |variant| variant['sku'] }
+      expect(skus).to include variant.sku
+      expect(skus).not_to include other_variant.sku
+    end
+  end
+
+  context "filtering by attributes" do
+    it "most attributes are not filterable by default" do
+      product = create(:product, description: "special product")
+      other_product = create(:product)
+
+      get "/api/products?q[description_cont]=special", token: user.spree_api_key
+
+      products_response = JSON.parse(response.body)
+      expect(products_response['total_count']).to eq(Spree::Product.count)
+    end
+
+    it "id is filterable by default" do
+      product = create(:product)
+      other_product = create(:product)
+
+      get "/api/products?q[id_eq]=#{product.id}", token: user.spree_api_key
+
+      product_names = JSON.parse(response.body)['products'].map { |product| product['name'] }
+      expect(product_names).to include product.name
+      expect(product_names).not_to include other_product.name
+    end
+  end
+
+  context "filtering by whitelisted attributes" do
+    it "filtering is supported for whitelisted attributes" do
+      product = create(:product, name: "Fritos")
+      other_product = create(:product)
+
+      get "/api/products?q[name_cont]=fritos", token: user.spree_api_key
+
+      product_names = JSON.parse(response.body)['products'].map { |product| product['name'] }
+      expect(product_names).to include product.name
+      expect(product_names).not_to include other_product.name
+    end
+  end
+
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spree_api
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Ryan Bigg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-28 00:00:00.000000000 Z
+date: 2015-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spree_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.3
+        version: 3.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.3
+        version: 3.0.4
 - !ruby/object:Gem::Dependency
   name: rabl
   requirement: !ruby/object:Gem::Requirement
@@ -239,6 +239,7 @@ files:
 - spec/fixtures/thinking-cat.jpg
 - spec/models/spree/legacy_user_spec.rb
 - spec/requests/rabl_cache_spec.rb
+- spec/requests/ransackable_attributes_spec.rb
 - spec/shared_examples/protect_product_actions.rb
 - spec/spec_helper.rb
 - spec/support/controller_hacks.rb
@@ -304,6 +305,7 @@ test_files:
 - spec/fixtures/thinking-cat.jpg
 - spec/models/spree/legacy_user_spec.rb
 - spec/requests/rabl_cache_spec.rb
+- spec/requests/ransackable_attributes_spec.rb
 - spec/shared_examples/protect_product_actions.rb
 - spec/spec_helper.rb
 - spec/support/controller_hacks.rb