spree-kashflow 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2346845707634b7353b64e8d2a982136ead6009e47f7b1ea5b94d1e905b5455
-  data.tar.gz: 2a238745c13d9cd5a6cf0fde8e2854b2a7bc9c12c3ad35df25e396ea0d8a7159
+  metadata.gz: d20212552f51bc299bb20645fc8f5dbca833b2bdb63a1678d752b29a15f00a17
+  data.tar.gz: fb65959bc02ff1ac1b1eb7b38257ca03b9fba95386efb49b40baf91378b7c0bb
 SHA512:
-  metadata.gz: ff74935654982f15a9094b50b36a26d1507705b33955444df4d9490c7511d51008c6c01cd92c42ff036475f5eb7d5ad475e820aa3ddee699fe9c35d895681956
-  data.tar.gz: ecca24ec4c22aef839778a214b0a62e206588836810cb012ac762151e08ef9aed538a5e0c5b8c5a8c90ca21151658003b644691437ac19e4a8244d68a8b46438
+  metadata.gz: a257c8a10a8576b39a5b58613568cc1faf751f3fa28caa505df9d190404be40d12e0e52272a48c3f2f141cc7e2b0c540b59bf32bb2501d7c2dd60b01b31ecf9b
+  data.tar.gz: 19f304c825178155659864ba3b064507ade831b27632d385befd8d27a60f84ccd74471b0eef8ce94cea0f1bd1391ce900fc034af404377e578d87e292527a276

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## 0.1.2
+
+- **Fix: every order sync still failed against a live KashFlow account**, now on
+  the invoice rather than the customer. KashFlow types every date field in the
+  WSDL as `s:dateTime`, and its .NET `XmlSerializer` rejected the whole envelope
+  with `The string '2026-08-18 10:53:48 UTC' is not a valid AllXsd value` —
+  no invoice created, and the fault naming only a character offset. Gyoku
+  type-switches with `Module#===`, so `ActiveSupport::TimeWithZone` (a
+  delegator, not a `Time` subclass) fell through to `to_s`; plain `Time` did
+  too, and `Date` emitted an xsd `date` rather than a `dateTime`. Since
+  `Time.current` and Active Record datetime attributes all return
+  `TimeWithZone`, this was the default path, affecting `InvoiceDate`, `DueDate`
+  and `PayDate` on orders and `InvoiceDate` / `DueDate` on refunds.
+  `Client#call` now normalises every temporal value in an outgoing message to
+  UTC xsd `dateTime`, so the wire format is owned by the one class that touches
+  the wire and any date field added later is correct by default.
+- Assert the *serialised* SOAP body for temporal values. The suite doubled the
+  client and asserted the payload Hash, where a `TimeWithZone` looks correct
+  right up until it reaches the wire — which is why 0.1.1 shipped with this
+  defect behind a green build.
+
 ## 0.1.1
 
 - **Fix: every order sync failed against a live KashFlow account.** The customer

data/lib/spree/kashflow/client.rb

@@ -182,7 +182,8 @@ module Spree
       #
       def call(operation, message = {})
         credentials = {"UserName" => @username, "Password" => @password}
-        response = savon_client.call(operation, message: credentials.merge(message))
+        body = coerce_temporal(credentials.merge(message))
+        response = savon_client.call(operation, message: body)
         body = response.body
         assert_status!(body)
         body
@@ -195,6 +196,48 @@ module Spree
         raise TransportError, e.message
       end
 
+      ##
+      # Rewrites every temporal value in an outgoing message to xsd `dateTime`.
+      #
+      # KashFlow types every date field in the WSDL as `s:dateTime`, and its
+      # .NET `XmlSerializer` rejects the *entire* envelope with a
+      # `FormatException` ("is not a valid AllXsd value") when one of them is
+      # not valid xsd — the invoice is never created, and the fault names only
+      # a character offset, not the field.
+      #
+      # Gyoku cannot be relied on to do this. It type-switches with
+      # `case/when`, i.e. `Module#===`, so:
+      # - `ActiveSupport::TimeWithZone` is a *delegator*, not a `Time`
+      #   subclass, and misses the branch entirely -> `to_s`
+      #   ("2026-08-18 10:53:48 UTC").
+      # - plain `Time` is likewise emitted via `to_s` by Gyoku 1.4.
+      # - `Date` serialises as `2026-08-18`, an xsd `date`, not the `dateTime`
+      #   the schema asks for.
+      #
+      # `Time.current` and every Active Record datetime attribute return
+      # `TimeWithZone`, so the broken path was the default one, which is why
+      # every caller was affected. Normalising here rather than at each call
+      # site keeps the wire format owned by the one class that touches the
+      # wire, and means a date field added to any future payload is correct
+      # without the author having to know this.
+      #
+      # Values are converted to UTC first so the instant is preserved and the
+      # emitted form is unambiguous (`...Z`) regardless of the app's zone.
+      #
+      # @param value [Object] any message value; Hashes and Arrays are walked
+      # @return [Object] the value with temporals replaced by xsd strings
+      #
+      def coerce_temporal(value)
+        case value
+        when Hash then value.transform_values { |element| coerce_temporal(element) }
+        when Array then value.map { |element| coerce_temporal(element) }
+        when ActiveSupport::TimeWithZone, Time then value.utc.xmlschema
+        when DateTime then value.to_time.utc.xmlschema
+        when Date then value.to_time(:utc).xmlschema
+        else value
+        end
+      end
+
       ##
       # KashFlow reports business-level rejections *in band*: the SOAP call
       # succeeds at HTTP 200 with an empty result element and a `Status` /

data/lib/spree/kashflow/version.rb

@@ -2,6 +2,6 @@
 
 module Spree
   module Kashflow
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spree-kashflow
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Aypex