sports_data_api 0.15.1 → 0.15.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 07f6aa2548068b6f74a06b0bda9eb6fffd2e422b0d3a5295c7eba744207a4788
-  data.tar.gz: b9cc63e395efdf1a7ad01090341731640bffdeac47c832a4ec3a45dbbc4e9ce2
+  metadata.gz: 90a618d57290eff4689456381867315bce98c10c38800ab90b501834ba2e96a0
+  data.tar.gz: d30d9f0126b1986744d5593097c262c2bbc3a11a3cfc9b3f250699872329345b
 SHA512:
-  metadata.gz: f482f859858ad07ca7787ffcd7fb3804ea42a6f541810ae4e747c0005516a6f991fd667d886a1a1b7da9f8babf89b223da8d36b6482ebf1f7ae3cd0cd3e58409
-  data.tar.gz: 3a71cb9e7fd68ad00eab45db25df95d9f1c04a78d0dfbaefcccd2255354d5256b22c293eb64a0dd36653f42a7b843eafa33d1c70bbe660c90a74e5de56379c99
+  metadata.gz: 963da55d3d2a1fb7133f1cd10e85efc087dadf5dfee5fc2362800b58c3be7d7186f28948fc2277ffff741fa17f1bf8f78470ff380117f229c4150ef92cbd27a8
+  data.tar.gz: 614bf62757c001d026fae6c892cf2470f71b56f7c763d27ff22f2d426ecfcd6a950c9d507bfd3fd6e4773f2044ebd1c0beeb61d62b8e03c689d63c0fca335517

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## v0.15.2
+* [#94](https://github.com/RLovelett/sports_data_api/pull/94) [FIX] Safe map of json responses
+
 ## v0.15.1
 * [#92](https://github.com/RLovelett/sports_data_api/pull/92) [FIX] NFL extra points stats
 * [#93](https://github.com/RLovelett/sports_data_api/pull/93) [Feature] Stats have #fetch like hash

data/lib/sports_data_api/golf/course.rb

@@ -12,7 +12,7 @@ module SportsDataApi
       end
 
       def pairings
-        @pairings ||= data['pairings'].map do |json|
+        @pairings ||= data.fetch('pairings', []).map do |json|
           Pairing.new(json)
         end
       end

data/lib/sports_data_api/golf/pairing.rb

@@ -10,7 +10,7 @@ module SportsDataApi
       end
 
       def players
-        @players ||= data['players'].map do |json|
+        @players ||= data.fetch('players', []).map do |json|
           Player.new(json)
         end
       end

data/lib/sports_data_api/golf/season.rb

@@ -8,7 +8,7 @@ module SportsDataApi
       def initialize(season_hash)
         @year = season_hash['season']['year']
         @tour = season_hash['tour']['alias'].downcase.to_sym
-        @tournaments = season_hash['tournaments'].map do |tournament_hash|
+        @tournaments = season_hash.fetch('tournaments', []).map do |tournament_hash|
           Tournament.new(tour, year, tournament_hash)
         end
       end

data/lib/sports_data_api/golf.rb

@@ -38,7 +38,7 @@ module SportsDataApi
       def players(tour, year)
         response = response_json UrlPaths::PLAYERS % { tour: tour, year: year }
 
-        response['players'].map do |json|
+        response.fetch('players', []).map do |json|
           Player.new(json)
         end
       end
@@ -57,7 +57,7 @@ module SportsDataApi
           { tour: tour, year: year, tournament_id: tournament_id, round: round }
 
 
-        response['round']['courses'].map do |json|
+        (response.dig('round', 'courses') || []).map do |json|
           Course.new(json)
         end
       end
@@ -73,7 +73,7 @@ module SportsDataApi
           status: response['round']['status'],
           year: year,
           tour: tour,
-          players: response['round']['players'].map do |json|
+          players: (response.dig('round', 'players') || []).map do |json|
             Player.new(json)
           end
         }
@@ -84,7 +84,7 @@ module SportsDataApi
         response = response_json UrlPaths::LEADERBOARDS %
           { tour: tour, year: year, tournament_id: tournament_id }
 
-        response['leaderboard'].map do |json|
+        response.fetch('leaderboard', []).map do |json|
           Player.new(json)
         end
       end

data/lib/sports_data_api/mlb/division.rb

@@ -2,7 +2,7 @@ module SportsDataApi
   module Mlb
     class Division < JsonData
       def teams
-        @teams ||= division[:teams].map do |data|
+        @teams ||= division.fetch(:teams, []).map do |data|
           Team.new(data).tap do |t|
             t.team[:division] = division[:name]
             t.team[:division_alias] = division[:alias]

data/lib/sports_data_api/mlb/league.rb

@@ -2,7 +2,7 @@ module SportsDataApi
   module Mlb
     class League < JsonData
       def divisions
-        @divisions ||= league[:divisions].map do |data|
+        @divisions ||= league.fetch(:divisions, []).map do |data|
           Division.new(data)
         end
       end

data/lib/sports_data_api/nba/games.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def games
-        @games ||= json['games'].map do |game_json|
+        @games ||= json.fetch('games', []).map do |game_json|
           Game.new(json: game_json)
         end
       end

data/lib/sports_data_api/nba/season.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def games
-        @games ||= json['games'].map do |game_json|
+        @games ||= json.fetch('games', []).map do |game_json|
           Game.new(year: year, season: type, json: game_json)
         end
       end

data/lib/sports_data_api/nba/teams.rb

@@ -8,7 +8,7 @@ module SportsDataApi
       end
 
       def teams
-        @teams ||= json['conferences'].flat_map do |conference|
+        @teams ||= json.fetch('conferences', []).flat_map do |conference|
           conference['divisions'].flat_map do |division|
             division['teams'].map do |json|
               Team.new(json, conference['alias'], division['alias'])

data/lib/sports_data_api/nfl/season.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def weeks
-        @weeks ||= json['weeks'].map do |week|
+        @weeks ||= json.fetch('weeks', []).map do |week|
           Week.new(week, year, type)
         end
       end

data/lib/sports_data_api/nfl/teams.rb

@@ -13,7 +13,7 @@ module SportsDataApi
       end
 
       def teams
-        @teams ||= json['conferences'].flat_map do |conference_json|
+        @teams ||= json.fetch('conferences', []).flat_map do |conference_json|
           conference = conference_json['name']
           conference_json['divisions'].flat_map do |division_json|
             division = division_json['name']

data/lib/sports_data_api/nfl/week.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def games
-        @games ||= json['games'].map do |game|
+        @games ||= json.fetch('games', []).map do |game|
           Game.new(game, year: year, season: season, week: number)
         end
       end

data/lib/sports_data_api/nhl/games.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def games
-        @games ||= json['games'].map do |game_json|
+        @games ||= json.fetch('games', []).map do |game_json|
           Game.new(json: game_json)
         end
       end

data/lib/sports_data_api/nhl/season.rb

@@ -11,7 +11,7 @@ module SportsDataApi
       end
 
       def games
-        @games ||= json['games'].map do |game_json|
+        @games ||= json.fetch('games', []).map do |game_json|
           Game.new(year: year, season: type, json: game_json)
         end
       end

data/lib/sports_data_api/nhl/teams.rb

@@ -8,7 +8,7 @@ module SportsDataApi
       end
 
       def teams
-        @teams ||= json['conferences'].flat_map do |conference|
+        @teams ||= json.fetch('conferences', []).flat_map do |conference|
           conference['divisions'].flat_map do |division|
             division['teams'].map do |team_json|
               Team.new(team_json, conference['alias'], division['alias'])

data/lib/sports_data_api/version.rb

@@ -1,3 +1,3 @@
 module SportsDataApi
-  VERSION = '0.15.1'
+  VERSION = '0.15.2'
 end

data/spec/cassettes/sports_data_api_nhl_season.yml

@@ -1,5 +1,76 @@
 ---
 http_interactions:
+- request:
+    method: get
+    uri: https://api.sportradar.us/nhl/trial/v5/en/games/2018/PST/schedule.json?api_key=<API_KEY>
+    body:
+      encoding: US-ASCII
+      base64_string: ''
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.5.1p57
+      Host:
+      - api.sportradar.us
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Accept-Ranges:
+      - bytes
+      Age:
+      - '0'
+      Cache-Control:
+      - public, must-revalidate, max-age=11
+      Content-Language:
+      - en
+      Content-Type:
+      - application/json;charset=utf-8
+      Date:
+      - Fri, 21 Sep 2018 16:30:19 GMT
+      Expires:
+      - Fri, 21 Sep 2018 16:30:30 GMT
+      Server:
+      - nginx
+      Via:
+      - 1.1 varnish-v4
+      - 1.1 varnish-v4
+      X-Be-Cache:
+      - MISS
+      X-Fe-Cache:
+      - MISS
+      X-Mashery-Responder:
+      - prod-j-worker-us-east-1b-50.mashery.com
+      X-Plan-Qps-Allotted:
+      - '25'
+      X-Plan-Qps-Current:
+      - '1'
+      X-Plan-Quota-Allotted:
+      - '15000'
+      X-Plan-Quota-Current:
+      - '4'
+      X-Varnish:
+      - '11247620'
+      - '25454331'
+      X-Via:
+      - Translation-Proxy
+      Content-Length:
+      - '163'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      base64_string: |
+        eyJsZWFndWUiOnsiaWQiOiJmZDU2MDEwNy1hODViLTQzODgtYWIwZC02NTVh
+        ZDAyMmFmZjciLCJuYW1lIjoiTkhMIiwiYWxpYXMiOiJOSEwifSwic2Vhc29u
+        Ijp7ImlkIjoiNDU1MmM0OWUtMzBlNi00YmNiLThhM2MtYTllM2I3OTUwOWQy
+        IiwieWVhciI6MjAxOCwidHlwZSI6IlBTVCJ9fQ==
+    http_version:
+  recorded_at: Fri, 21 Sep 2018 16:30:19 GMT
 - request:
     method: get
     uri: https://api.sportradar.us/nhl/trial/v5/en/games/2013/REG/schedule.json?api_key=<API_KEY>
@@ -12,7 +83,7 @@ http_interactions:
       Accept-Encoding:
       - gzip, deflate
       User-Agent:
-      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.3.3p222
+      - rest-client/2.0.2 (darwin16.7.0 x86_64) ruby/2.5.1p57
       Host:
       - api.sportradar.us
   response:
@@ -31,9 +102,9 @@ http_interactions:
       Content-Type:
       - application/json;charset=utf-8
       Date:
-      - Thu, 31 May 2018 20:58:18 GMT
+      - Fri, 21 Sep 2018 16:30:24 GMT
       Expires:
-      - Thu, 31 May 2018 20:58:29 GMT
+      - Fri, 21 Sep 2018 16:30:35 GMT
       Server:
       - nginx
       Via:
@@ -44,7 +115,7 @@ http_interactions:
       X-Fe-Cache:
       - MISS
       X-Mashery-Responder:
-      - prod-j-worker-us-east-1e-65.mashery.com
+      - prod-j-worker-us-east-1d-58.mashery.com
       X-Plan-Qps-Allotted:
       - '25'
       X-Plan-Qps-Current:
@@ -52,10 +123,10 @@ http_interactions:
       X-Plan-Quota-Allotted:
       - '15000'
       X-Plan-Quota-Current:
-      - '29'
+      - '5'
       X-Varnish:
-      - '1019646'
-      - '1195953'
+      - '24303725'
+      - '9523988'
       X-Via:
       - Translation-Proxy
       Content-Length:
@@ -15712,5 +15783,5 @@ http_interactions:
         MThhOTA1NzY3ZTQ0IiwibmFtZSI6IkRhbGxhcyBTdGFycyIsImFsaWFzIjoi
         REFMIn19XX0=
     http_version: 
-  recorded_at: Thu, 31 May 2018 20:58:19 GMT
+  recorded_at: Fri, 21 Sep 2018 16:30:25 GMT
 recorded_with: VCR 3.0.3

data/spec/lib/sports_data_api/nhl/season_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 describe SportsDataApi::Nhl::Season, vcr: {
-    cassette_name: 'sports_data_api_nhl_season',
-    record: :new_episodes,
-    match_requests_on: [:host, :path]
+  cassette_name: 'sports_data_api_nhl_season',
+  record: :new_episodes,
+  match_requests_on: [:host, :path]
 } do
   subject { SportsDataApi::Nhl::Season }
+
   describe '.season?' do
     context :PRE do
       it { SportsDataApi::Nhl::Season.valid?(:PRE).should eq(true) }
@@ -26,16 +27,30 @@ describe SportsDataApi::Nhl::Season, vcr: {
       it { subject.valid?(:pst).should eq(false) }
     end
   end
+
   context 'results from schedule fetch' do
-      let(:season) do
-        SportsDataApi.set_access_level(:nhl, 'trial')
-        SportsDataApi.set_key(:nhl, api_key(:nhl))
-        SportsDataApi::Nhl.schedule(2013, :reg)
-      end
-      subject { season }
-      it { should be_an_instance_of(SportsDataApi::Nhl::Season) }
-      its(:year) { should eq 2013 }
-      its(:type) { should eq :REG }
-      its(:games) { should have(1233).games }
+    let(:season) do
+      SportsDataApi.set_access_level(:nhl, 'trial')
+      SportsDataApi.set_key(:nhl, api_key(:nhl))
+      SportsDataApi::Nhl.schedule(2013, :reg)
+    end
+    subject { season }
+    it { should be_an_instance_of(SportsDataApi::Nhl::Season) }
+    its(:year) { should eq 2013 }
+    its(:type) { should eq :REG }
+    its(:games) { should have(1233).games }
+  end
+
+  context 'when season has no games' do
+    let(:season) do
+      SportsDataApi.set_access_level(:nhl, 'trial')
+      SportsDataApi.set_key(:nhl, api_key(:nhl))
+      SportsDataApi::Nhl.schedule(2018, :PST)
+    end
+    subject { season }
+    it { should be_an_instance_of(SportsDataApi::Nhl::Season) }
+    its(:year) { should eq 2018 }
+    its(:type) { should eq :PST }
+    its(:games) { should have(0).games }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sports_data_api
 version: !ruby/object:Gem::Version
-  version: 0.15.1
+  version: 0.15.2
 platform: ruby
 authors:
 - Ryan Lovelett
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-29 00:00:00.000000000 Z
+date: 2018-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri