spoom 1.7.11 → 1.7.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcd8a922c433ab7b03fd7d6a419205e983467d5437eed8a078e57835f2168eec
-  data.tar.gz: 2a74d166079aa6c1f7a2f95dca5de050f6d40b4a49eb43e2eaa7059df1275e7a
+  metadata.gz: e5cf816e6ecd86209b75a94d71474288762d94b97da6e6637f2b67bb80c5fcf0
+  data.tar.gz: fafeb36ec7993a9632dfa0e7c1b47b7e671122e2e0a89358b1c1ab86dd611aca
 SHA512:
-  metadata.gz: b735c17851bebe3875bc1023e799060146de1965b5d3dca786e2868b68d5d27ff0e0e13324c2c6762581eb176d036b078d7168378e0f7b1637e69084e5e9a2ab
-  data.tar.gz: 9e4730cd210bdef36bed6f610e7b56815fd7d6cad3bf791c8b628f2c5db08e29111e9e7d6a414af8af3612d739d8431ea7461b1205fff6d339f05b4116cc3560
+  metadata.gz: a28c07c9f9ddbd22a754d6f4619696d6a82caa6f8b355dd99fc90b27c42c14b8bbb4377e433ad593b7133fffe8397fa929c75e9d309dd9499a7aa105b2126fcb
+  data.tar.gz: a098d8d9fba5cef4988d5e3e5fdc01493beec8c3ddd3a75e1b78353570872d447ab82f47a83d2cc3192b6f3699a7409f45b848e29d373eee03d273647e0afacf

data/Gemfile

@@ -6,6 +6,7 @@ source "https://rubygems.org"
 gemspec
 
 gem "minitest"
+gem "minitest-mock"
 
 group :development do
   gem "debug"

data/README.md

@@ -377,6 +377,24 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`.
 
+## Releasing
+
+### Bump the gem version
+
+- [ ] Locally, update the version number in [`version.rb`](https://github.com/Shopify/spoom/blob/main/lib/spoom/version.rb)
+- [ ] Run `bundle install` to update the version number in `Gemfile.lock`
+- [ ] Commit this change with the message `Bump version to vx.y.z`
+- [ ] Push this change directly to main or open a PR
+
+### Create a new tag
+
+- [ ] Locally, create a new tag with the new version number: `git tag vx.y.z`
+- [ ] Push this tag up to the remote `git push origin vx.y.z`
+
+### Release workflow will run automatically
+
+We have a [release workflow](https://github.com/Shopify/spoom/actions/workflows/release.yml) that will publish your new gem version to rubygems.org via [Trusted Publishing](https://guides.rubygems.org/trusted-publishing/). This workflow must be approved by a member of the Ruby and Rails Infrastructure team at Shopify before it will run. Once it is approved, it will automatically publish a new gem version to rubygems.org and create a new GitHub release.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/Shopify/spoom. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/spoom/bundler_helper.rb

@@ -3,8 +3,6 @@
 
 module Spoom
   module BundlerHelper
-    extend T::Sig
-
     class << self
       # Generate a gem requirement for the given gem name, using that gem's version in the "real" current bundle.
       #

data/lib/spoom/cli/srb/metrics.rb

@@ -59,7 +59,7 @@ module Spoom
             .select { |key, _value| key.start_with?("rbs_") }
             .sort_by { |_key, value| -value }
             .each do |key, value|
-            say(" * #{key}: `#{value}`")
+              say(" * #{key}: `#{value}`")
           end
         end
       end

data/lib/spoom/file_tree.rb

@@ -4,14 +4,14 @@
 module Spoom
   # Build a file hierarchy from a set of file paths.
   class FileTree
-    #: (?T::Enumerable[String] paths) -> void
+    #: (?Enumerable[String] paths) -> void
     def initialize(paths = [])
       @roots = {} #: Hash[String, Node]
       add_paths(paths)
     end
 
     # Add all `paths` to the tree
-    #: (T::Enumerable[String] paths) -> void
+    #: (Enumerable[String] paths) -> void
     def add_paths(paths)
       paths.each { |path| add_path(path) }
     end

data/lib/spoom/sorbet/translate/rbs_comments_to_sorbet_sigs.rb

@@ -139,6 +139,12 @@ module Spoom
 
             apply_member_annotations(comments.method_annotations, sig)
 
+            # Sorbet runtime doesn't support `sig` on `method_added` or
+            # `singleton_method_added`, so we always use `without_runtime` for them.
+            if def_node.name == :method_added || def_node.name == :singleton_method_added
+              sig.without_runtime = true
+            end
+
             @rewriter << Source::Replace.new(
               signature.location.start_offset,
               signature.location.end_offset,
@@ -202,6 +208,9 @@ module Spoom
           signatures = comments.signatures
           if signatures.any?
             signatures.each do |signature|
+              # Only type param signatures (e.g. `#: [A, B]`) are valid on class/module nodes
+              next unless signature.string.start_with?("[")
+
               type_params = ::RBS::Parser.parse_type_params(signature.string)
               next if type_params.empty?
 

data/lib/spoom/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Spoom
-  VERSION = "1.7.11"
+  VERSION = "1.7.12"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spoom
 version: !ruby/object:Gem::Version
-  version: 1.7.11
+  version: 1.7.12
 platform: ruby
 authors:
 - Alexandre Terrasa
@@ -99,14 +99,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0.dev.4
+        version: 4.0.0.dev.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.0.dev.4
+        version: 4.0.0.dev.5
 - !ruby/object:Gem::Dependency
   name: rexml
   requirement: !ruby/object:Gem::Requirement
@@ -275,7 +275,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Useful tools for Sorbet enthusiasts.
 test_files: []