splitclient-rb 7.3.5.pre.rc1 → 7.3.5.pre.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69cfd920b90d9a1c7a22b9bdc708ee7ef2a911fc600e82070b9671ce918fe51c
-  data.tar.gz: 994523b6dbd861c5c7f8027c23272b65348ba8c7cd97e06b84e01ccdd3992aee
+  metadata.gz: 0f3db9ed40e5c2bf07caa781888d680307e649eca41fc2e5321aefb2373072d4
+  data.tar.gz: 421b1630311542b729069a73a29646a5c1162b89a902d070fcf88434c051b7b2
 SHA512:
-  metadata.gz: 704a28f628cb20b3f768435dcc400a240c75345de995e5633724aaff817778093f27a51a56d14e890a1306beedcd525035ac6d82f1c47730ba064504c75d4697
-  data.tar.gz: 8d26256da8265defea4214edbba7ebdf155f7da8ca1bfb69a40bc89e30b73175a50fdc40f4233fdfc81ee70ec4799fe0de8e4e644f71b2efb0d62aff9570eaa5
+  metadata.gz: 378c6248fa6e047ef94f1afa80e6a3f5a725ccb9588c8af11061a75e575d7441168a13672749e9e03ac38571ccd4578e4a821dee888b72403e923d1bfa5151c5
+  data.tar.gz: 1bb4d9b98cd783dd65b550811bee706e1b125153acd926d74bb5ae2ca3c8069eca8f9e3f212405f08ca0c3aa3613cf3d04afee4ac250f86c8713cceb00ad21a7

data/lib/splitclient-rb/cache/filter/bloom_filter.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'bitarray'
+
+module SplitIoClient
+  module Cache
+    module Filter
+      class BloomFilter
+        def initialize(capacity, false_positive_probability = 0.001)
+          @capacity = capacity.round
+          m = best_m(capacity, false_positive_probability)
+          @ba = BitArray.new(m.round)
+          @k = best_k(capacity)
+        end
+
+        def add(string)
+          return false if contains?(string)
+
+          positions = hashes(string)
+          
+          positions.each { |position| @ba[position] = 1 }
+
+          true
+        end
+      
+        def contains?(string)
+          !hashes(string).any? { |ea| @ba[ea] == 0 }
+        end
+
+        def clear
+          @ba.size.times { |i| @ba[i] = 0 }
+        end
+      
+        private
+
+        # m is the required number of bits in the array
+        def best_m(capacity, false_positive_probability)
+          -(capacity * Math.log(false_positive_probability)) / (Math.log(2) ** 2)
+        end
+
+        # k is the number of hash functions that minimizes the probability of false positives
+        def best_k(capacity)
+          (Math.log(2) * (@ba.size / capacity)).round
+        end
+
+        def hashes(data)
+          m = @ba.size
+          h = Digest::MD5.hexdigest(data.to_s).to_i(16)
+          x = h % m
+          h /= m
+          y = h % m
+          h /= m
+          z = h % m
+          [x] + 1.upto(@k - 1).collect do |i|
+            x = (x + y) % m
+            y = (y + z) % m
+            x
+          end
+        end
+      end
+    end
+  end
+end

data/lib/splitclient-rb/cache/filter/filter_adapter.rb

@@ -10,13 +10,13 @@ module SplitIoClient
         end
 
         def add(feature_name, key)
-          @filter.insert("#{feature_name}#{key}")
+          @filter.add("#{feature_name}#{key}")
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end
 
         def contains?(feature_name, key)
-          @filter.include?("#{feature_name}#{key}")
+          @filter.contains?("#{feature_name}#{key}")
         rescue StandardError => e
           @config.log_found_exception(__method__.to_s, e)
         end

data/lib/splitclient-rb/split_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'bloomfilter-rb'
-
 module SplitIoClient
   class SplitFactory
     ROOT_PROCESS_ID = Process.pid
@@ -218,7 +216,7 @@ module SplitIoClient
         return
       end
 
-      bf = BloomFilter::Native.new(size: 95_850_584, hashes: 2)
+      bf = Cache::Filter::BloomFilter.new(30_000_000)
       filter_adapter = Cache::Filter::FilterAdapter.new(@config, bf)
       cache = Concurrent::Hash.new
       @unique_keys_tracker = Engine::Impressions::UniqueKeysTracker.new(@config, filter_adapter, @impressions_sender_adapter, cache)

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.3.5.pre.rc1'
+  VERSION = '7.3.5.pre.rc2'
 end

data/lib/splitclient-rb.rb

@@ -12,6 +12,7 @@ require 'splitclient-rb/cache/adapters/memory_adapter'
 require 'splitclient-rb/cache/adapters/redis_adapter'
 require 'splitclient-rb/cache/fetchers/segment_fetcher'
 require 'splitclient-rb/cache/fetchers/split_fetcher'
+require 'splitclient-rb/cache/filter/bloom_filter'
 require 'splitclient-rb/cache/filter/filter_adapter'
 require 'splitclient-rb/cache/hashers/impression_hasher'
 require 'splitclient-rb/cache/observers/impression_observer'

data/splitclient-rb.gemspec

@@ -50,7 +50,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'timecop', '~> 0.9'
   spec.add_development_dependency 'webmock', '~> 3.14'
 
-  spec.add_runtime_dependency 'bloomfilter-rb', '~> 2.1'
+  spec.add_runtime_dependency 'bitarray', '~> 1.3'
   spec.add_runtime_dependency 'concurrent-ruby', '~> 1.0'
   spec.add_runtime_dependency 'faraday', '>= 0.8', '< 2.0'
   spec.add_runtime_dependency 'json', '>= 1.8', '< 3.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.3.5.pre.rc1
+  version: 7.3.5.pre.rc2
 platform: ruby
 authors:
 - Split Software
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-06 00:00:00.000000000 Z
+date: 2022-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -193,19 +193,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.14'
 - !ruby/object:Gem::Dependency
-  name: bloomfilter-rb
+  name: bitarray
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -407,6 +407,7 @@ files:
 - lib/splitclient-rb/cache/adapters/redis_adapter.rb
 - lib/splitclient-rb/cache/fetchers/segment_fetcher.rb
 - lib/splitclient-rb/cache/fetchers/split_fetcher.rb
+- lib/splitclient-rb/cache/filter/bloom_filter.rb
 - lib/splitclient-rb/cache/filter/filter_adapter.rb
 - lib/splitclient-rb/cache/hashers/impression_hasher.rb
 - lib/splitclient-rb/cache/observers/impression_observer.rb