splitclient-rb 7.1.0.pre.rc3 → 7.1.0.pre.rc4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 969980f2b594c4924eb9ac7660d91fe601ea15bd6f06975556fb7ab41862722b
-  data.tar.gz: '008b1afecc13e5adef0929712d931a56e69107635f6ae2bf737ceeeb25b1860d'
+  metadata.gz: 69fe751aec852ee524d59e0bddc36cb39454d7633a950590e15eb277fb113aa1
+  data.tar.gz: 9c5bbaaa6667ff765de75cdf898512b345b109a48a59d5bff95217e51291ad57
 SHA512:
-  metadata.gz: 9e0addd5efe17db22cf52f91088e157df273541adb7e8974848e4be53ab75f77272920d2edd22ca3806598bcc5cd10f90552797df54c04cdd12315338b8b1a1e
-  data.tar.gz: 17c975d2055ed67a12f3da075d0862e72ca6b02526c5d6d1efe57df43de01d0632b30983da029dd28edd7a79903722eaa166a72d98f0bb3c4018b36dfcf151cb
+  metadata.gz: 9d7778f0ee964578d877cb48b58b7f3f42153a68c9cb5a69b816cc78d5e9bf16059486819b157e667c5c58d31d6c7008cd1fe230f003c4e8945de468ada16fc8
+  data.tar.gz: d0aac080888d6364af6dc4672e7911095afbe30e9bbed43fd17ec6c7f6d0b76c64a4f5548701e3dc8b50732e7b70584760f7fd132b8d91e2def8ac0d7eb70862

data/.rubocop.yml

@@ -14,6 +14,7 @@ Metrics/LineLength:
   Max: 130
   Exclude:
     - spec/sse/**/*
+    - spec/integrations/**/*
 
 Metrics/BlockLength:
   Exclude:

data/lib/splitclient-rb/cache/fetchers/segment_fetcher.rb

@@ -10,6 +10,7 @@ module SplitIoClient
           @metrics = metrics
           @config = config
           @sdk_blocker = sdk_blocker
+          @semaphore = Mutex.new
         end
 
         def call
@@ -27,15 +28,17 @@ module SplitIoClient
         end
 
         def fetch_segment(name)
-          segments_api.fetch_segments_by_names([name])
+          @semaphore.synchronize { segments_api.fetch_segments_by_names([name]) }
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end
 
         def fetch_segments
-          segments_api.fetch_segments_by_names(@segments_repository.used_segment_names)
+          @semaphore.synchronize do
+            segments_api.fetch_segments_by_names(@segments_repository.used_segment_names)
 
-          @sdk_blocker.segments_ready!
+            @sdk_blocker.segments_ready!
+          end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end

data/lib/splitclient-rb/cache/fetchers/split_fetcher.rb

@@ -10,6 +10,7 @@ module SplitIoClient
           @metrics = metrics
           @config = config
           @sdk_blocker = sdk_blocker
+          @semaphore = Mutex.new
         end
 
         def call
@@ -27,18 +28,20 @@ module SplitIoClient
         end
 
         def fetch_splits
-          data = splits_since(@splits_repository.get_change_number)
+          @semaphore.synchronize do
+            data = splits_since(@splits_repository.get_change_number)
 
-          data[:splits] && data[:splits].each do |split|
-            add_split_unless_archived(split)
-          end
+            data[:splits] && data[:splits].each do |split|
+              add_split_unless_archived(split)
+            end
 
-          @splits_repository.set_segment_names(data[:segment_names])
-          @splits_repository.set_change_number(data[:till])
+            @splits_repository.set_segment_names(data[:segment_names])
+            @splits_repository.set_change_number(data[:till])
 
-          @config.logger.debug("segments seen(#{data[:segment_names].length}): #{data[:segment_names].to_a}") if @config.debug_enabled
+            @config.logger.debug("segments seen(#{data[:segment_names].length}): #{data[:segment_names].to_a}") if @config.debug_enabled
 
-          @sdk_blocker.splits_ready!
+            @sdk_blocker.splits_ready!
+          end
         rescue StandardError => error
           @config.log_found_exception(__method__.to_s, error)
         end

data/lib/splitclient-rb/engine/push_manager.rb

@@ -14,6 +14,7 @@ module SplitIoClient
       def start_sse
         response = @auth_api_client.authenticate(@api_key)
 
+        @config.logger.debug("Auth service response push_enabled: #{response[:push_enabled]}")
         if response[:push_enabled]
           @sse_handler.start(response[:token], response[:channels])
           schedule_next_token_refresh(response[:exp])

data/lib/splitclient-rb/engine/sync_manager.rb

@@ -19,6 +19,7 @@ module SplitIoClient
         @synchronizer = Synchronizer.new(repositories, api_key, config, sdk_blocker, sync_params)
         notification_manager_keeper = SplitIoClient::SSE::NotificationManagerKeeper.new(config) do |manager|
           manager.on_occupancy { |publisher_available| process_occupancy(publisher_available) }
+          manager.on_push_shutdown { process_push_shutdown }
         end
         @sse_handler = SplitIoClient::SSE::SSEHandler.new(
           config,
@@ -57,8 +58,8 @@ module SplitIoClient
       def start_poll
         @synchronizer.start_periodic_fetch
         @synchronizer.start_periodic_data_recording
-      rescue StandardError => error
-        @config.logger.error(error)
+      rescue StandardError => e
+        @config.logger.error(e)
       end
 
       # Starts thread which fetch splits and segments once and trigger task to periodic data recording.
@@ -67,8 +68,8 @@ module SplitIoClient
           begin
             @synchronizer.sync_all
             @synchronizer.start_periodic_data_recording
-          rescue StandardError => error
-            @config.logger.error(error)
+          rescue StandardError => e
+            @config.logger.error(e)
           end
         end
       end
@@ -78,8 +79,8 @@ module SplitIoClient
         @config.threads[:sync_manager_start_sse] = Thread.new do
           begin
             @push_manager.start_sse
-          rescue StandardError => error
-            @config.logger.error(error)
+          rescue StandardError => e
+            @config.logger.error(e)
           end
         end
       end
@@ -103,9 +104,17 @@ module SplitIoClient
         @synchronizer.start_periodic_fetch
       end
 
-      def process_occupancy(publisher_available)
-        process_disconnect unless publisher_available
-        process_connected if publisher_available
+      def process_occupancy(push_enable)
+        process_disconnect unless push_enable
+        process_connected if push_enable
+      end
+
+      def process_push_shutdown
+        @sse_handler.stop_workers
+        @push_manager.stop_sse
+        start_poll
+      rescue StandardError => e
+        @config.logger.error(e)
       end
     end
   end

data/lib/splitclient-rb/sse/notification_manager_keeper.rb

@@ -7,14 +7,18 @@ module SplitIoClient
     class NotificationManagerKeeper
       def initialize(config)
         @config = config
-        @polling_on = Concurrent::AtomicBoolean.new(false)
-        @on = { occupancy: ->(_) {} }
+        @publisher_available = Concurrent::AtomicBoolean.new(true)
+        @on = { occupancy: ->(_) {}, push_shutdown: ->(_) {} }
 
         yield self if block_given?
       end
 
       def handle_incoming_occupancy_event(event)
-        process_event(event.data['metrics']['publishers']) if event.channel == SplitIoClient::Constants::CONTROL_PRI
+        if event.data['type'] == 'CONTROL'
+          process_event_control(event.data['controlType'])
+        elsif event.channel == SplitIoClient::Constants::CONTROL_PRI
+          process_event_occupancy(event.data['metrics']['publishers'])
+        end
       rescue StandardError => e
         @config.logger.error(e)
       end
@@ -23,22 +27,46 @@ module SplitIoClient
         @on[:occupancy] = action
       end
 
+      def on_push_shutdown(&action)
+        @on[:push_shutdown] = action
+      end
+
       private
 
-      def process_event(publishers)
-        @config.logger.debug("Occupancy process event with #{publishers} publishers and polling on: #{@polling_on.value}")
-        if publishers <= 0 && !@polling_on.value
-          @polling_on.make_true
+      def process_event_control(type)
+        case type
+        when 'STREAMING_PAUSED'
           dispatch_occupancy_event(false)
-        elsif publishers >= 1 && @polling_on.value
-          @polling_on.make_false
+        when 'STREAMING_RESUMED'
+          dispatch_occupancy_event(true) if @publisher_available.value
+        when 'STREAMING_DISABLED'
+          dispatch_push_shutdown
+        else
+          @config.logger.error("Incorrect event type: #{incoming_notification}")
+        end
+      end
+
+      def process_event_occupancy(publishers)
+        @config.logger.debug(
+          "Occupancy process event with #{publishers} publishers and polling on: #{@publisher_available.value}"
+        )
+        if publishers <= 0 && @publisher_available.value
+          @publisher_available.make_false
+          dispatch_occupancy_event(false)
+        elsif publishers >= 1 && !@publisher_available.value
+          @publisher_available.make_true
           dispatch_occupancy_event(true)
         end
       end
 
-      def dispatch_occupancy_event(publisher_available)
-        @config.logger.debug("Dispatching occupancy event with publisher avaliable: #{publisher_available}")
-        @on[:occupancy].call(publisher_available)
+      def dispatch_occupancy_event(push_enable)
+        @config.logger.debug("Dispatching occupancy event with publisher avaliable: #{push_enable}")
+        @on[:occupancy].call(push_enable)
+      end
+
+      def dispatch_push_shutdown
+        @config.logger.debug('Dispatching push shutdown')
+        @on[:push_shutdown].call
       end
     end
   end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.1.0.pre.rc3'
+  VERSION = '7.1.0.pre.rc4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 7.1.0.pre.rc3
+  version: 7.1.0.pre.rc4
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-17 00:00:00.000000000 Z
+date: 2020-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats