splitclient-rb 6.1.0 → 6.2.0.pre.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 799cb7cc072735ec1d38ee26e6adb11abaf3d96a6d1981f97785735c417c5ddd
-  data.tar.gz: 59b4b04bab3ad6a63f9a6e135b52cba1af49364b2cb753481d9bad2ae9be9a96
+  metadata.gz: c45535b20ee4c539f3876f2dcc8f402c2deb19b140a849c292225ecb051e7cdb
+  data.tar.gz: 24005ef65f4080d89e4b2ca30db2cc8f16f70c7e524fc92e9903fce2347e08d3
 SHA512:
-  metadata.gz: 52fb852bf94f6a7ec54881742e1648a85f89d66dd2ef74a5dedb98d60d4c736cd85f99a1b61043371bdff73ad038ac1baae196c681f01049153f5f75b48f2247
-  data.tar.gz: b49c0c82fc6beef2c6d1eb26847c35c37807dd2ed15e76a0daf20b951815b1820f8ce30ad23410415ad9088b8df1cdf86aadccebd83ec59f57f50f77dd5fac94
+  metadata.gz: 07be0c01951df6acfde4254aa57c312e2bf77ae18fe97e1db9aa3aa95c233aab1d4e229aaedab3c0dc75afed0ad4562d26d8f18c0570a78c95589c1cd9755791
+  data.tar.gz: 8d1cd43002b2fbee1f34349fdb3c905810af12685ce41f4474072e3a6944a0aa444aa359e123848ee3ef0efada7d6a2e6b286aa837b329d0f7c9994b354f3ed6

data/.gitignore

@@ -49,3 +49,6 @@ dump.rdb
 
 # Ignore Mac OS generated files
 .DS_Store
+
+# Ignore Appraisal gemfile.lock files
+/gemfiles/*.gemfile.lock

data/.rubocop.yml

@@ -19,6 +19,7 @@ Naming/FileName:
 AllCops:
   TargetRubyVersion: 2.3.6
   Exclude:
+    - gemfiles/* # excluded as appraisal generates them with errors
     - lib/*
     - lib/murmurhash/**/*
     - lib/splitclient-rb/*

data/Appraisals

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+appraise 'faraday-before-0.13' do
+  gem 'faraday', '>= 0.9', '< 0.13'
+  gem 'net-http-persistent', '~> 3.0'
+end
+
+appraise 'faraday-after-0.13' do
+  gem 'faraday', '> 0.13'
+end

data/Detailed-README.md

@@ -206,6 +206,57 @@ The split client will return `on`. Note that this will be true for any bucketing
  factory = SplitIoClient::SplitFactoryBuilder.build('localhost', path: '/where/to-look-for/<file_name>', reload_rate: 3)
  ```
 
+### SDK Input Validations
+
+In order to provide consistency among the SDKs for the different programming languages, provide better output to users in case of errors, and prevent unexpected errors to raise exceptions in your application, most of the parameters in the SDK methods are validated against a set of rules. Similarly, some of the configuration parameters must follow these rules, too. Check your application against the list below to prevent issues when using the SDK.
+
+#### get_treatment (split_client)
+
+- `key` (when not using matching_key and bucketing_key): must be a non-empty `String` or a `Symbol`, shorter than 250 characters. If a non-NaN `Numeric` value is used, it'll be converted to its `String` representation.
+
+- `matching_key`, `bucketing_key`: the containing `Hash` must have both keys, and the same rules above apply for each.
+
+- `split_name`: must be a non-empty `String` or a `Symbol`. Whitespaces will be trimmed from both ends of it. The trimmed version of the `split_name` will be used for both evaluation and to store the resulting impression.
+
+- `attributes`: must be of type `Hash`.
+
+#### get_treatments (split_client)
+
+- `key`, `matching_key`, `bucketing_key`: same rules as those for `get_treatment` apply.
+
+- `split_names`: must be an non-empty Array. Split names will be filtered removing those not matching the corresponding rules for `split_name` in `get_treatment`. In addition, duplicates will be removed.
+
+#### track (split_client)
+
+- `key`: must be a non-empty `String` or a `Symbol`, shorter than 250 characters. If a non-NaN `Numeric` value is used, it'll be converted to its `String` representation.
+
+- `traffic_type_name`: must be a non-empty `String` or a `Symbol`. If `traffic_type_name` contains uppercase letters, it will be lowercased.
+
+- `event_type`: must be a non-empty `String` or `Symbol` that conforms with the regular expression `^[a-zA-Z0-9][-_.:a-zA-Z0-9]{0,79}$` (i.e. event name must be alphanumeric, cannot be more than 80 characters long, and can only include a dash, underscore, period, or colon as separators of alphanumeric characters).
+
+- `value`: must be either a non-NaN `Numeric` value, or nil.
+
+#### split (split_manager)
+
+- `split_name`: must be a non-empty `String` or a `Symbol`.
+
+#### Configuration Parameters
+
+- `api_key`: must be a non-empty `String` or a `Symbol` of type `sdk` (`browser` type API keys will break this rule).
+
+- `block_until_ready`: a warning log message will be issued if this value is not set.
+
+
+#### Client Destroyed Rules
+Calls to the SDK methods are still possible after `destroy` is called. All will log an error message stating _client has been destroyed_.
+
+- `get_treatment` will return `control` for all calls (`get_treatments`, will return an Array of `control` values, correspondingly).
+
+- Calls to `track` will return `false`.  
+
+- All calls to `split_manager` methods will return an empty Array, except `split`, which will return `nil`.
+
+
 ## Advanced Configuration
 
 Split client's default configuration should cover most scenarios. However, you can also provide custom configuration settings when initializing the factory using a hash of options. e.g.:
@@ -280,6 +331,8 @@ The following values can be customized:
 
 **block_until_ready** : The SDK will block your app for the provided amount of seconds until it's ready. A `SplitIoClient::SDKBlockerTimeoutExpiredException` will be thrown If the provided time expires. When `0` is provided, the SDK runs in non-blocking mode.
 
+_When using consumer mode, blocking has no effect._
+
 *default value* = `0`
 
 **labels_enabled** : Allows preventing labels from being sent to the Split servers, as they may contain sensitive information.
@@ -349,11 +402,8 @@ options = {
   mode: :consumer,
   redis_url: 'redis://127.0.0.1:6379/0'
 }
-begin
-  split_client = SplitIoClient::SplitFactoryBuilder.build('YOUR_API_KEY', options).client
-rescue SplitIoClient::SDKBlockerTimeoutExpiredException
-  # Code to treat raised exception
-end
+
+split_client = SplitIoClient::SplitFactoryBuilder.build('YOUR_API_KEY', options).client
 ```
 
 ### Logging

data/Rakefile

@@ -3,6 +3,7 @@
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
+require 'appraisal'
 
 Dir['tasks/**/*.rake'].each { |rake| load rake }
 
@@ -25,4 +26,10 @@ else
   end
 end
 
-task default: %i[spec rubocop]
+if !ENV['APPRAISAL_INITIALIZED']
+  task :default do
+    sh 'appraisal install && rake appraisal && rake rubocop'
+  end
+else
+  task default: %i[spec rubocop]
+end

data/gemfiles/faraday_after_0.13.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "faraday", "> 0.13"
+
+gemspec path: "../"

data/gemfiles/faraday_before_0.13.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "faraday", ">= 0.9", "< 0.13"
+gem "net-http-persistent", "~> 3.0"
+
+gemspec path: "../"

data/lib/splitclient-rb/cache/adapters/cache_adapter.rb

@@ -19,7 +19,6 @@ module SplitIoClient
 
         def clear(namespace_key)
           @cache.clear
-          @adapter.clear(namespace_key)
         end
 
         def string(key)

data/lib/splitclient-rb/cache/adapters/redis_adapter.rb

@@ -125,6 +125,7 @@ module SplitIoClient
           @redis.rpush(key, val)
         end
 
+        # count = 0 will result in lrange(0,-1), fetching all items
         def get_from_queue(key, count)
           items = @redis.lrange(key, 0, count - 1)
           fetched_count = items.size
@@ -157,9 +158,7 @@ module SplitIoClient
         end
 
         def clear(prefix)
-          keys = @redis.keys("#{prefix}*")
-
-          keys.map { |key| @redis.del(key) }
+          # noop
         end
 
         def expire(key, seconds)

data/lib/splitclient-rb/cache/repositories/events/memory_repository.rb

@@ -19,6 +19,10 @@ module SplitIoClient
             @adapter.clear
           end
 
+          def batch
+            @adapter.get_batch(EVENTS_SLICE)
+          end
+
           def clear
             @adapter.clear
           end

data/lib/splitclient-rb/cache/repositories/events/redis_repository.rb

@@ -16,11 +16,23 @@ module SplitIoClient
             )
           end
 
-          def clear
-            @adapter.get_from_queue(namespace_key('.events'), EVENTS_SLICE).map do |e|
+          def get_events(number_of_events = 0)
+            @adapter.get_from_queue(namespace_key('.events'), number_of_events).map do |e|
               JSON.parse(e, symbolize_names: true)
             end
+          rescue StandardError => e
+            SplitIoClient.configuration.logger.error("Exception while clearing events cache: #{e}")
+            []
+          end
+
+          def batch
+            get_events(EVENTS_SLICE)
           end
+
+          def clear
+            get_events
+          end
+
         end
       end
     end

data/lib/splitclient-rb/cache/repositories/events_repository.rb

@@ -4,7 +4,7 @@ module SplitIoClient
       # Repository which forwards events interface to the selected adapter
       class EventsRepository < Repository
         extend Forwardable
-        def_delegators :@adapter, :add, :clear
+        def_delegators :@adapter, :add, :clear, :batch
 
         def initialize(adapter)
           @adapter = case adapter.class.to_s

data/lib/splitclient-rb/cache/repositories/impressions/memory_repository.rb

@@ -41,6 +41,10 @@ module SplitIoClient
             @adapter.get_batch(SplitIoClient.configuration.impressions_bulk_size)
           end
 
+          def clear
+            @adapter.clear
+          end
+
           private
 
           def random_sampler

data/lib/splitclient-rb/cache/repositories/impressions/redis_repository.rb

@@ -35,8 +35,8 @@ module SplitIoClient
             @adapter.expire(key, EXPIRE_SECONDS) if impressions.size == impressions_list_size
           end
 
-          def batch
-            @adapter.get_from_queue(key, SplitIoClient.configuration.impressions_bulk_size).map do |e|
+          def get_impressions(number_of_impressions = 0)
+            @adapter.get_from_queue(key, number_of_impressions).map do |e|
               impression = JSON.parse(e, symbolize_names: true)
               impression[:i][:f] = impression[:i][:f].to_sym
               impression
@@ -46,6 +46,14 @@ module SplitIoClient
             []
           end
 
+          def batch
+            get_impressions(SplitIoClient.configuration.impressions_bulk_size)
+          end
+
+          def clear
+            get_impressions
+          end
+
           def key
             @key ||= namespace_key('.impressions')
           end

data/lib/splitclient-rb/cache/repositories/impressions_repository.rb

@@ -6,7 +6,7 @@ module SplitIoClient
       # Repository which forwards impressions interface to the selected adapter
       class ImpressionsRepository < Repository
         extend Forwardable
-        def_delegators :@adapter, :add, :add_bulk, :batch, :empty?
+        def_delegators :@adapter, :add, :add_bulk, :batch, :clear, :empty?
 
         def initialize(adapter)
           @adapter = case adapter.class.to_s

data/lib/splitclient-rb/cache/repositories/segments_repository.rb

@@ -13,7 +13,7 @@ module SplitIoClient
           else
             adapter
           end
-          @adapter.set_bool(namespace_key('.ready'), false) unless SplitIoClient.configuration.mode == :consumer
+          @adapter.set_bool(namespace_key('.ready'), false) unless SplitIoClient.configuration.mode.equal?(:consumer)
         end
 
         # Receives segment data, adds and removes segements from the store

data/lib/splitclient-rb/cache/repositories/splits_repository.rb

@@ -13,7 +13,7 @@ module SplitIoClient
           else
             adapter
           end
-          unless SplitIoClient.configuration.mode == :consumer
+          unless SplitIoClient.configuration.mode.equal?(:consumer)
             @adapter.set_string(namespace_key('.splits.till'), '-1')
             @adapter.initialize_map(namespace_key('.segments.registered'))
           end

data/lib/splitclient-rb/cache/senders/events_sender.rb

@@ -27,18 +27,25 @@ module SplitIoClient
 
         def events_thread
           SplitIoClient.configuration.threads[:events_sender] = Thread.new do
-            SplitIoClient.configuration.logger.info('Starting events service')
+            begin
+              SplitIoClient.configuration.logger.info('Starting events service')
+              
+              loop do
+                post_events(false)
 
-            loop do
+                sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.events_push_rate))
+              end
+            rescue SplitIoClient::SDKShutdownException
               post_events
 
-              sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.events_push_rate))
+              SplitIoClient.configuration.logger.info('Posting events due to shutdown')
             end
           end
         end
 
-        def post_events
-          events_api.post(@events_repository.clear)
+        def post_events(fetch_all_events = true)
+          events = fetch_all_events ? @events_repository.clear : @events_repository.batch
+          events_api.post(events)
         rescue StandardError => error
           SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
         end

data/lib/splitclient-rb/cache/senders/impressions_formatter.rb

@@ -8,8 +8,9 @@ module SplitIoClient
           @impressions_repository = impressions_repository
         end
 
-        def call(raw_impressions)
-          impressions = raw_impressions || @impressions_repository.batch
+        def call(fetch_all_impressions, raw_impressions = nil)
+          impressions = raw_impressions || (fetch_all_impressions ? @impressions_repository.clear : @impressions_repository.batch)
+          
           filtered_impressions = filter_impressions(impressions)
 
           return [] if impressions.empty? || filtered_impressions.empty?

data/lib/splitclient-rb/cache/senders/impressions_sender.rb

@@ -36,28 +36,27 @@ module SplitIoClient
               SplitIoClient.configuration.logger.info('Starting impressions service')
 
               loop do
-                post_impressions
+                post_impressions(false)
 
                 sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.impressions_refresh_rate))
               end
-            rescue SplitIoClient::ImpressionShutdownException
+            rescue SplitIoClient::SDKShutdownException
               post_impressions
 
-              @impressions_repository.clear
+              SplitIoClient.configuration.logger.info('Posting impressions due to shutdown')
             end
           end
         end
 
-        def post_impressions
+        def post_impressions(fetch_all_impressions = true)
+          formatted_impressions = ImpressionsFormatter.new(@impressions_repository)
+            .call(fetch_all_impressions)
+
           impressions_api.post(formatted_impressions)
         rescue StandardError => error
           SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
         end
 
-        def formatted_impressions(raw_impressions = nil)
-          ImpressionsFormatter.new(@impressions_repository).call(raw_impressions)
-        end
-
         def impressions_api
           @impressions_api ||= SplitIoClient::Api::Impressions.new(@api_key)
         end

data/lib/splitclient-rb/cache/senders/metrics_sender.rb

@@ -25,12 +25,18 @@ module SplitIoClient
 
         def metrics_thread
           SplitIoClient.configuration.threads[:metrics_sender] = Thread.new do
-            SplitIoClient.configuration.logger.info('Starting metrics service')
-
-            loop do
+            begin
+              SplitIoClient.configuration.logger.info('Starting metrics service')
+              
+              loop do
+                post_metrics
+
+                sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.metrics_refresh_rate))
+              end
+            rescue SplitIoClient::SDKShutdownException
               post_metrics
 
-              sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.metrics_refresh_rate))
+              SplitIoClient.configuration.logger.info('Posting metrics due to shutdown')
             end
           end
         end

data/lib/splitclient-rb/clients/split_client.rb

@@ -125,14 +125,16 @@ module SplitIoClient
 
     def destroy
       SplitIoClient.configuration.logger.info('Split client shutdown started...') if SplitIoClient.configuration.debug_enabled
-      SplitIoClient.configuration.threads[:impressions_sender].raise(SplitIoClient::ImpressionShutdownException)
-      SplitIoClient.configuration.threads.reject { |k, _| k == :impressions_sender }.each do |name, thread|
-        Thread.kill(thread)
+
+      SplitIoClient.configuration.threads.select { |name, thread| name.to_s.end_with? 'sender' }.values.each do |thread|
+        thread.raise(SplitIoClient::SDKShutdownException)
+        thread.join
       end
-      @metrics_repository.clear
+
+      SplitIoClient.configuration.threads.values.each { |thread| Thread.kill(thread) }
+
       @splits_repository.clear
       @segments_repository.clear
-      @events_repository.clear
 
       SplitIoClient.configuration.logger.info('Split client shutdown complete') if SplitIoClient.configuration.debug_enabled
       SplitIoClient.configuration.valid_mode = false

data/lib/splitclient-rb/engine/api/client.rb

@@ -43,12 +43,33 @@ module SplitIoClient
       private
 
       def api_client
+        if needs_patched_net_http_persistent_adapter?
+          require 'splitclient-rb/engine/api/faraday_adapter/patched_net_http_persistent'
+
+          Faraday::Adapter.register_middleware(
+            net_http_persistent: SplitIoClient::FaradayAdapter::PatchedNetHttpPersistent
+          )
+        end
+
         @api_client ||= Faraday.new do |builder|
           builder.use SplitIoClient::FaradayMiddleware::Gzip
           builder.adapter :net_http_persistent
         end
       end
 
+      def needs_patched_net_http_persistent_adapter?
+        new_net_http_persistent? && incompatible_faraday_version?
+      end
+
+      def incompatible_faraday_version?
+        version = Faraday::VERSION.split('.')[0..1]
+        version[0].to_i == 0 && version[1].to_i < 13
+      end
+
+      def new_net_http_persistent?
+        Net::HTTP::Persistent::VERSION.split('.').first.to_i >= 3
+      end
+
       def common_headers(api_key)
         {
           'Authorization' => "Bearer #{api_key}",

data/lib/splitclient-rb/engine/api/faraday_adapter/patched_net_http_persistent.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module SplitIoClient
+  module FaradayAdapter
+    class PatchedNetHttpPersistent < Faraday::Adapter::NetHttpPersistent
+      ##
+      # Borrowed directly from the latest `NetHttpPersistent` adapter implementation.
+      #
+      # https://github.com/lostisland/faraday/blob/master/lib/faraday/adapter/net_http_persistent.rb
+      #
+      def net_http_connection(env)
+        @cached_connection ||=
+          if Net::HTTP::Persistent.instance_method(:initialize).parameters.first == [:key, :name]
+            Net::HTTP::Persistent.new(name: 'Faraday')
+          else
+            Net::HTTP::Persistent.new('Faraday')
+          end
+
+        proxy_uri                = proxy_uri(env)
+        @cached_connection.proxy = proxy_uri if @cached_connection.proxy_uri != proxy_uri
+        @cached_connection
+      end
+
+      def proxy_uri(env)
+        proxy_uri = nil
+        if (proxy = env[:request][:proxy])
+          proxy_uri      = ::URI::HTTP === proxy[:uri] ? proxy[:uri].dup : ::URI.parse(proxy[:uri].to_s)
+          proxy_uri.user = proxy_uri.password = nil
+          # awful patch for net-http-persistent 2.8 not unescaping user/password
+          (
+          class << proxy_uri;
+            self;
+          end).class_eval do
+            define_method(:user) { proxy[:user] }
+            define_method(:password) { proxy[:password] }
+          end if proxy[:user]
+        end
+        proxy_uri
+      end
+
+      def with_net_http_connection(env)
+        yield net_http_connection(env)
+      end
+    end
+  end
+end

data/lib/splitclient-rb/engine/parser/split_adapter.rb

@@ -20,7 +20,7 @@ module SplitIoClient
     # @param splits_repository [SplitsRepository] SplitsRepository instance to store splits in
     # @param segments_repository [SegmentsRepository] SegmentsRepository instance to store segments in
     # @param impressions_repository [ImpressionsRepository] ImpressionsRepository instance to store impressions in
-    # @param metrics_repository [MetricsRepository] SplitsRepository instance to store metrics in
+    # @param metrics_repository [MetricsRepository] MetricsRepository instance to store metrics in
     # @param sdk_blocker [SDKBlocker] SDKBlocker instance which blocks splits_repository/segments_repository
     #
     # @return [SplitIoClient] split.io client instance

data/lib/splitclient-rb/exceptions.rb

@@ -1,7 +1,7 @@
 module SplitIoClient
   class SplitIoError < StandardError; end
 
-  class ImpressionShutdownException < SplitIoError; end
+  class SDKShutdownException < SplitIoError; end
 
   class SDKBlockerTimeoutExpiredException < SplitIoError; end
 end

data/lib/splitclient-rb/split_config.rb

@@ -70,7 +70,7 @@ module SplitIoClient
       @transport_debug_enabled = opts[:transport_debug_enabled] || SplitConfig.default_debug
       @block_until_ready = opts[:ready] || opts[:block_until_ready] || 0
 
-      @logger.warn 'no ready parameter has been set - incorrect control treatments could be logged' if block_until_ready == 0
+      @logger.warn 'no ready parameter has been set - incorrect control treatments could be logged' if block_until_ready == 0 && !mode.equal?(:consumer) 
 
       @machine_name = opts[:machine_name] || SplitConfig.machine_hostname
       @machine_ip = opts[:machine_ip] || SplitConfig.machine_ip

data/lib/splitclient-rb/split_factory.rb

@@ -7,6 +7,17 @@ module SplitIoClient
     attr_reader :adapter, :client, :manager
 
     def initialize(api_key, config_hash = {})
+      at_exit do
+        unless ENV['SPLITCLIENT_ENV'] == 'test'
+          if (Process.pid == ROOT_PROCESS_ID)
+            SplitIoClient.configuration.logger.info('Split SDK shutdown started...')
+            @client.destroy if @client
+            stop!
+            SplitIoClient.configuration.logger.info('Split SDK shutdown complete')
+          end
+        end
+      end
+
       @api_key = api_key
       SplitIoClient.configure(config_hash)
 
@@ -20,7 +31,10 @@ module SplitIoClient
       @metrics_repository = MetricsRepository.new(SplitIoClient.configuration.metrics_adapter)
       @events_repository = EventsRepository.new(SplitIoClient.configuration.events_adapter)
 
-      @sdk_blocker = SDKBlocker.new(@splits_repository, @segments_repository)
+      if SplitIoClient.configuration.mode == :standalone && SplitIoClient.configuration.block_until_ready > 0
+        @sdk_blocker = SDKBlocker.new(@splits_repository, @segments_repository)
+      end
+
       @adapter = start!
 
       @client = SplitClient.new(@api_key, @adapter, @splits_repository, @segments_repository, @impressions_repository, @metrics_repository, @events_repository)
@@ -28,19 +42,7 @@ module SplitIoClient
 
       validate_api_key
 
-      @sdk_blocker.block if SplitIoClient.configuration.block_until_ready > 0
-
-
-      at_exit do
-        unless ENV['SPLITCLIENT_ENV'] == 'test'
-          if (Process.pid == ROOT_PROCESS_ID)
-            SplitIoClient.configuration.logger.info('Split SDK shutdown started...')
-            @client.destroy
-            stop!
-            SplitIoClient.configuration.logger.info('Split SDK shutdown complete')
-          end
-        end
-      end
+      @sdk_blocker.block if @sdk_blocker
     end
 
     def start!

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '6.1.0'
+  VERSION = '6.2.0.pre.rc1'
 end

data/lib/splitclient-rb.rb

@@ -41,6 +41,7 @@ require 'splitclient-rb/split_config'
 require 'splitclient-rb/split_logger'
 
 require 'splitclient-rb/engine/api/faraday_middleware/gzip'
+require 'splitclient-rb/engine/api/faraday_adapter/patched_net_http_persistent'
 require 'splitclient-rb/engine/api/client'
 require 'splitclient-rb/engine/api/impressions'
 require 'splitclient-rb/engine/api/metrics'

data/splitclient-rb.gemspec

@@ -36,6 +36,7 @@ Gem::Specification.new do |spec|
   end
 
   spec.add_development_dependency 'allocation_stats'
+  spec.add_development_dependency 'appraisal'
   spec.add_development_dependency 'bundler', '~> 1.11'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-nav'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.2.0.pre.rc1
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-08 00:00:00.000000000 Z
+date: 2019-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: allocation_stats
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -273,6 +287,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".simplecov"
+- Appraisals
 - CHANGES.txt
 - Detailed-README.md
 - Gemfile
@@ -284,6 +299,8 @@ files:
 - ext/murmurhash/extconf.rb
 - ext/murmurhash/murmurhash.c
 - ext/murmurhash/murmurhash.h
+- gemfiles/faraday_after_0.13.gemfile
+- gemfiles/faraday_before_0.13.gemfile
 - lib/murmurhash/base.rb
 - lib/murmurhash/murmurhash.jar
 - lib/murmurhash/murmurhash_mri.rb
@@ -317,6 +334,7 @@ files:
 - lib/splitclient-rb/clients/split_client.rb
 - lib/splitclient-rb/engine/api/client.rb
 - lib/splitclient-rb/engine/api/events.rb
+- lib/splitclient-rb/engine/api/faraday_adapter/patched_net_http_persistent.rb
 - lib/splitclient-rb/engine/api/faraday_middleware/gzip.rb
 - lib/splitclient-rb/engine/api/impressions.rb
 - lib/splitclient-rb/engine/api/metrics.rb
@@ -369,7 +387,6 @@ files:
 - splitclient-rb.gemspec
 - tasks/benchmark_get_treatment.rake
 - tasks/irb.rake
-- tasks/rspec.rake
 homepage: https://github.com/splitio/ruby-client
 licenses:
 - Apache 2.0
@@ -385,9 +402,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.7.6

data/tasks/rspec.rake

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-require 'rspec/core/rake_task'
-
-RSpec::Core::RakeTask.new(:spec)