splitclient-rb 5.1.0 → 5.1.1.pre.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65f8f1fc2b395217192276c37c33ffe46385c426
-  data.tar.gz: 1c6ab963759d9dfba5a4390cb37fd22aecd5e82b
+  metadata.gz: '0491f827ad5bfa50672fcb2d5562c39c09ab393b'
+  data.tar.gz: 80313b3db90dff3a9622ffceaa812257f585ca96
 SHA512:
-  metadata.gz: 9c96b44c41046ada5f90fdb556e9d29af32ae22fda79649aff1fa415260a1fad655625d7d046a65de19d5a1da712fb505c4c0d8322087c00a8fa53334afe3918
-  data.tar.gz: f64066085181b67f2c4efe20fd348b7629795e8607aec3672e8182d2ed9c229857fa654e1d2e57f573f2b8a1e9968a94e915065a9b0d10f842b7550dfda94c62
+  metadata.gz: 53e671060ebaca132ab4205d077b4dec7216f65a371b8c89715bbc45e59b5b8a980c3fd9629b9e97090f03798641c640632a142036eb3bf8602d13da4dc8fc35
+  data.tar.gz: 8fff61604c5e9aa89cc0057f4b199de34a12161305c8d806a2e9122e7fd1c0c2584b707948b3a0fafe358c5f3f5338858213f27b12e22087f051622f6b69ab16

data/.gitignore

@@ -43,3 +43,6 @@ lib/murmurhash/murmurhash.so
 
 ext/murmurhash/murmurhash.bundle
 ext/murmurhash/murmurhash.so
+
+#Ignore dump.rdb
+dump.rdb

data/.rubocop.yml

@@ -5,11 +5,15 @@ Metrics/LineLength:
   Max: 121
 
 Metrics/BlockLength:
- Exclude:
-   - spec/**/*
-   - splitclient-rb.gemspec
-   - exe/splitio
+  Exclude:
+    - spec/**/*
+    - splitclient-rb.gemspec
+    - exe/splitio
+
+Naming/FileName:
+  Exclude:
+    - splitclient-rb.gemspec
 
 AllCops:
   Exclude:
-  - lib/**/* #TODO Apply rubocop to the library
+    - lib/**/* #TODO Apply rubocop to the library

data/Detailed-README.md

@@ -468,7 +468,7 @@ The gem uses `rspec` for unit testing. You can find the files for the unit tests
 To run all the specs in the `spec` folder, use the provided rake task (_make sure Redis is running in localhost_):
 
 ```bash
-  SPLITCLIENT_ENV=test bundle exec rspec spec
+  bundle exec rspec
 ```
 
 `Simplecov` is used for coverage reporting. Upon executing the rake task it will store the reports in the `/coverage` folder.

data/exe/splitio

@@ -78,12 +78,12 @@ opt_parser = OptionParser.new do |opts|
 end
 
 begin
-   opt_parser.parse!(ARGV)
- rescue OptionParser::InvalidOption => e
-   puts e
-   puts opt_parser
-   exit(1)
- end
+  opt_parser.parse!(ARGV)
+rescue OptionParser::InvalidOption => e
+  puts e
+  puts opt_parser
+  exit(1)
+end
 
 config = config_path != '' ? YAML.load_file(config_path) : {}
 config

data/lib/splitclient-rb/cache/repositories/events/memory_repository.rb

@@ -5,16 +5,15 @@ module SplitIoClient
         class MemoryRepository < EventsRepository
           EVENTS_SLICE = 100
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           def add(key, traffic_type, event_type, time, value)
             @adapter.add_to_queue(m: metadata, e: event(key, traffic_type, event_type, time, value))
           rescue ThreadError # queue is full
-            if @config.debug_enabled
-              @config.logger.warn("Dropping events. Current size is #{@config.events_queue_size}. " \
+            if SplitIoClient.configuration.debug_enabled
+              SplitIoClient.configuration.logger.warn("Dropping events. Current size is #{SplitIoClient.configuration.events_queue_size}. " \
                                   "Consider increasing events_queue_size")
             end
             @adapter.clear

data/lib/splitclient-rb/cache/repositories/events/redis_repository.rb

@@ -5,9 +5,8 @@ module SplitIoClient
         class RedisRepository < EventsRepository
           EVENTS_SLICE = 100
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           def add(key, traffic_type, event_type, time, value)

data/lib/splitclient-rb/cache/repositories/events_repository.rb

@@ -6,13 +6,12 @@ module SplitIoClient
         extend Forwardable
         def_delegators :@adapter, :add, :clear
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Events::MemoryRepository.new(adapter, config)
+            Repositories::Events::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Events::RedisRepository.new(adapter, config)
+            Repositories::Events::RedisRepository.new(adapter)
           end
         end
 
@@ -20,9 +19,9 @@ module SplitIoClient
 
         def metadata
           {
-            s: "#{@config.language}-#{@config.version}",
-            i: @config.machine_ip,
-            n: @config.machine_name
+            s: "#{SplitIoClient.configuration.language}-#{SplitIoClient.configuration.version}",
+            i: SplitIoClient.configuration.machine_ip,
+            n: SplitIoClient.configuration.machine_name
           }
         end
 

data/lib/splitclient-rb/cache/repositories/impressions/memory_repository.rb

@@ -4,9 +4,8 @@ module SplitIoClient
       module Impressions
         class MemoryRepository
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           # Store impression data in the selected adapter
@@ -14,7 +13,7 @@ module SplitIoClient
             @adapter.add_to_queue(feature: split_name, impressions: data)
           rescue ThreadError # queue is full
             if random_sampler.rand(1..1000) <= 2 # log only 0.2 % of the time
-              @config.logger.warn("Dropping impressions. Current size is #{@config.impressions_queue_size}. " \
+              SplitIoClient.configuration.logger.warn("Dropping impressions. Current size is #{SplitIoClient.configuration.impressions_queue_size}. " \
                                   "Consider increasing impressions_queue_size")
             end
           end
@@ -26,7 +25,7 @@ module SplitIoClient
                 'keyName' => key,
                 'bucketingKey' => bucketing_key,
                 'treatment' => treatment[:treatment],
-                'label' => @config.labels_enabled ? treatment[:label] : nil,
+                'label' => SplitIoClient.configuration.labels_enabled ? treatment[:label] : nil,
                 'changeNumber' => treatment[:change_number],
                 'time' => time
               )
@@ -34,9 +33,9 @@ module SplitIoClient
           end
 
           def get_batch
-            return [] if @config.impressions_bulk_size == 0
-            @adapter.get_batch(@config.impressions_bulk_size).map do |impression|
-              impression.update(ip: @config.machine_ip)
+            return [] if SplitIoClient.configuration.impressions_bulk_size == 0
+            @adapter.get_batch(SplitIoClient.configuration.impressions_bulk_size).map do |impression|
+              impression.update(ip: SplitIoClient.configuration.machine_ip)
             end
           end
 

data/lib/splitclient-rb/cache/repositories/impressions/redis_repository.rb

@@ -4,9 +4,8 @@ module SplitIoClient
       module Impressions
         class RedisRepository < Repository
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           # Store impression data in Redis
@@ -24,24 +23,24 @@ module SplitIoClient
                     'keyName' => key,
                     'bucketingKey' => bucketing_key,
                     'treatment' => treatment[:treatment],
-                    'label' => @config.labels_enabled ? treatment[:label] : nil,
+                    'label' => SplitIoClient.configuration.labels_enabled ? treatment[:label] : nil,
                     'changeNumber' => treatment[:change_number],
                     'time' => time)
               end
             end
           end
 
-          # Get random impressions from redis in batches of size @config.impressions_bulk_size,
+          # Get random impressions from redis in batches of size SplitIoClient.configuration.impressions_bulk_size,
           # delete fetched impressions afterwards
           def get_batch
             impressions = impression_keys.each_with_object([]) do |key, memo|
               ip = key.split('/')[-2] # 'prefix/sdk_lang/ip/impressions.name' -> ip
               if ip.nil?
-                @config.logger.warn("Impressions IP parse error for key: #{key}")
+                SplitIoClient.configuration.logger.warn("Impressions IP parse error for key: #{key}")
                 next
               end
               split_name = key.split('.').last
-              members = @adapter.random_set_elements(key, @config.impressions_bulk_size)
+              members = @adapter.random_set_elements(key, SplitIoClient.configuration.impressions_bulk_size)
               members.each do |impression|
                 parsed_impression = JSON.parse(impression)
 
@@ -53,11 +52,11 @@ module SplitIoClient
               end
 
               @adapter.delete_from_set(key, members)
-            end
 
+            end
             impressions
           rescue StandardError => e
-            @config.logger.error("Exception while clearing impressions cache: #{e}")
+            SplitIoClient.configuration.logger.error("Exception while clearing impressions cache: #{e}")
 
             []
           end
@@ -66,9 +65,9 @@ module SplitIoClient
 
           # Get all sets by prefix
           def impression_keys
-            @adapter.find_sets_by_prefix("#{@config.redis_namespace}/*/impressions.*")
+            @adapter.find_sets_by_prefix("#{SplitIoClient.configuration.redis_namespace}/*/impressions.*")
           rescue StandardError => e
-            @config.logger.error("Exception while fetching impression_keys: #{e}")
+            SplitIoClient.configuration.logger.error("Exception while fetching impression_keys: #{e}")
 
             []
           end

data/lib/splitclient-rb/cache/repositories/impressions_repository.rb

@@ -6,13 +6,12 @@ module SplitIoClient
         extend Forwardable
         def_delegators :@adapter, :add, :add_bulk, :get_batch, :empty?
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Impressions::MemoryRepository.new(adapter, config)
+            Repositories::Impressions::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Impressions::RedisRepository.new(adapter, config)
+            Repositories::Impressions::RedisRepository.new(adapter)
           end
         end
       end

data/lib/splitclient-rb/cache/repositories/metrics/memory_repository.rb

@@ -3,12 +3,10 @@ module SplitIoClient
     module Repositories
       module Metrics
         class MemoryRepository
-          def initialize(_ = nil, adapter, config)
+          def initialize(_ = nil, adapter)
             @counts = []
             @latencies = []
             @gauges = []
-
-            @config = config
           end
 
           def add_count(counter, delta)

data/lib/splitclient-rb/cache/repositories/metrics/redis_repository.rb

@@ -3,8 +3,7 @@ module SplitIoClient
     module Repositories
       module Metrics
         class RedisRepository < Repository
-          def initialize(adapter = nil, config)
-            @config = config
+          def initialize(adapter = nil)
             @adapter = adapter
           end
 

data/lib/splitclient-rb/cache/repositories/metrics_repository.rb

@@ -7,13 +7,12 @@ module SplitIoClient
         def_delegators :@adapter, :add_count, :add_latency, :add_gauge, :counts, :latencies, :gauges,
                        :clear_counts, :clear_latencies, :clear_gauges, :clear
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Metrics::MemoryRepository.new(adapter, config)
+            Repositories::Metrics::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Metrics::RedisRepository.new(adapter, config)
+            Repositories::Metrics::RedisRepository.new(adapter)
           end
         end
       end

data/lib/splitclient-rb/cache/repositories/repository.rb

@@ -12,11 +12,11 @@ module SplitIoClient
       protected
 
       def namespace_key(key = '')
-        "#{@config.redis_namespace}#{key}"
+        "#{SplitIoClient.configuration.redis_namespace}#{key}"
       end
 
       def impressions_metrics_key(key)
-        namespace_key("/#{@config.language}-#{@config.version}/#{@config.machine_ip}/#{key}")
+        namespace_key("/#{SplitIoClient.configuration.language}-#{SplitIoClient.configuration.version}/#{SplitIoClient.configuration.machine_ip}/#{key}")
       end
     end
   end

data/lib/splitclient-rb/cache/repositories/segments_repository.rb

@@ -6,10 +6,8 @@ module SplitIoClient
 
         attr_reader :adapter
 
-        def initialize(adapter, config)
+        def initialize(adapter)
           @adapter = adapter
-          @config = config
-
           @adapter.set_bool(namespace_key('.ready'), false)
         end
 

data/lib/splitclient-rb/cache/repositories/splits_repository.rb

@@ -8,10 +8,8 @@ module SplitIoClient
 
         attr_reader :adapter
 
-        def initialize(adapter, config)
+        def initialize(adapter)
           @adapter = adapter
-          @config = config
-
           @adapter.set_string(namespace_key('.splits.till'), '-1')
           @adapter.initialize_map(namespace_key('.segments.registered'))
         end

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -2,9 +2,8 @@ module SplitIoClient
   class ImpressionRouter
     attr_reader :router_thread
 
-    def initialize(config)
-      @config = config
-      @listener = config.impression_listener
+    def initialize
+      @listener = SplitIoClient.configuration.impression_listener
 
       return unless @listener
 
@@ -45,12 +44,12 @@ module SplitIoClient
     end
 
     def router_thread
-      @config.threads[:impression_router] = Thread.new do
+      SplitIoClient.configuration.threads[:impression_router] = Thread.new do
         loop do
           begin
             @listener.log(@queue.pop)
           rescue StandardError => error
-            @config.log_found_exception(__method__.to_s, error)
+            SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
           end
         end
       end

data/lib/splitclient-rb/cache/senders/events_sender.rb

@@ -2,9 +2,8 @@ module SplitIoClient
   module Cache
     module Senders
       class EventsSender
-        def initialize(events_repository, config, api_key)
+        def initialize(events_repository, api_key)
           @events_repository = events_repository
-          @config = config
           @api_key = api_key
         end
 
@@ -25,21 +24,21 @@ module SplitIoClient
         private
 
         def events_thread
-          @config.threads[:events_sender] = Thread.new do
-            @config.logger.info('Starting events service')
+          SplitIoClient.configuration.threads[:events_sender] = Thread.new do
+            SplitIoClient.configuration.logger.info('Starting events service')
 
             loop do
               post_events
 
-              sleep(SplitIoClient::Utilities.randomize_interval(@config.events_push_rate))
+              sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.events_push_rate))
             end
           end
         end
 
         def post_events
-          SplitIoClient::Api::Events.new(@api_key, @config, @events_repository.clear).post
+          SplitIoClient::Api::Events.new(@api_key, @events_repository.clear).post
         rescue StandardError => error
-          @config.log_found_exception(__method__.to_s, error)
+          SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
         end
       end
     end

data/lib/splitclient-rb/cache/senders/impressions_sender.rb

@@ -2,15 +2,14 @@ module SplitIoClient
   module Cache
     module Senders
       class ImpressionsSender
-        def initialize(impressions_repository, config, api_key)
+        def initialize(impressions_repository, api_key)
           @impressions_repository = impressions_repository
-          @config = config
           @api_key = api_key
         end
 
         def call
-          if @config.disable_impressions
-            @config.logger.info('Disabling impressions service by config')
+          if SplitIoClient.configuration.disable_impressions
+            SplitIoClient.configuration.logger.info('Disabling impressions service by config')
             return
           end
 
@@ -30,14 +29,14 @@ module SplitIoClient
         private
 
         def impressions_thread
-          @config.threads[:impressions_sender] = Thread.new do
+          SplitIoClient.configuration.threads[:impressions_sender] = Thread.new do
             begin
-              @config.logger.info('Starting impressions service')
+              SplitIoClient.configuration.logger.info('Starting impressions service')
 
               loop do
                 post_impressions
 
-                sleep(SplitIoClient::Utilities.randomize_interval(@config.impressions_refresh_rate))
+                sleep(SplitIoClient::Utilities.randomize_interval(SplitIoClient.configuration.impressions_refresh_rate))
               end
             rescue SplitIoClient::ImpressionShutdownException
               post_impressions
@@ -50,7 +49,7 @@ module SplitIoClient
         def post_impressions
           impressions_client.post
         rescue StandardError => error
-          @config.log_found_exception(__method__.to_s, error)
+          SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
         end
 
         def formatted_impressions(raw_impressions = nil)
@@ -58,7 +57,7 @@ module SplitIoClient
         end
 
         def impressions_client
-          SplitIoClient::Api::Impressions.new(@api_key, @config, formatted_impressions)
+          SplitIoClient::Api::Impressions.new(@api_key, formatted_impressions)
         end
       end
     end