splitclient-rb 5.1.0.pre.rc1-java → 5.1.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0407eae5550ac83cc494f48490d26f88c702876d
-  data.tar.gz: 9c03523b8a5ce1e48b8a6e1b9965f4f8766c8ab3
+  metadata.gz: 8903ab793f89c27a21ae3d916d68029978b22f72
+  data.tar.gz: 29606cfe1e0736b2060c53facc78142d78849374
 SHA512:
-  metadata.gz: 9d484be0c5e28a21e47a85cc147be454ad2dfccd1e3ef0d7a59252f3fba74278dedb27dd1d7db0d8294a3bd2892a5e183684b07e0dedff8600a8d3fcfad71267
-  data.tar.gz: cd6a785473b7d0d70a5483b2bd6891ca6c507e8a24fae495c3b89ca0a44506c68d328123dda54b61ad819feb63328550c83af189f55ded15354857adb0f12ff5
+  metadata.gz: 8bbca21009723c69445733989995a376ee8e8de059af13ec2a1cc4a4f970a01383f9a39dbba701848a7c3332615f13586eb1d78db5c510cdb5f1df82166bbbcf
+  data.tar.gz: a8874df6c0dc553648cd2dcfc10f78b678f2e21f0a3e21026b1df0906e1fe2f00e22aab03a21878940554b3b628178ba9416f667029d72a31171b9d4b0488f3d

data/.gitignore

@@ -43,3 +43,6 @@ lib/murmurhash/murmurhash.so
 
 ext/murmurhash/murmurhash.bundle
 ext/murmurhash/murmurhash.so
+
+#Ignore dump.rdb
+dump.rdb

data/.rubocop.yml

@@ -5,11 +5,15 @@ Metrics/LineLength:
   Max: 121
 
 Metrics/BlockLength:
- Exclude:
-   - spec/**/*
-   - splitclient-rb.gemspec
-   - exe/splitio
+  Exclude:
+    - spec/**/*
+    - splitclient-rb.gemspec
+    - exe/splitio
+
+Naming/FileName:
+  Exclude:
+    - splitclient-rb.gemspec
 
 AllCops:
   Exclude:
-  - lib/**/* #TODO Apply rubocop to the library
+    - lib/**/* #TODO Apply rubocop to the library

data/CHANGES.txt

@@ -1,3 +1,14 @@
+5.1.1 (October 4th, 2018)
+- Change get_treatments so that it sends a single latency metric
+- Removed unused call to Redis#scan when adding latencies
+- Removed Redis calls on initialization when SDK is set to consumer mode
+- Change split_config approach so that every property has an accessor
+- Removed @config parameter on most initializers
+
+5.1.0 (September 10th, 2018)
+- Change `get_api` to return only a Faraday response.
+- Add `SplitLogger` to clean up logging code and reduce the complexity in several methods.
+
 5.0.3 (August 13th, 2018)
 - Add `impressions_bulk_size` option to set the max number of impressions to be sent to the Split backend on each post.
 
@@ -8,7 +19,7 @@
 - Adds stop! method to the factory for gracefully stopping the SDK.
 
 5.0.0 (May 18th, 2018)
-- Fix bug where the sdk picked the wrong hashing algo. This is a breaking change. 
+- Fix bug where the sdk picked the wrong hashing algo. This is a breaking change.
 
 4.5.2 (May 16th, 2018)
 - do not return control when a split has custom attr and I don't pass attributes to get_treatment

data/Detailed-README.md

@@ -468,7 +468,7 @@ The gem uses `rspec` for unit testing. You can find the files for the unit tests
 To run all the specs in the `spec` folder, use the provided rake task (_make sure Redis is running in localhost_):
 
 ```bash
-  SPLITCLIENT_ENV=test bundle exec rspec spec
+  bundle exec rspec
 ```
 
 `Simplecov` is used for coverage reporting. Upon executing the rake task it will store the reports in the `/coverage` folder.

data/NEWS

@@ -1,3 +1,11 @@
+5.1.1
+
+Reduces the number of calls to Redis when calling #client.get_treatments using such cache adapter.
+
+5.1.0
+
+Prevent unhandled exceptions from raising when API get calls fail on Segments and Treatments.
+
 5.0.3
 
 Creates a new configuration parameter (impressions_bulk_size) to manage the max number of impressions sent to the Split backend on each post.
@@ -11,13 +19,13 @@ Prevents the impression thread from being started if a listener is not in place
 
 5.0.1
 
-Adding stop! method to the factory. 
+Adding stop! method to the factory.
 With this method the user will be able to stop the threads that queries the Split Service. This will be used in the before_fork configuration in Puma and Unicorn to stop the threads in the master process.
 
 5.0.0
 
 This is a breaking change in how users buckets are allocated.
-Ruby SDK was wrongly picking up the right buckets and defauled to 
+Ruby SDK was wrongly picking up the right buckets and defauled to
 use a "legacy hashing" instead of our moder murmur3 algo which is
 what other SDKs use. Please reach out to support@split.io for help
 on how to upgrade to this release.

data/exe/splitio

@@ -78,12 +78,12 @@ opt_parser = OptionParser.new do |opts|
 end
 
 begin
-   opt_parser.parse!(ARGV)
- rescue OptionParser::InvalidOption => e
-   puts e
-   puts opt_parser
-   exit(1)
- end
+  opt_parser.parse!(ARGV)
+rescue OptionParser::InvalidOption => e
+  puts e
+  puts opt_parser
+  exit(1)
+end
 
 config = config_path != '' ? YAML.load_file(config_path) : {}
 config

data/lib/splitclient-rb/cache/repositories/events/memory_repository.rb

@@ -5,16 +5,15 @@ module SplitIoClient
         class MemoryRepository < EventsRepository
           EVENTS_SLICE = 100
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           def add(key, traffic_type, event_type, time, value)
             @adapter.add_to_queue(m: metadata, e: event(key, traffic_type, event_type, time, value))
           rescue ThreadError # queue is full
-            if @config.debug_enabled
-              @config.logger.warn("Dropping events. Current size is #{@config.events_queue_size}. " \
+            if SplitIoClient.configuration.debug_enabled
+              SplitIoClient.configuration.logger.warn("Dropping events. Current size is #{SplitIoClient.configuration.events_queue_size}. " \
                                   "Consider increasing events_queue_size")
             end
             @adapter.clear

data/lib/splitclient-rb/cache/repositories/events/redis_repository.rb

@@ -5,9 +5,8 @@ module SplitIoClient
         class RedisRepository < EventsRepository
           EVENTS_SLICE = 100
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           def add(key, traffic_type, event_type, time, value)

data/lib/splitclient-rb/cache/repositories/events_repository.rb

@@ -6,13 +6,12 @@ module SplitIoClient
         extend Forwardable
         def_delegators :@adapter, :add, :clear
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Events::MemoryRepository.new(adapter, config)
+            Repositories::Events::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Events::RedisRepository.new(adapter, config)
+            Repositories::Events::RedisRepository.new(adapter)
           end
         end
 
@@ -20,9 +19,9 @@ module SplitIoClient
 
         def metadata
           {
-            s: "#{@config.language}-#{@config.version}",
-            i: @config.machine_ip,
-            n: @config.machine_name
+            s: "#{SplitIoClient.configuration.language}-#{SplitIoClient.configuration.version}",
+            i: SplitIoClient.configuration.machine_ip,
+            n: SplitIoClient.configuration.machine_name
           }
         end
 

data/lib/splitclient-rb/cache/repositories/impressions/memory_repository.rb

@@ -4,9 +4,8 @@ module SplitIoClient
       module Impressions
         class MemoryRepository
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           # Store impression data in the selected adapter
@@ -14,7 +13,7 @@ module SplitIoClient
             @adapter.add_to_queue(feature: split_name, impressions: data)
           rescue ThreadError # queue is full
             if random_sampler.rand(1..1000) <= 2 # log only 0.2 % of the time
-              @config.logger.warn("Dropping impressions. Current size is #{@config.impressions_queue_size}. " \
+              SplitIoClient.configuration.logger.warn("Dropping impressions. Current size is #{SplitIoClient.configuration.impressions_queue_size}. " \
                                   "Consider increasing impressions_queue_size")
             end
           end
@@ -26,7 +25,7 @@ module SplitIoClient
                 'keyName' => key,
                 'bucketingKey' => bucketing_key,
                 'treatment' => treatment[:treatment],
-                'label' => @config.labels_enabled ? treatment[:label] : nil,
+                'label' => SplitIoClient.configuration.labels_enabled ? treatment[:label] : nil,
                 'changeNumber' => treatment[:change_number],
                 'time' => time
               )
@@ -34,9 +33,9 @@ module SplitIoClient
           end
 
           def get_batch
-            return [] if @config.impressions_bulk_size == 0
-            @adapter.get_batch(@config.impressions_bulk_size).map do |impression|
-              impression.update(ip: @config.machine_ip)
+            return [] if SplitIoClient.configuration.impressions_bulk_size == 0
+            @adapter.get_batch(SplitIoClient.configuration.impressions_bulk_size).map do |impression|
+              impression.update(ip: SplitIoClient.configuration.machine_ip)
             end
           end
 

data/lib/splitclient-rb/cache/repositories/impressions/redis_repository.rb

@@ -4,9 +4,8 @@ module SplitIoClient
       module Impressions
         class RedisRepository < Repository
 
-          def initialize(adapter, config)
+          def initialize(adapter)
             @adapter = adapter
-            @config = config
           end
 
           # Store impression data in Redis
@@ -24,24 +23,24 @@ module SplitIoClient
                     'keyName' => key,
                     'bucketingKey' => bucketing_key,
                     'treatment' => treatment[:treatment],
-                    'label' => @config.labels_enabled ? treatment[:label] : nil,
+                    'label' => SplitIoClient.configuration.labels_enabled ? treatment[:label] : nil,
                     'changeNumber' => treatment[:change_number],
                     'time' => time)
               end
             end
           end
 
-          # Get random impressions from redis in batches of size @config.impressions_bulk_size,
+          # Get random impressions from redis in batches of size SplitIoClient.configuration.impressions_bulk_size,
           # delete fetched impressions afterwards
           def get_batch
             impressions = impression_keys.each_with_object([]) do |key, memo|
               ip = key.split('/')[-2] # 'prefix/sdk_lang/ip/impressions.name' -> ip
               if ip.nil?
-                @config.logger.warn("Impressions IP parse error for key: #{key}")
+                SplitIoClient.configuration.logger.warn("Impressions IP parse error for key: #{key}")
                 next
               end
               split_name = key.split('.').last
-              members = @adapter.random_set_elements(key, @config.impressions_bulk_size)
+              members = @adapter.random_set_elements(key, SplitIoClient.configuration.impressions_bulk_size)
               members.each do |impression|
                 parsed_impression = JSON.parse(impression)
 
@@ -53,11 +52,11 @@ module SplitIoClient
               end
 
               @adapter.delete_from_set(key, members)
-            end
 
+            end
             impressions
           rescue StandardError => e
-            @config.logger.error("Exception while clearing impressions cache: #{e}")
+            SplitIoClient.configuration.logger.error("Exception while clearing impressions cache: #{e}")
 
             []
           end
@@ -66,9 +65,9 @@ module SplitIoClient
 
           # Get all sets by prefix
           def impression_keys
-            @adapter.find_sets_by_prefix("#{@config.redis_namespace}/*/impressions.*")
+            @adapter.find_sets_by_prefix("#{SplitIoClient.configuration.redis_namespace}/*/impressions.*")
           rescue StandardError => e
-            @config.logger.error("Exception while fetching impression_keys: #{e}")
+            SplitIoClient.configuration.logger.error("Exception while fetching impression_keys: #{e}")
 
             []
           end

data/lib/splitclient-rb/cache/repositories/impressions_repository.rb

@@ -6,13 +6,12 @@ module SplitIoClient
         extend Forwardable
         def_delegators :@adapter, :add, :add_bulk, :get_batch, :empty?
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Impressions::MemoryRepository.new(adapter, config)
+            Repositories::Impressions::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Impressions::RedisRepository.new(adapter, config)
+            Repositories::Impressions::RedisRepository.new(adapter)
           end
         end
       end

data/lib/splitclient-rb/cache/repositories/metrics/memory_repository.rb

@@ -3,12 +3,10 @@ module SplitIoClient
     module Repositories
       module Metrics
         class MemoryRepository
-          def initialize(_ = nil, adapter, config)
+          def initialize(_ = nil, adapter)
             @counts = []
             @latencies = []
             @gauges = []
-
-            @config = config
           end
 
           def add_count(counter, delta)

data/lib/splitclient-rb/cache/repositories/metrics/redis_repository.rb

@@ -3,8 +3,7 @@ module SplitIoClient
     module Repositories
       module Metrics
         class RedisRepository < Repository
-          def initialize(adapter = nil, config)
-            @config = config
+          def initialize(adapter = nil)
             @adapter = adapter
           end
 
@@ -17,7 +16,6 @@ module SplitIoClient
 
           def add_latency(operation, time_in_ms, binary_search)
             prefixed_name = impressions_metrics_key("latency.#{operation}")
-            latencies = @adapter.find_strings_by_prefix(prefixed_name)
 
             if operation == 'sdk.get_treatment'
               @adapter.inc("#{prefixed_name}.#{binary_search.add_latency_millis(time_in_ms, true)}")

data/lib/splitclient-rb/cache/repositories/metrics_repository.rb

@@ -7,13 +7,12 @@ module SplitIoClient
         def_delegators :@adapter, :add_count, :add_latency, :add_gauge, :counts, :latencies, :gauges,
                        :clear_counts, :clear_latencies, :clear_gauges, :clear
 
-        def initialize(adapter, config)
-          @config = config
+        def initialize(adapter)
           @adapter = case adapter.class.to_s
           when 'SplitIoClient::Cache::Adapters::MemoryAdapter'
-            Repositories::Metrics::MemoryRepository.new(adapter, config)
+            Repositories::Metrics::MemoryRepository.new(adapter)
           when 'SplitIoClient::Cache::Adapters::RedisAdapter'
-            Repositories::Metrics::RedisRepository.new(adapter, config)
+            Repositories::Metrics::RedisRepository.new(adapter)
           end
         end
       end

data/lib/splitclient-rb/cache/repositories/repository.rb

@@ -12,11 +12,11 @@ module SplitIoClient
       protected
 
       def namespace_key(key = '')
-        "#{@config.redis_namespace}#{key}"
+        "#{SplitIoClient.configuration.redis_namespace}#{key}"
       end
 
       def impressions_metrics_key(key)
-        namespace_key("/#{@config.language}-#{@config.version}/#{@config.machine_ip}/#{key}")
+        namespace_key("/#{SplitIoClient.configuration.language}-#{SplitIoClient.configuration.version}/#{SplitIoClient.configuration.machine_ip}/#{key}")
       end
     end
   end

data/lib/splitclient-rb/cache/repositories/segments_repository.rb

@@ -6,11 +6,9 @@ module SplitIoClient
 
         attr_reader :adapter
 
-        def initialize(adapter, config)
+        def initialize(adapter)
           @adapter = adapter
-          @config = config
-
-          @adapter.set_bool(namespace_key('.ready'), false)
+          @adapter.set_bool(namespace_key('.ready'), false) unless SplitIoClient.configuration.mode == :consumer
         end
 
         # Receives segment data, adds and removes segements from the store

data/lib/splitclient-rb/cache/repositories/splits_repository.rb

@@ -4,16 +4,14 @@ module SplitIoClient
   module Cache
     module Repositories
       class SplitsRepository < Repository
-        SPLITS_SLICE = 10
-
         attr_reader :adapter
 
-        def initialize(adapter, config)
+        def initialize(adapter)
           @adapter = adapter
-          @config = config
-
-          @adapter.set_string(namespace_key('.splits.till'), '-1')
-          @adapter.initialize_map(namespace_key('.segments.registered'))
+          unless SplitIoClient.configuration.mode == :consumer
+            @adapter.set_string(namespace_key('.splits.till'), '-1')
+            @adapter.initialize_map(namespace_key('.segments.registered'))
+          end
         end
 
         def add_split(split)
@@ -26,16 +24,14 @@ module SplitIoClient
           @adapter.delete(namespace_key(".split.#{name}"))
         end
 
-        def get_splits(names, slice = SPLITS_SLICE)
+        def get_splits(names)
           splits = {}
-
-          names.each_slice(slice) do |splits_slice|
-            splits.merge!(
-              @adapter
-                .multiple_strings(splits_slice.map { |name| namespace_key(".split.#{name}") })
-                .map { |name, data| [name.gsub(namespace_key('.split.'), ''), data] }.to_h
-            )
-          end
+          split_names = names.reject(&:empty?).uniq.map { |name| namespace_key(".split.#{name}") }
+          splits.merge!(
+            @adapter
+              .multiple_strings(split_names)
+              .map { |name, data| [name.gsub(namespace_key('.split.'), ''), data] }.to_h
+          )
 
           splits.map do |name, data|
             parsed_data = data ? JSON.parse(data, symbolize_names: true) : nil

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -2,9 +2,8 @@ module SplitIoClient
   class ImpressionRouter
     attr_reader :router_thread
 
-    def initialize(config)
-      @config = config
-      @listener = config.impression_listener
+    def initialize
+      @listener = SplitIoClient.configuration.impression_listener
 
       return unless @listener
 
@@ -45,12 +44,12 @@ module SplitIoClient
     end
 
     def router_thread
-      @config.threads[:impression_router] = Thread.new do
+      SplitIoClient.configuration.threads[:impression_router] = Thread.new do
         loop do
           begin
             @listener.log(@queue.pop)
           rescue StandardError => error
-            @config.log_found_exception(__method__.to_s, error)
+            SplitIoClient.configuration.log_found_exception(__method__.to_s, error)
           end
         end
       end