splitclient-rb 5.0.1.pre.rc1-java → 5.0.2-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f176756b53bd301ddb1c98746e6faded243c1469
-  data.tar.gz: dfc5498bade324ade52c956a9061c4310487e35d
+  metadata.gz: d5c04717975f8f3719dab2e4b66e237a3f8f680a
+  data.tar.gz: a8b0d913af4125b8f2bfef40bd92fa45d1e26739
 SHA512:
-  metadata.gz: 62742afddd9d8c81cd4cd753e5ecdddb3af24a7e404e4e8b9faa8a5d139da284e0df873b1aa451190b1d9e5d1a8fb9acdb74b1ada2ae09538d43f580bff90974
-  data.tar.gz: 8616cc41633c2638552c44f4ea456b216bef709df4fb5728f34b8dc60287c56f07286bfd4cf76292ac9ccddf6e96f1e5df6ad47ab787794159ad15f4ee9c11a5
+  metadata.gz: 9a9ec6fb65440f0ec31df24f3e137bbe907b76a56310f0e768b49203adf1c019e25d5949ea935b66f430ec8f412575a005d74f602b776a3a5b4c8a25d5fc0b72
+  data.tar.gz: c1a72c76c15d66bd08ca076407069577b4051b39bdd1466921e5a5e209481d0bfa40ab1620b5bd5ce241a931c4af92b7cdbd7fee6ae0ae9388eedb5f2934ac04

data/CHANGES.txt

@@ -1,3 +1,6 @@
+5.0.2 (July 31st, 2018)
+- Prevents the impression thread from being started if a listener is not in place
+
 5.0.1 (July 19th, 2018)
 - Adds stop! method to the factory for gracefully stopping the SDK.
 

data/Detailed-README.md

@@ -366,7 +366,9 @@ transport_debug_enabled: true # used for log transport data (mostly http request
 
 ### Impression Listener
 
-In order to capture every single impression in your app SDK provides option called Impression Listener. It works pretty straightforward: you define a class which must have instance method called `log`, which must receive 1 argument `impression`. Let's say you have the following impression listener class:
+The SDK provides an optional featured called Impression Listener, that captures every single impression in your app.
+
+To set up an Impression Listener, define a class that implements a `log` instance method, which must receive the `impression` argument. As an example you could define your listener as follows:
 
 ```ruby
 class MyImpressionListener
@@ -376,7 +378,7 @@ class MyImpressionListener
 end
 ```
 
-Nothing fancy here, it just takes impression and logs it to the stdout. Now, to actually use this class you'll need to specify it in your config (i.e. initializer) like this:
+Nothing fancy here, the listener just takes an impression and logs it to the stdout. Now, to actually use this class you'll need to specify it as an option in your config (i.e. initializer) like this:
 
 ```ruby
 {

data/NEWS

@@ -1,3 +1,8 @@
+5.0.2
+
+Turn Impression Listener into an optional SDK feature.
+Prevents the impression thread from being started if a listener is not in place
+
 5.0.1
 
 Adding stop! method to the factory. 

data/lib/splitclient-rb/cache/routers/impression_router.rb

@@ -5,6 +5,9 @@ module SplitIoClient
     def initialize(config)
       @config = config
       @listener = config.impression_listener
+
+      return unless @listener
+
       @queue = Queue.new
       router_thread
 
@@ -16,12 +19,12 @@ module SplitIoClient
     end
 
     def add(impression)
-      @queue.push(impression)
+      enqueue(impression)
     end
 
     def add_bulk(impressions)
       impressions[:split_names].each do |split_name|
-        @queue.push(
+        enqueue(
           split_name: split_name.to_s,
           matching_key: impressions[:matching_key],
           bucketing_key: impressions[:bucketing_key],
@@ -37,6 +40,10 @@ module SplitIoClient
 
     private
 
+    def enqueue(impression)
+      @queue.push(impression) if @listener
+    end
+
     def router_thread
       @config.threads[:impression_router] = Thread.new do
         loop do

data/lib/splitclient-rb/clients/split_client.rb

@@ -144,9 +144,8 @@ module SplitIoClient
 
     def store_impression(split_name, matching_key, bucketing_key, treatment, store_impressions, attributes)
       time = (Time.now.to_f * 1000.0).to_i
-      route_impression(split_name, matching_key, bucketing_key, time, treatment, attributes) if @config.impression_listener && store_impressions
 
-      return if @config.impressions_queue_size <= 0 || !store_impressions
+      return unless @config.impressions_queue_size > 0 && store_impressions
 
       @impressions_repository.add(split_name,
         'keyName' => matching_key,
@@ -156,6 +155,9 @@ module SplitIoClient
         'time' => time,
         'changeNumber' => treatment[:change_number]
       )
+
+      route_impression(split_name, matching_key, bucketing_key, time, treatment, attributes)
+
     rescue StandardError => error
       @config.log_found_exception(__method__.to_s, error)
     end

data/lib/splitclient-rb/split_config.rb

@@ -22,6 +22,7 @@ module SplitIoClient
     # @option opts [Object] :logger a logger to user for messages from the client. Defaults to stdout
     # @option opts [Boolean] :debug_enabled (false) The value for the debug flag
     # @option opts [Int] :impressions_queue_size how big the impressions queue is before dropping impressions. -1 to disable it.
+    # @option opts [#log] :impression_listener this object will capture all impressions and process them through `#log`
     #
     # @return [type] SplitConfig with configuration options
     def initialize(opts = {})

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '5.0.1.pre.rc1'
+  VERSION = '5.0.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 5.0.1.pre.rc1
+  version: 5.0.2
 platform: java
 authors:
 - Split Software
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-07-20 00:00:00.000000000 Z
+date: 2018-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -309,9 +309,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project:
 rubygems_version: 2.6.14