splitclient-rb 4.3.0 → 4.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b62b60ce935de1b5345ec16107e6911321abf9c
-  data.tar.gz: 2ed5525256582608b165f9a42a056657fb6fc24c
+  metadata.gz: 323e8842262a2e84362ffe4285dd367d4c879eec
+  data.tar.gz: 2522f07752a4e4400c93e475d24443d7abfdbf34
 SHA512:
-  metadata.gz: 837b99afc42609f08b51eee920c0b9492da45fb93e3ddfe187f0edc454e36077684e1bef54312a3a31e529d7fba2b10730179cc7e82a88becc4dc4e9d2435acf
-  data.tar.gz: cb785d0b3152892b86fa24a7b3369247ee4d17ffd2a4e9d01452bdb3d4e7b7eedb7648793ce8eb5c9e51d3ce2911256ce1da5e9bea7ad285d90f1a6bee913708
+  metadata.gz: 69702cb3ca471b8a737ca473baa94fe1bfca33826cede3c28d1b74d7cce2cb9118d74d34ef4731508e409954a5366ea262368382edd279dcc850982c63dda1a8
+  data.tar.gz: e984e96c245b6c46069b85aa5d380101371d61a470b202fa6b712175bf2dfd80d40ccfc11c5fd055cc54e36750369490e388eed57a1ee89e9b4f9346ec45cca9

data/CHANGES.txt

@@ -1,3 +1,6 @@
+4.3.1 (Nov 10th, 2017)
+- Do not throw exception when storing impressions on reids and it is not available. Returns CONTROL instead.
+
 4.3.0 (Oct 13th, 2017)
 - Add impression listener
 - Add support for client shutdown (destroy())

data/lib/splitclient-rb/clients/split_client.rb

@@ -90,7 +90,10 @@ module SplitIoClient
 
         store_impression(
           split_name, matching_key, bucketing_key,
-          { treatment: SplitIoClient::Engine::Models::Treatment::CONTROL, label: SplitIoClient::Engine::Models::Label::EXCEPTION },
+          {
+            treatment: SplitIoClient::Engine::Models::Treatment::CONTROL,
+            label: SplitIoClient::Engine::Models::Label::EXCEPTION
+          },
           store_impressions, attributes
         )
 
@@ -109,7 +112,10 @@ module SplitIoClient
 
         store_impression(
           split_name, matching_key, bucketing_key,
-          { treatment: SplitIoClient::Engine::Models::Treatment::CONTROL, label: SplitIoClient::Engine::Models::Label::EXCEPTION },
+          {
+            treatment: SplitIoClient::Engine::Models::Treatment::CONTROL,
+            label: SplitIoClient::Engine::Models::Label::EXCEPTION
+          },
           store_impressions, attributes
         )
 
@@ -148,6 +154,8 @@ module SplitIoClient
         'time' => time,
         'changeNumber' => treatment[:change_number]
       )
+    rescue StandardError => error
+      @config.log_found_exception(__method__.to_s, error)
     end
 
     def route_impression(split_name, matching_key, bucketing_key, time, treatment, attributes)

data/lib/splitclient-rb/split_config.rb

@@ -313,10 +313,13 @@ module SplitIoClient
     # custom logger of exceptions
     #
     # @return [void]
-    def log_found_exception(caller, exn)
-      error_traceback = "#{exn.inspect} #{exn}\n\t#{exn.backtrace.join("\n\t")}"
-      error = "[splitclient-rb] Unexpected exception in #{caller}: #{error_traceback}"
-      @logger.warn(error)
+    def log_found_exception(caller, error)
+      message = ''
+
+      message << "[splitclient-rb] Unexpected exception in #{caller}: #{error.inspect} #{error}"
+      message << "\n\t#{error.backtrace.join("\n\t")}" if @debug_enabled
+
+      @logger.warn(message)
     end
 
     #

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '4.3.0'
+  VERSION = '4.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.1
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-13 00:00:00.000000000 Z
+date: 2017-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler