splitclient-rb 3.2.4 → 3.3.0.pre.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34298f62d2d0164b2706510f10e72dd4217d17d2
-  data.tar.gz: ba8aecd65f0c9e2df7a098e3866f6723865e8c78
+  metadata.gz: 8341508fbe2e85f51f48b68830a173dff7f8b87f
+  data.tar.gz: 6d199d8c2369cd469aba09869614009a38d6723a
 SHA512:
-  metadata.gz: 78ae2f847f2f3ff814aa68078436708a61f2060322e13bd2b622ab473cfc674bff77f86085fd6fa78569752f5b1521f276fd1d873775eeec04235ee7ea0b3029
-  data.tar.gz: 812807e946bac737c30033887eab25323f11f001c7d380c3e2a8796c8c5933bc74790e8fce4f118b9b086bcc5e0661ec9ea19d4b878e0f038156418e20214247
+  metadata.gz: 00372ba9e41399940663fc1ef0a8bb0128f5a1cc4dd0e178c619cf83c57446eb025983f7973b278e18b96e2abf15421aa5ffb056445a78584c50df07d290116e
+  data.tar.gz: 110fce581be2047a48453e336e26bb0125fb2f5753b5cab70fb313f522d061fa1599375887313162778266ad2562fa5d602e4b3b97ac8115fd73e365b29c3863

data/CHANGES.txt

@@ -1,3 +1,6 @@
+3.3.0
+- Add support for traffic allocation
+
 3.2.4
 - Fix Faraday compability issue (now compatible with Faraday 0.8.9)
 - Provide an interface to run SplitAdapter(start and resume), can be used to resurrect threads in Unicorn and Passenger servers

data/NEWS

@@ -1,3 +1,7 @@
+3.3.0
+
+Add support for traffic allocation
+
 3.1.0
 
 Now supporting Redis as a cache adapter

data/lib/engine/models/label.rb

@@ -2,10 +2,11 @@ module SplitIoClient
   module Engine
     module Models
       class Label
-        ARCHIVED = 'archived'
-        NO_RULE_MATCHED = 'no rule matched'
-        EXCEPTION = 'exception'
-        KILLED = 'killed'
+        ARCHIVED = 'archived'.freeze
+        NO_RULE_MATCHED = 'no rule matched'.freeze
+        EXCEPTION = 'exception'.freeze
+        KILLED = 'killed'.freeze
+        NOT_IN_SPLIT = 'not in split'.freeze
       end
     end
   end

data/lib/engine/parser/condition.rb

@@ -3,6 +3,8 @@ module SplitIoClient
   # acts as dto for a condition structure
   #
   class Condition < NoMethodError
+    TYPE_ROLLOUT = 'ROLLOUT'.freeze
+    TYPE_WHITELIST = 'WHITELIST'.freeze
     #
     # definition of the condition
     #
@@ -36,6 +38,12 @@ module SplitIoClient
       @data[:matcherGroup][:matchers]
     end
 
+    #
+    # @return [string] condition type
+    def type
+      @data[:conditionType]
+    end
+
     def negation_matcher(matcher)
       NegationMatcher.new(matcher)
     end

data/lib/engine/parser/partition.rb

@@ -1,5 +1,4 @@
 module SplitIoClient
-
   #
   # acts as dto for a partition structure
   #
@@ -30,8 +29,7 @@ module SplitIoClient
     #
     # @return [boolean] true if the partition is empty false otherwise
     def is_empty?
-      @data.empty? ? true : false
+      @data.empty?
     end
   end
-
-end
+end

data/lib/engine/parser/split_treatment.rb

@@ -21,13 +21,27 @@ module SplitIoClient
         private
 
         def match(split, keys, attributes)
+          in_rollout = false
+          key = keys[:bucketing_key] ? keys[:bucketing_key] : keys[:matching_key]
+
           split[:conditions].each do |c|
             condition = SplitIoClient::Condition.new(c)
 
             next if condition.empty?
 
+            if !in_rollout && condition.type == SplitIoClient::Condition::TYPE_ROLLOUT
+              if split[:trafficAllocation] < 100
+                bucket = Splitter.bucket(Splitter.hash(key, split[:trafficAllocationSeed].to_i))
+
+                if bucket >= split[:trafficAllocation]
+                  return treatment(Models::Label::NOT_IN_SPLIT, @default_treatment, split[:changeNumber])
+                end
+              end
+
+              in_rollout = true
+            end
+
             if matcher_type(condition).match?(keys[:matching_key], attributes)
-              key = keys[:bucketing_key] ? keys[:bucketing_key] : keys[:matching_key]
               result = Splitter.get_treatment(key, split[:seed], condition.partitions)
 
               if result.nil?

data/lib/splitclient-rb/clients/split_client.rb

@@ -77,34 +77,50 @@ module SplitIoClient
       rescue StandardError => error
         @config.log_found_exception(__method__.to_s, error)
 
+        store_impression(
+          split_name, matching_key, bucketing_key,
+          { treatment: SplitIoClient::Treatments::CONTROL, label: Models::Label::EXCEPTION },
+          store_impressions
+        )
+
         return parsed_treatment(multiple, treatment_label_change_number)
       end
 
       begin
         latency = (Time.now - start) * 1000.0
-        if @config.impressions_queue_size > 0 && store_impressions && split
-          # Disable impressions if @config.impressions_queue_size == -1
-          @impressions_repository.add(split_name,
-            'keyName' => matching_key,
-            'bucketingKey' => bucketing_key,
-            'treatment' => treatment_label_change_number[:treatment],
-            'label' => @config.labels_enabled ? treatment_label_change_number[:label] : nil,
-            'time' => (Time.now.to_f * 1000.0).to_i,
-            'changeNumber' => treatment_label_change_number[:change_number]
-          )
-        end
+        # Disable impressions if @config.impressions_queue_size == -1
+        split && store_impression(split_name, matching_key, bucketing_key, treatment_label_change_number, store_impressions)
 
         # Measure
         @adapter.metrics.time('sdk.get_treatment', latency)
       rescue StandardError => error
         @config.log_found_exception(__method__.to_s, error)
 
+        store_impression(
+          split_name, matching_key, bucketing_key,
+          { treatment: SplitIoClient::Treatments::CONTROL, label: Models::Label::EXCEPTION },
+          store_impressions
+        )
+
         return parsed_treatment(multiple, treatment_label_change_number)
       end
 
       parsed_treatment(multiple, treatment_label_change_number)
     end
 
+    def store_impression(split_name, matching_key, bucketing_key, treatment, store_impressions)
+      return if @config.impressions_queue_size <= 0 || !store_impressions
+
+      @impressions_repository.add(split_name,
+        'keyName' => matching_key,
+        'bucketingKey' => bucketing_key,
+        'treatment' => treatment[:treatment],
+        'label' => @config.labels_enabled ? treatment[:label] : nil,
+        'time' => (Time.now.to_f * 1000.0).to_i,
+        'changeNumber' => treatment[:change_number]
+      )
+    end
+
     def keys_from_key(key)
       case key.class.to_s
       when 'Hash'

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '3.2.4'
+  VERSION = '3.3.0-rc1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 3.2.4
+  version: 3.3.0.pre.rc1
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-24 00:00:00.000000000 Z
+date: 2017-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -330,9 +330,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.2