splitclient-rb 3.2.4.pre.rc2 → 3.2.4.pre.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f11642bc9c67b056c263522562fc62fcbbe4afb
-  data.tar.gz: 42b81c78e59f1003b0ebf9d5bee841369b5a97f5
+  metadata.gz: 223bd7fc20de406557f2f8a839ba8d85e27b4e52
+  data.tar.gz: 18ce388d744623aafcc90fb03cf2db3fc3b47900
 SHA512:
-  metadata.gz: b6264ad8c6f755169f01e763baa81451ebece87a0610460561ef18026d29ddafe768f1166577f16d8c5def5cf7ca3db6a93d2cabda5b053bfc76964260b351a7
-  data.tar.gz: 717d297e6483ab4c59e512787b7ad5f959c36ad66b7574114072918825b91bc43d87a9ae6126421181e343940923599552d08ca63f9e085679f5fea3b89338e9
+  metadata.gz: fd7ef95547add97314006955983b49c14f51fa0e4886601ef8c3bfb0b7c23b842074e774a083523a0722718214b0087d5f8465448034c230ca5ecfc7451a2163
+  data.tar.gz: d61aaabb2ec095d7fbcd7d32d6e975362a12ad116f2768fb62c6e1f07ae70d19a684996c2150a256fbd050f1f6a105bcda94c04a61696c4fb24651dc36e9bba3

data/CHANGES.txt

@@ -1,7 +1,9 @@
-
 3.2.4
 - Fix Faraday compability issue (now compatible with Faraday 0.8.9)
 - Provide an interface to run SplitAdapter(start and resume), can be used to resurrect threads in Unicorn and Passenger servers
+- Allow passing non-string values to get_treatment/get_treatments
+- Better logging when returning CONTROL and label:Exception as well as when restarting threads
+- Add exception logging when failed to clear impressions keys or fetch impressions keys
 
 3.2.3
 - Fix Redis namespace issue to align with the spec

data/Detailed-README.md

@@ -229,6 +229,36 @@ rescue SplitIoClient::SDKBlockerTimeoutExpiredException
 end
 ```
 
+#### Unicorn
+
+When using Unicorn without Redis (i.e. in memory mode) it's highly recommended to include the startup code above inside Unicorn's `after_fork` hook:
+
+*unicorn.rb*
+```ruby
+# Unicorn configuration
+after_fork do
+  options = {
+    connection_timeout: 10,
+    read_timeout: 5,
+    features_refresh_rate: 120,
+    segments_refresh_rate: 120,
+    metrics_refresh_rate: 360,
+    impressions_refresh_rate: 360,
+    logger: Logger.new('logfile.log'),
+    cache_adapter: :redis,
+    mode: :standalone,
+    redis_url: 'redis://127.0.0.1:6379/0'
+  }
+  begin
+    split_client = SplitIoClient::SplitFactoryBuilder.build('YOUR_API_KEY', options).client
+  rescue SplitIoClient::SDKBlockerTimeoutExpiredException
+    # Some arbitrary actions
+  end
+end
+```
+
+When initializing the SDK this way, SDK will only run HTTP requests from workers, not master process.
+
 #### IMPORTANT
 
 For now, SDK does not support both `producer` mode and `ready`. You must either run SDK in `standalone` mode, or do not use `ready` option.

data/lib/cache/repositories/impressions/redis_repository.rb

@@ -59,6 +59,8 @@ module SplitIoClient
             end
 
             impressions
+          rescue StandardError => e
+            @config.logger.error("Exception while clearing impressions cache: #{e}")
           end
 
           private
@@ -66,6 +68,8 @@ module SplitIoClient
           # Get all sets by prefix
           def impression_keys
             @adapter.find_sets_by_prefix("#{@config.redis_namespace}/*/impressions.*")
+          rescue StandardError => e
+            @config.logger.error("Exception while fetching impression_keys: #{e}")
           end
         end
       end

data/lib/cache/stores/segment_store.rb

@@ -30,6 +30,7 @@ module SplitIoClient
 
         def segments_thread
           @sdk_blocker.segments_thread = Thread.new do
+            @config.logger.info('Starting segments fetcher service')
             @config.block_until_ready > 0 ? blocked_store : unblocked_store
           end
         end

data/lib/cache/stores/split_store.rb

@@ -30,6 +30,7 @@ module SplitIoClient
 
         def splits_thread
           @sdk_blocker.splits_thread = Thread.new do
+            @config.logger.info('Starting splits fetcher service')
             loop do
               store_splits
 

data/lib/splitclient-rb/clients/split_client.rb

@@ -67,6 +67,7 @@ module SplitIoClient
         split = multiple ? split_data : @splits_repository.get_split(split_name)
 
         if split.nil?
+          @config.logger.debug("split_name: #{split_name} does not exist. Returning CONTROL")
           return parsed_treatment(multiple, treatment_label_change_number)
         else
           treatment_label_change_number = SplitIoClient::Engine::Parser::SplitTreatment.new(@segments_repository).call(
@@ -107,9 +108,9 @@ module SplitIoClient
     def keys_from_key(key)
       case key.class.to_s
       when 'Hash'
-        key.values_at(:bucketing_key, :matching_key)
-      when 'String'
-        [nil, key]
+        key.values_at(:bucketing_key, :matching_key).map { |k| k.nil? ? nil : k.to_s }
+      else
+        [nil, key].map { |k| k.nil? ? nil : k.to_s }
       end
     end
 

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '3.2.4-rc2'
+  VERSION = '3.2.4-rc3'
 end

data/lib/splitclient-rb.rb

@@ -3,7 +3,6 @@ require 'splitclient-rb/version'
 require 'exceptions/sdk_blocker_timeout_expired_exception'
 require 'cache/adapters/memory_adapters/map_adapter'
 require 'cache/adapters/memory_adapters/queue_adapter'
-require 'cache/adapters/memory_adapters/sized_queue_adapter'
 require 'cache/adapters/memory_adapter'
 require 'cache/adapters/redis_adapter'
 require 'cache/repositories/repository'

data/splitclient-rb.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "json", "~> 1.8"
   spec.add_runtime_dependency "thread_safe"
-  spec.add_runtime_dependency "concurrent-ruby"
+  spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
   spec.add_runtime_dependency "faraday"
   spec.add_runtime_dependency "faraday-http-cache"
   spec.add_runtime_dependency "faraday_middleware"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 3.2.4.pre.rc2
+  version: 3.2.4.pre.rc3
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -154,16 +154,16 @@ dependencies:
   name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -255,7 +255,6 @@ files:
 - lib/cache/adapters/memory_adapter.rb
 - lib/cache/adapters/memory_adapters/map_adapter.rb
 - lib/cache/adapters/memory_adapters/queue_adapter.rb
-- lib/cache/adapters/memory_adapters/sized_queue_adapter.rb
 - lib/cache/adapters/redis_adapter.rb
 - lib/cache/repositories/impressions/memory_repository.rb
 - lib/cache/repositories/impressions/redis_repository.rb

data/lib/cache/adapters/memory_adapters/sized_queue_adapter.rb

@@ -1,38 +0,0 @@
-module SplitIoClient
-  module Cache
-    module Adapters
-      module MemoryAdapters
-        # Memory adapter implementation, which stores everything inside sized queue
-        class SizedQueueAdapter
-          def initialize(size)
-            @size = size
-            @queue = SizedQueue.new(queue_size)
-          end
-
-          # Adds data to queue in non-blocking mode
-          def add_to_queue(data)
-            # IMPORTANT: this requires Ruby >= 2.2, consider changing implementation
-            @queue.push(data, true)
-          end
-
-          # Get all items from the queue
-          def clear
-            items = []
-
-            loop { items << @queue.pop(true) }
-          rescue ThreadError
-            # Last queue item reached
-            items
-          end
-
-          private
-
-          # Return 1 to prevent an exception
-          def queue_size
-            @size <= 0 ? 1 : @size
-          end
-        end
-      end
-    end
-  end
-end