splitclient-rb 3.1.0.pre.rc6 → 3.1.0.pre.rc7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58d09e0e5a6d94a0a79c0fc5b4cea7a32e7bdd1d
-  data.tar.gz: 8bdc8dbc17fd1cfd7e6fa1d2df4445d65638d139
+  metadata.gz: 466e08e89ced1060fc54b61943291949d592de14
+  data.tar.gz: d3dc48c5aadb358a573cec5d7774d173edcf0673
 SHA512:
-  metadata.gz: 584a396de37a5e5783f958bd6e3f93473af6b9bfc033aa47099997e9bd0a695ed05aca65e0880d5f43897928f9618cd175bd1a12ec8cb0a34b0fc7d4e799d57e
-  data.tar.gz: ec4bfc56c8fa786ba28d547d0a8198f6c4589e8ad89068f4a1fd64063bca796d7657d5e012f1b30da7366708044c221f6870a2942c25a1268d861ef74a30438a
+  metadata.gz: 929793f1ddf099968d42c1ff6397b127cf5e11791e66f702b44304374baed4b16600e5a2185941b71e8e4416999175f6530cfdd7d85dc33523dc17331c4ddd55
+  data.tar.gz: e992dcbac1d607b045da85132bdb913e72cd8b4d4cf98e12a002f97d3a2275488a96cb544b2497451515ffe1d63414b229b4810e1c38ad09ed2370fe92ce448a

data/CHANGES.txt

@@ -1,6 +1,7 @@
 3.1.0
 - Add RedisAdapter
 - adds manager.split_names()
+- add impressions_queue_size to prevent memory leak when Threads pauses due to 'smart' fork.
 
 3.0.3
 

data/README.md

@@ -104,6 +104,8 @@ The following values can be customized:
 
 **impressions_refresh_rate** : The SDK sends information on who got what treatment at what time back to Split servers to power analytics. This parameter controls how often this data is sent to Split servers in seconds
 
+**impressions_queue_size** : The size of the impressions queue. -1 to disable impressions.
+
 *default value* = `60`
 
 **debug_enabled** : Enables extra logging

data/lib/engine/api/segments.rb

@@ -49,7 +49,7 @@ module SplitIoClient
 
           segments << segment_content
         else
-          @config.logger.error('Unexpected result from API call')
+          @config.logger.error("Unexpected result from API Call for Segment #{name} status #{segment.status.to_s} since #{since.to_s}")
           @metrics.count(prefix + '.status.' + segment.status.to_s, 1)
         end
 

data/lib/engine/api/splits.rb

@@ -22,7 +22,7 @@ module SplitIoClient
         else
           @metrics.count(prefix + '.status.' + splits.status.to_s, 1)
 
-          @config.logger.error('Unexpected result from API call')
+          @config.logger.error('Unexpected result from Splits API call')
         end
 
         latency = (Time.now - start) * 1000.0

data/lib/engine/impressions/impressions.rb

@@ -18,10 +18,11 @@ module SplitIoClient
     #
     # initializes the class
     #
-    # @param max [int] max number of cached entries
-    def initialize(max)
-      @queue = Queue.new
-      @max_number_of_keys = max
+    # @param config [SplitConfig] the config object
+    def initialize(config)
+      @config = config
+      @queue = SizedQueue.new(config.impressions_queue_size <= 0? 1 : config.impressions_queue_size)
+      @max_number_of_keys = config.impressions_queue_size
     end
 
     #
@@ -34,8 +35,16 @@ module SplitIoClient
     #
     # @return void
     def log(id, feature, treatment, time)
+      return if @max_number_of_keys <= 0 # shortcut to desable impressions
       impressions = KeyImpressions.new(id, treatment, time)
-      @queue << {feature: feature, impressions: impressions}
+      begin 
+        @queue.push( {feature: feature, impressions: impressions} , true ) # don't wait if queue is full
+      rescue ThreadError
+        @random_sampler ||=  Random.new
+        if @random_sampler.rand(1..1000) <= 2 # log only 0.2 % of the time.
+          @config.logger.warn("Dropping impressions. Current size is #{@max_number_of_keys}. Consider increasing impressions_queue_size")
+        end
+      end
     end
 
     #

data/lib/engine/parser/split_adapter.rb

@@ -42,7 +42,7 @@ module SplitIoClient
     def initialize(api_key, config, splits_repository, segments_repository, sdk_blocker)
       @api_key = api_key
       @config = config
-      @impressions = Impressions.new(100)
+      @impressions = Impressions.new(@config)
       @metrics = Metrics.new(100)
 
       @splits_repository = splits_repository

data/lib/splitclient-rb/split_config.rb

@@ -21,6 +21,7 @@ module SplitIoClient
     # @option opts [Int] :impressions_refresh_rate
     # @option opts [Object] :logger a logger to user for messages from the client. Defaults to stdout
     # @option opts [Boolean] :debug_enabled (false) The value for the debug flag
+    # @option opts [Int] :impressions_queue_size how big the impressions queue is before dropping impressions. -1 to disable it.
     #
     # @return [type] SplitConfig with configuration options
     def initialize(opts = {})
@@ -35,6 +36,7 @@ module SplitIoClient
       @segments_refresh_rate = opts[:segments_refresh_rate] || SplitConfig.default_segments_refresh_rate
       @metrics_refresh_rate = opts[:metrics_refresh_rate] || SplitConfig.default_metrics_refresh_rate
       @impressions_refresh_rate = opts[:impressions_refresh_rate] || SplitConfig.default_impressions_refresh_rate
+      @impressions_queue_size = opts[:impressions_queue_size] || SplitConfig.default_impressions_queue_size
       @logger = opts[:logger] || SplitConfig.default_logger
       @debug_enabled = opts[:debug_enabled] || SplitConfig.default_debug
       @transport_debug_enabled = opts[:transport_debug_enabled] || SplitConfig.default_debug
@@ -113,6 +115,12 @@ module SplitIoClient
     attr_reader :metrics_refresh_rate
     attr_reader :impressions_refresh_rate
 
+    #
+    # Wow big the impressions queue is before dropping impressions. -1 to disable it.
+    #
+    # @return [Integer]
+    attr_reader :impressions_queue_size
+
     attr_reader :redis_url
 
     #
@@ -185,6 +193,10 @@ module SplitIoClient
       60
     end
 
+    def self.default_impressions_queue_size
+      5000
+    end
+
     #
     # The default logger object
     #

data/lib/splitclient-rb/split_factory.rb

@@ -200,6 +200,9 @@ module SplitIoClient
           begin
             @adapter.impressions.log(matching_key, split_name, result, (Time.now.to_f * 1000.0))
             latency = (Time.now - start) * 1000.0
+
+            # Measure
+            @adapter.metrics.time("sdk.get_treatment", latency)
           rescue StandardError => error
             @config.log_found_exception(__method__.to_s, error)
           end

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '3.1.0-rc6'
+  VERSION = '3.1.0-rc7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 3.1.0.pre.rc6
+  version: 3.1.0.pre.rc7
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2016-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler