splitclient-rb 3.1.0.pre.rc11 → 3.1.0.pre.rc12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 02331c7576d5207396d36d2f35da18b3a68f0216
-  data.tar.gz: e7b45fedc47e7b79ab31005f0c695c3723f52479
+  metadata.gz: 792c1c774edec245bff63e2a6bc6a400df5b3e66
+  data.tar.gz: 73b1d0d2087fa5c75bfd3adb4e38bbcd83b73584
 SHA512:
-  metadata.gz: 9949de92f9ffa311d873ebb6e2ed18ddcf402ca55333a67739438bed1bde4d4aa8c3934d62000e75f0570964e9281c1b7715da7e2d419c99e65e56f323d58447
-  data.tar.gz: b1a2bad851319e62fe343558b99252deb967b43ea60631610f7cdc943d8bccd6298dbfc7cbef4c872bb1ebf16cf316c1e05ea8a7f3be306af9ab4c091490e033
+  metadata.gz: d51c707dcad7e97aab05edb06651f11b9265af9ee2769eb7d92684dfc189fa90dd546fbf895dbeead0163e798249a13b20af5e8351a20ead2b40a5fc94a1e40f
+  data.tar.gz: e27d3b2122d0b362e5c3d7455545720965f2a8542d194e0c9fa8d2ea9bd406bbb3c4b8db2eaf3815fc65d48c419f0b64fe89fce2eabd6c61ef9a46e2d9a64d5f

data/CHANGES.txt

@@ -3,6 +3,7 @@
 - adds manager.split_names()
 - add impressions_queue_size to prevent memory leak when Threads pauses due to 'smart' fork.
 - do not report latencies for get_treatment is array is all zeros
+- Fix deduplication problem when posting impressions
 
 3.0.3
 

data/lib/cache/repositories/impressions/redis_repository.rb

@@ -40,6 +40,7 @@ module SplitIoClient
                   impressions: parsed_impression.reject { |k, _| k == 'split_name' }
                 }
               end
+
               @adapter.delete_from_set(key, members)
             end
 

data/lib/engine/parser/split_adapter.rb

@@ -135,6 +135,9 @@ module SplitIoClient
     #
 
     def metrics_sender
+      # TODO: Send metrics in main thread for test ENV
+      return if ENV['SPLITCLIENT_ENV'] == 'test'
+
       Thread.new do
         loop do
           begin
@@ -158,6 +161,9 @@ module SplitIoClient
 
       @config.logger.info("Starting impressions service...")
 
+      # TODO: Send impressions in main thread for test ENV
+      return if ENV['SPLITCLIENT_ENV'] == 'test'
+
       Thread.new do
         loop do
           begin
@@ -170,6 +176,7 @@ module SplitIoClient
           end
         end
       end
+
       @config.logger.info("Started impressions service")
     end
 
@@ -205,40 +212,37 @@ module SplitIoClient
 
     # REFACTOR
     def impressions_array(impressions = nil)
-      impressions_data = impressions || @impressions_repository
-      popped_impressions = impressions_data.clear
-      test_impression_array = []
-      filtered_impressions = []
-      keys_treatments_seen = []
+      popped_impressions = impressions ? impressions : @impressions_repository.clear
+      test_impression_array, filtered_impressions, keys_treatments_seen = [], [], []
 
-      if !popped_impressions.empty?
-        popped_impressions.each do |item|
-          item_hash = "#{item[:impressions]['key_name']}:#{item[:impressions]['treatment']}"
+      return [] if popped_impressions.empty?
 
-          next if keys_treatments_seen.include?(item_hash)
+      popped_impressions.each do |item|
+        item_hash = "#{item[:feature]}:#{item[:impressions]['key_name']}:#{item[:impressions]['treatment']}"
 
-          keys_treatments_seen << item_hash
-          filtered_impressions << item
-        end
+        next if keys_treatments_seen.include?(item_hash)
 
-        return [] unless filtered_impressions
-
-        features = filtered_impressions.map { |i| i[:feature] }.uniq
-        test_impression_array = features.each_with_object([]) do |feature, memo|
-          current_impressions = filtered_impressions.select { |i| i[:feature] == feature }
-          current_impressions.map! do |i|
-            {
-              keyName: i[:impressions]['key_name'],
-              treatment: i[:impressions]['treatment'],
-              time: i[:impressions]['time']
-            }
-          end
+        keys_treatments_seen << item_hash
+        filtered_impressions << item
+      end
 
-          memo << {
-            testName: feature,
-            keyImpressions: current_impressions
+      return [] if filtered_impressions.empty?
+
+      features = filtered_impressions.map { |i| i[:feature] }.uniq
+      test_impression_array = features.each_with_object([]) do |feature, memo|
+        current_impressions = filtered_impressions.select { |i| i[:feature] == feature }
+        current_impressions.map! do |i|
+          {
+            keyName: i[:impressions]['key_name'],
+            treatment: i[:impressions]['treatment'],
+            time: i[:impressions]['time']
           }
         end
+
+        memo << {
+          testName: feature,
+          keyImpressions: current_impressions
+        }
       end
 
       test_impression_array

data/lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '3.1.0-rc11'
+  VERSION = '3.1.0-rc12'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: splitclient-rb
 version: !ruby/object:Gem::Version
-  version: 3.1.0.pre.rc11
+  version: 3.1.0.pre.rc12
 platform: ruby
 authors:
 - Split Software
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2016-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler