split_cacheable 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 514a9d878ce909f2c3de0c556c52caf32804cc75
-  data.tar.gz: 0ddd41fcdb78e194904ab73a07cd69c7d83ee66d
+  metadata.gz: 88bf6a45b6ca1479a616341ae2e5ac7ed63c2eee
+  data.tar.gz: c091304482e6a064c71c9759e615cf4eae60a157
 SHA512:
-  metadata.gz: f781f6ea770b92cfdc324e6683f56eb849bb17df545c9ee1f19b65d19aff7baae0d349333afcb5306e8f3be11ac16320fed8ca2e7ecac77ad620a116360b4e0e
-  data.tar.gz: 4e1510714732bc8d7c5a240acbfc418323a89854e9d098085fcbe89d1a6ed59aaee0e12505470fba6fc0db8f72b09fba3e4fec5513af3c6f979b26c86b6c912d
+  metadata.gz: f989aae4a469c7aa4c5fc3a0f7503b7b6fdadfb27befef780c55cc3d2e88f4f14a78ab92de4f72fbb91b5487e33a9b3d89b204ede51eb438a959640a026104c5
+  data.tar.gz: f6248284e6c30814e336c7e0e8094ce499509d82f6b01fea398ac3338ffb4552c85a132e5bb45dad264703434edba625129366ac2721701254f4be63bf6491a7

data/.travis.yml

@@ -1,3 +1,4 @@
+sudo: false
 language: ruby
 rvm:
   - 2.0.0

data/lib/split_cacheable/version.rb

@@ -1,5 +1,5 @@
 module Split
 	module Cacheable
-		VERSION = "1.0.3"
+		VERSION = "1.0.4"
 	end
 end

data/lib/split_cacheable.rb

@@ -67,7 +67,7 @@ module Split
             # Use this to clear all your action_caches
             def get_all_possible_variations
                 test_variations = Array.new
-                active_tests.each { |test_obj|  
+                active_tests.each { |test_obj|
                     split_test = Split::ExperimentCatalog.find(test_obj[:test_name])
                     if split_test
                         test_variations << split_test.alternatives.map { |alternative|
@@ -83,8 +83,12 @@ module Split
                     test_variations[0].unshift(DEFAULT_KEY)
                     return test_variations[0]
                 else
-                    first_test = test_variations.shift
-                    all_variations = first_test.product(*test_variations).map{|a| a.join("/")}
+                    all_variations = []
+                    test_variations.each.with_index(1) do |value, index|
+                        test_variations.combination(index).each do |set|
+                            all_variations += set.first.product(*set[1..-1]).map{|a| a.join("/")}
+                        end
+                    end
                     all_variations.unshift(DEFAULT_KEY)
                     return all_variations
                 end

data/spec/cacheable_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Split::Cacheable do
-    ALL_VARIATIONS = [Split::Cacheable::Adapter::DEFAULT_KEY, "test_1/old/test_2/left", "test_1/old/test_2/right", "test_1/new/test_2/left", "test_1/new/test_2/right"]
+    ALL_VARIATIONS = [Split::Cacheable::Adapter::DEFAULT_KEY, "test_1/old", "test_1/new", "test_2/left", "test_2/right", "test_1/old/test_2/left", "test_1/old/test_2/right", "test_1/new/test_2/left", "test_1/new/test_2/right"]
 
     it "should return the default variation if there is no request" do
         expect(Split::Cacheable::Adapter.new(TestControllerWithoutRequest.new, :index).get_current_variations).to eql Split::Cacheable::Adapter::DEFAULT_KEY
@@ -35,5 +35,9 @@ describe Split::Cacheable do
         it "should return one test plus the default key when there is one test" do
             expect(Split::Cacheable::Adapter.new(TestControllerWithOneVariation.new, :index).get_all_possible_variations).to eql [Split::Cacheable::Adapter::DEFAULT_KEY, "test_1/old", "test_1/new"]
         end
+
+        it "should return all possible variations of the cachekey when controller has multiple tests on same action" do
+            expect(Split::Cacheable::Adapter.new(TestControllerWithRequestAndMultiTestOnSameAction.new, :index).get_all_possible_variations).to eql ALL_VARIATIONS
+        end
     end
 end

data/spec/spec_helper.rb

@@ -80,4 +80,9 @@ class TestControllerWithRequestAndProc < TestControllerWithRequest
     def mobile_device?
         @is_mobile
     end
+end
+
+class TestControllerWithRequestAndMultiTestOnSameAction < TestControllerWithRequest
+    cacheable_ab_test :test_1, :only => :index
+    cacheable_ab_test :test_2, :only => :index
 end

data/split_cacheable.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "split", ">=  0.7.1"
+  spec.add_dependency "split", "~> 1.0.0"
   spec.add_dependency "activesupport", ">= 3.2.17"
 
   spec.add_development_dependency "rspec", ">= 2.14"

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: split_cacheable
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Daniel Schwartz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-05 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: split
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -146,3 +146,4 @@ summary: We use action caching in Rails 3 to cache both our standard and mobile
 test_files:
 - spec/cacheable_spec.rb
 - spec/spec_helper.rb
+has_rdoc: