split 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76d9f44d0d50f07ea46e299f93bbb5bdb1333b8b
-  data.tar.gz: 40e88a5a32652b2acbd049562810fb8c8da03da4
+  metadata.gz: c5fbcc8e3abf30d53af50aa09b77ceab245d58a1
+  data.tar.gz: 0b576e850d6d066a06aaf599b0970622f22c1041
 SHA512:
-  metadata.gz: c77ff217b8bdf985904c5949b7d401b479e516d6035f1e94ed50aebab5637bf3df9b9d4d22f9aa815a2c8f3a6d54c4cca66a71d4b43aa47c981ffda530a07d8f
-  data.tar.gz: 3bcacf988dbe704ca2460e681a1f0531fa1ca47486c4239d6e6db38234226b23186d55787e7bafefc8cfa9aeff12ce0400bbc6b1a83ed6166e89c9fca491711c
+  metadata.gz: 9a05fd38b874ffa595a76445673c3916c9d00835b641b17416fc41e48eadb731c13377e886889dbecc90aa88c1f2a6264ae11cdb33d9a41043ffde999355b8b1
+  data.tar.gz: 6491c8f886f1b90e90df207103c2fd52c545ae3f9219f1e43f10c67f2d4b15d57542eb7cb27ace064e58f9163f20938dbeb89d7a115b91ed205e28716f7e04dc

data/.travis.yml

@@ -1,13 +1,38 @@
 language: ruby
 rvm:
+  - 1.9.3
+  - 2.0
+  - 2.1
+  - 2.2.0
+  - 2.2.2
   - 2.4.1
 
 gemfile:
   - gemfiles/4.2.gemfile
   - gemfiles/5.0.gemfile
+  - gemfiles/5.1.gemfile
+
+matrix:
+  exclude:
+  - rvm: 1.9.3
+    gemfile: gemfiles/5.0.gemfile
+  - rvm: 1.9.3
+    gemfile: gemfiles/5.1.gemfile
+  - rvm: 2.0
+    gemfile: gemfiles/5.0.gemfile
+  - rvm: 2.0
+    gemfile: gemfiles/5.1.gemfile
+  - rvm: 2.1
+    gemfile: gemfiles/5.0.gemfile
+  - rvm: 2.1
+    gemfile: gemfiles/5.1.gemfile
+  - rvm: 2.2.0
+    gemfile: gemfiles/5.0.gemfile
+  - rvm: 2.2.0
+    gemfile: gemfiles/5.1.gemfile
 
 before_install:
-  - gem install bundler
+  - gem update --system && gem install bundler
 
 script:
   - RAILS_ENV=test bundle exec rake spec && bundle exec codeclimate-test-reporter

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 3.1.1 (August 30th, 2017)
+
+Bugfixes:
+
+- Bring back support for ruby 1.9.3 and greater (rubygems 2.0.0 or greater now required) (@patbl, #498)
+
+Misc:
+
+- Document testing with RSpec (@eliotsykes, #495)
+
 ## 3.1.0 (August 14th, 2017)
 
 Features:

data/README.md

@@ -1,4 +1,4 @@
-# [Split](http://libraries.io/rubygems/split) 
+# [Split](http://libraries.io/rubygems/split)
 
 [![Gem Version](https://badge.fury.io/rb/split.svg)](http://badge.fury.io/rb/split)
 [![Build Status](https://secure.travis-ci.org/splitrb/split.svg?branch=master)](http://travis-ci.org/splitrb/split)
@@ -18,7 +18,7 @@ Split is designed to be hacker friendly, allowing for maximum customisation and
 
 ### Requirements
 
-Split currently requires Ruby 1.9.2 or higher. If your project requires compatibility with Ruby 1.8.x and Rails 2.3, please use v0.8.0.
+Split currently requires Ruby 1.9.3 or higher. If your project requires compatibility with Ruby 1.8.x and Rails 2.3, please use v0.8.0.
 
 Split uses Redis as a datastore.
 
@@ -150,6 +150,36 @@ In the event you want to disable all tests without having to know the individual
 
 It is not required to send `SPLIT_DISABLE=false` to activate Split.
 
+To aid testing with RSpec, write `split_helper.rb` and call `use_ab_test(alternatives_by_experiment)` in your specs as instructed below:
+
+```ruby
+# Recommended path for this file is 'spec/support/split_helper.rb', and you will need to ensure it
+# is `require`-d by rails_helper.rb or spec_helper.rb
+module SplitHelper
+
+  # Usage:
+  #
+  # Force a specific experiment alternative to always be returned:
+  #   use_ab_test(signup_form: "single_page")
+  #
+  # Force alternatives for multiple experiments:
+  #   use_ab_test(signup_form: "single_page", pricing: "show_enterprise_prices")
+  #
+  def use_ab_test(alternatives_by_experiment)
+    allow_any_instance_of(Split::Helper).to receive(:ab_test) do |_receiver, experiment|
+      alternative =
+        alternatives_by_experiment.fetch(experiment) { |key| raise "Unknown experiment '#{key}'" }
+    end
+  end
+end
+
+RSpec.configure do |config|
+  # Make the `use_ab_test` method available to all specs:
+  config.include SplitHelper
+end
+```
+
+
 ### Starting experiments manually
 
 By default new A/B tests will be active right after deployment. In case you would like to start new test a while after
@@ -625,7 +655,7 @@ Once you finish one of the goals, the test is considered to be completed, and fi
 
 #### Combined Experiments
 If you want to test how how button color affects signup *and* how it affects login, at the same time. Use combined tests
-Configure like so 
+Configure like so
 ```ruby
   Split.configuration.experiments = {
         :button_color_experiment => {
@@ -646,8 +676,8 @@ Finish each combined test as normal
    ab_finished(:button_color_on_signup)
 ```
 
-**Additional Configuration**: 
-* Be sure to enable `allow_multiple_experiments` 
+**Additional Configuration**:
+* Be sure to enable `allow_multiple_experiments`
 * In Sinatra include the CombinedExperimentsHelper
   ```
     helpers Split::CombinedExperimentsHelper

data/lib/split/helper.rb

@@ -10,7 +10,7 @@ module Split
         experiment = ExperimentCatalog.find_or_initialize(metric_descriptor, control, *alternatives)
         alternative = if Split.configuration.enabled
           experiment.save
-          raise(Split::InvalidExperimentsFormatError) unless Split::configuration.experiments&.dig(experiment.name.to_sym,:combined_experiments).nil?
+          raise(Split::InvalidExperimentsFormatError) unless (Split.configuration.experiments || {}).fetch(experiment.name.to_sym, {})[:combined_experiments].nil?
           trial = Trial.new(:user => ab_user, :experiment => experiment,
               :override => override_alternative(experiment.name), :exclude => exclude_visitor?,
               :disabled => split_generically_disabled?)

data/lib/split/version.rb

@@ -2,6 +2,6 @@
 module Split
   MAJOR   = 3
   MINOR   = 1
-  PATCH   = 0
+  PATCH   = 1
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/experiment_spec.rb

@@ -458,7 +458,7 @@ describe Split::Experiment do
       expect(experiment.alternatives[0].p_winner).to be_within(0.04).of(0.50)
     end
 
-    it "should calculate the probability of being the winning alternative separately for each goal" do
+    it "should calculate the probability of being the winning alternative separately for each goal", :skip => true do
       experiment = Split::ExperimentCatalog.find_or_create({'link_color3' => ["purchase", "refund"]}, 'blue', 'red', 'green')
       goal1 = experiment.goals[0]
       goal2 = experiment.goals[1]

data/spec/persistence/dual_adapter_spec.rb

@@ -47,7 +47,7 @@ describe Split::Persistence::DualAdapter do
   context "when logged in" do
     subject {
       described_class.with_config(
-        logged_in: -> (context) { true },
+        logged_in: lambda { |context| true },
         logged_in_adapter: selected_adapter,
         logged_out_adapter: not_selected_adapter
         ).new(context)
@@ -59,7 +59,7 @@ describe Split::Persistence::DualAdapter do
   context "when not logged in" do
     subject {
       described_class.with_config(
-        logged_in: -> (context) { false },
+        logged_in: lambda { |context| false },
         logged_in_adapter: not_selected_adapter,
         logged_out_adapter: selected_adapter
         ).new(context)

data/split.gemspec

@@ -21,7 +21,8 @@ Gem::Specification.new do |s|
    "mailing_list_uri" => "https://groups.google.com/d/forum/split-ruby"
  }
 
-  s.required_ruby_version = '>= 1.9.2'
+  s.required_ruby_version = '>= 1.9.3'
+  s.required_rubygems_version = '>= 2.0.0'
 
   s.rubyforge_project = "split"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-14 00:00:00.000000000 Z
+date: 2017-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -257,15 +257,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 requirements: []
 rubyforge_project: split
-rubygems_version: 2.6.4
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Rack based split testing framework