split 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60d1a66ab97c5078436d0d296fc25ad34922ef38
-  data.tar.gz: 284625b3580739a2e27f6fc9a7995e85102eca73
+  metadata.gz: 75e3f5edc1fef8a1131b615f82d5ec12cac72c29
+  data.tar.gz: bd21bc8f80816d06b3e05532152525e81c54e018
 SHA512:
-  metadata.gz: a0c68d144101879fb891a5be0bdeeab33b09279e04254fb64d969d83330c93dcbac450e1abb489ddfc06e31cdd891f71f8b24d2198d54eab7e38e3f98212aea3
-  data.tar.gz: caada44139cec833add6c1f4085d5dc11e5289b3b0571b137bdf52c904d340cdc06f985944bee402dfaebed6cfa4f3283c75fd882dd12e929ab49952465d8f35
+  metadata.gz: 6c3dc4cf24791918469b0c7677b63ea04510ff216c3cb46de2fffe82ebb77110d8ec94269dff6ee32fe20c49ff256c9dee304b07933116166ba91746ca486737
+  data.tar.gz: 51b7bceb61bb92b61abd0b35eae3f5b142f6e1b48341a4a9d1753a4853289fc998e1a60dc462c3b8bac53c71f231b050952ab3f89a69d175ec32e78f0e7f3e97

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.7.0 (June 28th, 2016)
+
+Features:
+
+- Running concurrent experiments on same endpoint/view (@karmakaze, #421)
+
 ## 1.6.0 (June 16th, 2016)
 
 Features:

data/README.md

@@ -171,7 +171,7 @@ Any old unfinished experiment key will be deleted from the user's data storage i
 
 By default Split will avoid users participating in multiple experiments at once. This means you are less likely to skew results by adding in more variation to your tests.
 
-To stop this behaviour and allow users to participate in multiple experiments at once enable the `allow_multiple_experiments` config option like so:
+To stop this behaviour and allow users to participate in multiple experiments at once set the `allow_multiple_experiments` config option to true like so:
 
 ```ruby
 Split.configure do |config|
@@ -179,6 +179,17 @@ Split.configure do |config|
 end
 ```
 
+This will allow the user to participate in any number of experiments and belong to any alternative in each experiment. This has the possible downside of a variation in one experiment influencing the outcome of another.
+
+To address this, setting the `allow_multiple_experiments` config option to 'control' like so:
+```ruby
+Split.configure do |config|
+  config.allow_multiple_experiments = 'control'
+end
+```
+
+For this to work, each and every experiment you define must have an alternative named 'control'. This will allow the user to participate in multiple experiments as long as the user belongs to the alternative 'control' in each experiment. As soon as the user belongs to an alternative named something other than 'control' the user may not participate in any more experiments. Calling ab_test(<other experiments>) will always return the first alternative without adding the user to that experiment.
+
 ### Experiment Persistence
 
 Split comes with three built-in persistence adapters for storing users and the alternatives they've been given for each experiment.

data/lib/split/user.rb

@@ -19,8 +19,14 @@ module Split
     end
 
     def max_experiments_reached?(experiment_key)
-      !Split.configuration.allow_multiple_experiments &&
-        keys_without_experiment(user.keys, experiment_key).length > 0
+      if Split.configuration.allow_multiple_experiments == 'control'
+        experiments = active_experiments
+        count_control = experiments.values.count {|v| v == 'control'}
+        experiments.size > count_control
+      else
+        !Split.configuration.allow_multiple_experiments &&
+          keys_without_experiment(user.keys, experiment_key).length > 0
+      end
     end
 
     def cleanup_old_versions!(experiment)

data/lib/split/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module Split
   MAJOR   = 1
-  MINOR   = 6
+  MINOR   = 7
   PATCH   = 0
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/helper_spec.rb

@@ -191,6 +191,26 @@ describe Split::Helper do
       expect(button_size_alt.participant_count).to eq(1)
     end
 
+    it "should let a user participate in many experiment with one non-'control' alternative with allow_multiple_experiments = 'control'" do
+      Split.configure do |config|
+        config.allow_multiple_experiments = 'control'
+      end
+      groups = []
+      (0..100).each do |n|
+        alt = ab_test("test#{n}".to_sym, {'control' => (100 - n)}, {'test#{n}-alt' => n})
+        groups << alt
+      end
+
+      experiments = ab_user.active_experiments
+      expect(experiments.size).to be > 1
+
+      count_control = experiments.values.count { |g| g == 'control' }
+      expect(count_control).to eq(experiments.size - 1)
+
+      count_alts = groups.count { |g| g != 'control' }
+      expect(count_alts).to eq(1)
+    end
+
     it "should not over-write a finished key when an experiment is on a later version" do
       experiment.increment_version
       ab_user = { experiment.key => 'blue', experiment.finished_key => true }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-16 00:00:00.000000000 Z
+date: 2016-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis