split 1.4.5 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c048eebd0c41a821d257be6a6ee61175df3d413
-  data.tar.gz: 1585aa44b15a8ba0258f545f84a880d06b1b58fc
+  metadata.gz: ee14a60caa6a0c07d046a7496ed7134f8fcc2693
+  data.tar.gz: 81f5c53dbb61c759e28d646f38ec498354d6b02d
 SHA512:
-  metadata.gz: d65b2592b5c29c53da81491234d00264444a5261bcb354eed72914aa3b6e9faf9b9b9a533412895899d54dffb93b9483b6943318b53771a257faf71518860361
-  data.tar.gz: 856c23b850dee54c658c73cca8bb6b5f02220f5c44d394bb2281c4d948eeb7529773867fa1403ca6b20122c2a032c405378faa1baac7dff8eaf6e9f64e153066
+  metadata.gz: cd05eba6701c96c861f688416e56ee4fc7086a2fcbba07ce81ca6cfa0a9bc5b0c070f135bc1de99693610009b557dff082a9882a8e129109284beaefbb4cdc4a
+  data.tar.gz: cdc9d7430bba23a5ca53656b3cd3509de65b605821126853cdee23424cd017097bacb534d64f0cd3631907cf88b28dee49d6bd800cb2a10235a2ddeefea5a183

data/.travis.yml

@@ -9,7 +9,5 @@ gemfile:
 before_install:
   - gem install bundler
 
-services:
-   - redis-server
 cache: bundler
 sudo: false

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 1.5.0 (June 8th, 2016)
+
+Features:
+
+- Add `expire_seconds:` TTL option to RedisAdapter (@karmakaze, #409)
+- Optional custom persistence adapter (@ndelage, #411)
+
+Misc:
+
+- Use fakeredis for testing (@andrew, #412)
+
 ## 1.4.5 (June 7th, 2016)
 
 Bugfixes:

data/README.md

@@ -221,6 +221,7 @@ end
 Options:
 * `lookup_by`: method to invoke per request for uniquely identifying ab_users (mandatory configuration)
 * `namespace`: separate namespace to store these persisted values (default "persistence")
+* `expire_seconds`: sets TTL for user key. (if a user is in multiple experiments most recent update will reset TTL for all their assignments)
 
 #### Custom Adapter
 

data/lib/split/persistence/redis_adapter.rb

@@ -27,6 +27,8 @@ module Split
 
       def []=(field, value)
         Split.redis.hset(redis_key, field, value)
+        expire_seconds = self.class.config[:expire_seconds]
+        Split.redis.expire(redis_key, expire_seconds) if expire_seconds
       end
 
       def delete(field)

data/lib/split/user.rb

@@ -4,8 +4,8 @@ module Split
     def_delegators :@user, :keys, :[], :[]=, :delete
     attr_reader :user
 
-    def initialize(context)
-      @user = Split::Persistence.adapter.new(context)
+    def initialize(context, adapter=nil)
+      @user = adapter || Split::Persistence.adapter.new(context)
     end
 
     def cleanup_old_experiments!

data/lib/split/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 module Split
   MAJOR   = 1
-  MINOR   = 4
-  PATCH   = 5
+  MINOR   = 5
+  PATCH   = 0
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/spec/spec_helper.rb

@@ -14,10 +14,15 @@ require 'complex' if RUBY_VERSION.match(/1\.8/)
 
 Dir['./spec/support/*.rb'].each { |f| require f }
 
+require "fakeredis"
+
+fakeredis = Redis.new
+
 RSpec.configure do |config|
   config.order = 'random'
   config.before(:each) do
     Split.configuration = Split::Configuration.new
+    Split.redis = fakeredis
     Split.redis.flushall
     @ab_user = mock_user
     params = nil

data/spec/user_spec.rb

@@ -60,4 +60,17 @@ describe Split::User do
       end
     end
   end
+
+  context "instantiated with custom adapter" do
+    let(:custom_adapter) { double(:persistence_adapter) }
+
+    before do
+      @subject = described_class.new(context, custom_adapter)
+    end
+
+    it "sets user to the custom adapter" do
+      expect(@subject.user).to eq(custom_adapter)
+    end
+  end
+
 end

data/split.gemspec

@@ -31,4 +31,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake',        '~> 11.1'
   s.add_development_dependency 'rspec',       '~> 3.4'
   s.add_development_dependency 'pry',         '~> 0.10'
+  s.add_development_dependency 'fakeredis',   '~> 0.5.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: split
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.5.0
 platform: ruby
 authors:
 - Andrew Nesbitt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-07 00:00:00.000000000 Z
+date: 2016-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: fakeredis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
 description: 
 email:
 - andrewnez@gmail.com